1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "base/strings/pattern.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/values_test_util.h"
#include "base/test/with_feature_override.h"
#include "build/build_config.h"
#include "content/browser/devtools/render_frame_devtools_agent_host.h"
#include "content/browser/permissions/permission_controller_impl.h"
#include "content/browser/renderer_host/render_frame_host_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/url_constants.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_content_browser_client.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/public/test/test_devtools_protocol_client.h"
#include "content/public/test/test_utils.h"
#include "content/shell/browser/shell.h"
#include "content/test/content_browser_test_utils_internal.h"
#include "net/base/net_errors.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "storage/browser/blob/features.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
#include "url/gurl.h"
#include "url/origin.h"
namespace content {
namespace {
class MockContentBrowserClient : public ContentBrowserTestContentBrowserClient {
public:
MockContentBrowserClient() = default;
~MockContentBrowserClient() override = default;
MOCK_METHOD(void,
LogWebFeatureForCurrentPage,
(content::RenderFrameHost*, blink::mojom::WebFeature),
(override));
bool IsFullCookieAccessAllowed(
content::BrowserContext* browser_context,
content::WebContents* web_contents,
const GURL& url,
const blink::StorageKey& storage_key,
net::CookieSettingOverrides overrides) override {
return allow_cookie_access_;
}
bool allow_cookie_access_ = false;
};
} // namespace
// Tests of the blob: URL scheme.
class BlobUrlBrowserTest : public ContentBrowserTest {
public:
BlobUrlBrowserTest() = default;
BlobUrlBrowserTest(const BlobUrlBrowserTest&) = delete;
BlobUrlBrowserTest& operator=(const BlobUrlBrowserTest&) = delete;
void SetUpOnMainThread() override {
host_resolver()->AddRule("*", "127.0.0.1");
SetupCrossSiteRedirector(embedded_test_server());
ASSERT_TRUE(embedded_test_server()->Start());
client_ = std::make_unique<MockContentBrowserClient>();
}
MockContentBrowserClient& GetMockClient() { return *client_; }
void TearDownOnMainThread() override { client_.reset(); }
private:
base::test::ScopedFeatureList feature_list_;
std::unique_ptr<MockContentBrowserClient> client_;
};
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest, LinkToUniqueOriginBlob) {
// Use a data URL to obtain a test page in a unique origin. The page
// contains a link to a "blob:null/SOME-GUID-STRING" URL.
EXPECT_TRUE(NavigateToURL(
shell(),
GURL("data:text/html,<body><script>"
"var link = document.body.appendChild(document.createElement('a'));"
"link.innerText = 'Click Me!';"
"link.href = URL.createObjectURL(new Blob(['potato']));"
"link.target = '_blank';"
"link.id = 'click_me';"
"</script></body>")));
// Click the link.
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecJs(shell(), "document.getElementById('click_me').click()"));
// The link should create a new tab.
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
EXPECT_TRUE(
base::MatchPattern(new_contents->GetVisibleURL().spec(), "blob:null/*"));
EXPECT_EQ(
"null potato",
EvalJs(new_contents, "self.origin + ' ' + document.body.innerText;"));
}
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest, LinkToSameOriginBlob) {
// Using an http page, click a link that opens a popup to a same-origin blob.
GURL url = embedded_test_server()->GetURL("chromium.org", "/title1.html");
url::Origin origin = url::Origin::Create(url);
EXPECT_TRUE(NavigateToURL(shell(), url));
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecJs(
shell(),
"var link = document.body.appendChild(document.createElement('a'));"
"link.innerText = 'Click Me!';"
"link.href = URL.createObjectURL(new Blob(['potato']));"
"link.target = '_blank';"
"link.click()"));
// The link should create a new tab.
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
EXPECT_TRUE(base::MatchPattern(new_contents->GetVisibleURL().spec(),
"blob:" + origin.Serialize() + "/*"));
EXPECT_EQ(
origin.Serialize() + " potato",
EvalJs(new_contents, " self.origin + ' ' + document.body.innerText;"));
}
// Regression test for https://crbug.com/646278
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest, LinkToSameOriginBlobWithAuthority) {
// Using an http page, click a link that opens a popup to a same-origin blob
// that has a spoofy authority section applied. This should be blocked.
GURL url = embedded_test_server()->GetURL("chromium.org", "/title1.html");
url::Origin origin = url::Origin::Create(url);
EXPECT_TRUE(NavigateToURL(shell(), url));
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecJs(
shell(),
"var link = document.body.appendChild(document.createElement('a'));"
"link.innerText = 'Click Me!';"
"link.href = 'blob:http://spoof.com@' + "
" URL.createObjectURL(new Blob(['potato'])).split('://')[1];"
"link.rel = 'opener'; link.target = '_blank';"
"link.click()"));
// The link should create a new tab.
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
// The spoofy URL should not be shown to the user.
EXPECT_FALSE(
base::MatchPattern(new_contents->GetVisibleURL().spec(), "*spoof*"));
// The currently implemented behavior is that the URL gets rewritten to
// about:blank#blocked.
EXPECT_EQ(kBlockedURL, new_contents->GetVisibleURL().spec());
EXPECT_EQ(
origin.Serialize() + " ",
EvalJs(new_contents,
"self.origin + ' ' + document.body.innerText;")); // no potato
}
// Regression test for https://crbug.com/646278
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest, ReplaceStateToAddAuthorityToBlob) {
// history.replaceState from a validly loaded blob URL shouldn't allow adding
// an authority to the inner URL, which would be spoofy.
GURL url = embedded_test_server()->GetURL("chromium.org", "/title1.html");
url::Origin origin = url::Origin::Create(url);
EXPECT_TRUE(NavigateToURL(shell(), url));
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecJs(shell(),
"args = ['<body>potato</body>'];\n"
"b = new Blob(args, {type: 'text/html'});"
"window.open(URL.createObjectURL(b));"));
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
const GURL non_spoofy_blob_url = new_contents->GetLastCommittedURL();
// Now try to URL spoof by embedding an authority to the inner URL using
// `replaceState()` to perform a same-document navigation.
EXPECT_FALSE(
ExecJs(new_contents,
"let host_port = self.origin.split('://')[1];\n"
"let spoof_url = 'blob:http://spoof.com@' + host_port + '/abcd';\n"
"window.history.replaceState({}, '', spoof_url);\n"));
// The spoofy URL should not be shown to the user.
EXPECT_FALSE(
base::MatchPattern(new_contents->GetVisibleURL().spec(), "*spoof*"));
// The currently implemented behavior is a same-document navigation to a
// blocked URL gets rewritten to the current document's URL, i.e.
// `non_spoofy_blob_url`.
// The content of the page stays the same.
EXPECT_EQ(non_spoofy_blob_url, new_contents->GetVisibleURL());
EXPECT_EQ(origin.Serialize(), EvalJs(new_contents, "origin"));
EXPECT_EQ("potato", EvalJs(new_contents, "document.body.innerText"));
std::string window_location =
EvalJs(new_contents, "window.location.href;").ExtractString();
EXPECT_FALSE(base::MatchPattern(window_location, "*spoof*"));
}
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest,
TestUseCounterForCrossPartitionSameOriginBlobURLFetch) {
GetMockClient().allow_cookie_access_ = true;
GURL main_url = embedded_test_server()->GetURL(
"c.com", "/cross_site_iframe_factory.html?c(b(c))");
EXPECT_TRUE(NavigateToURL(shell(), main_url));
RenderFrameHost* rfh_c = shell()->web_contents()->GetPrimaryMainFrame();
std::string blob_url_string =
EvalJs(
rfh_c,
"const blob_url = URL.createObjectURL(new "
"Blob(['<!doctype html><body>potato</body>'], {type: 'text/html'}));"
"blob_url;")
.ExtractString();
GURL blob_url(blob_url_string);
RenderFrameHost* rfh_b = ChildFrameAt(rfh_c, 0);
RenderFrameHost* rfh_c_2 = ChildFrameAt(rfh_b, 0);
EXPECT_CALL(
GetMockClient(),
LogWebFeatureForCurrentPage(
testing::_,
blink::mojom::WebFeature::kCrossPartitionSameOriginBlobURLFetch))
.Times(1);
std::string fetch_blob_url_js = JsReplace(
"async function test() {"
" const blob = await fetch($1).then(response => response.blob());"
" await blob.text();}"
"test();",
blob_url);
EXPECT_FALSE(ExecJs(rfh_b, fetch_blob_url_js));
EXPECT_TRUE(ExecJs(rfh_c_2, fetch_blob_url_js));
EXPECT_TRUE(ExecJs(rfh_c, JsReplace("URL.revokeObjectURL($1)", blob_url)));
EXPECT_FALSE(ExecJs(rfh_c_2, fetch_blob_url_js));
}
IN_PROC_BROWSER_TEST_F(BlobUrlBrowserTest, TestBlobFetchRequestError) {
base::HistogramTester histogram_tester;
GURL url = embedded_test_server()->GetURL("chromium.org", "/title1.html");
url::Origin origin = url::Origin::Create(url);
EXPECT_TRUE(NavigateToURL(shell(), url));
// The data should not be accessible after being revoked.
EXPECT_EQ("TypeError",
EvalJs(shell(),
"async function test() {"
"let error;"
"const url = URL.createObjectURL(new Blob(['potato']));"
"URL.revokeObjectURL(url);"
"try { await fetch(url); } catch (e) { error = e };"
"return new Promise(resolve => { resolve(error.name); });"
"}"
"test();"));
FetchHistogramsFromChildProcesses();
// The blob error should be recorded in UMA.
histogram_tester.ExpectUniqueSample("Net.BlobFetch.ResponseNetErrorCode",
-net::Error::ERR_FILE_NOT_FOUND, 1u);
}
class BlobUrlDevToolsIssueTest : public ContentBrowserTest {
protected:
BlobUrlDevToolsIssueTest() {
feature_list_.InitWithFeatures(
{features::kBlockCrossPartitionBlobUrlFetching,
blink::features::kEnforceNoopenerOnBlobURLNavigation},
{});
}
void SetUpOnMainThread() override {
ContentBrowserTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
SetupCrossSiteRedirector(embedded_test_server());
ASSERT_TRUE(embedded_test_server()->Start());
client_ = std::make_unique<MockContentBrowserClient>();
}
void TearDownOnMainThread() override { client_.reset(); }
void WaitForIssueAndCheckUrl(const std::string& url,
TestDevToolsProtocolClient* client,
const std::string& expected_info_enum) {
// Wait for notification of a Partitioning Blob URL Issue.
base::Value::Dict params = client->WaitForMatchingNotification(
"Audits.issueAdded",
base::BindRepeating([](const base::Value::Dict& params) {
const std::string* issue_code =
params.FindStringByDottedPath("issue.code");
return issue_code && *issue_code == "PartitioningBlobURLIssue";
}));
EXPECT_THAT(params, base::test::IsSupersetOfValue(
base::test::ParseJson(content::JsReplace(
R"({
"issue": {
"code": "PartitioningBlobURLIssue",
"details": {
"partitioningBlobURLIssueDetails": {
"url": $1,
"partitioningBlobURLInfo": $2,
}
}
}
})",
url, expected_info_enum))));
// Clear existing notifications so subsequent calls don't fail by checking
// `url` against old notifications.
client->ClearNotifications();
}
private:
base::test::ScopedFeatureList feature_list_;
private:
std::unique_ptr<MockContentBrowserClient> client_;
};
IN_PROC_BROWSER_TEST_F(BlobUrlDevToolsIssueTest, PartitioningBlobUrlIssue) {
// TODO(https://crbug.com/395911627): convert browser_tests to
// inspector-protocol test
GURL main_url = embedded_test_server()->GetURL(
"c.com", "/cross_site_iframe_factory.html?c(b(c))");
EXPECT_TRUE(NavigateToURL(shell(), main_url));
RenderFrameHost* rfh_c = shell()->web_contents()->GetPrimaryMainFrame();
std::string blob_url_string =
EvalJs(
rfh_c,
"const blob_url = URL.createObjectURL(new "
"Blob(['<!doctype html><body>potato</body>'], {type: 'text/html'}));"
"blob_url;")
.ExtractString();
GURL blob_url(blob_url_string);
RenderFrameHost* rfh_b = ChildFrameAt(rfh_c, 0);
RenderFrameHost* rfh_c_2 = ChildFrameAt(rfh_b, 0);
static_cast<PermissionControllerImpl*>(
rfh_c_2->GetBrowserContext()->GetPermissionController())
->SetPermissionOverride(/*origin=*/std::nullopt,
blink::PermissionType::STORAGE_ACCESS_GRANT,
blink::mojom::PermissionStatus::DENIED);
std::unique_ptr<content::TestDevToolsProtocolClient> client =
std::make_unique<content::TestDevToolsProtocolClient>();
client->AttachToFrameTreeHost(rfh_c_2);
client->SendCommandSync("Audits.enable");
client->ClearNotifications();
EXPECT_FALSE(ExecJs(
rfh_c_2,
JsReplace(
"async function test() {"
"const blob = await fetch($1).then(response => response.blob());"
"await blob.text();}"
"test();",
blob_url)));
WaitForIssueAndCheckUrl(blob_url_string, client.get(),
"BlockedCrossPartitionFetching");
client->DetachProtocolClient();
}
IN_PROC_BROWSER_TEST_F(BlobUrlDevToolsIssueTest,
PartitioningBlobUrlNavigationIssue) {
// TODO(https://crbug.com/395911627): convert browser_tests to
// inspector-protocol test
// 1. Navigate to c.com.
GURL main_url = embedded_test_server()->GetURL("c.com", "/title1.html");
WebContents* web_contents = shell()->web_contents();
EXPECT_TRUE(NavigateToURL(web_contents, main_url));
RenderFrameHost* rfh_c = web_contents->GetPrimaryMainFrame();
std::string blob_url_string =
EvalJs(
rfh_c,
"const blob_url = URL.createObjectURL(new "
"Blob(['<!doctype html><body>potato</body>'], {type: 'text/html'}));"
"blob_url;")
.ExtractString();
// 2. Create blob_url in c.com (blob url origin is c.com).
GURL blob_url(blob_url_string);
// 3. window.open b.com with c.com embedded.
// 3a. Navigate to b.com.
GURL b_url = embedded_test_server()->GetURL(
"b.com", "/cross_site_iframe_factory.html?b(c)");
// 3b. Open new tab from b.com context.
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(
content::ExecJs(rfh_c, content::JsReplace("window.open($1)", b_url)));
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
RenderFrameHost* rfh_b = new_contents->GetPrimaryMainFrame();
RenderFrameHost* rfh_c_in_b = ChildFrameAt(rfh_b, 0);
// 4. Attach DevTools client to the innermost frame (c.com inside b.com).
std::unique_ptr<TestDevToolsProtocolClient> client =
std::make_unique<TestDevToolsProtocolClient>();
client->AttachToFrameTreeHost(rfh_c_in_b);
client->SendCommandSync("Audits.enable");
client->ClearNotifications();
// 4. Do the window.open of blob url from c.com.
EXPECT_TRUE(
ExecJs(rfh_c_in_b, JsReplace("handle = window.open($1);", blob_url)));
WaitForIssueAndCheckUrl(blob_url_string, client.get(),
"EnforceNoopenerForNavigation");
client->DetachProtocolClient();
}
class BlobURLBrowserTestP : public base::test::WithFeatureOverride,
public BlobUrlBrowserTest {
public:
BlobURLBrowserTestP()
: base::test::WithFeatureOverride(
blink::features::kEnforceNoopenerOnBlobURLNavigation) {}
};
INSTANTIATE_FEATURE_OVERRIDE_TEST_SUITE(BlobURLBrowserTestP);
// Tests that an opaque origin document is able to window.open a Blob URL it
// created.
IN_PROC_BROWSER_TEST_P(BlobURLBrowserTestP,
NavigationWithOpaqueTopLevelOrigin) {
EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,<script></script>")));
ShellAddedObserver new_shell_observer;
EXPECT_TRUE(ExecJs(
shell(),
"const blob_url = URL.createObjectURL(new "
"Blob(['<!doctype html><body>potato</body>'], {type: 'text/html'}));"
"var handle = window.open(blob_url);"));
Shell* new_shell = new_shell_observer.GetShell();
WebContents* new_contents = new_shell->web_contents();
EXPECT_TRUE(WaitForLoadStop(new_contents));
bool handle_null = EvalJs(shell(), "handle === null;").ExtractBool();
EXPECT_FALSE(handle_null);
}
} // namespace content
|
