1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_util.h"
#include "base/path_service.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "cc/test/pixel_comparator.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/common/content_paths.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "content/shell/browser/shell.h"
#include "gpu/config/gpu_finch_features.h"
#include "ui/base/ui_base_features.h"
#include "ui/base/ui_base_switches.h"
#if BUILDFLAG(IS_ANDROID)
#include "base/android/build_info.h"
#endif
// TODO(crbug.com/40625383): Move the baselines to skia gold for easier
// rebaselining when all platforms are supported.
// To rebaseline this test on all platforms:
// 1. Run a CQ+1 dry run.
// 2. Click the failing bots for android, windows, mac, and linux.
// 3. Find the failing content_browsertests step.
// 4. Click the "Deterministic failure" link for the failing test case.
// 5. Copy the "Actual pixels" data url and paste into browser.
// 6. Save the image into your chromium checkout in content/test/data/forms/.
namespace content {
class FormControlsBrowserTest : public ContentBrowserTest {
public:
FormControlsBrowserTest() {
#if BUILDFLAG(IS_ANDROID)
// TODO(crbug.com/391378106): On Android the graphite results are different
// enough to need separate expected images. Force using ganesh until either
// all Android bots are running graphite or these tests support skia gold.
feature_list_.InitAndDisableFeature(features::kSkiaGraphite);
#endif
}
void SetUp() override {
EnablePixelOutput(/*force_device_scale_factor=*/1.f);
ContentBrowserTest::SetUp();
}
void SetUpCommandLine(base::CommandLine* command_line) override {
// The --disable-lcd-text flag helps text render more similarly on
// different bots and platform.
command_line->AppendSwitch(switches::kDisableLCDText);
// This is required to allow dark mode to be used on some platforms.
command_line->AppendSwitch(switches::kForceDarkMode);
}
void RunTest(const std::string& screenshot_filename,
const std::string& body_html,
int screenshot_width,
int screenshot_height) {
base::ScopedAllowBlockingForTesting allow_blocking;
std::string platform_suffix;
#if BUILDFLAG(IS_MAC)
platform_suffix = "_mac";
#elif BUILDFLAG(IS_WIN)
platform_suffix = "_win";
#elif BUILDFLAG(IS_LINUX)
platform_suffix = "_linux";
#elif BUILDFLAG(IS_CHROMEOS)
platform_suffix = "_chromeos";
#elif BUILDFLAG(IS_ANDROID)
int sdk_int = base::android::BuildInfo::GetInstance()->sdk_int();
if (sdk_int >= base::android::SDK_VERSION_T) {
platform_suffix = "_android_T";
} else {
platform_suffix = "_android";
}
#elif BUILDFLAG(IS_FUCHSIA)
platform_suffix = "_fuchsia";
#elif BUILDFLAG(IS_IOS)
platform_suffix = "_ios";
#endif
base::FilePath dir_test_data;
ASSERT_TRUE(base::PathService::Get(DIR_TEST_DATA, &dir_test_data));
base::FilePath golden_filepath =
dir_test_data.AppendASCII("forms").AppendASCII(screenshot_filename +
".png");
base::FilePath golden_filepath_platform =
golden_filepath.InsertBeforeExtensionASCII(platform_suffix);
if (base::PathExists(golden_filepath_platform)) {
golden_filepath = golden_filepath_platform;
}
ASSERT_TRUE(
NavigateToURL(shell()->web_contents(),
GURL("data:text/html,<!DOCTYPE html>" + body_html)));
#if BUILDFLAG(IS_APPLE)
// This fuzzy pixel comparator handles several mac behaviors:
// - Different font rendering after 10.14
// - Slight differences in radio and checkbox rendering in 10.15
// TODO(wangxianzhu): Tighten these parameters.
auto comparator = cc::FuzzyPixelComparator()
.DiscardAlpha()
.SetErrorPixelsPercentageLimit(26.f)
.SetAvgAbsErrorLimit(20.f)
.SetAbsErrorLimit(120);
#elif BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_WIN) || (OS_LINUX) || \
BUILDFLAG(IS_FUCHSIA)
// Different versions of android may have slight differences in rendering.
// Some versions have more significant differences than others, which are
// tracked separately in separate baseline image files. The less significant
// differences are accommodated for with this fuzzy pixel comparator.
// This also applies to different versions of other OSes.
auto comparator = cc::FuzzyPixelComparator()
.DiscardAlpha()
.SetErrorPixelsPercentageLimit(11.f)
.SetAvgAbsErrorLimit(5.f)
.SetAbsErrorLimit(140);
#else
cc::AlphaDiscardingExactPixelComparator comparator;
#endif
EXPECT_TRUE(CompareWebContentsOutputToReference(
shell()->web_contents(), golden_filepath,
gfx::Size(screenshot_width, screenshot_height), comparator));
}
// Check if the test can run on the current system.
bool SkipTestForOldAndroidVersions() const {
#if BUILDFLAG(IS_ANDROID)
// Lower versions of android running on older devices, ex Nexus 5, render
// form controls with a too large of a difference -- >20% error -- to
// pixel compare.
if (base::android::BuildInfo::GetInstance()->sdk_int() <
base::android::SDK_VERSION_OREO) {
return true;
}
#endif // BUILDFLAG(IS_ANDROID)
return false;
}
base::test::ScopedFeatureList feature_list_;
};
// Checkbox renders differently on Android x86. crbug.com/1238283
// TODO(crbug.com/401594933): The test fails on Windows ARM64.
#if (BUILDFLAG(IS_ANDROID) && defined(ARCH_CPU_X86)) || \
(BUILDFLAG(IS_WIN) && defined(ARCH_CPU_ARM64))
#define MAYBE_Checkbox DISABLED_Checkbox
#else
#define MAYBE_Checkbox Checkbox
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_Checkbox) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_checkbox",
"<input type=checkbox>"
"<input type=checkbox checked>"
"<input type=checkbox disabled>"
"<input type=checkbox checked disabled>"
"<input type=checkbox id=\"indeterminate\">"
"<script>"
" document.getElementById('indeterminate').indeterminate = true"
"</script>",
/* screenshot_width */ 130,
/* screenshot_height */ 40);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Radio) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_radio",
"<input type=radio>"
"<input type=radio checked>"
"<input type=radio disabled>"
"<input type=radio checked disabled>"
"<input type=radio id=\"indeterminate\">"
"<script>"
" document.getElementById('indeterminate').indeterminate = true"
"</script>",
/* screenshot_width */ 140,
/* screenshot_height */ 40);
}
#if BUILDFLAG(IS_MAC)
#define MAYBE_DarkModeTextSelection DISABLED_DarkModeTextSelection
#else
#define MAYBE_DarkModeTextSelection DarkModeTextSelection
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_DarkModeTextSelection) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_dark_mode_text_selection",
"<meta name=\"color-scheme\" content=\"dark\">"
"<div id=\"target\">This is some basic text that we are going to "
"select.</div>"
"<script>"
" let container = document.getElementById('target');"
" container.focus();"
" let targetText = container.firstChild;"
" let selectionRange = window.getSelection();"
" selectionRange.setBaseAndExtent(targetText, 5, targetText, 35);"
"</script>",
/* screenshot_width */ 400,
/* screenshot_height */ 40);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Input) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_input",
"<style>body {margin: 8px} input {width: 150px; "
"margin-bottom: 18px}</style>"
"<input type=\"text\" /><br>"
"<input type=\"number\" /><br>"
"<input type=\"search\" /><br>"
"<input type=\"email\" /><br>"
"<input type=\"password\" /><br>"
"<!-- border -->"
"<input type=\"text\" style=\"border: 3px solid lime;\"/><br>"
"<!-- shadow -->"
"<input type=\"text\" style=\"box-shadow: 4px 4px 10px "
"rgba(255,0,0,0.5), inset 4px 4px 4px rgba(0,255,0,0.5);\"/><br>"
"<!-- disabled -->"
"<input type=\"text\" disabled/>",
/* screenshot_width */ 200,
/* screenshot_height */ 330);
}
// The test fails on Windows ARM64: crbug.com/401594933.
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_CHROMEOS) || \
(BUILDFLAG(IS_WIN) && defined(ARCH_CPU_ARM64))
#define MAYBE_Textarea DISABLED_Textarea
#else
#define MAYBE_Textarea Textarea
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_Textarea) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_textarea",
R"HTML(
<style>
body {margin: 8px} textarea {width: 150px; margin-bottom: 18px}
</style>
<textarea></textarea><br>
<textarea style="border: 3px solid lime"></textarea><br>
<!-- shadow -->
<textarea style="box-shadow: 4px 4px 10px rgba(255,0,0,0.5),
inset 4px 4px 4px rgba(0,255,0,0.5);"></textarea><br>
<!-- disabled -->
<textarea disabled></textarea>)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 260);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Button) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_button",
R"HTML(
<style>body {margin: 8px} input {margin-bottom: 18px;}</style>
<input type="button" value="button"/><br>
<input type="submit" /><br>
<input type="reset" /><br>
<input type="file" /><br>
<!-- border -->
<input type="button" value="button"
style="border: 3px solid lime;"/><br>
<!-- shadow -->
<input type="button" value="button"
style="box-shadow: 4px 4px 10px
rgba(255,0,0,0.5), inset 4px 4px 4px rgba(0,255,0,0.5);"/><br>
<!-- disabled -->
<input type="button" value="button" disabled/>)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 300);
}
// TODO(crbug.com/1160104/#25) This test creates large average_error_rate on
// Android FYI SkiaRenderer Vulkan. Disable it until a resolution for is
// found.
// TODO(crbug.com/401594933): The test fails on Windows ARM64.
#if BUILDFLAG(IS_ANDROID) || (BUILDFLAG(IS_WIN) && defined(ARCH_CPU_ARM64))
#define MAYBE_ColorInput DISABLED_ColorInput
#else
#define MAYBE_ColorInput ColorInput
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_ColorInput) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_color_input",
R"HTML(
<style>body {margin: 8px} input {margin-bottom: 18px;}</style>
<input type="color" /><br>
<input type="color" value='%2300ff00' /><br>
<input type="color" list /><br>
<!-- border -->
<input type="color" value="%2300ff00"
style="border: 3px solid lime;"/><br>
<!-- disabled -->
<input type="color" disabled/>)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 250);
}
// TODO(crbug.com/401594933): The test fails on Windows ARM64.
#if BUILDFLAG(IS_WIN) && defined(ARCH_CPU_ARM64)
#define MAYBE_Select DISABLED_Select
#else
#define MAYBE_Select DISABLED_Select
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_Select) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_select",
R"HTML(
<style>
body {margin: 8px}
select {margin-bottom: 18px; width: 170px;}
</style>
<select></select><br>
<select style="color:darkturquoise"></select><br>
<!-- border -->
<select style="border: 3px solid lime;"></select><br>
<!-- shadow -->
<select style="box-shadow: 4px 4px 10px rgba(255,0,0,0.5),
inset 4px 4px 4px rgba(0,255,0,0.5);"></select><br>
<!-- disabled -->
<select disabled></select><br>)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 200);
}
// TODO(crbug.com/377986468) : Flaky on Windows. Seems to lose focus of top
// <select> in some runs which causes the results to be different from
// expectations.
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_CHROMEOS)
#define MAYBE_MultiSelect DISABLED_MultiSelect
#else
#define MAYBE_MultiSelect MultiSelect
#endif
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, MAYBE_MultiSelect) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_multi_select",
R"HTML(
<style>
body {margin: 8px}
select {margin-bottom: 18px; width: 170px; }
</style>
<select multiple autofocus size=5>
<optgroup label="unstyled select"></optgroup>
</select> <br>
<!-- border -->
<select multiple style="border: 3px solid lime;" size=5>
<optgroup label="thick lime border"></optgroup>
</select><br>
<!-- disabled -->
<select multiple disabled size=5>
<optgroup label="disabled select">
</optgroup>
</select>)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 330);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Progress) {
if (SkipTestForOldAndroidVersions())
return;
#if BUILDFLAG(IS_MAC) && !defined(ARCH_CPU_ARM64)
// The pixel comparison fails on Mac Intel GPUs with Graphite due to MSAA
// issues.
// TODO(crbug.com/40940637): Re-enable test if possible.
if (features::IsSkiaGraphiteEnabled(base::CommandLine::ForCurrentProcess())) {
return;
}
#endif
RunTest("form_controls_browsertest_progress",
R"HTML(
<style>
body {margin: 8px} progress {margin-bottom: 18px}
</style>
<progress max="100" value="0"></progress><br>
<progress max="100" value="5"></progress><br>
<progress max="100" value="25"></progress><br><br>
<progress max="100" value="50"></progress><br><br>
<progress max="100" value="100"></progress><br><br>
<progress max="100" value="50" style="height:30px"></progress>
)HTML",
/* screenshot_width */ 200,
/* screenshot_height */ 300);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Meter) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_meter",
R"HTML(
<style>
body {margin: 8px} meter {margin-bottom: 10px}
</style>
<meter min="0" max="100" low="33" high="66" optimum="100"
value="20"></meter><br>
<meter min="0" max="100" low="33" high="66" optimum="100"
value="50"></meter><br>
<meter min="0" max="100" low="33" high="66" optimum="100"
value="66"></meter><br>
<meter min="0" max="100" low="33" high="66" optimum="100"
value="90"></meter><br>
<!-- border -->
<meter style="border-color: %23000000; border-style: solid;
border-width: 5px;" min="0" max="100" low="30" high="60"
optimum="100" value="80" ></meter><br>
<meter style="box-shadow: 4px 4px 10px rgba(255,0,0,0.5),
inset 4px 4px 4px rgba(0,255,0,0.5);"></meter>)HTML",
/* screenshot_width */ 150,
/* screenshot_height */ 200);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Range) {
if (SkipTestForOldAndroidVersions())
return;
RunTest("form_controls_browsertest_range",
R"HTML(
<style>
body {margin: 8px} input {margin-bottom: 18px}
</style>
<input type="range"><br>
)HTML",
/* screenshot_width */ 150,
/* screenshot_height */ 150);
}
// TODO(jarhar): Add tests for other elements from
// https://concrete-hardboard.glitch.me
} // namespace content
|
