File: scroll_tracing_browsertest.cc

package info (click to toggle)
chromium 138.0.7204.183-1~deb12u1
  • links: PTS, VCS
  • area: main
  • in suites: bookworm-proposed-updates
  • size: 6,080,960 kB
  • sloc: cpp: 34,937,079; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,954; asm: 946,768; xml: 739,971; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,811; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (499 lines) | stat: -rw-r--r-- 18,566 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <memory>
#include <string_view>

#include "base/strings/string_number_conversions.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_trace_processor.h"
#include "components/ukm/test_ukm_recorder.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/input/synthetic_gesture_controller.h"
#include "content/common/input/synthetic_smooth_scroll_gesture.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/shell/browser/shell.h"
#include "net/dns/mock_host_resolver.h"
#include "services/metrics/public/cpp/metrics_utils.h"
#include "services/metrics/public/cpp/ukm_builders.h"
#include "third_party/blink/public/common/input/synthetic_web_input_event_builders.h"

namespace content {

class ScrollTracingBrowserTest : public ContentBrowserTest {
 public:
  ScrollTracingBrowserTest() {
    scoped_feature_list_.InitWithFeatures({ukm::kUkmFeature}, {});
  }

  ScrollTracingBrowserTest(const ScrollTracingBrowserTest&) = delete;
  ScrollTracingBrowserTest& operator=(const ScrollTracingBrowserTest&) = delete;

  ~ScrollTracingBrowserTest() override = default;

  void PreRunTestOnMainThread() override {
    ContentBrowserTest::PreRunTestOnMainThread();
    test_ukm_recorder_ = std::make_unique<ukm::TestAutoSetUkmRecorder>();
  }

  RenderWidgetHostImpl* GetRenderWidgetHostImpl() {
    FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
                              ->GetPrimaryFrameTree()
                              .root();
    return root->current_frame_host()->GetRenderWidgetHost();
  }

  void DoScroll(gfx::Point starting_point,
                std::vector<gfx::Vector2d> distances,
                content::mojom::GestureSourceType source) {
    // Create and queue gestures
    for (const auto distance : distances) {
      SyntheticSmoothScrollGestureParams params;
      params.gesture_source_type = source;
      params.anchor = gfx::PointF(starting_point);
      params.distances.push_back(-distance);
      params.granularity = ui::ScrollGranularity::kScrollByPrecisePixel;
      auto gesture = std::make_unique<SyntheticSmoothScrollGesture>(params);

      base::RunLoop run_loop;
      GetRenderWidgetHostImpl()->QueueSyntheticGesture(
          std::move(gesture),
          base::BindLambdaForTesting([&](SyntheticGesture::Result result) {
            EXPECT_EQ(SyntheticGesture::GESTURE_FINISHED, result);
            run_loop.Quit();
          }));
      run_loop.Run();

      // Update the previous start point.
      starting_point = gfx::Point(starting_point.x() + distance.x(),
                                  starting_point.y() + distance.y());
    }
  }

  void ValidateUkm(GURL url,
                   std::string_view entry_name,
                   std::map<std::string_view, int64_t> expected_values) {
    const auto& entries =
        test_ukm_recorder_->GetMergedEntriesByName(entry_name);
    EXPECT_EQ(1u, entries.size());
    for (const auto& kv : entries) {
      test_ukm_recorder_->ExpectEntrySourceHasUrl(kv.second.get(), url);
      for (const auto& expected_kv : expected_values) {
        EXPECT_TRUE(test_ukm_recorder_->EntryHasMetric(kv.second.get(),
                                                       expected_kv.first));
        if (*(test_ukm_recorder_->GetEntryMetric(kv.second.get(),
                                                 expected_kv.first)) != 0) {
          test_ukm_recorder_->ExpectEntryMetric(
              kv.second.get(), expected_kv.first,
              ukm::GetExponentialBucketMinForCounts1000(expected_kv.second));
        }
      }
    }
  }

 protected:
  base::test::ScopedFeatureList scoped_feature_list_;
  std::unique_ptr<base::HistogramTester> histogram_tester_;
  std::unique_ptr<ukm::TestAutoSetUkmRecorder> test_ukm_recorder_;
};

std::optional<int64_t> ConvertToIntValue(std::string query_value) {
  int64_t result;
  if (base::StringToInt64(query_value, &result)) {
    return result;
  }
  return std::nullopt;
}

// NOTE:  Mac doesn't support touch events, and will not record scrolls with
// touch input. Linux bots are inconsistent.
#if BUILDFLAG(IS_ANDROID)
// Basic parity matching test between trace events and UKM if both are recorded
// during a scroll.
IN_PROC_BROWSER_TEST_F(ScrollTracingBrowserTest, ScrollingMetricsParity) {
  base::test::TestTraceProcessor ttp_;
  ttp_.StartTrace("input.scrolling");

  ASSERT_TRUE(embedded_test_server()->Start());

  GURL url(
      embedded_test_server()->GetURL("/scrollable_page_with_content.html"));
  EXPECT_TRUE(NavigateToURL(shell(), url));
  ASSERT_TRUE(WaitForLoadStop(shell()->web_contents()));

  // Scroll with 3 updates to ensure:
  //  1) One frame is missed (maximum 2 may be missed).
  //  2) Predictor jank occurs.
  DoScroll(gfx::Point(10, 10), {gfx::Vector2d(0, 100), gfx::Vector2d(0, -100)},
           content::mojom::GestureSourceType::kTouchInput);

  RunUntilInputProcessed(GetRenderWidgetHostImpl());
  EXPECT_EQ(true, EvalJs(shell()->web_contents(), "did_scroll;"));

  absl::Status status = ttp_.StopAndParseTrace();
  ASSERT_TRUE(status.ok()) << status.message();

  // Use the values in chrome_scroll_interactions to validate values in UKM.
  auto result = ttp_.RunQuery(R"(
    INCLUDE PERFETTO MODULE chrome.scroll_interactions;

    SELECT
      frame_count,
      vsync_count,
      missed_vsync_max,
      missed_vsync_sum,
      delayed_frame_count,
      predictor_janky_frame_count
    FROM chrome_scroll_interactions
    LIMIT 1;
  )");

  ASSERT_TRUE(result.has_value()) << result.error();
  auto scroll_metrics_result = result.value();

  // Validate that there are two rows in the output. The first row is the
  // column names, the second row is the values. If there is only one row,
  // then the query produced no data (a.k.a the data model was not populated).
  EXPECT_EQ(scroll_metrics_result.size(), 2u);

  // Validate that each column of the query is present.
  ASSERT_TRUE(scroll_metrics_result[1].size() == 6);

  auto scroll_metrics = scroll_metrics_result[1];

  // frame_count
  std::optional<int64_t> metrics = ConvertToIntValue(scroll_metrics[0]);
  EXPECT_TRUE(metrics.has_value());
  EXPECT_GE(metrics.value(), 1);
  // vsync_count
  metrics = ConvertToIntValue(scroll_metrics[1]);
  EXPECT_TRUE(metrics.has_value());
  EXPECT_GE(metrics.value(), 1);

  ValidateUkm(
      url, ukm::builders::Event_Scroll::kEntryName,
      {
          {ukm::builders::Event_Scroll::kFrameCountName,
           ConvertToIntValue(scroll_metrics[0]).value()},
          {ukm::builders::Event_Scroll::kVsyncCountName,
           ConvertToIntValue(scroll_metrics[1]).value()},
          {ukm::builders::Event_Scroll::kScrollJank_MissedVsyncsMaxName,
           ConvertToIntValue(scroll_metrics[2]).value()},
          {ukm::builders::Event_Scroll::kScrollJank_MissedVsyncsSumName,
           ConvertToIntValue(scroll_metrics[3]).value()},
          {ukm::builders::Event_Scroll::kScrollJank_DelayedFrameCountName,
           ConvertToIntValue(scroll_metrics[4]).value()},
          {ukm::builders::Event_Scroll::kPredictorJankyFrameCountName,
           ConvertToIntValue(scroll_metrics[5]).value()},
      });
}

/**
 * Helper classes to make it more convenient to iterate on the results returned
 * by `TestTraceProcessor::RunQuery()`. This is the basic version that is only
 * used in one test at the moment. If more tests start using
 *`TestTraceProcessor`, we can improve the helpers and move them to
 *`TestTraceProcessor`.
 **/
class Column {
 public:
  explicit Column(std::vector<std::string> column) : column_(column) {}

  std::vector<std::optional<int64_t>> GetIntValuesOrNulls() const {
    std::vector<std::optional<int64_t>> result;
    for (const std::string& row : column_) {
      result.push_back(ConvertToIntValue(row));
    }
    return result;
  }

 private:
  const std::vector<std::string> column_;
};

class Row {
 public:
  Row(const std::vector<std::string>& row,
      const std::map<std::string, int64_t>& column_name_to_index_)
      : row_(row), column_name_to_index_(column_name_to_index_) {}

  bool HasValue(const std::string& column_name) {
    const auto it = column_name_to_index_->find(column_name);
    EXPECT_NE(it, column_name_to_index_->end())
        << "Column " << column_name << " not found";
    return (*row_)[it->second] != "[NULL]";
  }

  std::optional<int64_t> GetIntValueOrNull(
      const std::string& column_name) const {
    const auto it = column_name_to_index_->find(column_name);
    EXPECT_NE(it, column_name_to_index_->end())
        << "Column " << column_name << " not found";
    return ConvertToIntValue((*row_)[it->second]);
  }

 private:
  const raw_ref<const std::vector<std::string>> row_;
  const raw_ref<const std::map<std::string, int64_t>> column_name_to_index_;
};

class Result {
 public:
  explicit Result(std::vector<std::vector<std::string>>& results)
      : results_(results) {
    const std::vector<std::string>& column_names = results_[0];

    for (size_t i = 0; i < column_names.size(); ++i) {
      column_name_to_index_[column_names[i]] = i;
    }

    // Remove the header with column names.
    results_.erase(results_.begin());
  }

  Column GetColumn(const std::string& column_name) const {
    std::vector<std::string> column;
    auto it = column_name_to_index_.find(column_name);
    EXPECT_NE(it, column_name_to_index_.end())
        << "Column " << column_name << " not found";
    for (const auto& result : results_) {
      column.push_back(result[it->second]);
    }
    return Column(std::move(column));
  }

  std::vector<Row> GetRows() const {
    std::vector<Row> result;
    for (const std::vector<std::string>& row : results_) {
      result.emplace_back(row, column_name_to_index_);
    }
    return result;
  }

 private:
  std::map<std::string, int64_t> column_name_to_index_;
  std::vector<std::vector<std::string>> results_;
};

std::vector<std::optional<int64_t>> GetNullableValues(
    const Row& row,
    const std::vector<const char*>& column_names) {
  std::vector<std::optional<int64_t>> nullable_values;

  for (const char* column_name : column_names) {
    nullable_values.push_back(row.GetIntValueOrNull(column_name));
  }

  return nullable_values;
}

std::vector<int64_t> FilterOutNulls(
    const std::vector<std::optional<int64_t>>& nullable_values) {
  std::vector<int64_t> result;
  for (const auto& nullable_value : nullable_values) {
    if (nullable_value) {
      result.push_back(nullable_value.value());
    }
  }
  return result;
}

// Verifies that the scroll updates in the tracing standard library
// have correct properties and expected sequence of steps.
IN_PROC_BROWSER_TEST_F(ScrollTracingBrowserTest, ScrollUpdateInfo) {
  using base::test::TestTraceProcessor;
  TestTraceProcessor ttp_;
  ttp_.StartTrace("input");

  ASSERT_TRUE(embedded_test_server()->Start());

  GURL url(
      embedded_test_server()->GetURL("/scrollable_page_with_content.html"));
  ASSERT_TRUE(NavigateToURL(shell(), url));
  ASSERT_TRUE(WaitForLoadStop(shell()->web_contents()));

  // Do a single scroll.
  DoScroll(gfx::Point(10, 10), {gfx::Vector2d(0, 10), gfx::Vector2d(0, 10)},
           content::mojom::GestureSourceType::kTouchInput);

  RunUntilInputProcessed(GetRenderWidgetHostImpl());
  ASSERT_EQ(true, EvalJs(shell()->web_contents(), "did_scroll;"));

  absl::Status status = ttp_.StopAndParseTrace();
  ASSERT_TRUE(status.ok()) << status.message();

  // Select chrome scroll updates.
  base::expected<TestTraceProcessor::QueryResult, std::string> raw_result =
      ttp_.RunQuery(R"(
    INCLUDE PERFETTO MODULE chrome.chrome_scrolls;

    SELECT
      id,
      is_presented,
      is_first_scroll_update_in_scroll,
      is_first_scroll_update_in_frame,
      previous_input_id,
      presentation_timestamp,
      generation_ts,
      touch_move_received_ts,
      scroll_update_created_ts,
      compositor_dispatch_ts,
      compositor_on_begin_frame_ts,
      compositor_generate_compositor_frame_ts,
      compositor_submit_compositor_frame_ts,
      viz_receive_compositor_frame_ts,
      viz_draw_and_swap_ts,
      viz_swap_buffers_ts,
      latch_timestamp,
      generation_to_browser_main_dur,
      touch_move_processing_dur,
      scroll_update_processing_dur,
      browser_to_compositor_delay_dur,
      compositor_dispatch_dur,
      compositor_dispatch_to_on_begin_frame_delay_dur,
      compositor_on_begin_frame_dur,
      compositor_on_begin_frame_to_generation_delay_dur,
      compositor_generate_frame_to_submit_frame_dur,
      compositor_submit_frame_dur,
      compositor_to_viz_delay_dur,
      viz_receive_compositor_frame_dur,
      viz_wait_for_draw_dur,
      viz_draw_and_swap_dur,
      viz_to_gpu_delay_dur,
      viz_swap_buffers_dur,
      viz_swap_buffers_to_latch_dur,
      viz_latch_to_presentation_dur
    FROM
      chrome_scroll_update_info
    ORDER BY id
  )");

  ASSERT_TRUE(raw_result.has_value()) << raw_result.error();
  TestTraceProcessor::QueryResult result_value = raw_result.value();

  Result result(result_value);
  EXPECT_GE(result.GetRows().size(), 1u);

  std::vector<std::optional<int64_t>> nullable_scroll_update_ids =
      result.GetColumn("id").GetIntValuesOrNulls();
  std::vector<int64_t> scroll_update_ids =
      FilterOutNulls(nullable_scroll_update_ids);

  // Check that latency ids are not duplicated
  std::set<int64_t> unique_ids(std::begin(scroll_update_ids),
                               std::end(scroll_update_ids));
  EXPECT_THAT(scroll_update_ids,
              testing::UnorderedElementsAreArray(unique_ids));

  // Check that at least one frame was presented and at least
  // one update was the first in the frame.
  EXPECT_THAT(
      FilterOutNulls(result.GetColumn("is_presented").GetIntValuesOrNulls()),
      testing::Contains(1))
      << "No rows with is_presented = 1";
  EXPECT_THAT(FilterOutNulls(result.GetColumn("is_first_scroll_update_in_frame")
                                 .GetIntValuesOrNulls()),
              testing::Contains(1))
      << "No rows with is_first_scroll_update_in_frame = 1";

  size_t row_number = 0;
  for (Row row : result.GetRows()) {
    std::optional<int64_t> maybe_is_presented =
        row.GetIntValueOrNull("is_presented");
    EXPECT_TRUE(maybe_is_presented.has_value());
    bool is_presented = maybe_is_presented.value() == 1;
    LOG(ERROR) << "is presented = " << is_presented;
    if (is_presented) {
      EXPECT_TRUE(row.HasValue("presentation_timestamp"))
          << "No presentation timestamp for update in row " << row_number
          << ", result:\n"
          << result_value;
    }

    std::optional<int64_t> maybe_is_first_scroll_update_in_frame =
        row.GetIntValueOrNull("is_first_scroll_update_in_frame");
    EXPECT_TRUE(maybe_is_first_scroll_update_in_frame.has_value());
    bool is_first_scroll_update_in_frame =
        maybe_is_first_scroll_update_in_frame.value() == 1;

    std::optional<int64_t> maybe_is_first_scroll_update_in_scroll =
        row.GetIntValueOrNull("is_first_scroll_update_in_scroll");
    EXPECT_TRUE(maybe_is_first_scroll_update_in_scroll.has_value());
    bool is_first_scroll_update_in_scroll =
        maybe_is_first_scroll_update_in_scroll.value() == 1;

    std::optional<int64_t> maybe_previous_input_id =
        row.GetIntValueOrNull("previous_input_id");

    if (is_first_scroll_update_in_scroll) {
      EXPECT_FALSE(maybe_previous_input_id.has_value())
          << "Previous input id is not null for the first update in a scroll "
             "in row "
          << row_number << ", result:\n"
          << result_value;
      EXPECT_TRUE(is_first_scroll_update_in_frame)
          << "First update in scroll is not first update in frame in row "
          << row_number << ", result:\n"
          << result_value;
    }

    // Static constant array of timestamp column names.
    static const std::vector<const char*> kTimestampColumnNames = {
        "generation_ts",
        "touch_move_received_ts",
        "scroll_update_created_ts",
        "compositor_dispatch_ts",
        "compositor_on_begin_frame_ts",
        "compositor_generate_compositor_frame_ts",
        "compositor_submit_compositor_frame_ts",
        "viz_receive_compositor_frame_ts",
        "viz_draw_and_swap_ts",
        "viz_swap_buffers_ts",
        "latch_timestamp"};

    std::vector<std::optional<int64_t>> nullable_timestamps =
        GetNullableValues(row, kTimestampColumnNames);
    std::vector<int64_t> timestamps = FilterOutNulls(nullable_timestamps);

    std::vector<int64_t> expected_timestamps = timestamps;

    // The non-NULL timestamps for consecutive stages should be increasing.
    std::sort(expected_timestamps.begin(), expected_timestamps.end());
    EXPECT_EQ(timestamps, expected_timestamps)
        << "Timestamps for consecutive stages are not increasing in row "
        << row_number << ", result:\n"
        << result_value;

    static const std::vector<const char*> kDurationColumnNames = {
        "generation_to_browser_main_dur", "touch_move_processing_dur",
        "scroll_update_processing_dur", "browser_to_compositor_delay_dur",
        "compositor_dispatch_dur",
        // TODO(b:381273884): fix negative stage duration
        // "compositor_dispatch_to_on_begin_frame_delay_dur",
        "compositor_on_begin_frame_dur",
        "compositor_on_begin_frame_to_generation_delay_dur",
        "compositor_generate_frame_to_submit_frame_dur",
        "compositor_submit_frame_dur", "compositor_to_viz_delay_dur",
        "viz_receive_compositor_frame_dur", "viz_wait_for_draw_dur",
        "viz_draw_and_swap_dur", "viz_to_gpu_delay_dur", "viz_swap_buffers_dur",
        "viz_swap_buffers_to_latch_dur", "viz_latch_to_presentation_dur"};

    std::vector<std::optional<int64_t>> nullable_durations =
        GetNullableValues(row, kDurationColumnNames);
    std::vector<int64_t> durations = FilterOutNulls(nullable_durations);

    EXPECT_THAT(durations, testing::Not(testing::Contains(testing::Lt(0))))
        << "Negative duration(s) in row " << row_number << ", result:\n"
        << result_value;
    row_number++;
  }
}

#endif  // BUILDFLAG(IS_ANDROID)

}  // namespace content