1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/sync_bookmarks/synced_bookmark_tracker.h"
#include <algorithm>
#include <unordered_map>
#include <unordered_set>
#include <vector>
#include "base/base64.h"
#include "base/hash/hash.h"
#include "base/hash/sha1.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/trace_event/memory_usage_estimator.h"
#include "base/uuid.h"
#include "components/bookmarks/browser/bookmark_node.h"
#include "components/sync/base/deletion_origin.h"
#include "components/sync/base/time.h"
#include "components/sync/protocol/bookmark_model_metadata.pb.h"
#include "components/sync/protocol/data_type_state_helper.h"
#include "components/sync/protocol/entity_specifics.pb.h"
#include "components/sync/protocol/proto_memory_estimations.h"
#include "components/sync/protocol/unique_position.pb.h"
#include "components/sync_bookmarks/bookmark_model_view.h"
#include "components/sync_bookmarks/switches.h"
#include "components/sync_bookmarks/synced_bookmark_tracker_entity.h"
#include "components/version_info/version_info.h"
#include "ui/base/models/tree_node_iterator.h"
namespace sync_bookmarks {
namespace {
void HashSpecifics(const sync_pb::EntitySpecifics& specifics,
std::string* hash) {
DCHECK_GT(specifics.ByteSizeLong(), 0u);
*hash =
base::Base64Encode(base::SHA1HashString(specifics.SerializeAsString()));
}
// Returns a map from id to node for all nodes in |model|.
std::unordered_map<int64_t, const bookmarks::BookmarkNode*>
BuildIdToBookmarkNodeMap(const BookmarkModelView* model) {
std::unordered_map<int64_t, const bookmarks::BookmarkNode*>
id_to_bookmark_node_map;
// The TreeNodeIterator used below doesn't include the node itself, and hence
// add the root node separately.
id_to_bookmark_node_map[model->root_node()->id()] = model->root_node();
ui::TreeNodeIterator<const bookmarks::BookmarkNode> iterator(
model->root_node());
while (iterator.has_next()) {
const bookmarks::BookmarkNode* node = iterator.Next();
id_to_bookmark_node_map[node->id()] = node;
}
return id_to_bookmark_node_map;
}
} // namespace
// static
syncer::ClientTagHash SyncedBookmarkTracker::GetClientTagHashFromUuid(
const base::Uuid& uuid) {
return syncer::ClientTagHash::FromUnhashed(syncer::BOOKMARKS,
uuid.AsLowercaseString());
}
// static
std::unique_ptr<SyncedBookmarkTracker> SyncedBookmarkTracker::CreateEmpty(
sync_pb::DataTypeState data_type_state) {
// base::WrapUnique() used because the constructor is private.
return base::WrapUnique(new SyncedBookmarkTracker(
std::move(data_type_state), /*bookmarks_reuploaded=*/false,
/*num_ignored_updates_due_to_missing_parent=*/std::optional<int64_t>(0),
/*max_version_among_ignored_updates_due_to_missing_parent=*/
std::nullopt));
}
// static
std::unique_ptr<SyncedBookmarkTracker>
SyncedBookmarkTracker::CreateFromBookmarkModelAndMetadata(
const BookmarkModelView* model,
sync_pb::BookmarkModelMetadata model_metadata) {
DCHECK(model);
if (!syncer::IsInitialSyncDone(
model_metadata.data_type_state().initial_sync_state())) {
return nullptr;
}
// When the reupload feature is enabled and disabled again, there may occur
// new entities which weren't reuploaded.
const bool bookmarks_reuploaded =
model_metadata.bookmarks_hierarchy_fields_reuploaded() &&
base::FeatureList::IsEnabled(switches::kSyncReuploadBookmarks);
std::optional<int64_t> num_ignored_updates_due_to_missing_parent;
if (model_metadata.has_num_ignored_updates_due_to_missing_parent()) {
num_ignored_updates_due_to_missing_parent =
model_metadata.num_ignored_updates_due_to_missing_parent();
}
std::optional<int64_t>
max_version_among_ignored_updates_due_to_missing_parent;
if (model_metadata
.has_max_version_among_ignored_updates_due_to_missing_parent()) {
max_version_among_ignored_updates_due_to_missing_parent =
model_metadata
.max_version_among_ignored_updates_due_to_missing_parent();
}
// base::WrapUnique() used because the constructor is private.
auto tracker = base::WrapUnique(new SyncedBookmarkTracker(
model_metadata.data_type_state(), bookmarks_reuploaded,
num_ignored_updates_due_to_missing_parent,
max_version_among_ignored_updates_due_to_missing_parent));
const CorruptionReason corruption_reason =
tracker->InitEntitiesFromModelAndMetadata(model,
std::move(model_metadata));
UMA_HISTOGRAM_ENUMERATION("Sync.BookmarksModelMetadataCorruptionReason",
corruption_reason);
if (corruption_reason != CorruptionReason::NO_CORRUPTION) {
return nullptr;
}
return tracker;
}
SyncedBookmarkTracker::~SyncedBookmarkTracker() = default;
void SyncedBookmarkTracker::SetBookmarksReuploaded() {
bookmarks_reuploaded_ = true;
}
const SyncedBookmarkTrackerEntity* SyncedBookmarkTracker::GetEntityForSyncId(
const std::string& sync_id) const {
auto it = sync_id_to_entities_map_.find(sync_id);
return it != sync_id_to_entities_map_.end() ? it->second.get() : nullptr;
}
const SyncedBookmarkTrackerEntity*
SyncedBookmarkTracker::GetEntityForClientTagHash(
const syncer::ClientTagHash& client_tag_hash) const {
auto it = client_tag_hash_to_entities_map_.find(client_tag_hash);
return it != client_tag_hash_to_entities_map_.end() ? it->second : nullptr;
}
const SyncedBookmarkTrackerEntity* SyncedBookmarkTracker::GetEntityForUuid(
const base::Uuid& uuid) const {
return GetEntityForClientTagHash(GetClientTagHashFromUuid(uuid));
}
SyncedBookmarkTrackerEntity* SyncedBookmarkTracker::AsMutableEntity(
const SyncedBookmarkTrackerEntity* entity) {
DCHECK(entity);
DCHECK_EQ(entity, GetEntityForSyncId(entity->metadata().server_id()));
// As per DCHECK above, this tracker owns |*entity|, so it's legitimate to
// return non-const pointer.
return const_cast<SyncedBookmarkTrackerEntity*>(entity);
}
const SyncedBookmarkTrackerEntity*
SyncedBookmarkTracker::GetEntityForBookmarkNode(
const bookmarks::BookmarkNode* node) const {
auto it = bookmark_node_to_entities_map_.find(node);
return it != bookmark_node_to_entities_map_.end() ? it->second : nullptr;
}
const SyncedBookmarkTrackerEntity* SyncedBookmarkTracker::Add(
const bookmarks::BookmarkNode* bookmark_node,
const std::string& sync_id,
int64_t server_version,
base::Time creation_time,
const sync_pb::EntitySpecifics& specifics) {
DCHECK_GT(specifics.ByteSizeLong(), 0u);
DCHECK(bookmark_node);
DCHECK(specifics.has_bookmark());
DCHECK(bookmark_node->is_permanent_node() ||
specifics.bookmark().has_unique_position());
// Note that this gets computed for permanent nodes too.
syncer::ClientTagHash client_tag_hash =
GetClientTagHashFromUuid(bookmark_node->uuid());
sync_pb::EntityMetadata metadata;
metadata.set_is_deleted(false);
metadata.set_server_id(sync_id);
metadata.set_server_version(server_version);
metadata.set_creation_time(syncer::TimeToProtoTime(creation_time));
metadata.set_modification_time(syncer::TimeToProtoTime(creation_time));
metadata.set_sequence_number(0);
metadata.set_acked_sequence_number(0);
*metadata.mutable_unique_position() = specifics.bookmark().unique_position();
metadata.set_client_tag_hash(client_tag_hash.value());
HashSpecifics(specifics, metadata.mutable_specifics_hash());
metadata.set_bookmark_favicon_hash(
base::PersistentHash(specifics.bookmark().favicon()));
auto entity = std::make_unique<SyncedBookmarkTrackerEntity>(
bookmark_node, std::move(metadata));
DCHECK_EQ(0U, bookmark_node_to_entities_map_.count(bookmark_node));
bookmark_node_to_entities_map_[bookmark_node] = entity.get();
DCHECK_EQ(0U, client_tag_hash_to_entities_map_.count(client_tag_hash));
client_tag_hash_to_entities_map_.emplace(std::move(client_tag_hash),
entity.get());
DCHECK_EQ(0U, sync_id_to_entities_map_.count(sync_id));
const SyncedBookmarkTrackerEntity* raw_entity = entity.get();
sync_id_to_entities_map_[sync_id] = std::move(entity);
DCHECK_EQ(sync_id_to_entities_map_.size(),
client_tag_hash_to_entities_map_.size());
return raw_entity;
}
void SyncedBookmarkTracker::Update(const SyncedBookmarkTrackerEntity* entity,
int64_t server_version,
base::Time modification_time,
const sync_pb::EntitySpecifics& specifics) {
DCHECK_GT(specifics.ByteSizeLong(), 0u);
DCHECK(entity);
DCHECK(specifics.has_bookmark());
DCHECK(specifics.bookmark().has_unique_position());
SyncedBookmarkTrackerEntity* mutable_entity = AsMutableEntity(entity);
mutable_entity->MutableMetadata()->set_server_version(server_version);
mutable_entity->MutableMetadata()->set_modification_time(
syncer::TimeToProtoTime(modification_time));
*mutable_entity->MutableMetadata()->mutable_unique_position() =
specifics.bookmark().unique_position();
HashSpecifics(specifics,
mutable_entity->MutableMetadata()->mutable_specifics_hash());
mutable_entity->MutableMetadata()->set_bookmark_favicon_hash(
base::PersistentHash(specifics.bookmark().favicon()));
}
void SyncedBookmarkTracker::UpdateServerVersion(
const SyncedBookmarkTrackerEntity* entity,
int64_t server_version) {
DCHECK(entity);
AsMutableEntity(entity)->MutableMetadata()->set_server_version(
server_version);
}
void SyncedBookmarkTracker::MarkCommitMayHaveStarted(
const SyncedBookmarkTrackerEntity* entity) {
DCHECK(entity);
AsMutableEntity(entity)->set_commit_may_have_started(true);
}
void SyncedBookmarkTracker::MarkDeleted(
const SyncedBookmarkTrackerEntity* entity,
const base::Location& location) {
DCHECK(entity);
DCHECK(!entity->metadata().is_deleted());
DCHECK(entity->bookmark_node());
DCHECK_EQ(1U, bookmark_node_to_entities_map_.count(entity->bookmark_node()));
SyncedBookmarkTrackerEntity* mutable_entity = AsMutableEntity(entity);
mutable_entity->MutableMetadata()->set_is_deleted(true);
*mutable_entity->MutableMetadata()->mutable_deletion_origin() =
syncer::DeletionOrigin::FromLocation(location).ToProto(
version_info::GetVersionNumber());
mutable_entity->MutableMetadata()->clear_bookmark_favicon_hash();
// Clear all references to the deleted bookmark node.
bookmark_node_to_entities_map_.erase(mutable_entity->bookmark_node());
mutable_entity->clear_bookmark_node();
DCHECK_EQ(0, std::ranges::count(ordered_local_tombstones_, entity));
ordered_local_tombstones_.push_back(mutable_entity);
}
void SyncedBookmarkTracker::Remove(const SyncedBookmarkTrackerEntity* entity) {
DCHECK(entity);
DCHECK_EQ(entity, GetEntityForSyncId(entity->metadata().server_id()));
DCHECK_EQ(entity, GetEntityForClientTagHash(entity->GetClientTagHash()));
DCHECK_EQ(sync_id_to_entities_map_.size(),
client_tag_hash_to_entities_map_.size());
if (entity->bookmark_node()) {
DCHECK(!entity->metadata().is_deleted());
DCHECK_EQ(0, std::ranges::count(ordered_local_tombstones_, entity));
bookmark_node_to_entities_map_.erase(entity->bookmark_node());
} else {
DCHECK(entity->metadata().is_deleted());
}
client_tag_hash_to_entities_map_.erase(entity->GetClientTagHash());
std::erase(ordered_local_tombstones_, entity);
sync_id_to_entities_map_.erase(entity->metadata().server_id());
DCHECK_EQ(sync_id_to_entities_map_.size(),
client_tag_hash_to_entities_map_.size());
}
void SyncedBookmarkTracker::IncrementSequenceNumber(
const SyncedBookmarkTrackerEntity* entity) {
DCHECK(entity);
DCHECK(!entity->bookmark_node() ||
!entity->bookmark_node()->is_permanent_node());
AsMutableEntity(entity)->MutableMetadata()->set_sequence_number(
entity->metadata().sequence_number() + 1);
}
sync_pb::BookmarkModelMetadata
SyncedBookmarkTracker::BuildBookmarkModelMetadata() const {
sync_pb::BookmarkModelMetadata model_metadata;
model_metadata.set_bookmarks_hierarchy_fields_reuploaded(
bookmarks_reuploaded_);
if (num_ignored_updates_due_to_missing_parent_.has_value()) {
model_metadata.set_num_ignored_updates_due_to_missing_parent(
*num_ignored_updates_due_to_missing_parent_);
}
if (max_version_among_ignored_updates_due_to_missing_parent_.has_value()) {
model_metadata.set_max_version_among_ignored_updates_due_to_missing_parent(
*max_version_among_ignored_updates_due_to_missing_parent_);
}
for (const auto& [sync_id, entity] : sync_id_to_entities_map_) {
DCHECK(entity) << " for ID " << sync_id;
if (entity->metadata().is_deleted()) {
// Deletions will be added later because they need to maintain the same
// order as in |ordered_local_tombstones_|.
continue;
}
DCHECK(entity->bookmark_node());
sync_pb::BookmarkMetadata* bookmark_metadata =
model_metadata.add_bookmarks_metadata();
bookmark_metadata->set_id(entity->bookmark_node()->id());
*bookmark_metadata->mutable_metadata() = entity->metadata();
}
// Add pending deletions.
for (const SyncedBookmarkTrackerEntity* tombstone_entity :
ordered_local_tombstones_) {
DCHECK(tombstone_entity);
DCHECK(tombstone_entity->metadata().is_deleted());
sync_pb::BookmarkMetadata* bookmark_metadata =
model_metadata.add_bookmarks_metadata();
*bookmark_metadata->mutable_metadata() = tombstone_entity->metadata();
}
*model_metadata.mutable_data_type_state() = data_type_state_;
return model_metadata;
}
bool SyncedBookmarkTracker::HasLocalChanges() const {
for (const auto& [sync_id, entity] : sync_id_to_entities_map_) {
if (entity->IsUnsynced()) {
return true;
}
}
return false;
}
size_t SyncedBookmarkTracker::GetUnsyncedDataCount() const {
return std::ranges::count_if(GetAllEntities(),
&SyncedBookmarkTrackerEntity::IsUnsynced);
}
std::vector<const SyncedBookmarkTrackerEntity*>
SyncedBookmarkTracker::GetAllEntities() const {
std::vector<const SyncedBookmarkTrackerEntity*> entities;
for (const auto& [sync_id, entity] : sync_id_to_entities_map_) {
entities.push_back(entity.get());
}
return entities;
}
std::vector<const SyncedBookmarkTrackerEntity*>
SyncedBookmarkTracker::GetEntitiesWithLocalChanges() const {
std::vector<const SyncedBookmarkTrackerEntity*> entities_with_local_changes;
// Entities with local non deletions should be sorted such that parent
// creation/update comes before child creation/update.
for (const auto& [sync_id, entity] : sync_id_to_entities_map_) {
if (entity->metadata().is_deleted()) {
// Deletions are stored sorted in |ordered_local_tombstones_| and will be
// added later.
continue;
}
if (entity->IsUnsynced()) {
entities_with_local_changes.push_back(entity.get());
}
}
std::vector<const SyncedBookmarkTrackerEntity*> ordered_local_changes =
ReorderUnsyncedEntitiesExceptDeletions(entities_with_local_changes);
for (const SyncedBookmarkTrackerEntity* tombstone_entity :
ordered_local_tombstones_) {
DCHECK_EQ(0, std::ranges::count(ordered_local_changes, tombstone_entity));
ordered_local_changes.push_back(tombstone_entity);
}
return ordered_local_changes;
}
SyncedBookmarkTracker::SyncedBookmarkTracker(
sync_pb::DataTypeState data_type_state,
bool bookmarks_reuploaded,
std::optional<int64_t> num_ignored_updates_due_to_missing_parent,
std::optional<int64_t>
max_version_among_ignored_updates_due_to_missing_parent)
: data_type_state_(std::move(data_type_state)),
bookmarks_reuploaded_(bookmarks_reuploaded),
num_ignored_updates_due_to_missing_parent_(
num_ignored_updates_due_to_missing_parent),
max_version_among_ignored_updates_due_to_missing_parent_(
max_version_among_ignored_updates_due_to_missing_parent) {}
SyncedBookmarkTracker::CorruptionReason
SyncedBookmarkTracker::InitEntitiesFromModelAndMetadata(
const BookmarkModelView* model,
sync_pb::BookmarkModelMetadata model_metadata) {
DCHECK(syncer::IsInitialSyncDone(data_type_state_.initial_sync_state()));
// Build a temporary map to look up bookmark nodes efficiently by node ID.
std::unordered_map<int64_t, const bookmarks::BookmarkNode*>
id_to_bookmark_node_map = BuildIdToBookmarkNodeMap(model);
for (sync_pb::BookmarkMetadata& bookmark_metadata :
*model_metadata.mutable_bookmarks_metadata()) {
if (!bookmark_metadata.metadata().has_server_id()) {
DLOG(ERROR) << "Error when decoding sync metadata: Entities must contain "
"server id.";
return CorruptionReason::MISSING_SERVER_ID;
}
const std::string sync_id = bookmark_metadata.metadata().server_id();
if (sync_id_to_entities_map_.count(sync_id) != 0) {
DLOG(ERROR) << "Error when decoding sync metadata: Duplicated server id.";
return CorruptionReason::DUPLICATED_SERVER_ID;
}
// Handle tombstones.
if (bookmark_metadata.metadata().is_deleted()) {
if (bookmark_metadata.has_id()) {
DLOG(ERROR) << "Error when decoding sync metadata: Tombstones "
"shouldn't have a bookmark id.";
return CorruptionReason::BOOKMARK_ID_IN_TOMBSTONE;
}
if (!bookmark_metadata.metadata().has_client_tag_hash()) {
DLOG(ERROR) << "Error when decoding sync metadata: "
<< "Tombstone client tag hash is missing.";
return CorruptionReason::MISSING_CLIENT_TAG_HASH;
}
const syncer::ClientTagHash client_tag_hash =
syncer::ClientTagHash::FromHashed(
bookmark_metadata.metadata().client_tag_hash());
auto tombstone_entity = std::make_unique<SyncedBookmarkTrackerEntity>(
/*node=*/nullptr, std::move(*bookmark_metadata.mutable_metadata()));
if (!client_tag_hash_to_entities_map_
.emplace(client_tag_hash, tombstone_entity.get())
.second) {
DLOG(ERROR) << "Error when decoding sync metadata: Duplicated client "
"tag hash.";
return CorruptionReason::DUPLICATED_CLIENT_TAG_HASH;
}
ordered_local_tombstones_.push_back(tombstone_entity.get());
DCHECK_EQ(0U, sync_id_to_entities_map_.count(sync_id));
sync_id_to_entities_map_[sync_id] = std::move(tombstone_entity);
DCHECK_EQ(sync_id_to_entities_map_.size(),
client_tag_hash_to_entities_map_.size());
continue;
}
// Non-tombstones.
DCHECK(!bookmark_metadata.metadata().is_deleted());
if (!bookmark_metadata.has_id()) {
DLOG(ERROR)
<< "Error when decoding sync metadata: Bookmark id is missing.";
return CorruptionReason::MISSING_BOOKMARK_ID;
}
const bookmarks::BookmarkNode* node =
id_to_bookmark_node_map[bookmark_metadata.id()];
if (!node) {
DLOG(ERROR) << "Error when decoding sync metadata: unknown Bookmark id.";
return CorruptionReason::UNKNOWN_BOOKMARK_ID;
}
// Note that currently the client tag hash is persisted for permanent nodes
// too, although it's irrelevant (and even subject to change value upon
// restart if the code changes).
if (!bookmark_metadata.metadata().has_client_tag_hash() &&
!node->is_permanent_node()) {
DLOG(ERROR) << "Error when decoding sync metadata: "
<< "Bookmark client tag hash is missing.";
return CorruptionReason::MISSING_CLIENT_TAG_HASH;
}
// The client-tag-hash is expected to be equal to the hash of the bookmark's
// UUID. This can be hit for example if local bookmark UUIDs were
// reassigned upon startup due to duplicates (which is a BookmarkModel
// invariant violation and should be impossible).
const syncer::ClientTagHash client_tag_hash =
GetClientTagHashFromUuid(node->uuid());
if (client_tag_hash !=
syncer::ClientTagHash::FromHashed(
bookmark_metadata.metadata().client_tag_hash())) {
if (node->is_permanent_node()) {
// For permanent nodes the client tag hash is irrelevant and subject to
// change if the constants in components/bookmarks change and adopt
// different UUID constants. To avoid treating such state as corrupt
// metadata, let's fix it automatically.
bookmark_metadata.mutable_metadata()->set_client_tag_hash(
client_tag_hash.value());
} else {
DLOG(ERROR) << "Bookmark UUID does not match the client tag.";
return CorruptionReason::BOOKMARK_UUID_MISMATCH;
}
}
// The code populates |bookmark_favicon_hash| for all new nodes, including
// folders, but it is possible that folders are tracked that predate the
// introduction of |bookmark_favicon_hash|, which never got it populated
// because for some time it got populated opportunistically upon favicon
// load, which never triggers for folders.
if (!node->is_folder() &&
!bookmark_metadata.metadata().has_bookmark_favicon_hash()) {
return CorruptionReason::MISSING_FAVICON_HASH;
}
auto entity = std::make_unique<SyncedBookmarkTrackerEntity>(
node, std::move(*bookmark_metadata.mutable_metadata()));
if (!client_tag_hash_to_entities_map_.emplace(client_tag_hash, entity.get())
.second) {
DLOG(ERROR) << "Error when decoding sync metadata: Duplicated client "
"tag hash.";
return CorruptionReason::DUPLICATED_CLIENT_TAG_HASH;
}
entity->set_commit_may_have_started(true);
CHECK_EQ(0U, bookmark_node_to_entities_map_.count(node));
bookmark_node_to_entities_map_[node] = entity.get();
DCHECK_EQ(0U, sync_id_to_entities_map_.count(sync_id));
sync_id_to_entities_map_[sync_id] = std::move(entity);
DCHECK_EQ(sync_id_to_entities_map_.size(),
client_tag_hash_to_entities_map_.size());
}
// See if there are untracked entities in the BookmarkModel.
std::vector<int> model_node_ids;
ui::TreeNodeIterator<const bookmarks::BookmarkNode> iterator(
model->root_node());
while (iterator.has_next()) {
const bookmarks::BookmarkNode* node = iterator.Next();
if (!model->IsNodeSyncable(node)) {
if (bookmark_node_to_entities_map_.count(node) != 0) {
return CorruptionReason::TRACKED_MANAGED_NODE;
}
continue;
}
if (bookmark_node_to_entities_map_.count(node) == 0) {
return CorruptionReason::UNTRACKED_BOOKMARK;
}
}
CheckAllNodesTracked(model);
return CorruptionReason::NO_CORRUPTION;
}
std::vector<const SyncedBookmarkTrackerEntity*>
SyncedBookmarkTracker::ReorderUnsyncedEntitiesExceptDeletions(
const std::vector<const SyncedBookmarkTrackerEntity*>& entities) const {
// This method sorts the entities with local non deletions such that parent
// creation/update comes before child creation/update.
// The algorithm works by constructing a forest of all non-deletion updates
// and then traverses each tree in the forest recursively:
// 1. Iterate over all entities and collect all nodes in |nodes|.
// 2. Iterate over all entities again and node that is a child of another
// node. What's left in |nodes| are the roots of the forest.
// 3. Start at each root in |nodes|, emit the update and recurse over its
// children.
std::unordered_set<const bookmarks::BookmarkNode*> nodes;
// Collect nodes with updates
for (const SyncedBookmarkTrackerEntity* entity : entities) {
DCHECK(entity->IsUnsynced());
DCHECK(!entity->metadata().is_deleted());
DCHECK(entity->bookmark_node());
nodes.insert(entity->bookmark_node());
}
// Remove those who are direct children of another node.
for (const SyncedBookmarkTrackerEntity* entity : entities) {
const bookmarks::BookmarkNode* node = entity->bookmark_node();
for (const auto& child : node->children()) {
nodes.erase(child.get());
}
}
// |nodes| contains only roots of all trees in the forest all of which are
// ready to be processed because their parents have no pending updates.
std::vector<const SyncedBookmarkTrackerEntity*> ordered_entities;
for (const bookmarks::BookmarkNode* node : nodes) {
TraverseAndAppend(node, &ordered_entities);
}
return ordered_entities;
}
bool SyncedBookmarkTracker::ReuploadBookmarksOnLoadIfNeeded() {
if (bookmarks_reuploaded_ ||
!base::FeatureList::IsEnabled(switches::kSyncReuploadBookmarks)) {
return false;
}
for (const auto& [sync_id, entity] : sync_id_to_entities_map_) {
if (entity->IsUnsynced() || entity->metadata().is_deleted()) {
continue;
}
if (entity->bookmark_node()->is_permanent_node()) {
continue;
}
IncrementSequenceNumber(entity.get());
}
SetBookmarksReuploaded();
return true;
}
void SyncedBookmarkTracker::RecordIgnoredServerUpdateDueToMissingParent(
int64_t server_version) {
if (num_ignored_updates_due_to_missing_parent_.has_value()) {
++(*num_ignored_updates_due_to_missing_parent_);
}
if (max_version_among_ignored_updates_due_to_missing_parent_.has_value()) {
*max_version_among_ignored_updates_due_to_missing_parent_ =
std::max(*max_version_among_ignored_updates_due_to_missing_parent_,
server_version);
} else {
max_version_among_ignored_updates_due_to_missing_parent_ = server_version;
}
}
std::optional<int64_t>
SyncedBookmarkTracker::GetNumIgnoredUpdatesDueToMissingParentForTest() const {
return num_ignored_updates_due_to_missing_parent_;
}
std::optional<int64_t> SyncedBookmarkTracker::
GetMaxVersionAmongIgnoredUpdatesDueToMissingParentForTest() const {
return max_version_among_ignored_updates_due_to_missing_parent_;
}
void SyncedBookmarkTracker::TraverseAndAppend(
const bookmarks::BookmarkNode* node,
std::vector<const SyncedBookmarkTrackerEntity*>* ordered_entities) const {
const SyncedBookmarkTrackerEntity* entity = GetEntityForBookmarkNode(node);
DCHECK(entity);
DCHECK(entity->IsUnsynced());
DCHECK(!entity->metadata().is_deleted());
ordered_entities->push_back(entity);
// Recurse for all children.
for (const auto& child : node->children()) {
const SyncedBookmarkTrackerEntity* child_entity =
GetEntityForBookmarkNode(child.get());
DCHECK(child_entity);
if (!child_entity->IsUnsynced()) {
// If the entity has no local change, no need to check its children. If
// any of the children would have a pending commit, it would be a root for
// a separate tree in the forest built in
// ReorderEntitiesWithLocalNonDeletions() and will be handled by another
// call to TraverseAndAppend().
continue;
}
if (child_entity->metadata().is_deleted()) {
// Deletion are stored sorted in |ordered_local_tombstones_| and will be
// added later.
continue;
}
TraverseAndAppend(child.get(), ordered_entities);
}
}
void SyncedBookmarkTracker::UpdateUponCommitResponse(
const SyncedBookmarkTrackerEntity* entity,
const std::string& sync_id,
int64_t server_version,
int64_t acked_sequence_number) {
DCHECK(entity);
SyncedBookmarkTrackerEntity* mutable_entity = AsMutableEntity(entity);
mutable_entity->MutableMetadata()->set_acked_sequence_number(
acked_sequence_number);
mutable_entity->MutableMetadata()->set_server_version(server_version);
// If there are no pending commits, remove tombstones.
if (!mutable_entity->IsUnsynced() &&
mutable_entity->metadata().is_deleted()) {
Remove(mutable_entity);
return;
}
UpdateSyncIdIfNeeded(mutable_entity, sync_id);
}
void SyncedBookmarkTracker::UpdateSyncIdIfNeeded(
const SyncedBookmarkTrackerEntity* entity,
const std::string& sync_id) {
DCHECK(entity);
const std::string old_id = entity->metadata().server_id();
if (old_id == sync_id) {
return;
}
DCHECK_EQ(1U, sync_id_to_entities_map_.count(old_id));
DCHECK_EQ(0U, sync_id_to_entities_map_.count(sync_id));
std::unique_ptr<SyncedBookmarkTrackerEntity> owned_entity =
std::move(sync_id_to_entities_map_.at(old_id));
DCHECK_EQ(entity, owned_entity.get());
owned_entity->MutableMetadata()->set_server_id(sync_id);
sync_id_to_entities_map_[sync_id] = std::move(owned_entity);
sync_id_to_entities_map_.erase(old_id);
}
void SyncedBookmarkTracker::UndeleteTombstoneForBookmarkNode(
const SyncedBookmarkTrackerEntity* entity,
const bookmarks::BookmarkNode* node) {
DCHECK(entity);
DCHECK(node);
DCHECK(entity->metadata().is_deleted());
const syncer::ClientTagHash client_tag_hash =
GetClientTagHashFromUuid(node->uuid());
// The same entity must be used only for the same bookmark node.
DCHECK_EQ(entity->metadata().client_tag_hash(), client_tag_hash.value());
DCHECK(bookmark_node_to_entities_map_.find(node) ==
bookmark_node_to_entities_map_.end());
DCHECK_EQ(GetEntityForSyncId(entity->metadata().server_id()), entity);
std::erase(ordered_local_tombstones_, entity);
SyncedBookmarkTrackerEntity* mutable_entity = AsMutableEntity(entity);
mutable_entity->MutableMetadata()->set_is_deleted(false);
mutable_entity->set_bookmark_node(node);
bookmark_node_to_entities_map_[node] = mutable_entity;
}
void SyncedBookmarkTracker::AckSequenceNumber(
const SyncedBookmarkTrackerEntity* entity) {
DCHECK(entity);
AsMutableEntity(entity)->MutableMetadata()->set_acked_sequence_number(
entity->metadata().sequence_number());
}
bool SyncedBookmarkTracker::IsEmpty() const {
return sync_id_to_entities_map_.empty();
}
size_t SyncedBookmarkTracker::EstimateMemoryUsage() const {
using base::trace_event::EstimateMemoryUsage;
size_t memory_usage = 0;
memory_usage += EstimateMemoryUsage(sync_id_to_entities_map_);
memory_usage += EstimateMemoryUsage(bookmark_node_to_entities_map_);
memory_usage += EstimateMemoryUsage(ordered_local_tombstones_);
memory_usage += EstimateMemoryUsage(data_type_state_);
return memory_usage;
}
size_t SyncedBookmarkTracker::TrackedBookmarksCount() const {
return bookmark_node_to_entities_map_.size();
}
size_t SyncedBookmarkTracker::TrackedUncommittedTombstonesCount() const {
return ordered_local_tombstones_.size();
}
size_t SyncedBookmarkTracker::TrackedEntitiesCountForTest() const {
return sync_id_to_entities_map_.size();
}
void SyncedBookmarkTracker::ClearSpecificsHashForTest(
const SyncedBookmarkTrackerEntity* entity) {
AsMutableEntity(entity)->MutableMetadata()->clear_specifics_hash();
}
void SyncedBookmarkTracker::CheckAllNodesTracked(
const BookmarkModelView* bookmark_model) const {
#if DCHECK_IS_ON()
DCHECK(GetEntityForBookmarkNode(bookmark_model->bookmark_bar_node()));
DCHECK(GetEntityForBookmarkNode(bookmark_model->other_node()));
DCHECK(GetEntityForBookmarkNode(bookmark_model->mobile_node()));
ui::TreeNodeIterator<const bookmarks::BookmarkNode> iterator(
bookmark_model->root_node());
while (iterator.has_next()) {
const bookmarks::BookmarkNode* node = iterator.Next();
if (!bookmark_model->IsNodeSyncable(node)) {
DCHECK(!GetEntityForBookmarkNode(node));
continue;
}
DCHECK(GetEntityForBookmarkNode(node));
}
#endif // DCHECK_IS_ON()
}
} // namespace sync_bookmarks
|