File: app_list_model_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (655 lines) | stat: -rw-r--r-- 26,524 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "ash/app_list/model/app_list_model.h"

#include <stddef.h>

#include <map>
#include <string>

#include "ash/app_list/model/app_list_folder_item.h"
#include "ash/app_list/model/app_list_item.h"
#include "ash/app_list/model/app_list_model_observer.h"
#include "ash/app_list/model/app_list_test_model.h"
#include "ash/constants/ash_features.h"
#include "ash/public/cpp/app_list/app_list_config.h"
#include "ash/public/cpp/app_list/app_list_config_provider.h"
#include "base/command_line.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/models/list_model_observer.h"

namespace ash {

namespace {

class TestObserver : public AppListModelObserver {
 public:
  TestObserver() = default;
  TestObserver(const TestObserver&) = delete;
  TestObserver& operator=(const TestObserver&) = delete;
  ~TestObserver() override = default;

  // AppListModelObserver
  void OnAppListModelStatusChanged() override { ++status_changed_count_; }

  void OnAppListItemAdded(AppListItem* item) override { items_added_++; }

  void OnAppListItemWillBeDeleted(AppListItem* item) override {
    items_removed_++;
  }

  void OnAppListItemUpdated(AppListItem* item) override { items_updated_++; }

  int status_changed_count() const { return status_changed_count_; }
  size_t items_added() { return items_added_; }
  size_t items_removed() { return items_removed_; }
  size_t items_updated() { return items_updated_; }

  void ResetCounts() {
    status_changed_count_ = 0;
    items_added_ = 0;
    items_removed_ = 0;
    items_updated_ = 0;
  }

 private:
  int status_changed_count_ = 0;
  size_t items_added_ = 0;
  size_t items_removed_ = 0;
  size_t items_updated_ = 0;
};

}  // namespace

class AppListModelTest : public testing::Test {
 public:
  AppListModelTest() = default;
  AppListModelTest(const AppListModelTest&) = delete;
  AppListModelTest& operator=(const AppListModelTest&) = delete;
  ~AppListModelTest() override = default;

  // testing::Test overrides:
  void SetUp() override {
    model_ = std::make_unique<test::AppListTestModel>();
    model_->AddObserver(&observer_);
  }
  void TearDown() override { model_->RemoveObserver(&observer_); }

 protected:
  static bool ItemObservedByFolder(const AppListFolderItem* folder,
                                   const AppListItem* item,
                                   AppListConfigType config) {
    return item->observers_.HasObserver(
        folder->GetFolderImageForTesting(config));
  }

  std::string GetItemListContents(AppListItemList* item_list) {
    std::string s;
    for (size_t i = 0; i < item_list->item_count(); ++i) {
      if (i != 0)
        s += ",";
      s += item_list->item_at(i)->id();
    }
    return s;
  }

  bool MoveItemToFolderAt(AppListItem* item,
                          const std::string& folder_id,
                          const syncer::StringOrdinal& position) {
    if (item->folder_id() == folder_id)
      return false;

    AppListFolderItem* src_folder = model_->FindFolderItem(item->folder_id());
    if (src_folder &&
        src_folder->folder_type() == AppListFolderItem::FOLDER_TYPE_OEM) {
      return false;
    }

    model_->MoveItemToFolder(item, folder_id);
    model_->SetItemPosition(item, position);
    return true;
  }

  std::string GetModelContents() {
    return GetItemListContents(model_->top_level_item_list());
  }

  // Creates a folder named `name` with `num_apps` items. The returned pointer
  // is owned by the `model_`.
  AppListFolderItem* CreateFolderWithApps(const char* name, size_t num_apps) {
    AppListFolderItem* folder = new AppListFolderItem(name, model_.get());
    model_->AddItem(folder);  // Takes ownership.
    for (int i = 0; static_cast<size_t>(i) < num_apps; ++i) {
      model_->AddItemToFolder(model_->CreateItem(model_->GetItemName(i)),
                              folder->id());
    }
    return folder;
  }

  std::unique_ptr<test::AppListTestModel> model_;
  TestObserver observer_;
};

TEST_F(AppListModelTest, SetStatus) {
  EXPECT_EQ(AppListModelStatus::kStatusNormal, model_->status());
  model_->SetStatus(AppListModelStatus::kStatusSyncing);
  EXPECT_EQ(1, observer_.status_changed_count());
  EXPECT_EQ(AppListModelStatus::kStatusSyncing, model_->status());
  model_->SetStatus(AppListModelStatus::kStatusNormal);
  EXPECT_EQ(2, observer_.status_changed_count());
  // Set the same status, no change is expected.
  model_->SetStatus(AppListModelStatus::kStatusNormal);
  EXPECT_EQ(2, observer_.status_changed_count());
}

TEST_F(AppListModelTest, AppsObserver) {
  const size_t num_apps = 2;
  model_->PopulateApps(num_apps);
  EXPECT_EQ(num_apps, observer_.items_added());
}

TEST_F(AppListModelTest, ModelGetItem) {
  const size_t num_apps = 2;
  model_->PopulateApps(num_apps);
  AppListItem* item0 = model_->top_level_item_list()->item_at(0);
  ASSERT_TRUE(item0);
  EXPECT_EQ(model_->GetItemName(0), item0->id());
  AppListItem* item1 = model_->top_level_item_list()->item_at(1);
  ASSERT_TRUE(item1);
  EXPECT_EQ(model_->GetItemName(1), item1->id());
}

TEST_F(AppListModelTest, ModelFindItem) {
  const size_t num_apps = 2;
  model_->PopulateApps(num_apps);
  std::string item_name0 = model_->GetItemName(0);
  AppListItem* item0 = model_->FindItem(item_name0);
  ASSERT_TRUE(item0);
  EXPECT_EQ(item_name0, item0->id());
  std::string item_name1 = model_->GetItemName(1);
  AppListItem* item1 = model_->FindItem(item_name1);
  ASSERT_TRUE(item1);
  EXPECT_EQ(item_name1, item1->id());
}

TEST_F(AppListModelTest, SetItemPosition) {
  const size_t num_apps = 2;
  model_->PopulateApps(num_apps);
  // Adding another item will add it to the end.
  model_->CreateAndAddItem("Added Item 1");
  ASSERT_EQ(num_apps + 1, model_->top_level_item_list()->item_count());
  EXPECT_EQ("Added Item 1",
            model_->top_level_item_list()->item_at(num_apps)->id());
  // Add an item between items 0 and 1.
  AppListItem* item0 = model_->top_level_item_list()->item_at(0);
  ASSERT_TRUE(item0);
  AppListItem* item1 = model_->top_level_item_list()->item_at(1);
  ASSERT_TRUE(item1);
  AppListItem* item2 = model_->CreateItem("Added Item 2");
  model_->AddItem(item2);
  EXPECT_EQ("Item 0,Item 1,Added Item 1,Added Item 2", GetModelContents());
  model_->SetItemPosition(item2,
                          item0->position().CreateBetween(item1->position()));
  EXPECT_EQ(num_apps + 2, model_->top_level_item_list()->item_count());
  EXPECT_EQ(num_apps + 2, observer_.items_added());
  EXPECT_EQ("Item 0,Added Item 2,Item 1,Added Item 1", GetModelContents());
}

TEST_F(AppListModelTest, ModelMoveItem) {
  const size_t num_apps = 3;
  model_->PopulateApps(num_apps);
  // Adding another item will add it to the end.
  model_->CreateAndAddItem("Inserted Item");
  ASSERT_EQ(num_apps + 1, model_->top_level_item_list()->item_count());
  // Move it to the position 1.
  observer_.ResetCounts();
  model_->top_level_item_list()->MoveItem(num_apps, 1);
  EXPECT_EQ(1u, observer_.items_updated());
  EXPECT_EQ("Item 0,Inserted Item,Item 1,Item 2", GetModelContents());
}

TEST_F(AppListModelTest, ModelRemoveItem) {
  const size_t num_apps = 4;
  model_->PopulateApps(num_apps);
  // Remove an item in the middle.
  model_->DeleteItem(model_->GetItemName(1));
  EXPECT_EQ(num_apps - 1, model_->top_level_item_list()->item_count());
  EXPECT_EQ(1u, observer_.items_removed());
  EXPECT_EQ("Item 0,Item 2,Item 3", GetModelContents());
  // Remove the first item in the list.
  model_->DeleteItem(model_->GetItemName(0));
  EXPECT_EQ(num_apps - 2, model_->top_level_item_list()->item_count());
  EXPECT_EQ(2u, observer_.items_removed());
  EXPECT_EQ("Item 2,Item 3", GetModelContents());
  // Remove the last item in the list.
  model_->DeleteItem(model_->GetItemName(num_apps - 1));
  EXPECT_EQ(num_apps - 3, model_->top_level_item_list()->item_count());
  EXPECT_EQ(3u, observer_.items_removed());
  EXPECT_EQ("Item 2", GetModelContents());
}

TEST_F(AppListModelTest, AppOrder) {
  const size_t num_apps = 5;
  model_->PopulateApps(num_apps);
  // Ensure order is preserved.
  for (size_t i = 1; i < num_apps; ++i) {
    EXPECT_TRUE(
        model_->top_level_item_list()->item_at(i)->position().GreaterThan(
            model_->top_level_item_list()->item_at(i - 1)->position()));
  }
  // Move an app
  model_->top_level_item_list()->MoveItem(num_apps - 1, 1);
  // Ensure order is preserved.
  for (size_t i = 1; i < num_apps; ++i) {
    EXPECT_TRUE(
        model_->top_level_item_list()->item_at(i)->position().GreaterThan(
            model_->top_level_item_list()->item_at(i - 1)->position()));
  }
}

using AppListModelFolderTest = AppListModelTest;

// Test that moving an item into a folder does not crash. (See
// https://crbug.com/1130901)
TEST_F(AppListModelFolderTest, MergeItemIntoFolder) {
  model_->PopulateApps(1);

  AppListItem* item0 = model_->top_level_item_list()->item_at(0);
  const size_t num_folder_apps = 2;
  AppListFolderItem* folder = CreateFolderWithApps("folder1", num_folder_apps);

  // Calling MergeItems(AppListItem, AppListFolderItem) results in
  // AppListFolderItem being deleted. Previously AppListModel did not remove
  // itself from observing AppListFolderItem's AppListItemList, causing a crash
  // on ~AppListModel when clearing observers.
  model_->MergeItems(item0->id(), folder->id());
}

// Tests Icon generation configuration for folders on different grid types.
TEST_F(AppListModelFolderTest, NonSharedConfigIconGeneration) {
  // Ensure any configs set by previous tests are cleared.
  AppListConfigProvider::Get().ResetForTesting();

  // Start with kRegular config available.
  const AppListConfig* regular_config =
      AppListConfigProvider::Get().GetConfigForType(AppListConfigType::kRegular,
                                                    true);
  ASSERT_TRUE(regular_config);

  const size_t num_folder_apps = 5;
  const size_t num_observed_apps = 4;
  AppListFolderItem* folder = CreateFolderWithApps("folder1", num_folder_apps);

  // Verify that the folder has folder image for regular config.
  FolderImage* regular_config_image =
      folder->GetFolderImageForTesting(AppListConfigType::kRegular);
  ASSERT_TRUE(regular_config_image);
  EXPECT_EQ(regular_config->folder_icon_size(),
            regular_config_image->icon().size());

  // Verify that the folder is observing the app list item.
  EXPECT_TRUE(ItemObservedByFolder(
      folder, folder->item_list()->item_at(num_observed_apps - 1),
      AppListConfigType::kRegular));
  EXPECT_FALSE(ItemObservedByFolder(
      folder, folder->item_list()->item_at(num_observed_apps),
      AppListConfigType::kRegular));

  // Not kDense folder image, as the config does not exist yet.
  EXPECT_FALSE(folder->GetFolderImageForTesting(AppListConfigType::kDense));

  // Create dense config, and verify the folder image for dense config gets
  // created.
  const AppListConfig* dense_config =
      AppListConfigProvider::Get().GetConfigForType(AppListConfigType::kDense,
                                                    true);
  FolderImage* dense_config_image =
      folder->GetFolderImageForTesting(AppListConfigType::kDense);
  ASSERT_TRUE(dense_config_image);
  EXPECT_EQ(dense_config->folder_icon_size(),
            dense_config_image->icon().size());

  // Verify that the folder is observing the app list item.
  EXPECT_TRUE(ItemObservedByFolder(
      folder, folder->item_list()->item_at(num_observed_apps - 1),
      AppListConfigType::kDense));
  EXPECT_FALSE(ItemObservedByFolder(
      folder, folder->item_list()->item_at(num_observed_apps),
      AppListConfigType::kDense));

  AppListConfigProvider::Get().ResetForTesting();
}

TEST_F(AppListModelFolderTest, MergeItems) {
  model_->PopulateApps(3);
  ASSERT_EQ(3u, model_->top_level_item_list()->item_count());
  AppListItem* item0 = model_->top_level_item_list()->item_at(0);
  AppListItem* item1 = model_->top_level_item_list()->item_at(1);
  AppListItem* item2 = model_->top_level_item_list()->item_at(2);

  // Merge an item onto a non-existent target.
  EXPECT_EQ(std::string(), model_->MergeItems("nonexistent", item0->id()));
  ASSERT_EQ(3u, model_->top_level_item_list()->item_count());

  // Merge a non-existent item onto a target.
  EXPECT_EQ(std::string(), model_->MergeItems(item0->id(), "nonexistent"));
  ASSERT_EQ(3u, model_->top_level_item_list()->item_count());

  // Merge an item onto itself (should have no effect). This should not be
  // possible, but there have been bugs in the past that made it possible (see
  // http://crbug.com/415530), so it should be handled correctly.
  EXPECT_EQ(std::string(), model_->MergeItems(item0->id(), item0->id()));
  ASSERT_EQ(3u, model_->top_level_item_list()->item_count());

  // Merge two items.
  std::string folder1_id = model_->MergeItems(item0->id(), item1->id());
  ASSERT_EQ(2u,
            model_->top_level_item_list()->item_count());  // Folder + 1 item
  AppListFolderItem* folder1_item = model_->FindFolderItem(folder1_id);
  ASSERT_TRUE(folder1_item);
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder1_item->item_list()));

  // Merge an item onto an item that is already in a folder (should have no
  // effect). This should not be possible, but it should be handled correctly
  // if it does happen.
  EXPECT_EQ(std::string(), model_->MergeItems(item1->id(), item2->id()));
  ASSERT_EQ(2u,
            model_->top_level_item_list()->item_count());  // Folder + 1 item
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder1_item->item_list()));

  // Merge an item from the new folder into the third item.
  std::string folder2_id = model_->MergeItems(item2->id(), item1->id());
  ASSERT_EQ(2u, model_->top_level_item_list()->item_count());  // 2 folders
  AppListFolderItem* folder2_item = model_->FindFolderItem(folder2_id);
  EXPECT_EQ("Item 0", GetItemListContents(folder1_item->item_list()));
  EXPECT_EQ("Item 2,Item 1", GetItemListContents(folder2_item->item_list()));

  // Merge the remaining item to the new folder, ensure it is added to the end.
  std::string folder_id = model_->MergeItems(folder2_id, item0->id());
  EXPECT_EQ(folder2_id, folder_id);
  EXPECT_EQ("Item 2,Item 1,Item 0",
            GetItemListContents(folder2_item->item_list()));

  // The empty folder should be deleted.
  folder1_item = model_->FindFolderItem(folder1_id);
  EXPECT_FALSE(folder1_item);
  EXPECT_EQ(1u, model_->top_level_item_list()->item_count());  // 1 folder
}

TEST_F(AppListModelFolderTest, AddItemToFolder) {
  AppListFolderItem* folder = new AppListFolderItem("folder1", model_.get());
  model_->AddItem(folder);
  AppListItem* item0 = new AppListItem("Item 0");
  model_->AddItemToFolder(item0, folder->id());
  ASSERT_EQ(1u, model_->top_level_item_list()->item_count());
  AppListFolderItem* folder_item = model_->FindFolderItem(folder->id());
  ASSERT_TRUE(folder_item);
  ASSERT_EQ(1u, folder_item->item_list()->item_count());
  EXPECT_EQ(item0, folder_item->item_list()->item_at(0));
  EXPECT_EQ(folder->id(), item0->folder_id());
}

TEST_F(AppListModelFolderTest, MoveItemToFolder) {
  AppListFolderItem* folder = new AppListFolderItem("folder1", model_.get());
  model_->AddItem(folder);
  AppListItem* item0 = new AppListItem("Item 0");
  AppListItem* item1 = new AppListItem("Item 1");
  model_->AddItem(item0);
  model_->AddItem(item1);
  ASSERT_EQ(3u, model_->top_level_item_list()->item_count());
  // Move item0 and item1 to folder.
  std::string folder_id = folder->id();
  model_->MoveItemToFolder(item0, folder_id);
  model_->MoveItemToFolder(item1, folder_id);
  AppListFolderItem* folder_item = model_->FindFolderItem(folder_id);
  ASSERT_TRUE(folder_item);
  EXPECT_EQ(folder_id, item0->folder_id());
  EXPECT_EQ(folder_id, item1->folder_id());
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder_item->item_list()));
  // Move item0 out of folder.
  model_->MoveItemToFolder(item0, "");
  EXPECT_EQ("", item0->folder_id());
  folder_item = model_->FindFolderItem(folder_id);
  ASSERT_TRUE(folder_item);
  // Move item1 out of folder, folder should be deleted.
  model_->MoveItemToFolder(item1, "");
  EXPECT_EQ("", item1->folder_id());
  folder_item = model_->FindFolderItem(folder_id);
  EXPECT_FALSE(folder_item);
}

TEST_F(AppListModelFolderTest, MoveItemToRootAt) {
  model_->AddItem(new AppListItem("Item 0"));
  model_->AddItem(new AppListItem("Item 1"));
  AppListFolderItem* folder1 = static_cast<AppListFolderItem*>(
      model_->AddItem(new AppListFolderItem("folder1", model_.get())));
  model_->AddItem(new AppListItem("Item 2"));
  model_->AddItem(new AppListItem("Item 3"));
  ASSERT_EQ(5u, model_->top_level_item_list()->item_count());
  EXPECT_EQ("Item 0,Item 1,folder1,Item 2,Item 3", GetModelContents());
  // Move Item 1 to folder1, then Item 2 before Item 1.
  model_->MoveItemToFolder(model_->top_level_item_list()->item_at(1),
                           folder1->id());
  EXPECT_EQ("Item 0,folder1,Item 2,Item 3", GetModelContents());
  MoveItemToFolderAt(
      model_->top_level_item_list()->item_at(2), folder1->id(),
      folder1->item_list()->item_at(0)->position().CreateBefore());
  EXPECT_EQ("Item 2,Item 1", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("Item 0,folder1,Item 3", GetModelContents());
  // Move Item 2 out of folder to before folder.
  model_->MoveItemToRootAt(folder1->item_list()->item_at(0),
                           folder1->position());
  EXPECT_EQ("Item 0,Item 2,folder1,Item 3", GetModelContents());
  // Move remaining folder item, (Item 1) out of folder to folder position.
  ASSERT_EQ(1u, folder1->item_list()->item_count());
  model_->MoveItemToRootAt(folder1->item_list()->item_at(0),
                           folder1->position());
  EXPECT_EQ("Item 0,Item 2,Item 1,Item 3", GetModelContents());
}

TEST_F(AppListModelFolderTest, MoveItemFromFolderToFolder) {
  AppListFolderItem* folder0 = new AppListFolderItem("folder0", model_.get());
  AppListFolderItem* folder1 = new AppListFolderItem("folder1", model_.get());
  model_->AddItem(folder0);
  model_->AddItem(folder1);
  EXPECT_EQ("folder0,folder1", GetModelContents());
  AppListItem* item0 = new AppListItem("Item 0");
  AppListItem* item1 = new AppListItem("Item 1");
  model_->AddItemToFolder(item0, folder0->id());
  model_->AddItemToFolder(item1, folder0->id());
  EXPECT_EQ(folder0->id(), item0->folder_id());
  EXPECT_EQ(folder0->id(), item1->folder_id());
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder0->item_list()));

  // Move item0 from folder0 to folder1.
  model_->MoveItemToFolder(item0, folder1->id());
  ASSERT_EQ(1u, folder0->item_list()->item_count());
  ASSERT_EQ(1u, folder1->item_list()->item_count());
  EXPECT_EQ(folder1->id(), item0->folder_id());
  EXPECT_EQ("Item 1", GetItemListContents(folder0->item_list()));
  EXPECT_EQ("Item 0", GetItemListContents(folder1->item_list()));

  // Move item1 from folder0 to folder1. folder0 should get deleted.
  model_->MoveItemToFolder(item1, folder1->id());
  ASSERT_EQ(1u, model_->top_level_item_list()->item_count());
  ASSERT_EQ(2u, folder1->item_list()->item_count());
  EXPECT_EQ(folder1->id(), item1->folder_id());
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder1->item_list()));

  // Move item1 to a non-existent folder2 which should get created.
  model_->MoveItemToFolder(item1, "folder2");
  ASSERT_EQ(2u, model_->top_level_item_list()->item_count());
  ASSERT_EQ(1u, folder1->item_list()->item_count());
  EXPECT_EQ("folder2", item1->folder_id());
  AppListFolderItem* folder2 = model_->FindFolderItem("folder2");
  ASSERT_TRUE(folder2);
}

TEST_F(AppListModelFolderTest, UninstallFolderItems) {
  AppListItem* item0 = model_->CreateAndAddItem("Item 0");
  AppListItem* item1 = model_->CreateAndAddItem("Item 1");
  AppListItem* item2 = model_->CreateAndAddItem("Item 2");
  AppListFolderItem* folder1 = static_cast<AppListFolderItem*>(
      model_->AddItem(new AppListFolderItem("folder1", model_.get())));
  EXPECT_EQ("Item 0,Item 1,Item 2,folder1", GetModelContents());

  // Move all items to folder1.
  MoveItemToFolderAt(item0, folder1->id(), item0->position());
  MoveItemToFolderAt(item1, folder1->id(), item1->position());
  MoveItemToFolderAt(item2, folder1->id(), item2->position());
  EXPECT_EQ("Item 0,Item 1,Item 2", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("folder1", GetModelContents());

  // Delete Item 2 from folder.
  model_->DeleteItem("Item 2");
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("folder1", GetModelContents());

  // Delete Item 1 from folder, should reparent Item 0 and delete folder1.
  model_->DeleteItem("Item 1");
  EXPECT_EQ("Item 0", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("folder1", GetModelContents());
}

TEST_F(AppListModelFolderTest, UninstallSystemFolderItem) {
  AppListItem* item0 = model_->CreateAndAddItem("Item 0");
  AppListItem* item1 = model_->CreateAndAddItem("Item 1");
  AppListFolderItem* folder1 = static_cast<AppListFolderItem*>(
      model_->AddItem(new AppListFolderItem("folder1", model_.get())));
  folder1->SetIsSystemFolder(true);
  EXPECT_EQ("Item 0,Item 1,folder1", GetModelContents());

  // Move all items to folder1.
  MoveItemToFolderAt(item0, folder1->id(), item0->position());
  MoveItemToFolderAt(item1, folder1->id(), item1->position());
  EXPECT_EQ("Item 0,Item 1", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("folder1", GetModelContents());

  // Delete Item from folder.
  model_->DeleteItem("Item 1");
  ASSERT_EQ("folder1", GetModelContents());
  EXPECT_EQ("Item 0", GetItemListContents(folder1->item_list()));
}

TEST_F(AppListModelFolderTest, UninstallSingleItemFolderItem) {
  AppListItem* item0 = model_->CreateAndAddItem("Item 0");
  AppListFolderItem* folder1 = static_cast<AppListFolderItem*>(
      model_->AddItem(new AppListFolderItem("folder1", model_.get())));
  EXPECT_EQ("Item 0,folder1", GetModelContents());

  // Move item0 to folder1.
  MoveItemToFolderAt(item0, folder1->id(), item0->position());
  EXPECT_EQ("Item 0", GetItemListContents(folder1->item_list()));
  EXPECT_EQ("folder1", GetModelContents());

  // Delete only item from folder, folder should also be removed.
  model_->DeleteItem("Item 0");
  EXPECT_EQ(nullptr, model_->FindItem("folder1"));
  EXPECT_EQ("", GetModelContents());
}

TEST_F(AppListModelFolderTest, FindItemInFolder) {
  AppListFolderItem* folder = new AppListFolderItem("folder1", model_.get());
  EXPECT_TRUE(folder);
  model_->AddItem(folder);
  std::string folder_id = folder->id();
  AppListItem* item0 = new AppListItem("Item 0");
  model_->AddItemToFolder(item0, folder_id);
  AppListItem* found_item = model_->FindItem(item0->id());
  ASSERT_EQ(item0, found_item);
  EXPECT_EQ(folder_id, found_item->folder_id());
}

TEST_F(AppListModelFolderTest, OemFolder) {
  AppListFolderItem* folder = new AppListFolderItem(kOemFolderId, model_.get());
  model_->AddItem(folder);
  std::string folder_id = folder->id();

  // Should not be able to move to an OEM folder with MergeItems.
  AppListItem* item0 = new AppListItem("Item 0");
  model_->AddItem(item0);
  syncer::StringOrdinal item0_pos = item0->position();
  std::string new_folder = model_->MergeItems(folder_id, item0->id());
  EXPECT_EQ("", new_folder);
  EXPECT_EQ("", item0->folder_id());
  EXPECT_TRUE(item0->position().Equals(item0_pos));

  // Should not be able to move from an OEM folder with MoveItemToFolderAt.
  AppListItem* item1 = new AppListItem("Item 1");
  model_->AddItemToFolder(item1, folder_id);
  syncer::StringOrdinal item1_pos = item1->position();
  bool move_res = MoveItemToFolderAt(item1, "", syncer::StringOrdinal());
  EXPECT_FALSE(move_res);
  EXPECT_TRUE(item1->position().Equals(item1_pos));
}

TEST_F(AppListModelFolderTest, DisableFolders) {
  // Set up a folder with two items and an OEM folder with one item.
  AppListFolderItem* folder = new AppListFolderItem("folder1", model_.get());
  model_->AddItem(folder);
  std::string folder_id = folder->id();
  AppListItem* item0 = new AppListItem("Item 0");
  model_->AddItemToFolder(item0, folder_id);
  AppListItem* item1 = new AppListItem("Item 1");
  model_->AddItemToFolder(item1, folder_id);
  AppListFolderItem* folder_item = model_->FindFolderItem(folder_id);
  ASSERT_TRUE(folder_item);
  EXPECT_EQ(2u, folder_item->item_list()->item_count());
  AppListFolderItem* oem_folder =
      new AppListFolderItem(kOemFolderId, model_.get());
  model_->AddItem(oem_folder);
  AppListItem* oem_item = new AppListItem("OEM Item");
  std::string oem_folder_id = oem_folder->id();
  model_->AddItemToFolder(oem_item, oem_folder_id);
  EXPECT_EQ(std::string("folder1,") + kOemFolderId, GetModelContents());
}

TEST_F(AppListModelFolderTest, IsNewInstall) {
  AppListFolderItem* folder = CreateFolderWithApps("folder1", 2);
  AppListItem* item0 = model_->FindItem("Item 0");
  ASSERT_TRUE(item0);
  AppListItem* item1 = model_->FindItem("Item 1");
  ASSERT_TRUE(item1);

  // If both children are new installs, the folder contains a new install.
  item0->SetIsNewInstall(true);
  item1->SetIsNewInstall(true);
  EXPECT_TRUE(item0->is_new_install());
  EXPECT_TRUE(item1->is_new_install());
  EXPECT_TRUE(folder->is_new_install());

  // If one child is a new install, the folder contains a new install.
  item0->SetIsNewInstall(false);
  EXPECT_FALSE(item0->is_new_install());
  EXPECT_TRUE(item1->is_new_install());
  EXPECT_TRUE(folder->is_new_install());

  // If no child is a new install, the folder does not contain a new install.
  item1->SetIsNewInstall(false);
  EXPECT_FALSE(item0->is_new_install());
  EXPECT_FALSE(item1->is_new_install());
  EXPECT_FALSE(folder->is_new_install());
}

TEST_F(AppListModelFolderTest, IsNewInstallClearedOnDeleteItem) {
  AppListFolderItem* folder = CreateFolderWithApps("folder1", 2);
  AppListItem* item0 = model_->FindItem("Item 0");
  ASSERT_TRUE(item0);
  AppListItem* item1 = model_->FindItem("Item 1");
  ASSERT_TRUE(item1);

  // If the second item is a new install, the folder contains a new install.
  item1->SetIsNewInstall(true);
  EXPECT_TRUE(folder->is_new_install());

  // Deleting the item means the folder no longer contains a new install.
  model_->DeleteItem("Item 1");
  item1 = nullptr;
  EXPECT_FALSE(folder->is_new_install());
}

}  // namespace ash