1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/clipboard/clipboard_history_menu_model_adapter.h"
#include <string>
#include "ash/clipboard/clipboard_history.h"
#include "ash/clipboard/clipboard_history_controller_impl.h"
#include "ash/clipboard/clipboard_history_util.h"
#include "ash/clipboard/views/clipboard_history_view_constants.h"
#include "ash/constants/ash_features.h"
#include "ash/constants/ash_pref_names.h"
#include "ash/session/session_controller_impl.h"
#include "ash/shell.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/test/ash_test_base.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/test/test_future.h"
#include "chromeos/crosapi/mojom/clipboard_history.mojom.h"
#include "chromeos/ui/clipboard_history/clipboard_history_util.h"
#include "testing/gmock/include/gmock/gmock-matchers.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/clipboard/scoped_clipboard_writer.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/mojom/menu_source_type.mojom.h"
#include "ui/base/ui_base_types.h"
#include "ui/gfx/text_constants.h"
#include "ui/menus/simple_menu_model.h"
#include "ui/views/controls/label.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/styled_label.h"
#include "ui/views/view_utils.h"
namespace ash {
using ::testing::AllOf;
using ::testing::Bool;
using ::testing::Combine;
using ::testing::Conditional;
using ::testing::Eq;
using ::testing::IsNull;
using ::testing::NotNull;
using ::testing::Property;
using ::testing::ResultOf;
using ::testing::Values;
using ::testing::ValuesIn;
using ::testing::WithParamInterface;
using crosapi::mojom::ClipboardHistoryControllerShowSource;
namespace {
// Helpers ---------------------------------------------------------------------
ClipboardHistoryControllerImpl* GetClipboardHistoryController() {
return Shell::Get()->clipboard_history_controller();
}
std::vector<ClipboardHistoryControllerShowSource>
GetClipboardHistoryShowSources() {
std::vector<ClipboardHistoryControllerShowSource> sources;
for (int i =
static_cast<int>(ClipboardHistoryControllerShowSource::kMinValue);
i <= static_cast<int>(ClipboardHistoryControllerShowSource::kMaxValue);
++i) {
sources.push_back(static_cast<ClipboardHistoryControllerShowSource>(i));
}
return sources;
}
void FlushMessageLoop() {
base::RunLoop run_loop;
base::SequencedTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, run_loop.QuitClosure());
run_loop.Run();
}
// Matchers --------------------------------------------------------------------
template <typename ViewType, typename MatcherType>
auto GetViewById(int id, MatcherType m) {
return ResultOf(
[id](const auto* arg) {
return views::AsViewClass<ViewType>(arg->GetViewByID(id));
},
m);
}
} // namespace
// ClipboardHistoryMenuModelAdapterRefreshTest ---------------------------------
// Base class for `ClipboardHistoryMenuModelAdapter` tests whose only required
// parameterization is whether the clipboard history refresh is enabled.
class ClipboardHistoryMenuModelAdapterRefreshTest : public AshTestBase {
public:
ClipboardHistoryMenuModelAdapterRefreshTest() = default;
// AshTestBase:
void SetUp() override {
AshTestBase::SetUp();
GetClipboardHistoryController()->set_confirmed_operation_callback_for_test(
operation_confirmed_future_.GetRepeatingCallback());
}
void WriteTextToClipboardAndConfirm(const std::u16string& str) {
EXPECT_FALSE(operation_confirmed_future_.IsReady());
{
ui::ScopedClipboardWriter scw(ui::ClipboardBuffer::kCopyPaste);
scw.WriteText(str);
}
EXPECT_TRUE(operation_confirmed_future_.Take());
}
private:
base::test::TestFuture<bool> operation_confirmed_future_;
};
TEST_F(ClipboardHistoryMenuModelAdapterRefreshTest, FirstItemShowsCtrlVLabel) {
// Write items to clipboard history so that the menu can show.
WriteTextToClipboardAndConfirm(u"A");
WriteTextToClipboardAndConfirm(u"B");
WriteTextToClipboardAndConfirm(u"C");
// Show the clipboard history menu and wait for the first item to be selected
// so that item selection does not interfere with removing items later.
auto* const controller = GetClipboardHistoryController();
ASSERT_TRUE(controller);
base::RunLoop run_loop;
controller->set_initial_item_selected_callback_for_test(
run_loop.QuitClosure());
EXPECT_TRUE(controller->ShowMenu(
gfx::Rect(), ui::mojom::MenuSourceType::kNone,
ClipboardHistoryControllerShowSource::kDefaultValue));
run_loop.Run();
EXPECT_TRUE(controller->IsMenuShowing());
// Verify the number of items in the menu.
auto* const adapter = controller->context_menu_for_test();
ASSERT_EQ(adapter->GetMenuItemsCount(), 3u);
// Get handles to three clipboard history items' Ctrl+V labels, noting that
// the items' indices will be offset by 1 if the menu has a header.
const size_t offset = 1u;
const auto* const ctrl_v_label1 =
adapter->GetMenuItemViewAtForTest(0u + offset)
->GetViewByID(clipboard_history_util::kCtrlVLabelID);
ASSERT_TRUE(ctrl_v_label1);
const auto* const ctrl_v_label2 =
adapter->GetMenuItemViewAtForTest(1u + offset)
->GetViewByID(clipboard_history_util::kCtrlVLabelID);
ASSERT_TRUE(ctrl_v_label2);
const auto* const ctrl_v_label3 =
adapter->GetMenuItemViewAtForTest(2u + offset)
->GetViewByID(clipboard_history_util::kCtrlVLabelID);
ASSERT_TRUE(ctrl_v_label3);
// If the labels do exist, test that only the first item's label is visible.
// Initially, the first item's label should be visible.
EXPECT_TRUE(ctrl_v_label1->GetVisible());
EXPECT_FALSE(ctrl_v_label2->GetVisible());
EXPECT_FALSE(ctrl_v_label3->GetVisible());
// Remove the first item. Now the second item's label should be visible.
adapter->RemoveMenuItemWithCommandId(
clipboard_history_util::kFirstItemCommandId);
FlushMessageLoop();
EXPECT_TRUE(ctrl_v_label2->GetVisible());
EXPECT_FALSE(ctrl_v_label3->GetVisible());
// Remove the second item. Now the third item's label should be visible.
adapter->RemoveMenuItemWithCommandId(
clipboard_history_util::kFirstItemCommandId + 1);
FlushMessageLoop();
EXPECT_TRUE(ctrl_v_label3->GetVisible());
}
TEST_F(ClipboardHistoryMenuModelAdapterRefreshTest,
TextItemHasExpectedDisplayTextLabel) {
// Write items to clipboard history so that the menu can show.
WriteTextToClipboardAndConfirm(u"A");
WriteTextToClipboardAndConfirm(u"https://google.com/");
// Show the clipboard history menu.
auto* const controller = GetClipboardHistoryController();
ASSERT_TRUE(controller);
EXPECT_TRUE(controller->ShowMenu(
gfx::Rect(), ui::mojom::MenuSourceType::kNone,
ClipboardHistoryControllerShowSource::kDefaultValue));
EXPECT_TRUE(controller->IsMenuShowing());
// Verify the number of items in the menu.
const auto* const adapter = controller->context_menu_for_test();
ASSERT_THAT(
adapter,
Property(&ClipboardHistoryMenuModelAdapter::GetMenuItemsCount, Eq(2u)));
// Verify expected display text labels.
const size_t offset = 1u;
for (size_t i = 0u; i < 2u; ++i) {
const views::Label* display_text_label = views::AsViewClass<views::Label>(
adapter->GetMenuItemViewAtForTest(i + offset)
->GetViewByID(clipboard_history_util::kDisplayTextLabelID));
gfx::ElideBehavior elide_behavior = gfx::ELIDE_TAIL;
size_t max_lines = 1u;
if (chromeos::clipboard_history::IsUrl(display_text_label->GetText())) {
elide_behavior = gfx::ELIDE_MIDDLE;
} else {
max_lines = ClipboardHistoryViews::kTextItemMaxLines;
}
EXPECT_THAT(
display_text_label,
AllOf(Property(&views::Label::GetElideBehavior, Eq(elide_behavior)),
Property(&views::Label::GetMaxLines, Eq(max_lines)),
Property(&views::Label::GetMultiLine, Eq(max_lines > 1u))));
}
}
// Base class for `ClipboardHistoryMenuModelAdapter` tests that verify the
// presence of a menu header, a menu footer, both, or neither.
class ClipboardHistoryMenuModelAdapterMenuItemTest
: public AshTestBase,
public WithParamInterface<std::tuple<
ClipboardHistoryControllerShowSource,
/*time_since_menu_shown=*/std::optional<base::TimeDelta>,
/*time_since_nudge_shown=*/std::optional<base::TimeDelta>>> {
public:
ClipboardHistoryMenuModelAdapterMenuItemTest()
: AshTestBase(base::test::TaskEnvironment::TimeSource::MOCK_TIME) {
scoped_feature_list_.InitWithFeatureStates(
{{features::kClipboardHistoryLongpress,
IsClipboardHistoryLongpressEnabled()}});
}
// AshTestBase:
void SetUp() override {
AshTestBase::SetUp();
auto* session_controller = Shell::Get()->session_controller();
ASSERT_TRUE(session_controller);
auto* prefs = session_controller->GetLastActiveUserPrefService();
ASSERT_TRUE(prefs);
// Set nudge last time shown.
if (const auto& time_since_nudge_shown = GetTimeSinceNudgeShown()) {
ClipboardHistoryController::Get()->OnScreenshotNotificationCreated();
task_environment()->FastForwardBy(*time_since_nudge_shown);
}
// Set menu last time shown.
if (const auto& time_since_menu_shown = GetTimeSinceMenuShown()) {
prefs->SetTime(prefs::kMultipasteMenuLastTimeShown,
base::Time::Now() - time_since_menu_shown.value());
}
}
void WriteTextToClipboardAndFlushMessageLoop(const std::u16string& str) {
{
ui::ScopedClipboardWriter scw(ui::ClipboardBuffer::kCopyPaste);
scw.WriteText(str);
}
FlushMessageLoop();
}
ClipboardHistoryControllerShowSource GetSource() const {
return std::get<0>(GetParam());
}
const std::optional<base::TimeDelta>& GetTimeSinceMenuShown() const {
return std::get<1>(GetParam());
}
const std::optional<base::TimeDelta>& GetTimeSinceNudgeShown() const {
return std::get<2>(GetParam());
}
bool IsClipboardHistoryLongpressEnabled() const {
return GetSource() ==
ClipboardHistoryControllerShowSource::kControlVLongpress;
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(All,
ClipboardHistoryMenuModelAdapterMenuItemTest,
Combine(ValuesIn(GetClipboardHistoryShowSources()),
/*time_since_menu_shown=*/
Values(std::make_optional(base::Days(60)),
std::make_optional(base::Days(59)),
std::nullopt),
/*time_since_nudge_shown=*/
Values(std::make_optional(base::Seconds(61)),
std::make_optional(base::Seconds(60)),
std::nullopt)));
TEST_P(ClipboardHistoryMenuModelAdapterMenuItemTest,
HeaderAndFooterConditionallyPresent) {
// Write items to clipboard history so that the menu can show.
WriteTextToClipboardAndFlushMessageLoop(u"A");
WriteTextToClipboardAndFlushMessageLoop(u"B");
auto* const controller = GetClipboardHistoryController();
ASSERT_TRUE(controller);
EXPECT_EQ(controller->history()->GetItems().size(), 2u);
// Show the clipboard history menu.
EXPECT_TRUE(controller->ShowMenu(
gfx::Rect(), ui::mojom::MenuSourceType::kNone, GetSource()));
EXPECT_TRUE(controller->IsMenuShowing());
const auto time_since_menu_shown =
GetTimeSinceMenuShown().value_or(base::TimeDelta::Max());
const auto time_since_nudge_shown =
GetTimeSinceNudgeShown().value_or(base::TimeDelta::Max());
const bool has_header = true;
const bool has_footer = IsClipboardHistoryLongpressEnabled() ||
((time_since_menu_shown >= base::Days(60)) ||
(time_since_nudge_shown <= base::Seconds(60)));
// Verify the number of items in the menu model.
size_t expected_menu_item_count = controller->history()->GetItems().size();
if (has_header) {
// The menu's first item should be a header.
++expected_menu_item_count;
}
if (has_footer) {
// The menu's last item should be a footer.
++expected_menu_item_count;
}
const auto* const adapter = controller->context_menu_for_test();
const auto* const model = adapter->GetModelForTest();
ASSERT_TRUE(model);
ASSERT_EQ(model->GetItemCount(), expected_menu_item_count);
// Verify that the first item is a header iff the UI refresh is enabled.
EXPECT_EQ(model->GetTypeAt(0u), has_header
? ui::MenuModel::ItemType::TYPE_TITLE
: ui::MenuModel::ItemType::TYPE_COMMAND);
// Verify that the last item is a footer iff the menu was shown via Ctrl+V
// long-press.
EXPECT_EQ(model->GetTypeAt(model->GetItemCount() - 1u),
has_footer ? ui::MenuModel::ItemType::TYPE_TITLE
: ui::MenuModel::ItemType::TYPE_COMMAND);
if (!has_footer) {
return;
}
// Verify that footer content is of the expected version.
const int footer_index = model->GetItemCount() - 1u;
const auto* const footer = adapter->GetMenuItemViewAtForTest(footer_index);
EXPECT_FALSE(
footer->GetViewByID(clipboard_history_util::kFooterContentViewID));
EXPECT_THAT(
footer->GetViewByID(clipboard_history_util::kFooterContentV2ViewID),
GetViewById<views::StyledLabel>(
clipboard_history_util::kFooterContentV2LabelID,
Property(
&views::StyledLabel::GetText,
Conditional(
IsClipboardHistoryLongpressEnabled(),
l10n_util::GetStringUTF16(
IDS_ASH_CLIPBOARD_HISTORY_CONTROL_V_LONGPRESS_FOOTER),
l10n_util::GetStringFUTF16(
IDS_ASH_CLIPBOARD_HISTORY_FOOTER,
clipboard_history_util::GetShortcutKeyName())))));
}
} // namespace ash
|