1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/system/hotspot/hotspot_feature_pod_controller.h"
#include "ash/constants/quick_settings_catalogs.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/system/hotspot/hotspot_detailed_view.h"
#include "ash/system/tray/tray_detailed_view.h"
#include "ash/system/unified/feature_tile.h"
#include "ash/system/unified/unified_system_tray.h"
#include "ash/system/unified/unified_system_tray_bubble.h"
#include "ash/system/unified/unified_system_tray_controller.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/ash_test_helper.h"
#include "base/run_loop.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
#include "chromeos/ash/services/hotspot_config/public/cpp/cros_hotspot_config_test_helper.h"
#include "chromeos/ash/services/hotspot_config/public/mojom/cros_hotspot_config.mojom.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/views/view_utils.h"
namespace ash {
namespace {
constexpr char kToggledOnHistogram[] = "Ash.QuickSettings.FeaturePod.ToggledOn";
constexpr char kToggledOffHistogram[] =
"Ash.QuickSettings.FeaturePod.ToggledOff";
constexpr char kDiveInHistogram[] = "Ash.QuickSettings.FeaturePod.DiveIn";
} // namespace
using hotspot_config::mojom::HotspotAllowStatus;
using hotspot_config::mojom::HotspotInfo;
using hotspot_config::mojom::HotspotState;
class HotspotFeaturePodControllerTest : public AshTestBase {
public:
HotspotFeaturePodControllerTest()
: AshTestBase(std::make_unique<base::test::TaskEnvironment>(
base::test::TaskEnvironment::MainThreadType::UI,
base::test::TaskEnvironment::TimeSource::MOCK_TIME)) {}
~HotspotFeaturePodControllerTest() override = default;
void SetUp() override {
AshTestBase::SetUp();
// Spin the runloop to have HotspotInfoCache finish querying the hotspot
// info.
base::RunLoop().RunUntilIdle();
GetPrimaryUnifiedSystemTray()->ShowBubble();
CreateHotspotFeatureTile();
}
void TearDown() override {
hotspot_feature_tile_.reset();
hotspot_feature_pod_controller_.reset();
AshTestBase::TearDown();
}
void CreateHotspotFeatureTile() {
CHECK(GetPrimaryUnifiedSystemTray()->IsBubbleShown());
hotspot_feature_pod_controller_ =
std::make_unique<HotspotFeaturePodController>(
GetPrimaryUnifiedSystemTray()
->bubble()
->unified_system_tray_controller());
hotspot_feature_tile_ = hotspot_feature_pod_controller_->CreateTile();
}
void UpdateHotspotInfo(HotspotState state,
HotspotAllowStatus allow_status,
uint32_t client_count = 0) {
auto hotspot_info = HotspotInfo::New();
hotspot_info->state = state;
hotspot_info->allow_status = allow_status;
hotspot_info->client_count = client_count;
ash_test_helper()->cros_hotspot_config_test_helper()->SetFakeHotspotInfo(
std::move(hotspot_info));
// Spin the runloop to observe the hotspot info change.
base::RunLoop().RunUntilIdle();
}
void EnableAndDisableHotspotOnce() {
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed);
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
}
void PressIcon() {
hotspot_feature_pod_controller_->OnIconPressed();
base::RunLoop().RunUntilIdle();
}
void PressLabel() {
hotspot_feature_pod_controller_->OnLabelPressed();
base::RunLoop().RunUntilIdle();
}
void LockScreen() {
GetSessionControllerClient()->LockScreen();
base::RunLoop().RunUntilIdle();
}
const gfx::VectorIcon* GetVectorIcon() {
return hotspot_feature_tile_->vector_icon_.get();
}
void ExpectHotspotDetailedViewShown() {
TrayDetailedView* detailed_view =
GetPrimaryUnifiedSystemTray()
->bubble()
->quick_settings_view()
->GetDetailedViewForTest<TrayDetailedView>();
ASSERT_TRUE(detailed_view);
EXPECT_TRUE(views::IsViewClass<HotspotDetailedView>(detailed_view));
}
protected:
std::unique_ptr<HotspotFeaturePodController> hotspot_feature_pod_controller_;
std::unique_ptr<FeatureTile> hotspot_feature_tile_;
};
TEST_F(HotspotFeaturePodControllerTest, HotspotNotUsedBefore) {
EXPECT_FALSE(hotspot_feature_tile_->GetVisible());
}
TEST_F(HotspotFeaturePodControllerTest, PressLabelWhenHotspotEnabled) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"On", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, no device connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is on.",
hotspot_feature_tile_->GetTooltipText());
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed, 2);
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, 2 devices connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(&kHotspotOnIcon, GetVectorIcon());
// Press on the label should navigate to the detailed page without toggle
// hotspot.
PressLabel();
ExpectHotspotDetailedViewShown();
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
}
TEST_F(HotspotFeaturePodControllerTest, PressIconWhenHotspotEnabled) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kEnabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"On", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is on, no device connected.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is on.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOnIcon, GetVectorIcon());
// Press on the icon should toggle hotspot.
PressIcon();
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
}
TEST_F(HotspotFeaturePodControllerTest, HotspotEnabling) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kEnabling, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Turning on…", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning on.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning on.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotDotIcon, GetVectorIcon());
// Verifies the hotspot icon is animating when enabling.
task_environment()->FastForwardBy(base::Milliseconds(500));
EXPECT_EQ(&kHotspotOneArcIcon, GetVectorIcon());
task_environment()->FastForwardBy(base::Milliseconds(500));
EXPECT_EQ(&kHotspotOnIcon, GetVectorIcon());
// Press on the icon should navigate to the detailed page but not to toggle
// hotspot.
PressIcon();
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest, HotspotDisabling) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabling, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Turning off…", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is turning off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should navigate to the detailed page but not to toggle
// hotspot.
PressIcon();
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest,
PressIconWhenHotspotDisabledAndAllowEnable) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should toggle hotspot and navigate to the detailed page.
PressIcon();
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest,
PressLabelWhenHotspotDisabledAndAllowEnable) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the drive in label should navigate to the detailed page without
// toggling hotspot.
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
PressLabel();
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest, HotspotDisabledNoMobileNetwork) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabled,
HotspotAllowStatus::kDisallowedNoMobileData);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Connect to mobile network to use hotspot.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should navigate to the detailed page but not to toggle
// hotspot.
PressIcon();
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest,
HotspotDisabledMobileNetworkNotSupported) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabled,
HotspotAllowStatus::kDisallowedReadinessCheckFail);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(
u"Show hotspot details. Your mobile network doesn't support hotspot.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should navigate to the detailed page but not to toggle
// hotspot.
PressIcon();
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest, HotspotDisabledBlockedByPolicy) {
EnableAndDisableHotspotOnce();
UpdateHotspotInfo(HotspotState::kDisabled,
HotspotAllowStatus::kDisallowedByPolicy);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Show hotspot details. Hotspot is blocked by your administrator.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Show hotspot details. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should navigate to the detailed page but not to toggle
// hotspot.
PressIcon();
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest, LockScreen) {
EnableAndDisableHotspotOnce();
LockScreen();
// Locking the screen closes the system tray bubble thus destroying the
// hotspot feature tile, so re-show the bubble and recreate the tile.
GetPrimaryUnifiedSystemTray()->ShowBubble();
CreateHotspotFeatureTile();
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
EXPECT_FALSE(hotspot_feature_tile_->IsToggled());
EXPECT_EQ(u"Hotspot", hotspot_feature_tile_->label()->GetText());
EXPECT_EQ(u"Off", hotspot_feature_tile_->sub_label()->GetText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->icon_button()->GetTooltipText());
EXPECT_EQ(u"Toggle hotspot. Hotspot is off.",
hotspot_feature_tile_->GetTooltipText());
EXPECT_EQ(&kHotspotOffIcon, GetVectorIcon());
// Press on the icon should toggle hotspot and navigate to the detailed page.
PressIcon();
EXPECT_TRUE(hotspot_feature_tile_->IsToggled());
EXPECT_TRUE(hotspot_feature_tile_->GetVisible());
EXPECT_TRUE(hotspot_feature_tile_->GetEnabled());
ExpectHotspotDetailedViewShown();
}
TEST_F(HotspotFeaturePodControllerTest, LabelUMATracking) {
UpdateHotspotInfo(HotspotState::kDisabled, HotspotAllowStatus::kAllowed);
auto histogram_tester = std::make_unique<base::HistogramTester>();
histogram_tester->ExpectTotalCount(kToggledOnHistogram,
/*expected_count=*/0);
histogram_tester->ExpectTotalCount(kToggledOffHistogram,
/*expected_count=*/0);
histogram_tester->ExpectTotalCount(kDiveInHistogram,
/*expected_count=*/0);
// Press on the label to show detailed page.
PressLabel();
histogram_tester->ExpectTotalCount(kToggledOnHistogram,
/*expected_count=*/0);
histogram_tester->ExpectBucketCount(kToggledOnHistogram,
QsFeatureCatalogName::kHotspot,
/*expected_count=*/0);
histogram_tester->ExpectTotalCount(kToggledOffHistogram,
/*expected_count=*/0);
histogram_tester->ExpectTotalCount(kDiveInHistogram,
/*expected_count=*/1);
histogram_tester->ExpectBucketCount(kDiveInHistogram,
QsFeatureCatalogName::kHotspot,
/*expected_count=*/1);
// Press on the icon to toggle hotspot and show detailed page.
PressIcon();
histogram_tester->ExpectTotalCount(kToggledOnHistogram,
/*expected_count=*/1);
histogram_tester->ExpectBucketCount(kToggledOnHistogram,
QsFeatureCatalogName::kHotspot,
/*expected_count=*/1);
histogram_tester->ExpectTotalCount(kToggledOffHistogram,
/*expected_count=*/0);
histogram_tester->ExpectBucketCount(kToggledOffHistogram,
QsFeatureCatalogName::kHotspot,
/*expected_count=*/0);
histogram_tester->ExpectTotalCount(kDiveInHistogram,
/*expected_count=*/2);
histogram_tester->ExpectBucketCount(kDiveInHistogram,
QsFeatureCatalogName::kHotspot,
/*expected_count=*/2);
}
} // namespace ash
|
