1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <optional>
#include <string>
#include <utility>
#include "ash/system/mahi/mahi_constants.h"
#include "ash/system/mahi/mahi_panel_view.h"
#include "ash/system/mahi/mahi_panel_widget.h"
#include "ash/system/mahi/mahi_ui_controller.h"
#include "ash/system/mahi/test/mock_mahi_manager.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/pixel/ash_pixel_differ.h"
#include "base/functional/callback.h"
#include "base/test/scoped_feature_list.h"
#include "chromeos/components/mahi/public/cpp/mahi_manager.h"
#include "chromeos/constants/chromeos_features.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/display/display.h"
#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/view.h"
#include "ui/views/view_utils.h"
#include "ui/views/widget/unique_widget_ptr.h"
#include "ui/views/widget/widget.h"
namespace ash {
namespace {
// Aliases
using chromeos::MahiResponseStatus;
using ::testing::NiceMock;
using ::testing::Return;
using ::testing::Values;
std::string GetScreenShotNameForErrorStatus(MahiResponseStatus status) {
switch (status) {
case chromeos::MahiResponseStatus::kCantFindOutputData:
return "CantFindOutputData";
case chromeos::MahiResponseStatus::kContentExtractionError:
return "ContentExtractionError";
case chromeos::MahiResponseStatus::kInappropriate:
return "Inappropriate";
case chromeos::MahiResponseStatus::kUnknownError:
return "UnknownError";
case chromeos::MahiResponseStatus::kQuotaLimitHit:
return "QuotaLimitHit";
case chromeos::MahiResponseStatus::kResourceExhausted:
return "ResourceExhausted";
case chromeos::MahiResponseStatus::kRestrictedCountry:
return "RestrictedCountry";
case chromeos::MahiResponseStatus::kUnsupportedLanguage:
return "UnsupportedLanguage";
case chromeos::MahiResponseStatus::kLowQuota:
case chromeos::MahiResponseStatus::kSuccess:
NOTREACHED();
}
}
} // namespace
class MahiErrorStatusViewPixelTestBase : public AshTestBase {
protected:
void ShowMahiPanel() {
mahi_panel_widget_ = MahiPanelWidget::CreateAndShowPanelWidget(
GetPrimaryDisplay().id(), /*mahi_menu_bounds=*/gfx::Rect(),
ui_controller());
mahi_panel_widget_->Show();
}
views::Widget* mahi_panel_widget() { return mahi_panel_widget_.get(); }
MockMahiManager& mock_mahi_manager() { return mock_mahi_manager_; }
MahiUiController* ui_controller() { return &ui_controller_; }
private:
// AshTestBase:
std::optional<pixel_test::InitParams> CreatePixelTestInitParams()
const override {
return pixel_test::InitParams();
}
void SetUp() override {
scoped_feature_list_.InitWithFeatures(
/*enabled_features=*/{chromeos::features::kMahi,
chromeos::features::kFeatureManagementMahi},
/*disabled_features=*/{});
AshTestBase::SetUp();
ON_CALL(mock_mahi_manager_, GetContentTitle)
.WillByDefault(Return(u"content title"));
}
void TearDown() override {
mahi_panel_widget_.reset();
AshTestBase::TearDown();
}
base::test::ScopedFeatureList scoped_feature_list_;
NiceMock<MockMahiManager> mock_mahi_manager_;
MahiUiController ui_controller_;
chromeos::ScopedMahiManagerSetter scoped_setter_{&mock_mahi_manager_};
views::UniqueWidgetPtr mahi_panel_widget_;
};
// MahiErrorStatusViewPixelTest ------------------------------------------------
class MahiErrorStatusViewPixelTest
: public MahiErrorStatusViewPixelTestBase,
public testing::WithParamInterface<MahiResponseStatus> {};
INSTANTIATE_TEST_SUITE_P(All,
MahiErrorStatusViewPixelTest,
Values(MahiResponseStatus::kCantFindOutputData,
MahiResponseStatus::kContentExtractionError,
MahiResponseStatus::kInappropriate,
MahiResponseStatus::kQuotaLimitHit,
MahiResponseStatus::kResourceExhausted,
MahiResponseStatus::kRestrictedCountry,
MahiResponseStatus::kUnsupportedLanguage,
MahiResponseStatus::kUnknownError));
// Verifies the error status view when a summary update incurs an error
// specified by the test param.
TEST_P(MahiErrorStatusViewPixelTest, Basics) {
ON_CALL(mock_mahi_manager(), GetSummary)
.WillByDefault([&](chromeos::MahiManager::MahiSummaryCallback callback) {
std::move(callback).Run(u"fake summary", GetParam());
});
ShowMahiPanel();
views::View* const error_status_view =
mahi_panel_widget()->GetContentsView()->GetViewByID(
mahi_constants::ViewId::kErrorStatusView);
ASSERT_TRUE(error_status_view);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
GetScreenShotNameForErrorStatus(GetParam()), /*revision_number=*/10,
error_status_view));
}
// Verifies the error status on the Mahi panel scroll view when asking a
// question.
TEST_P(MahiErrorStatusViewPixelTest, QuestionAnswerView) {
ON_CALL(mock_mahi_manager(), AnswerQuestion)
.WillByDefault(
[](const std::u16string& question, bool current_panel_content,
chromeos::MahiManager::MahiAnswerQuestionCallback callback) {
std::move(callback).Run(u"answer", GetParam());
});
ShowMahiPanel();
views::View* const mahi_contents_view =
mahi_panel_widget()->GetContentsView();
auto* const question_textfield =
views::AsViewClass<views::Textfield>(mahi_contents_view->GetViewByID(
mahi_constants::ViewId::kQuestionTextfield));
ASSERT_TRUE(question_textfield);
question_textfield->SetText(u"fake inappropriate question");
auto* const send_button = mahi_contents_view->GetViewByID(
mahi_constants::ViewId::kAskQuestionSendButton);
ASSERT_TRUE(send_button);
send_button->SetEnabled(true);
LeftClickOn(send_button);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
GetScreenShotNameForErrorStatus(GetParam()), /*revision_number=*/8,
mahi_contents_view->GetViewByID(mahi_constants::ViewId::kScrollView)));
}
} // namespace ash
|
