1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/system/network/managed_sim_lock_notifier.h"
#include "ash/constants/ash_features.h"
#include "ash/system/system_notification_controller.h"
#include "ash/test/ash_test_base.h"
#include "base/functional/bind.h"
#include "base/run_loop.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "chromeos/ash/components/network/cellular_metrics_logger.h"
#include "chromeos/ash/components/network/network_handler.h"
#include "chromeos/ash/components/network/network_handler_test_helper.h"
#include "chromeos/ash/components/network/network_state_handler.h"
#include "chromeos/ash/components/network/technology_state_controller.h"
#include "chromeos/ash/services/network_config/public/cpp/cros_network_config_test_helper.h"
#include "chromeos/services/network_config/public/mojom/cros_network_config.mojom.h"
#include "third_party/cros_system_api/dbus/shill/dbus-constants.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/public/cpp/notification.h"
namespace ash {
namespace {
const char kTestCellularServicePath[] = "cellular_service_path";
const char kTestCellularDevicePath[] = "cellular_path";
const char kTestCellularDevicePathName[] = "stub_cellular_device";
const char kTestIccid[] = "1234567890123456789";
const char kTestCellularGuid[] = "cellular_guid";
const char kTestCellularName[] = "cellular_name";
const char kTestEid[] = "123456789012345678901234567890123";
} // namespace
class ManagedSimLockNotifierTest : public NoSessionAshTestBase {
protected:
ManagedSimLockNotifierTest() = default;
ManagedSimLockNotifierTest(const ManagedSimLockNotifierTest&) = delete;
ManagedSimLockNotifierTest& operator=(const ManagedSimLockNotifierTest&) =
delete;
~ManagedSimLockNotifierTest() override = default;
void SetUp() override {
network_handler_test_helper_ = std::make_unique<NetworkHandlerTestHelper>();
network_config_helper_ =
std::make_unique<network_config::CrosNetworkConfigTestHelper>();
AshTestBase::SetUp();
base::RunLoop().RunUntilIdle();
// User must be logged in for notification to be visible.
LogIn();
}
void TearDown() override {
AshTestBase::TearDown();
network_config_helper_.reset();
network_handler_test_helper_.reset();
}
void LogIn() { SimulateUserLogin({"user1@test.com"}); }
void LogOut() { ClearLogin(); }
ManagedNetworkConfigurationHandler* managed_network_configuration_handler() {
return NetworkHandler::Get()->managed_network_configuration_handler();
}
void SetCellularEnabled(bool enabled) {
NetworkHandler::Get()
->technology_state_controller()
->SetTechnologiesEnabled(NetworkTypePattern::Cellular(), enabled,
network_handler::ErrorCallback());
base::RunLoop().RunUntilIdle();
}
void SetCellularSimLockEnabled(
bool enable,
const std::optional<std::string>& lock_type = std::nullopt) {
// Simulate a locked SIM.
base::Value::Dict sim_lock_status;
sim_lock_status.Set(shill::kSIMLockEnabledProperty, enable);
if (lock_type.has_value())
sim_lock_status.Set(shill::kSIMLockTypeProperty, *lock_type);
network_config_helper_->network_state_helper()
.device_test()
->SetDeviceProperty(
kTestCellularDevicePath, shill::kSIMLockStatusProperty,
base::Value(std::move(sim_lock_status)), /*notify_changed=*/true);
// Set the cellular service to be the active profile.
base::Value::List sim_slot_infos;
base::Value::Dict slot_info_item;
slot_info_item.Set(shill::kSIMSlotInfoICCID, kTestIccid);
slot_info_item.Set(shill::kSIMSlotInfoPrimary, true);
sim_slot_infos.Append(std::move(slot_info_item));
network_config_helper_->network_state_helper()
.device_test()
->SetDeviceProperty(
kTestCellularDevicePath, shill::kSIMSlotInfoProperty,
base::Value(std::move(sim_slot_infos)), /*notify_changed=*/true);
base::RunLoop().RunUntilIdle();
}
void SetAllowCellularSimLock(bool allow_cellular_sim_lock) {
base::Value::Dict global_config;
global_config.Set(::onc::global_network_config::kAllowCellularSimLock,
allow_cellular_sim_lock);
managed_network_configuration_handler()->SetPolicy(
::onc::ONC_SOURCE_DEVICE_POLICY, /*userhash=*/std::string(),
base::Value::List(), global_config);
base::RunLoop().RunUntilIdle();
}
void AddCellularDevice() {
network_config_helper_->network_state_helper().AddDevice(
kTestCellularDevicePath, shill::kTypeCellular,
kTestCellularDevicePathName);
}
void AddCellularService(
const std::string& service_path = kTestCellularServicePath,
const std::string& iccid = kTestIccid) {
// Add idle, non-connectable network.
network_config_helper_->network_state_helper().service_test()->AddService(
service_path, kTestCellularGuid, kTestCellularName,
shill::kTypeCellular, shill::kStateIdle, /*visible=*/true);
network_config_helper_->network_state_helper()
.service_test()
->SetServiceProperty(service_path, shill::kEidProperty,
base::Value(kTestEid));
network_config_helper_->network_state_helper()
.service_test()
->SetServiceProperty(service_path, shill::kIccidProperty,
base::Value(iccid));
base::RunLoop().RunUntilIdle();
}
void ClickOnNotification() {
message_center::MessageCenter::Get()->ClickOnNotification(
ManagedSimLockNotifier::kManagedSimLockNotificationId);
}
void RemoveNotification(bool by_user) {
message_center::MessageCenter::Get()->RemoveNotification(
ManagedSimLockNotifier::kManagedSimLockNotificationId, by_user);
}
// Returns the managed SIM lock notification if it is shown, and null if it is
// not shown.
message_center::Notification* GetManagedSimLockNotification() {
return message_center::MessageCenter::Get()->FindVisibleNotificationById(
ManagedSimLockNotifier::kManagedSimLockNotificationId);
}
std::unique_ptr<network_config::CrosNetworkConfigTestHelper>
network_config_helper_;
std::unique_ptr<NetworkHandlerTestHelper> network_handler_test_helper_;
base::test::ScopedFeatureList scoped_feature_list_;
base::HistogramTester histogram_tester_;
};
TEST_F(ManagedSimLockNotifierTest, PolicyChanged) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
AddCellularDevice();
AddCellularService();
EXPECT_FALSE(GetManagedSimLockNotification());
SetCellularSimLockEnabled(true);
EXPECT_FALSE(GetManagedSimLockNotification());
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
SetAllowCellularSimLock(true);
EXPECT_FALSE(GetManagedSimLockNotification());
}
TEST_F(ManagedSimLockNotifierTest, NewActiveSession) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
// Notification should be shown; proceed to remove it.
EXPECT_TRUE(GetManagedSimLockNotification());
RemoveNotification(/*by_user=*/false);
EXPECT_FALSE(GetManagedSimLockNotification());
LogOut();
LogIn();
base::RunLoop().RunUntilIdle();
// Notification should surface in new active session since the SIM is PIN
// locked and policy is true.
EXPECT_TRUE(GetManagedSimLockNotification());
RemoveNotification(/*by_user=*/false);
SetAllowCellularSimLock(true);
LogOut();
LogIn();
base::RunLoop().RunUntilIdle();
// Notification should not surface in new active session since the policy is
// false.
EXPECT_FALSE(GetManagedSimLockNotification());
SetCellularSimLockEnabled(false);
SetAllowCellularSimLock(false);
LogOut();
LogIn();
base::RunLoop().RunUntilIdle();
// Notification should not surface in new active session since the SIM is not
// PIN locked.
EXPECT_FALSE(GetManagedSimLockNotification());
SetAllowCellularSimLock(true);
LogOut();
LogIn();
base::RunLoop().RunUntilIdle();
// Notification should not surface in new active session since the SIM is not
// PIN locked.
EXPECT_FALSE(GetManagedSimLockNotification());
}
TEST_F(ManagedSimLockNotifierTest, HideNotificationOnLockDisabled) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
// Notification will disappear once user disables SIM Lock setting.
SetCellularSimLockEnabled(false);
EXPECT_FALSE(GetManagedSimLockNotification());
}
TEST_F(ManagedSimLockNotifierTest, PrimarySimIccidChanged) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
RemoveNotification(/*by_user=*/false);
EXPECT_FALSE(GetManagedSimLockNotification());
// Simulate primary ICCID changed. Notification should be shown after.
base::Value::List sim_slot_infos;
base::Value::Dict slot_info_item;
slot_info_item.Set(shill::kSIMSlotInfoICCID, kTestIccid);
slot_info_item.Set(shill::kSIMSlotInfoPrimary, false);
sim_slot_infos.Append(std::move(slot_info_item));
base::Value::Dict slot_info_item_2;
slot_info_item_2.Set(shill::kSIMSlotInfoICCID, "kTestIccid2");
slot_info_item_2.Set(shill::kSIMSlotInfoPrimary, true);
sim_slot_infos.Append(std::move(slot_info_item_2));
network_config_helper_->network_state_helper()
.device_test()
->SetDeviceProperty(kTestCellularDevicePath, shill::kSIMSlotInfoProperty,
base::Value(std::move(sim_slot_infos)),
/*notify_changed=*/true);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(GetManagedSimLockNotification());
}
TEST_F(ManagedSimLockNotifierTest, NotificationOnCellularOnOrOff) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
base::HistogramTester histograms;
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kShown, 1);
// Notification will disappear if user turns off Cellular.
SetCellularEnabled(false);
EXPECT_FALSE(GetManagedSimLockNotification());
// Notification will appear if user turns on Cellular.
SetCellularEnabled(true);
EXPECT_TRUE(GetManagedSimLockNotification());
}
TEST_F(ManagedSimLockNotifierTest, NotificationClicked) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
base::HistogramTester histograms;
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
ClickOnNotification();
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kShown, 1);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kClicked, 1);
// Notification will be dismissed by the system, in which case we shouldn't
// be emitting the dismissed by user metric.
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kDismissed, 0);
}
TEST_F(ManagedSimLockNotifierTest, NotificationDismissedByUser) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
base::HistogramTester histograms;
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true);
SetAllowCellularSimLock(false);
RemoveNotification(/*by_user=*/true);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kShown, 1);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kClicked, 0);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationEventHistogram,
CellularMetricsLogger::SimLockNotificationEvent::kDismissed, 1);
}
TEST_F(ManagedSimLockNotifierTest, SIMLockTypeMetrics) {
scoped_feature_list_.InitAndDisableFeature(
ash::features::kAllowApnModificationPolicy);
base::HistogramTester histograms;
AddCellularDevice();
AddCellularService();
SetCellularSimLockEnabled(true, shill::kSIMLockPin);
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationLockType,
CellularMetricsLogger::SimPinLockType::kPinLocked, 1);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationLockType,
CellularMetricsLogger::SimPinLockType::kPukLocked, 0);
SetCellularSimLockEnabled(false);
SetAllowCellularSimLock(true);
EXPECT_FALSE(GetManagedSimLockNotification());
SetCellularSimLockEnabled(true, shill::kSIMLockPuk);
SetAllowCellularSimLock(false);
EXPECT_TRUE(GetManagedSimLockNotification());
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationLockType,
CellularMetricsLogger::SimPinLockType::kPinLocked, 1);
histograms.ExpectBucketCount(
CellularMetricsLogger::kSimLockNotificationLockType,
CellularMetricsLogger::SimPinLockType::kPukLocked, 1);
}
} // namespace ash
|
