1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "ash/constants/ash_features.h"
#include "ash/system/tray/tray_constants.h"
#include "ash/system/unified/feature_tile.h"
#include "ash/system/video_conference/fake_video_conference_tray_controller.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/pixel/ash_pixel_differ.h"
#include "ash/test/pixel/ash_pixel_test_init_params.h"
#include "base/functional/callback_helpers.h"
#include "base/i18n/rtl.h"
#include "base/test/scoped_feature_list.h"
#include "components/vector_icons/vector_icons.h"
#include "ui/chromeos/styles/cros_tokens_color_mappings.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
#include "ui/views/background.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/layout/box_layout_view.h"
#include "ui/views/layout/flex_layout_types.h"
#include "ui/views/view.h"
#include "ui/views/view_class_properties.h"
#include "ui/views/widget/widget.h"
namespace ash {
namespace {
// Quick Settings `FeatureTile` size constants.
constexpr gfx::Size kQSPrimaryTileSize =
gfx::Size(kPrimaryFeatureTileWidth, kFeatureTileHeight);
constexpr gfx::Size kQSCompactTileSize =
gfx::Size(kCompactFeatureTileWidth, kFeatureTileHeight);
// Creates a `Feature Tile` base that follows Quick Settings sizing standards.
FeatureTile* CreateQSFeatureTileBase(views::Widget* widget,
bool is_compact = false) {
auto tile = std::make_unique<FeatureTile>(
views::Button::PressedCallback(), /*is_togglable=*/true,
is_compact ? FeatureTile::TileType::kCompact
: FeatureTile::TileType::kPrimary);
// Quick Settings Feature Tiles set a fixed size for their feature tiles.
tile->SetPreferredSize(is_compact ? kQSCompactTileSize : kQSPrimaryTileSize);
tile->SetProperty(
views::kFlexBehaviorKey,
views::FlexSpecification(views::MinimumFlexSizeRule::kScaleToZero,
views::MaximumFlexSizeRule::kPreferred,
/*adjust_height_for_width=*/false));
return widget->GetContentsView()->AddChildView(std::move(tile));
}
} // namespace
// Pixel tests for the quick settings feature tile view.
class FeatureTilePixelTest : public AshTestBase {
public:
FeatureTilePixelTest() = default;
void SetUp() override {
AshTestBase::SetUp();
// We don't want tooltips to get in the way of the images we're testing.
::views::View::DisableKeyboardTooltipsForTesting();
widget_ = CreateFramelessTestWidget();
// Ensure the widget is large enough for the tile's focus ring (which is
// drawn outside the tile's bounds).
widget_->SetBounds(gfx::Rect(200, 80));
auto* contents =
widget_->SetContentsView(std::make_unique<views::BoxLayoutView>());
contents->SetMainAxisAlignment(
views::BoxLayout::MainAxisAlignment::kCenter);
contents->SetCrossAxisAlignment(
views::BoxLayout::CrossAxisAlignment::kCenter);
// The tile colors have transparency, so set a background color so they
// render like in production.
contents->SetBackground(
views::CreateSolidBackground(cros_tokens::kCrosSysSystemBaseElevated));
}
void TearDown() override {
widget_.reset();
::views::View::EnableKeyboardTooltipsForTesting();
AshTestBase::TearDown();
}
// AshTestBase:
std::optional<pixel_test::InitParams> CreatePixelTestInitParams()
const override {
return pixel_test::InitParams();
}
std::unique_ptr<views::Widget> widget_;
};
TEST_F(FeatureTilePixelTest, PrimaryTile) {
auto* tile = CreateQSFeatureTileBase(widget_.get());
tile->SetVectorIcon(vector_icons::kDogfoodIcon);
tile->SetLabel(u"Label");
tile->SetSubLabel(u"Sub-label");
// Needed for accessibility paint checks.
tile->SetTooltipText(u"Tooltip");
tile->CreateDecorativeDrillInArrow();
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"basic",
/*revision_number=*/1, widget_.get()));
widget_->GetFocusManager()->SetFocusedView(tile);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"focused",
/*revision_number=*/1, widget_.get()));
tile->SetToggled(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"toggled",
/*revision_number=*/1, widget_.get()));
// Test eliding.
tile->SetLabel(u"A very very long label");
tile->SetSubLabel(u"A very very long label");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"elided",
/*revision_number=*/1, widget_.get()));
}
TEST_F(FeatureTilePixelTest, PrimaryTileWithoutDiveInButton) {
auto* tile = CreateQSFeatureTileBase(widget_.get());
tile->SetVectorIcon(vector_icons::kDogfoodIcon);
tile->SetLabel(u"Label");
tile->SetSubLabel(u"Sub-label");
// Needed for accessibility paint checks.
tile->SetTooltipText(u"Tooltip");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"basic",
/*revision_number=*/1, widget_.get()));
widget_->GetFocusManager()->SetFocusedView(tile);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"focused",
/*revision_number=*/1, widget_.get()));
tile->SetToggled(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"toggled",
/*revision_number=*/1, widget_.get()));
// Test eliding.
tile->SetLabel(u"A very very long label");
tile->SetSubLabel(u"A very very long label");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"elided",
/*revision_number=*/1, widget_.get()));
}
TEST_F(FeatureTilePixelTest, PrimaryTile_RTL) {
// Turn on RTL mode.
base::i18n::SetRTLForTesting(true);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(base::i18n::IsRTL());
auto* tile = CreateQSFeatureTileBase(widget_.get());
tile->SetVectorIcon(vector_icons::kDogfoodIcon);
tile->SetLabel(u"Label");
tile->SetSubLabel(u"Sub-label");
tile->CreateDecorativeDrillInArrow();
// Needed for accessibility paint checks.
tile->SetTooltipText(u"Tooltip");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"basic",
/*revision_number=*/1, widget_.get()));
}
TEST_F(FeatureTilePixelTest, CompactTile) {
auto* tile = CreateQSFeatureTileBase(widget_.get(), /*is_compact=*/true);
tile->SetVectorIcon(vector_icons::kDogfoodIcon);
tile->SetLabel(u"Multi-line label");
// Needed for accessibility paint checks.
tile->SetTooltipText(u"Tooltip");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"basic",
/*revision_number=*/2, widget_.get()));
widget_->GetFocusManager()->SetFocusedView(tile);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"focused",
/*revision_number=*/2, widget_.get()));
tile->SetToggled(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"toggled",
/*revision_number=*/2, widget_.get()));
// Test eliding.
tile->SetLabel(u"A very very long label");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"elided",
/*revision_number=*/3, widget_.get()));
// Test font descenders ("g").
tile->SetLabel(u"Multi-line ggggg");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"descenders",
/*revision_number=*/1, widget_.get()));
// Test one-line labels.
tile->SetLabel(u"One line");
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"one_line",
/*revision_number=*/1, widget_.get()));
// Test one-line labels with one-line sub-labels.
tile->SetLabel(u"One line");
tile->SetSubLabel(u"One line");
tile->SetSubLabelVisibility(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"one_line_with_sub_label",
/*revision_number=*/1, widget_.get()));
// Test eliding with sub-labels.
tile->SetLabel(u"A very very long label");
tile->SetSubLabel(u"A very very long sub-label");
tile->SetSubLabelVisibility(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"elided_with_sub_label",
/*revision_number=*/1, widget_.get()));
}
class FeatureTileVcDlcUiEnabledPixelTest : public FeatureTilePixelTest {
public:
FeatureTileVcDlcUiEnabledPixelTest() = default;
FeatureTileVcDlcUiEnabledPixelTest(
const FeatureTileVcDlcUiEnabledPixelTest&) = delete;
FeatureTileVcDlcUiEnabledPixelTest& operator=(
const FeatureTileVcDlcUiEnabledPixelTest&) = delete;
~FeatureTileVcDlcUiEnabledPixelTest() override = default;
// AshTestBase:
void SetUp() override {
scoped_feature_list_
.InitWithFeatures(/*enabled_features=*/
{features::kFeatureManagementVideoConference,
features::kVcDlcUi},
/*disabled_features=*/{});
// Need to create a fake VC tray controller if VcDlcUi is enabled because
// this implies `features::IsVideoConferenceEnabled()` is true, and when
// that is true the VC tray is created (and the VC tray depends on the
// VC tray controller being available).
tray_controller_ = std::make_unique<FakeVideoConferenceTrayController>();
FeatureTilePixelTest::SetUp();
// Shrink the container's contents bounds slightly to give even padding
// around the tile, and ensure that focus rings don't get cut off in
// screenshots.
auto* layout_manager = static_cast<views::BoxLayout*>(
widget_->GetContentsView()->GetLayoutManager());
layout_manager->set_inside_border_insets(gfx::Insets::VH(0, 8));
// Create the tile. The tooltip text needs to be set to pass accessibility
// paint checks.
tile_ = widget_->GetContentsView()
->AddChildView(std::make_unique<FeatureTile>(
views::Button::PressedCallback(), /*is_togglable=*/true,
FeatureTile::TileType::kCompact))
->GetWeakPtr();
tile_->SetProperty(views::kBoxLayoutFlexKey,
views::BoxLayoutFlexSpecification());
tile_->SetTooltipText(u"Tooltip");
tile_->SetVectorIcon(vector_icons::kDogfoodIcon);
tile_->SetLabel(u"One-line label");
}
void TearDown() override {
FeatureTilePixelTest::TearDown();
tray_controller_.reset();
}
void SetDownloadProgress(FeatureTile* tile, int progress) {
tile->SetDownloadState(FeatureTile::DownloadState::kDownloading, progress);
}
FeatureTile* tile() { return tile_.get(); }
private:
std::unique_ptr<FakeVideoConferenceTrayController> tray_controller_ = nullptr;
base::WeakPtr<FeatureTile> tile_ = nullptr;
base::test::ScopedFeatureList scoped_feature_list_;
};
// Tests the UI of a compact tile that is allowed to fill the size of its
// container.
//
// TODO(b/312771691): Add more cases, like the ones in
// `FeatureTilePixelTest.CompactTile`.
TEST_F(FeatureTileVcDlcUiEnabledPixelTest, CompactTileCanFillContainer) {
// Use the default, one-line compact tile that is created during test set-up.
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"basic",
/*revision_number=*/2, widget_.get()));
// Focus the tile (and reset the focus after the screenshot is taken).
auto* previous_focused_view = widget_->GetFocusManager()->GetFocusedView();
widget_->GetFocusManager()->SetFocusedView(tile());
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"focused",
/*revision_number=*/2, widget_.get()));
widget_->GetFocusManager()->SetFocusedView(previous_focused_view);
// Toggle the tile (and reset the toggle state after the screenshot is taken).
tile()->SetToggled(true);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"toggled",
/*revision_number=*/2, widget_.get()));
tile()->SetToggled(false);
}
// Tests the UI of a compact tile that has an in-progress download, for various
// download percentages.
TEST_F(FeatureTileVcDlcUiEnabledPixelTest, DownloadInProgress) {
// Set the tile's download to be 0% complete.
SetDownloadProgress(tile(), 0);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"0_percent",
/*revision_number=*/2, widget_.get()));
// Set the tile's download to be 1% complete.
SetDownloadProgress(tile(), 1);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"1_percent",
/*revision_number=*/2, widget_.get()));
// Set the tile's download to be 50% complete.
SetDownloadProgress(tile(), 50);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"50_percent",
/*revision_number=*/2, widget_.get()));
// Set the tile's download to be 99% complete.
SetDownloadProgress(tile(), 99);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"99_percent",
/*revision_number=*/2, widget_.get()));
// Set the tile's download to be 100% complete.
SetDownloadProgress(tile(), 100);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"100_percent",
/*revision_number=*/2, widget_.get()));
}
// Tests the UI of a compact tile that has an error during download.
TEST_F(FeatureTileVcDlcUiEnabledPixelTest, ErrorInDlcDownload) {
tile()->SetDownloadState(FeatureTile::DownloadState::kError, 0);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"error",
/*revision_number=*/2, widget_.get()));
}
// Tests the UI of a compact tile that has a pending download.
TEST_F(FeatureTileVcDlcUiEnabledPixelTest, PendingDownload) {
tile()->SetDownloadState(FeatureTile::DownloadState::kPending, 0);
EXPECT_TRUE(GetPixelDiffer()->CompareUiComponentsOnPrimaryScreen(
"pending",
/*revision_number=*/1, widget_.get()));
}
} // namespace ash
|