1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/allocator/partition_alloc_support.h"
#include <array>
#include <string>
#include <utility>
#include <vector>
#include "base/allocator/partition_alloc_features.h"
#include "base/test/gtest_util.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "partition_alloc/buildflags.h"
#include "partition_alloc/dangling_raw_ptr_checks.h"
#include "partition_alloc/partition_alloc_base/cpu.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base::allocator {
using testing::AllOf;
using testing::HasSubstr;
TEST(PartitionAllocSupportTest,
ProposeSyntheticFinchTrials_DanglingPointerDetector) {
std::string dpd_group =
ProposeSyntheticFinchTrials()["DanglingPointerDetector"];
#if PA_BUILDFLAG(ENABLE_DANGLING_RAW_PTR_CHECKS)
EXPECT_EQ(dpd_group, "Enabled");
#else
EXPECT_EQ(dpd_group, "Disabled");
#endif
}
// - Death tests misbehave on Android, http://crbug.com/643760.
#if PA_BUILDFLAG(ENABLE_DANGLING_RAW_PTR_CHECKS) && !BUILDFLAG(IS_ANDROID) && \
defined(GTEST_HAS_DEATH_TEST)
namespace {
// Install dangling raw_ptr handler and restore them when going out of scope.
class ScopedInstallDanglingRawPtrChecks {
public:
struct ConstructorParams {
std::string mode = "crash";
std::string type = "all";
};
explicit ScopedInstallDanglingRawPtrChecks(ConstructorParams params) {
enabled_feature_list_.InitWithFeaturesAndParameters(
{{features::kPartitionAllocDanglingPtr,
{{"mode", params.mode}, {"type", params.type}}}},
{/* disabled_features */});
old_detected_fn_ = partition_alloc::GetDanglingRawPtrDetectedFn();
old_dereferenced_fn_ = partition_alloc::GetDanglingRawPtrReleasedFn();
InstallDanglingRawPtrChecks();
}
ScopedInstallDanglingRawPtrChecks()
: ScopedInstallDanglingRawPtrChecks(ConstructorParams{}) {}
~ScopedInstallDanglingRawPtrChecks() {
InstallDanglingRawPtrChecks(); // Check for leaks.
partition_alloc::SetDanglingRawPtrDetectedFn(old_detected_fn_);
partition_alloc::SetDanglingRawPtrReleasedFn(old_dereferenced_fn_);
}
private:
test::ScopedFeatureList enabled_feature_list_;
partition_alloc::DanglingRawPtrDetectedFn* old_detected_fn_;
partition_alloc::DanglingRawPtrReleasedFn* old_dereferenced_fn_;
};
} // namespace
TEST(PartitionAllocDanglingPtrChecks, Basic) {
EXPECT_DEATH(
{
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks;
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
partition_alloc::GetDanglingRawPtrReleasedFn()(42);
},
AllOf(HasSubstr("[DanglingSignature]\t"),
HasSubstr("[DanglingPtr](1/3) A raw_ptr/raw_ref is dangling."),
HasSubstr("[DanglingPtr](2/3) First, the memory was freed at:"),
HasSubstr("[DanglingPtr](3/3) Later, the dangling raw_ptr was "
"released at:")));
}
// The StackTrace buffer might run out of storage and not record where the
// memory was freed. Anyway, it must still report the error.
TEST(PartitionAllocDanglingPtrChecks, FreeNotRecorded) {
EXPECT_DEATH(
{
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks;
partition_alloc::GetDanglingRawPtrReleasedFn()(42);
},
AllOf(HasSubstr("[DanglingSignature]\tmissing\tmissing\t"),
HasSubstr("[DanglingPtr](1/3) A raw_ptr/raw_ref is dangling."),
HasSubstr("[DanglingPtr](2/3) It was not recorded where the memory "
"was freed."),
HasSubstr("[DanglingPtr](3/3) Later, the dangling raw_ptr was "
"released at:")));
}
// TODO(crbug.com/40260713): Check for leaked refcount on Android.
#if BUILDFLAG(IS_ANDROID)
// Some raw_ptr might never release their refcount. Make sure this cause a
// crash on exit.
TEST(PartitionAllocDanglingPtrChecks, ReleaseNotRecorded) {
EXPECT_DEATH(
{
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks;
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
},
HasSubstr("A freed allocation is still referenced by a dangling pointer "
"at exit, or at test end. Leaked raw_ptr/raw_ref "
"could cause PartitionAlloc's quarantine memory bloat."
"\n\n"
"Memory was released on:"));
}
#endif
// Getting the same allocation reported twice in a row, without matching
// `DanglingRawPtrReleased` in between is unexpected. Make sure this kind of
// potential regression would be detected.
TEST(PartitionAllocDanglingPtrChecks, DoubleDetection) {
EXPECT_DCHECK_DEATH_WITH(
{
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks;
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
},
"Check failed: !entry \\|\\| entry->id != id");
}
// Free and release from two different tasks with cross task dangling pointer
// detection enabled.
TEST(PartitionAllocDanglingPtrChecks, CrossTask) {
BASE_EXPECT_DEATH(
{
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks({
.type = "cross_task",
});
base::test::TaskEnvironment task_environment;
task_environment.GetMainThreadTaskRunner()->PostTask(
FROM_HERE,
base::BindOnce(partition_alloc::GetDanglingRawPtrDetectedFn(), 42));
task_environment.GetMainThreadTaskRunner()->PostTask(
FROM_HERE,
base::BindOnce(partition_alloc::GetDanglingRawPtrReleasedFn(), 42));
task_environment.RunUntilIdle();
},
AllOf(HasSubstr("[DanglingSignature]\t"),
HasSubstr("[DanglingPtr](1/3) A raw_ptr/raw_ref is dangling."),
HasSubstr("[DanglingPtr](2/3) First, the memory was freed at:"),
HasSubstr("[DanglingPtr](3/3) Later, the dangling raw_ptr was "
"released at:")));
}
TEST(PartitionAllocDanglingPtrChecks, CrossTaskIgnoredFailuresClearsCache) {
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks({
.type = "cross_task",
});
base::test::TaskEnvironment task_environment;
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
partition_alloc::GetDanglingRawPtrReleasedFn()(42);
task_environment.GetMainThreadTaskRunner()->PostTask(
FROM_HERE,
base::BindOnce(partition_alloc::GetDanglingRawPtrReleasedFn(), 42));
task_environment.RunUntilIdle();
}
TEST(PartitionAllocDanglingPtrChecks, CrossTaskIgnoresNoTask) {
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks({
.type = "cross_task",
});
partition_alloc::GetDanglingRawPtrDetectedFn()(42);
partition_alloc::GetDanglingRawPtrReleasedFn()(42);
}
TEST(PartitionAllocDanglingPtrChecks, CrossTaskIgnoresSameTask) {
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks({
.type = "cross_task",
});
base::test::TaskEnvironment task_environment;
task_environment.GetMainThreadTaskRunner()->PostTask(
FROM_HERE, base::BindOnce([] {
partition_alloc::GetDanglingRawPtrDetectedFn()(37);
partition_alloc::GetDanglingRawPtrReleasedFn()(37);
}));
task_environment.RunUntilIdle();
}
TEST(PartitionAllocDanglingPtrChecks, CrossTaskNoFreeConsideredCrossTask) {
ScopedInstallDanglingRawPtrChecks scoped_install_dangling_checks({
.type = "cross_task",
});
partition_alloc::GetDanglingRawPtrReleasedFn()(42);
}
TEST(PartitionAllocDanglingPtrChecks,
ExtractDanglingPtrSignatureMacStackTrace) {
const std::string stack_trace_output =
"0 lib_1 0x0000000115fdfa12 base::F1(**) + 18\r\n"
"1 lib_1 0x0000000115ec0043 base::F2() + 19\r\n"
"2 lib_1 0x000000011601fb01 "
"allocator_shim::internal::PartitionFree(foo) + 13265\r\n"
"3 lib_1 0x0000000114831027 base::F3(bar) + 42\r\n"
"4 lib_2 0x00000001148eae35 base::F4() + 437\r\n";
EXPECT_EQ("base::F3(bar)",
PartitionAllocSupport::ExtractDanglingPtrSignatureForTests(
stack_trace_output));
}
TEST(PartitionAllocDanglingPtrChecks, ExtractDanglingPtrSignatureMacTaskTrace) {
const std::string task_trace_output =
"Task trace:\r\n"
"0 lib_1 0x00000001161fd431 base::F1() + 257\r\n"
"1 lib_1 0x0000000115a49404 base::F2() + 68\r\n";
EXPECT_EQ("base::F1()",
PartitionAllocSupport::ExtractDanglingPtrSignatureForTests(
task_trace_output));
}
TEST(PartitionAllocDanglingPtrChecks,
ExtractDanglingPtrSignatureWindowsStackTrace) {
const std::string stack_trace_output =
"\tbase::F1 [0x055643C3+19] (o:\\base\\F1.cc:329)\r\n"
"\tallocator_shim::internal::PartitionFree [0x0648F87B+5243] "
"(o:\\path.cc:441)\r\n"
"\t_free_base [0x0558475D+29] (o:\\file_path.cc:142)\r\n"
"\tbase::F2 [0x04E5B317+23] (o:\\base\\F2.cc:91)\r\n"
"\tbase::F3 [0x04897800+544] (o:\\base\\F3.cc:638)\r\n";
EXPECT_EQ("base::F2",
PartitionAllocSupport::ExtractDanglingPtrSignatureForTests(
stack_trace_output));
}
TEST(PartitionAllocDanglingPtrChecks,
ExtractDanglingPtrSignatureWindowsTaskTrace) {
const std::string task_trace_output =
"Task trace:\r\n"
"\tbase::F1 [0x049068A3+813] (o:\\base\\F1.cc:207)\r\n"
"\tbase::F2 [0x0490614C+192] (o:\\base\\F2.cc:116)\r\n";
EXPECT_EQ("base::F1",
PartitionAllocSupport::ExtractDanglingPtrSignatureForTests(
task_trace_output));
}
#endif
#if PA_BUILDFLAG(HAS_MEMORY_TAGGING)
TEST(PartitionAllocSupportTest,
ProposeSyntheticFinchTrials_MemoryTaggingDogfood) {
{
test::ScopedFeatureList scope;
scope.InitWithFeatures({}, {features::kPartitionAllocMemoryTagging});
auto trials = ProposeSyntheticFinchTrials();
auto group_iter = trials.find("MemoryTaggingDogfood");
EXPECT_EQ(group_iter, trials.end());
}
{
test::ScopedFeatureList scope;
scope.InitWithFeatures({features::kPartitionAllocMemoryTagging}, {});
auto trials = ProposeSyntheticFinchTrials();
std::string expectation =
partition_alloc::internal::base::CPU::GetInstanceNoAllocation()
.has_mte()
? "Enabled"
: "Disabled";
auto group_iter = trials.find("MemoryTaggingDogfood");
EXPECT_NE(group_iter, trials.end());
EXPECT_EQ(group_iter->second, expectation);
}
}
#endif // PA_BUILDFLAG(HAS_MEMORY_TAGGING)
class MemoryReclaimerSupportTest : public ::testing::Test {
public:
void SetUp() override {
feature_list_.InitWithFeatures(
{base::features::kPartitionAllocMemoryReclaimer,
base::allocator::kDisableMemoryReclaimerInBackground},
{});
MemoryReclaimerSupport::Instance().ResetForTesting();
}
protected:
base::test::SingleThreadTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
test::ScopedFeatureList feature_list_;
};
TEST_F(MemoryReclaimerSupportTest, StartSeveralTimes) {
test::ScopedFeatureList feature_list{
base::features::kPartitionAllocMemoryReclaimer};
auto& instance = MemoryReclaimerSupport::Instance();
EXPECT_FALSE(instance.has_pending_task_for_testing());
instance.Start(task_environment_.GetMainThreadTaskRunner());
instance.Start(task_environment_.GetMainThreadTaskRunner());
instance.Start(task_environment_.GetMainThreadTaskRunner());
// Only one task.
EXPECT_TRUE(instance.has_pending_task_for_testing());
EXPECT_EQ(1u, task_environment_.GetPendingMainThreadTaskCount());
}
TEST_F(MemoryReclaimerSupportTest, ForegroundToBackground) {
test::ScopedFeatureList feature_list{
base::features::kPartitionAllocMemoryReclaimer};
auto& instance = MemoryReclaimerSupport::Instance();
EXPECT_FALSE(instance.has_pending_task_for_testing());
instance.Start(task_environment_.GetMainThreadTaskRunner());
EXPECT_TRUE(instance.has_pending_task_for_testing());
EXPECT_EQ(1u, task_environment_.GetPendingMainThreadTaskCount());
task_environment_.FastForwardBy(
MemoryReclaimerSupport::kFirstPAPurgeOrReclaimDelay);
// Task gets reposted.
EXPECT_TRUE(instance.has_pending_task_for_testing());
EXPECT_EQ(1u, task_environment_.GetPendingMainThreadTaskCount());
instance.SetForegrounded(false);
task_environment_.FastForwardBy(MemoryReclaimerSupport::GetInterval());
// But not once in background.
EXPECT_FALSE(instance.has_pending_task_for_testing());
EXPECT_EQ(0u, task_environment_.GetPendingMainThreadTaskCount());
}
TEST_F(MemoryReclaimerSupportTest, ForegroundToBackgroundAndBack) {
test::ScopedFeatureList feature_list{
base::features::kPartitionAllocMemoryReclaimer};
auto& instance = MemoryReclaimerSupport::Instance();
instance.Start(task_environment_.GetMainThreadTaskRunner());
task_environment_.FastForwardBy(
MemoryReclaimerSupport::kFirstPAPurgeOrReclaimDelay);
// Task gets reposted.
EXPECT_TRUE(instance.has_pending_task_for_testing());
EXPECT_EQ(1u, task_environment_.GetPendingMainThreadTaskCount());
instance.SetForegrounded(false);
task_environment_.FastForwardBy(MemoryReclaimerSupport::GetInterval());
// But not once in background.
EXPECT_FALSE(instance.has_pending_task_for_testing());
EXPECT_EQ(0u, task_environment_.GetPendingMainThreadTaskCount());
// Until we go to foreground again.
instance.SetForegrounded(true);
EXPECT_TRUE(instance.has_pending_task_for_testing());
EXPECT_EQ(1u, task_environment_.GetPendingMainThreadTaskCount());
}
} // namespace base::allocator
|