1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/390223051): Remove C-library calls to fix the errors.
#pragma allow_unsafe_libc_calls
#endif
#include "base/memory/safety_checks.h"
#include <new>
#include "base/allocator/partition_alloc_features.h"
#include "base/feature_list.h"
#include "partition_alloc/partition_address_space.h"
#include "partition_alloc/tagging.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using base::internal::is_memory_safety_checked;
using base::internal::MemorySafetyCheck;
// Normal object: should be targeted by no additional |MemorySafetyCheck|.
struct DefaultChecks {
public:
char data[16];
};
// Annotated object: should have |base::internal::kAdvancedMemorySafetyChecks|.
struct AdvancedChecks {
ADVANCED_MEMORY_SAFETY_CHECKS();
public:
char data[16];
};
// Annotated object: should have |base::internal::kAdvancedMemorySafetyChecks|.
struct AnotherAdvancedChecks {
ADVANCED_MEMORY_SAFETY_CHECKS();
public:
char data[16];
};
// Annotated and aligned object for testing aligned allocations.
constexpr int kLargeAlignment = 2 * __STDCPP_DEFAULT_NEW_ALIGNMENT__;
struct alignas(kLargeAlignment) AlignedAdvancedChecks {
ADVANCED_MEMORY_SAFETY_CHECKS();
public:
char data[16];
};
struct PrivateInheritanceWithInheritMacro : private AdvancedChecks {
INHERIT_MEMORY_SAFETY_CHECKS(AdvancedChecks);
};
static_assert(
is_memory_safety_checked<PrivateInheritanceWithInheritMacro,
MemorySafetyCheck::kForcePartitionAlloc>);
struct PrivateInheritanceWithDefaultMacro : private AdvancedChecks {
DEFAULT_MEMORY_SAFETY_CHECKS();
};
static_assert(
!is_memory_safety_checked<PrivateInheritanceWithDefaultMacro,
MemorySafetyCheck::kForcePartitionAlloc>);
struct MultipleInheritanceWithInheritMacro : AdvancedChecks,
AnotherAdvancedChecks {
INHERIT_MEMORY_SAFETY_CHECKS(AdvancedChecks);
};
static_assert(
is_memory_safety_checked<MultipleInheritanceWithInheritMacro,
MemorySafetyCheck::kForcePartitionAlloc>);
struct MultipleInheritanceWithDefaultMacro : AdvancedChecks,
AnotherAdvancedChecks {
DEFAULT_MEMORY_SAFETY_CHECKS();
};
static_assert(
!is_memory_safety_checked<MultipleInheritanceWithDefaultMacro,
MemorySafetyCheck::kForcePartitionAlloc>);
struct AdvancedChecksWithPartialOverwrite {
ADVANCED_MEMORY_SAFETY_CHECKS(kNone, kForcePartitionAlloc);
public:
char data[16];
};
static_assert(
!is_memory_safety_checked<AdvancedChecksWithPartialOverwrite,
MemorySafetyCheck::kForcePartitionAlloc>);
struct InheritanceWithPartialOverwrite : private AdvancedChecks {
INHERIT_MEMORY_SAFETY_CHECKS(AdvancedChecks, kNone, kForcePartitionAlloc);
};
static_assert(
!is_memory_safety_checked<InheritanceWithPartialOverwrite,
MemorySafetyCheck::kForcePartitionAlloc>);
// The macro may hook memory allocation/deallocation but should forward the
// request to PA or any other allocator via
// |HandleMemorySafetyCheckedOperator***|.
TEST(MemorySafetyCheckTest, AllocatorFunctions) {
static_assert(
!is_memory_safety_checked<DefaultChecks,
MemorySafetyCheck::kForcePartitionAlloc>);
static_assert(
is_memory_safety_checked<AdvancedChecks,
MemorySafetyCheck::kForcePartitionAlloc>);
static_assert(
is_memory_safety_checked<AlignedAdvancedChecks,
MemorySafetyCheck::kForcePartitionAlloc>);
// void* operator new(std::size_t count);
auto* ptr1 = new DefaultChecks();
auto* ptr2 = new AdvancedChecks();
EXPECT_NE(ptr1, nullptr);
EXPECT_NE(ptr2, nullptr);
// AdvancedChecks is kForcePartitionAlloc.
#if PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
EXPECT_TRUE(partition_alloc::IsManagedByPartitionAlloc(
reinterpret_cast<uintptr_t>(partition_alloc::UntagPtr(ptr2))));
#endif // PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
// void operator delete(void* ptr);
delete ptr1;
delete ptr2;
// void* operator new(std::size_t count, std::align_val_t alignment)
ptr1 = new (std::align_val_t(64)) DefaultChecks();
ptr2 = new (std::align_val_t(64)) AdvancedChecks();
EXPECT_NE(ptr1, nullptr);
EXPECT_NE(ptr2, nullptr);
// AdvancedChecks is kForcePartitionAlloc.
#if PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
EXPECT_TRUE(partition_alloc::IsManagedByPartitionAlloc(
reinterpret_cast<uintptr_t>(partition_alloc::UntagPtr(ptr2))));
#endif // PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
// void operator delete(void* ptr, std::align_val_t alignment)
::operator delete(ptr1, std::align_val_t(64));
AdvancedChecks::operator delete(ptr2, std::align_val_t(64));
// void* operator new(std::size_t count, std::align_val_t alignment)
auto* ptr3 = new AlignedAdvancedChecks();
EXPECT_NE(ptr3, nullptr);
// AlignedAdvancedChecks is kForcePartitionAlloc.
#if PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
EXPECT_TRUE(partition_alloc::IsManagedByPartitionAlloc(
reinterpret_cast<uintptr_t>(partition_alloc::UntagPtr(ptr3))));
#endif // PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
// void operator delete(void* ptr, std::align_val_t alignment)
delete ptr3;
// void* operator new(std::size_t, void* ptr)
alignas(AlignedAdvancedChecks) char data[32];
ptr1 = new (data) DefaultChecks();
ptr2 = new (data) AdvancedChecks();
ptr3 = new (data) AlignedAdvancedChecks();
}
#if PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
TEST(MemorySafetyCheckTest, SchedulerLoopQuarantine) {
// The check is performed only if `kPartitionAllocSchedulerLoopQuarantine` is
// enabled. `base::ScopedFeatureList` does not work here because the default
// `PartitionRoot` is configured before running this test.
if (!base::FeatureList::IsEnabled(
base::features::kPartitionAllocSchedulerLoopQuarantine)) {
return;
}
static_assert(
!is_memory_safety_checked<DefaultChecks,
MemorySafetyCheck::kSchedulerLoopQuarantine>);
static_assert(
is_memory_safety_checked<AdvancedChecks,
MemorySafetyCheck::kSchedulerLoopQuarantine>);
auto* root =
base::internal::GetPartitionRootForMemorySafetyCheckedAllocation();
partition_alloc::internal::
ScopedSchedulerLoopQuarantineBranchAccessorForTesting branch(root);
auto* ptr1 = new DefaultChecks();
EXPECT_NE(ptr1, nullptr);
delete ptr1;
EXPECT_FALSE(branch.IsQuarantined(ptr1));
auto* ptr2 = new AdvancedChecks();
EXPECT_NE(ptr2, nullptr);
delete ptr2;
EXPECT_TRUE(branch.IsQuarantined(ptr2));
branch.Purge();
}
TEST(MemorySafetyCheckTest, ZapOnFree) {
// The check is performed only if `kPartitionAllocZappingByFreeFlags` is
// enabled. `base::ScopedFeatureList` does not work here because the default
// `PartitionRoot` is configured before running this test.
if (!base::FeatureList::IsEnabled(
base::features::kPartitionAllocZappingByFreeFlags)) {
return;
}
static_assert(
!is_memory_safety_checked<DefaultChecks,
MemorySafetyCheck::kSchedulerLoopQuarantine>);
static_assert(
is_memory_safety_checked<AdvancedChecks,
MemorySafetyCheck::kSchedulerLoopQuarantine>);
{
// Without kSchedulerLoopQuarantine.
auto* ptr = new DefaultChecks();
EXPECT_NE(ptr, nullptr);
delete ptr;
// *ptr is undefined.
}
{
// With kSchedulerLoopQuarantine.
auto* ptr = new AdvancedChecks();
EXPECT_NE(ptr, nullptr);
memset(ptr->data, 'A', sizeof(ptr->data));
delete ptr;
// Dereferencing `ptr` is still undefiner behavior, but we can say it is
// somewhat defined as this test is gated behind
// `PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)`.
// I believe behavior here is concrete enough to be tested, but it can be
// affected by changes in PA. Please disable this test if it flakes.
EXPECT_NE(ptr->data[0], 'A');
}
}
#endif // PA_BUILDFLAG(USE_PARTITION_ALLOC_AS_MALLOC)
} // namespace
|