1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/task/thread_pool/delayed_task_manager.h"
#include <memory>
#include <utility>
#include "base/cancelable_callback.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/task_features.h"
#include "base/task/thread_pool/task.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_mock_time_task_runner.h"
#include "base/threading/thread.h"
#include "base/time/time.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base::internal {
namespace {
constexpr TimeDelta kLongerDelay = Hours(3);
constexpr TimeDelta kLongDelay = Hours(1);
constexpr TimeDelta kLeeway = base::kDefaultLeeway;
class MockCallback {
public:
MOCK_METHOD0(Run, void());
};
void PostTaskNow(Task task) {
std::move(task.task).Run();
}
Task ConstructMockedTask(testing::StrictMock<MockCallback>& mock_task,
TimeTicks now,
TimeDelta delay) {
Task task(FROM_HERE, BindOnce(&MockCallback::Run, Unretained(&mock_task)),
now, delay);
return task;
}
Task ConstructMockedTask(testing::StrictMock<MockCallback>& mock_task,
TimeTicks now,
TimeTicks delayed_run_time,
subtle::DelayPolicy delay_policy) {
Task task(FROM_HERE, BindOnce(&MockCallback::Run, Unretained(&mock_task)),
now, delayed_run_time, kLeeway, delay_policy);
return task;
}
class ThreadPoolDelayedTaskManagerTest : public testing::Test {
public:
ThreadPoolDelayedTaskManagerTest(const ThreadPoolDelayedTaskManagerTest&) =
delete;
ThreadPoolDelayedTaskManagerTest& operator=(
const ThreadPoolDelayedTaskManagerTest&) = delete;
protected:
ThreadPoolDelayedTaskManagerTest() {
// A null clock triggers some assertions.
service_thread_task_runner_->AdvanceMockTickClock(Milliseconds(1));
task_ = ConstructMockedTask(
mock_callback_, service_thread_task_runner_->NowTicks(), kLongDelay);
}
~ThreadPoolDelayedTaskManagerTest() override = default;
const scoped_refptr<TestMockTimeTaskRunner> service_thread_task_runner_ =
MakeRefCounted<TestMockTimeTaskRunner>();
DelayedTaskManager delayed_task_manager_{
service_thread_task_runner_->GetMockTickClock()};
testing::StrictMock<MockCallback> mock_callback_;
Task task_;
};
} // namespace
// Verify that a delayed task isn't forwarded before Start().
TEST_F(ThreadPoolDelayedTaskManagerTest, DelayedTaskDoesNotRunBeforeStart) {
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
// Fast-forward time until the task is ripe for execution. Since Start() has
// not been called, the task should not be forwarded to PostTaskNow()
// (MockCallback is a StrictMock without expectations so test will fail if
// PostTaskNow() runs it).
service_thread_task_runner_->FastForwardBy(kLongDelay);
}
// Verify that a delayed task added before Start() and whose delay expires after
// Start() is forwarded when its delay expires.
TEST_F(ThreadPoolDelayedTaskManagerTest,
DelayedTaskPostedBeforeStartExpiresAfterStartRunsOnExpire) {
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
delayed_task_manager_.Start(service_thread_task_runner_);
// Run tasks on the service thread. Don't expect any forwarding to
// |task_target_| since the task isn't ripe for execution.
service_thread_task_runner_->RunUntilIdle();
// Fast-forward time until the task is ripe for execution. Expect the task to
// be forwarded to PostTaskNow().
EXPECT_CALL(mock_callback_, Run());
service_thread_task_runner_->FastForwardBy(kLongDelay);
}
// Verify that a delayed task added before Start() and whose delay expires
// before Start() is forwarded when Start() is called.
TEST_F(ThreadPoolDelayedTaskManagerTest,
DelayedTaskPostedBeforeStartExpiresBeforeStartRunsOnStart) {
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
// Run tasks on the service thread. Don't expect any forwarding to
// |task_target_| since the task isn't ripe for execution.
service_thread_task_runner_->RunUntilIdle();
// Fast-forward time until the task is ripe for execution. Don't expect the
// task to be forwarded since Start() hasn't been called yet.
service_thread_task_runner_->FastForwardBy(kLongDelay);
// Start the DelayedTaskManager. Expect the task to be forwarded to
// PostTaskNow().
EXPECT_CALL(mock_callback_, Run());
delayed_task_manager_.Start(service_thread_task_runner_);
service_thread_task_runner_->RunUntilIdle();
}
// Verify that a delayed task added after Start() isn't forwarded before it is
// ripe for execution.
TEST_F(ThreadPoolDelayedTaskManagerTest, DelayedTaskDoesNotRunTooEarly) {
delayed_task_manager_.Start(service_thread_task_runner_);
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
// Run tasks that are ripe for execution. Don't expect any forwarding to
// PostTaskNow().
service_thread_task_runner_->RunUntilIdle();
}
// Verify that a delayed task added after Start() is forwarded when it is ripe
// for execution.
TEST_F(ThreadPoolDelayedTaskManagerTest, DelayedTaskRunsAfterDelay) {
delayed_task_manager_.Start(service_thread_task_runner_);
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
// Fast-forward time. Expect the task to be forwarded to PostTaskNow().
EXPECT_CALL(mock_callback_, Run());
service_thread_task_runner_->FastForwardBy(kLongDelay);
}
// Verify that a delayed task posted with kFlexiblePreferEarly delay policy
// is forwarded within the leeway period preceding the deadline.
TEST_F(ThreadPoolDelayedTaskManagerTest,
DelayedTaskRunsAtTime_FlexiblePreferEarly) {
const TimeDelta kUnalignedLongDelay = kLongDelay + Milliseconds(1);
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(kAlignWakeUps);
delayed_task_manager_.Start(service_thread_task_runner_);
TimeTicks now = service_thread_task_runner_->NowTicks();
Task task =
ConstructMockedTask(mock_callback_, now, now + kUnalignedLongDelay,
base::subtle::DelayPolicy::kFlexiblePreferEarly);
// Send |task| to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task), BindOnce(&PostTaskNow));
// The task isn't forwarded before the earliest run time is reached.
service_thread_task_runner_->FastForwardBy(kUnalignedLongDelay - kLeeway -
Milliseconds(1));
testing::Mock::VerifyAndClear(&mock_callback_);
// Fast-forward time. Expect the task to be forwarded to PostTaskNow().
EXPECT_CALL(mock_callback_, Run());
service_thread_task_runner_->FastForwardBy(kLeeway + Milliseconds(1));
}
// Verify that a delayed task added after Start() is forwarded when it is
// canceled, even if its delay hasn't expired.
TEST_F(ThreadPoolDelayedTaskManagerTest, DelayedTaskRunsAfterCancelled) {
static_assert(kLongerDelay > kLongDelay, "");
delayed_task_manager_.Start(service_thread_task_runner_);
// Add a cancelable task to the DelayedTaskManager with a longer delay.
CancelableOnceClosure cancelable_closure(DoNothing());
bool post_cancelable_task_now_invoked = false;
Task cancelable_task(FROM_HERE, cancelable_closure.callback(),
TimeTicks::Now(), kLongerDelay);
auto post_cancelable_task_now = BindLambdaForTesting(
[&](Task task) { post_cancelable_task_now_invoked = true; });
delayed_task_manager_.AddDelayedTask(std::move(cancelable_task),
post_cancelable_task_now);
// Add |task_| to the DelayedTaskManager with a long delay.
delayed_task_manager_.AddDelayedTask(std::move(task_),
BindOnce(&PostTaskNow));
// Cancel the cancelable task.
cancelable_closure.Cancel();
// Fast-forward time by |kLongDelay|. The non-cancelable task should have its
// "post task now" callback invoked and it should run. The canceled task
// should have its "post task now" callback invoked, even if its delay hasn't
// expired.
EXPECT_CALL(mock_callback_, Run());
service_thread_task_runner_->FastForwardBy(kLongDelay);
EXPECT_TRUE(post_cancelable_task_now_invoked);
}
// Verify that multiple delayed tasks added after Start() are forwarded when
// they are ripe for execution.
TEST_F(ThreadPoolDelayedTaskManagerTest, DelayedTasksRunAfterDelay) {
delayed_task_manager_.Start(service_thread_task_runner_);
testing::StrictMock<MockCallback> mock_callback_a;
Task task_a = ConstructMockedTask(
mock_callback_a, service_thread_task_runner_->NowTicks(), Hours(1));
testing::StrictMock<MockCallback> mock_callback_b;
Task task_b = ConstructMockedTask(
mock_callback_b, service_thread_task_runner_->NowTicks(), Hours(2));
testing::StrictMock<MockCallback> mock_callback_c;
Task task_c = ConstructMockedTask(
mock_callback_c, service_thread_task_runner_->NowTicks(), Hours(1));
// Send tasks to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_a),
BindOnce(&PostTaskNow));
delayed_task_manager_.AddDelayedTask(std::move(task_b),
BindOnce(&PostTaskNow));
delayed_task_manager_.AddDelayedTask(std::move(task_c),
BindOnce(&PostTaskNow));
// Run tasks that are ripe for execution on the service thread. Don't expect
// any call to PostTaskNow().
service_thread_task_runner_->RunUntilIdle();
// Fast-forward time. Expect |task_a| and |task_c| to be forwarded to
// |task_target_|.
EXPECT_CALL(mock_callback_a, Run());
EXPECT_CALL(mock_callback_c, Run());
service_thread_task_runner_->FastForwardBy(Hours(1));
testing::Mock::VerifyAndClear(&mock_callback_a);
testing::Mock::VerifyAndClear(&mock_callback_c);
// Fast-forward time. Expect |task_b| to be forwarded to PostTaskNow().
EXPECT_CALL(mock_callback_b, Run());
service_thread_task_runner_->FastForwardBy(Hours(1));
testing::Mock::VerifyAndClear(&mock_callback_b);
}
// Verify that multiple delayed tasks are forwarded respecting the order
// prescibed by their latest deadline.
TEST_F(ThreadPoolDelayedTaskManagerTest,
DelayedTasksRunAtTime_MixedDelayPolicy) {
delayed_task_manager_.Start(service_thread_task_runner_);
TimeTicks now = service_thread_task_runner_->NowTicks();
testing::StrictMock<MockCallback> mock_callback_a;
Task task_a =
ConstructMockedTask(mock_callback_a, now, now + Milliseconds(8),
base::subtle::DelayPolicy::kFlexibleNoSooner);
testing::StrictMock<MockCallback> mock_callback_b;
Task task_b =
ConstructMockedTask(mock_callback_b, now, now + Milliseconds(10),
base::subtle::DelayPolicy::kPrecise);
// Send tasks to the DelayedTaskManager.
delayed_task_manager_.AddDelayedTask(std::move(task_a),
BindOnce(&PostTaskNow));
EXPECT_EQ(base::subtle::DelayPolicy::kFlexibleNoSooner,
delayed_task_manager_.TopTaskDelayPolicyForTesting());
delayed_task_manager_.AddDelayedTask(std::move(task_b),
BindOnce(&PostTaskNow));
EXPECT_EQ(base::subtle::DelayPolicy::kPrecise,
delayed_task_manager_.TopTaskDelayPolicyForTesting());
// The task doesn't run before the delay has completed.
service_thread_task_runner_->FastForwardBy(Milliseconds(10) -
Milliseconds(1));
// Run tasks that are ripe for execution on the service thread. Don't expect
// any call to PostTaskNow().
service_thread_task_runner_->RunUntilIdle();
// Fast-forward time. Expect |task_b| and |task_b| to be forwarded.
EXPECT_CALL(mock_callback_b, Run());
EXPECT_CALL(mock_callback_a, Run());
service_thread_task_runner_->FastForwardBy(Milliseconds(1));
}
TEST_F(ThreadPoolDelayedTaskManagerTest, PostTaskDuringStart) {
Thread other_thread("Test");
other_thread.StartAndWaitForTesting();
WaitableEvent task_posted;
other_thread.task_runner()->PostTask(FROM_HERE, BindLambdaForTesting([&] {
delayed_task_manager_.AddDelayedTask(
std::move(task_),
BindOnce(&PostTaskNow));
task_posted.Signal();
}));
delayed_task_manager_.Start(service_thread_task_runner_);
// The test is testing a race between AddDelayedTask/Start but it still needs
// synchronization to ensure we don't do the final verification before the
// task itself is posted.
task_posted.Wait();
// Fast-forward time. Expect the task to be forwarded to PostTaskNow().
EXPECT_CALL(mock_callback_, Run());
service_thread_task_runner_->FastForwardBy(kLongDelay);
}
} // namespace base::internal
|