1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/task/thread_pool/thread_group.h"
#include <memory>
#include <tuple>
#include <utility>
#include "base/barrier_closure.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/task/task_runner.h"
#include "base/task/task_traits.h"
#include "base/task/thread_pool/can_run_policy_test.h"
#include "base/task/thread_pool/delayed_task_manager.h"
#include "base/task/thread_pool/pooled_sequenced_task_runner.h"
#include "base/task/thread_pool/task_tracker.h"
#include "base/task/thread_pool/test_task_factory.h"
#include "base/task/thread_pool/test_utils.h"
#include "base/task/thread_pool/thread_group_impl.h"
#include "base/test/bind.h"
#include "base/test/test_timeouts.h"
#include "base/test/test_waitable_event.h"
#include "base/threading/platform_thread.h"
#include "base/threading/scoped_blocking_call.h"
#include "base/threading/scoped_blocking_call_internal.h"
#include "base/threading/simple_thread.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
#if BUILDFLAG(IS_WIN)
#include "base/win/com_init_check_hook.h"
#include "base/win/com_init_util.h"
#endif
namespace base::internal {
namespace {
constexpr size_t kMaxTasks = 4;
constexpr size_t kTooManyTasks = 1000;
// By default, tests allow half of the thread group to be used by best-effort
// tasks.
constexpr size_t kMaxBestEffortTasks = kMaxTasks / 2;
constexpr size_t kNumThreadsPostingTasks = 4;
constexpr size_t kNumTasksPostedPerThread = 150;
using PostNestedTask = test::TestTaskFactory::PostNestedTask;
class ThreadPostingTasks : public SimpleThread {
public:
// Constructs a thread that posts |num_tasks_posted_per_thread| tasks to
// |thread_group| through an |execution_mode| task runner. If
// |post_nested_task| is YES, each task posted by this thread posts another
// task when it runs.
ThreadPostingTasks(
test::MockPooledTaskRunnerDelegate* mock_pooled_task_runner_delegate_,
TaskSourceExecutionMode execution_mode,
PostNestedTask post_nested_task)
: SimpleThread("ThreadPostingTasks"),
post_nested_task_(post_nested_task),
factory_(test::CreatePooledTaskRunnerWithExecutionMode(
execution_mode,
mock_pooled_task_runner_delegate_),
execution_mode) {}
ThreadPostingTasks(const ThreadPostingTasks&) = delete;
ThreadPostingTasks& operator=(const ThreadPostingTasks&) = delete;
const test::TestTaskFactory* factory() const { return &factory_; }
private:
void Run() override {
for (size_t i = 0; i < kNumTasksPostedPerThread; ++i) {
EXPECT_TRUE(factory_.PostTask(post_nested_task_, OnceClosure()));
}
}
const scoped_refptr<TaskRunner> task_runner_;
const PostNestedTask post_nested_task_;
test::TestTaskFactory factory_;
};
class ThreadGroupTestBase : public testing::Test, public ThreadGroup::Delegate {
public:
ThreadGroupTestBase(const ThreadGroupTestBase&) = delete;
ThreadGroupTestBase& operator=(const ThreadGroupTestBase&) = delete;
protected:
ThreadGroupTestBase() = default;
void SetUp() override {
service_thread_.Start();
delayed_task_manager_.Start(service_thread_.task_runner());
CreateThreadGroup();
}
void TearDown() override {
delayed_task_manager_.Shutdown();
service_thread_.Stop();
DestroyThreadGroup();
}
void CreateThreadGroup() {
ASSERT_FALSE(thread_group_);
thread_group_ = std::make_unique<ThreadGroupImpl>(
"TestThreadGroup", "A", ThreadType::kDefault,
/*thread_group_type=*/0, task_tracker_.GetTrackedRef(),
tracked_ref_factory_.GetTrackedRef());
mock_pooled_task_runner_delegate_.SetThreadGroup(thread_group_.get());
}
void StartThreadGroup(ThreadGroup::WorkerEnvironment worker_environment =
ThreadGroup::WorkerEnvironment::NONE) {
ASSERT_TRUE(thread_group_);
ThreadGroupImpl* thread_group_impl =
static_cast<ThreadGroupImpl*>(thread_group_.get());
thread_group_impl->Start(kMaxTasks, kMaxBestEffortTasks, TimeDelta::Max(),
service_thread_.task_runner(), nullptr,
worker_environment,
/*synchronous_thread_start_for_testing=*/false,
/*may_block_threshold=*/{});
}
void DestroyThreadGroup() {
if (!thread_group_) {
return;
}
thread_group_->JoinForTesting();
mock_pooled_task_runner_delegate_.SetThreadGroup(nullptr);
thread_group_.reset();
}
Thread service_thread_{"ThreadPoolServiceThread"};
TaskTracker task_tracker_;
DelayedTaskManager delayed_task_manager_;
test::MockPooledTaskRunnerDelegate mock_pooled_task_runner_delegate_ = {
task_tracker_.GetTrackedRef(), &delayed_task_manager_};
std::unique_ptr<ThreadGroup> thread_group_;
private:
// ThreadGroup::Delegate:
ThreadGroup* GetThreadGroupForTraits(const TaskTraits& traits) override {
return thread_group_.get();
}
TrackedRefFactory<ThreadGroup::Delegate> tracked_ref_factory_{this};
};
using ThreadGroupTest = ThreadGroupTestBase;
// TODO(etiennep): Audit tests that don't need TaskSourceExecutionMode
// parameter.
class ThreadGroupTestAllExecutionModes
: public ThreadGroupTestBase,
public testing::WithParamInterface<TaskSourceExecutionMode> {
public:
ThreadGroupTestAllExecutionModes() = default;
ThreadGroupTestAllExecutionModes(const ThreadGroupTestAllExecutionModes&) =
delete;
ThreadGroupTestAllExecutionModes& operator=(
const ThreadGroupTestAllExecutionModes&) = delete;
TaskSourceExecutionMode execution_mode() const { return GetParam(); }
scoped_refptr<TaskRunner> CreatePooledTaskRunner(
const TaskTraits& traits = {}) {
return test::CreatePooledTaskRunnerWithExecutionMode(
execution_mode(), &mock_pooled_task_runner_delegate_, traits);
}
};
void ShouldNotRun() {
ADD_FAILURE() << "Ran a task that shouldn't run.";
}
} // namespace
TEST_P(ThreadGroupTestAllExecutionModes, PostTasks) {
StartThreadGroup();
// Create threads to post tasks.
std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
for (size_t i = 0; i < kNumThreadsPostingTasks; ++i) {
threads_posting_tasks.push_back(std::make_unique<ThreadPostingTasks>(
&mock_pooled_task_runner_delegate_, execution_mode(),
PostNestedTask::NO));
threads_posting_tasks.back()->Start();
}
// Wait for all tasks to run.
for (const auto& thread_posting_tasks : threads_posting_tasks) {
thread_posting_tasks->Join();
thread_posting_tasks->factory()->WaitForAllTasksToRun();
}
// Flush the task tracker to be sure that no task accesses its TestTaskFactory
// after |thread_posting_tasks| is destroyed.
task_tracker_.FlushForTesting();
}
TEST_P(ThreadGroupTestAllExecutionModes, NestedPostTasks) {
StartThreadGroup();
// Create threads to post tasks. Each task posted by these threads will post
// another task when it runs.
std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
for (size_t i = 0; i < kNumThreadsPostingTasks; ++i) {
threads_posting_tasks.push_back(std::make_unique<ThreadPostingTasks>(
&mock_pooled_task_runner_delegate_, execution_mode(),
PostNestedTask::YES));
threads_posting_tasks.back()->Start();
}
// Wait for all tasks to run.
for (const auto& thread_posting_tasks : threads_posting_tasks) {
thread_posting_tasks->Join();
thread_posting_tasks->factory()->WaitForAllTasksToRun();
}
// Flush the task tracker to be sure that no task accesses its TestTaskFactory
// after |thread_posting_tasks| is destroyed.
task_tracker_.FlushForTesting();
}
// Verify that a Task can't be posted after shutdown.
TEST_P(ThreadGroupTestAllExecutionModes, PostTaskAfterShutdown) {
StartThreadGroup();
auto task_runner = CreatePooledTaskRunner();
test::ShutdownTaskTracker(&task_tracker_);
EXPECT_FALSE(task_runner->PostTask(FROM_HERE, BindOnce(&ShouldNotRun)));
}
// Verify that a Task runs shortly after its delay expires.
TEST_P(ThreadGroupTestAllExecutionModes, PostDelayedTask) {
StartThreadGroup();
// kJob doesn't support delays.
if (execution_mode() == TaskSourceExecutionMode::kJob) {
return;
}
TestWaitableEvent task_ran(WaitableEvent::ResetPolicy::AUTOMATIC);
auto task_runner = CreatePooledTaskRunner();
// Wait until the task runner is up and running to make sure the test below is
// solely timing the delayed task, not bringing up a physical thread.
task_runner->PostTask(
FROM_HERE, BindOnce(&TestWaitableEvent::Signal, Unretained(&task_ran)));
task_ran.Wait();
ASSERT_TRUE(!task_ran.IsSignaled());
// Post a task with a short delay.
const TimeTicks start_time = TimeTicks::Now();
EXPECT_TRUE(task_runner->PostDelayedTask(
FROM_HERE, BindOnce(&TestWaitableEvent::Signal, Unretained(&task_ran)),
TestTimeouts::tiny_timeout()));
// Wait until the task runs.
task_ran.Wait();
// Expect the task to run after its delay expires, but no more than a
// reasonable amount of time after that (overloaded bots can be slow sometimes
// so give it 10X flexibility).
const TimeDelta actual_delay = TimeTicks::Now() - start_time;
EXPECT_GE(actual_delay, TestTimeouts::tiny_timeout());
EXPECT_LT(actual_delay, 10 * TestTimeouts::tiny_timeout());
}
// Verify that the RunsTasksInCurrentSequence() method of a SEQUENCED TaskRunner
// returns false when called from a task that isn't part of the sequence. Note:
// Tests that use TestTaskFactory already verify that
// RunsTasksInCurrentSequence() returns true when appropriate so this method
// complements it to get full coverage of that method.
TEST_P(ThreadGroupTestAllExecutionModes, SequencedRunsTasksInCurrentSequence) {
StartThreadGroup();
auto task_runner = CreatePooledTaskRunner();
auto sequenced_task_runner = test::CreatePooledSequencedTaskRunner(
TaskTraits(), &mock_pooled_task_runner_delegate_);
TestWaitableEvent task_ran;
task_runner->PostTask(
FROM_HERE,
BindOnce(
[](scoped_refptr<SequencedTaskRunner> sequenced_task_runner,
TestWaitableEvent* task_ran) {
EXPECT_FALSE(sequenced_task_runner->RunsTasksInCurrentSequence());
task_ran->Signal();
},
sequenced_task_runner, Unretained(&task_ran)));
task_ran.Wait();
}
// Verify that tasks posted before Start run after Start.
TEST_P(ThreadGroupTestAllExecutionModes, PostBeforeStart) {
TestWaitableEvent task_1_running;
TestWaitableEvent task_2_running;
auto task_runner = CreatePooledTaskRunner();
task_runner->PostTask(FROM_HERE, BindOnce(&TestWaitableEvent::Signal,
Unretained(&task_1_running)));
task_runner->PostTask(FROM_HERE, BindOnce(&TestWaitableEvent::Signal,
Unretained(&task_2_running)));
// Workers should not be created and tasks should not run before the thread
// group is started. The sleep is to give time for the tasks to potentially
// run.
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_FALSE(task_1_running.IsSignaled());
EXPECT_FALSE(task_2_running.IsSignaled());
StartThreadGroup();
// Tasks should run shortly after the thread group is started.
task_1_running.Wait();
task_2_running.Wait();
task_tracker_.FlushForTesting();
}
// Verify that tasks only run when allowed by the CanRunPolicy.
TEST_P(ThreadGroupTestAllExecutionModes, CanRunPolicyBasic) {
StartThreadGroup();
test::TestCanRunPolicyBasic(
thread_group_.get(),
[this](TaskPriority priority) {
return CreatePooledTaskRunner({priority});
},
&task_tracker_);
}
TEST_F(ThreadGroupTest, CanRunPolicyUpdatedBeforeRun) {
StartThreadGroup();
// This test only works with SequencedTaskRunner become it assumes
// ordered execution of 2 posted tasks.
test::TestCanRunPolicyChangedBeforeRun(
thread_group_.get(),
[this](TaskPriority priority) {
return test::CreatePooledSequencedTaskRunner(
{priority}, &mock_pooled_task_runner_delegate_);
},
&task_tracker_);
}
TEST_P(ThreadGroupTestAllExecutionModes, CanRunPolicyLoad) {
StartThreadGroup();
test::TestCanRunPolicyLoad(
thread_group_.get(),
[this](TaskPriority priority) {
return CreatePooledTaskRunner({priority});
},
&task_tracker_);
}
// Verifies that ShouldYield() returns true for a priority that is not allowed
// to run by the CanRunPolicy.
TEST_F(ThreadGroupTest, CanRunPolicyShouldYield) {
StartThreadGroup();
task_tracker_.SetCanRunPolicy(CanRunPolicy::kNone);
thread_group_->DidUpdateCanRunPolicy();
EXPECT_TRUE(
thread_group_->ShouldYield({TaskPriority::BEST_EFFORT, TimeTicks()}));
EXPECT_TRUE(
thread_group_->ShouldYield({TaskPriority::USER_VISIBLE, TimeTicks()}));
task_tracker_.SetCanRunPolicy(CanRunPolicy::kForegroundOnly);
thread_group_->DidUpdateCanRunPolicy();
EXPECT_TRUE(
thread_group_->ShouldYield({TaskPriority::BEST_EFFORT, TimeTicks()}));
EXPECT_FALSE(
thread_group_->ShouldYield({TaskPriority::USER_VISIBLE, TimeTicks()}));
task_tracker_.SetCanRunPolicy(CanRunPolicy::kAll);
thread_group_->DidUpdateCanRunPolicy();
EXPECT_FALSE(
thread_group_->ShouldYield({TaskPriority::BEST_EFFORT, TimeTicks()}));
EXPECT_FALSE(
thread_group_->ShouldYield({TaskPriority::USER_VISIBLE, TimeTicks()}));
}
TEST_F(ThreadGroupTest, SetMaxTasks) {
StartThreadGroup();
constexpr size_t kNewMaxTasks = kMaxTasks / 2;
ASSERT_EQ(thread_group_->GetMaxTasksForTesting(), kMaxTasks);
thread_group_->SetMaxTasks(kNewMaxTasks);
ASSERT_EQ(thread_group_->GetMaxTasksForTesting(), kNewMaxTasks);
TestWaitableEvent threads_running;
TestWaitableEvent busy_threads_continue;
const scoped_refptr<TaskRunner> task_runner =
test::CreatePooledTaskRunner({MayBlock(), WithBaseSyncPrimitives()},
&mock_pooled_task_runner_delegate_);
RepeatingClosure threads_running_barrier = BarrierClosure(
kNewMaxTasks,
BindOnce(&TestWaitableEvent::Signal, Unretained(&threads_running)));
// Posting these tasks should cause new workers to be created.
for (size_t i = 0; i < kNewMaxTasks; ++i) {
task_runner->PostTask(
FROM_HERE, BindLambdaForTesting(
[&busy_threads_continue, &threads_running_barrier]() {
threads_running_barrier.Run();
busy_threads_continue.Wait();
}));
}
threads_running.Wait();
AtomicFlag is_exiting;
// These tasks should not get executed until after other tasks become
// unblocked.
for (size_t i = 0; i < kNewMaxTasks; ++i) {
task_runner->PostTask(FROM_HERE, BindOnce(
[](AtomicFlag* is_exiting) {
EXPECT_TRUE(is_exiting->IsSet());
},
Unretained(&is_exiting)));
}
// Give time for those idle workers to possibly do work (which should not
// happen).
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
is_exiting.Set();
thread_group_->ResetMaxTasks();
busy_threads_continue.Signal();
task_tracker_.FlushForTesting();
}
// Verify that the maximum number of BEST_EFFORT tasks that can run concurrently
// in a thread group does not affect Sequences with a priority that was
// increased from BEST_EFFORT to USER_BLOCKING.
TEST_F(ThreadGroupTest, UpdatePriorityBestEffortToUserBlocking) {
StartThreadGroup();
CheckedLock num_tasks_running_lock;
ConditionVariable num_tasks_running_cv =
num_tasks_running_lock.CreateConditionVariable();
num_tasks_running_cv.declare_only_used_while_idle();
size_t num_tasks_running = 0;
// Post |kMaxTasks| BEST_EFFORT tasks that block until they all start running.
std::vector<scoped_refptr<PooledSequencedTaskRunner>> task_runners;
for (size_t i = 0; i < kMaxTasks; ++i) {
task_runners.push_back(MakeRefCounted<PooledSequencedTaskRunner>(
TaskTraits(TaskPriority::BEST_EFFORT),
&mock_pooled_task_runner_delegate_));
task_runners.back()->PostTask(
FROM_HERE, BindLambdaForTesting([&] {
// Increment the number of tasks running.
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
++num_tasks_running;
}
num_tasks_running_cv.Broadcast();
// Wait until all posted tasks are running.
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxTasks) {
num_tasks_running_cv.Wait();
}
}));
}
// Wait until |kMaxBestEffort| tasks start running.
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxBestEffortTasks) {
num_tasks_running_cv.Wait();
}
}
// Update the priority of all TaskRunners to USER_BLOCKING.
for (size_t i = 0; i < kMaxTasks; ++i) {
task_runners[i]->UpdatePriority(TaskPriority::USER_BLOCKING);
}
// Wait until all posted tasks start running. This should not block forever,
// even in a thread group that enforces a maximum number of concurrent
// BEST_EFFORT tasks lower than |kMaxTasks|.
static_assert(kMaxBestEffortTasks < kMaxTasks, "");
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxTasks) {
num_tasks_running_cv.Wait();
}
}
task_tracker_.FlushForTesting();
}
// Regression test for crbug.com/955953.
TEST_P(ThreadGroupTestAllExecutionModes, ScopedBlockingCallTwice) {
StartThreadGroup();
auto task_runner = test::CreatePooledTaskRunnerWithExecutionMode(
execution_mode(), &mock_pooled_task_runner_delegate_, {MayBlock()});
TestWaitableEvent task_ran;
task_runner->PostTask(FROM_HERE,
BindOnce(
[](TestWaitableEvent* task_ran) {
{
ScopedBlockingCall scoped_blocking_call(
FROM_HERE, BlockingType::MAY_BLOCK);
}
{
ScopedBlockingCall scoped_blocking_call(
FROM_HERE, BlockingType::MAY_BLOCK);
}
task_ran->Signal();
},
Unretained(&task_ran)));
task_ran.Wait();
}
#if BUILDFLAG(IS_WIN)
TEST_P(ThreadGroupTestAllExecutionModes, COMMTAWorkerEnvironment) {
StartThreadGroup(ThreadGroup::WorkerEnvironment::COM_MTA);
auto task_runner = test::CreatePooledTaskRunnerWithExecutionMode(
execution_mode(), &mock_pooled_task_runner_delegate_);
TestWaitableEvent task_ran;
task_runner->PostTask(
FROM_HERE, BindOnce(
[](TestWaitableEvent* task_ran) {
win::AssertComApartmentType(win::ComApartmentType::MTA);
task_ran->Signal();
},
Unretained(&task_ran)));
task_ran.Wait();
}
TEST_P(ThreadGroupTestAllExecutionModes, NoWorkerEnvironment) {
StartThreadGroup(ThreadGroup::WorkerEnvironment::NONE);
auto task_runner = test::CreatePooledTaskRunnerWithExecutionMode(
execution_mode(), &mock_pooled_task_runner_delegate_);
TestWaitableEvent task_ran;
task_runner->PostTask(
FROM_HERE, BindOnce(
[](TestWaitableEvent* task_ran) {
win::AssertComApartmentType(win::ComApartmentType::NONE);
task_ran->Signal();
},
Unretained(&task_ran)));
task_ran.Wait();
}
#endif
// Verifies that ShouldYield() returns false when there is no pending task.
TEST_F(ThreadGroupTest, ShouldYieldSingleTask) {
StartThreadGroup();
test::CreatePooledTaskRunner({TaskPriority::USER_BLOCKING},
&mock_pooled_task_runner_delegate_)
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
EXPECT_FALSE(thread_group_->ShouldYield(
{TaskPriority::BEST_EFFORT, TimeTicks::Now()}));
EXPECT_FALSE(thread_group_->ShouldYield(
{TaskPriority::USER_VISIBLE, TimeTicks::Now()}));
EXPECT_FALSE(thread_group_->ShouldYield(
{TaskPriority::USER_VISIBLE, TimeTicks::Now()}));
}));
task_tracker_.FlushForTesting();
}
// Verify that tasks from a JobTaskSource run at the intended concurrency.
TEST_F(ThreadGroupTest, ScheduleJobTaskSource) {
StartThreadGroup();
TestWaitableEvent threads_running;
TestWaitableEvent threads_continue;
RepeatingClosure threads_running_barrier = BarrierClosure(
kMaxTasks,
BindOnce(&TestWaitableEvent::Signal, Unretained(&threads_running)));
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting(
[&threads_running_barrier, &threads_continue](JobDelegate*) {
threads_running_barrier.Run();
threads_continue.Wait();
}),
/* num_tasks_to_run */ kMaxTasks);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
auto registered_task_source =
task_tracker_.RegisterTaskSource(std::move(task_source));
EXPECT_TRUE(registered_task_source);
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
std::move(registered_task_source)));
threads_running.Wait();
threads_continue.Signal();
// Flush the task tracker to be sure that no local variables are accessed by
// tasks after the end of the scope.
task_tracker_.FlushForTesting();
}
// Verify that tasks from a JobTaskSource run at the intended concurrency.
TEST_F(ThreadGroupTest, ScheduleJobTaskSourceMultipleTime) {
StartThreadGroup();
TestWaitableEvent thread_running;
TestWaitableEvent thread_continue;
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting([&thread_running, &thread_continue](JobDelegate*) {
DCHECK(!thread_running.IsSignaled());
thread_running.Signal();
thread_continue.Wait();
}),
/* num_tasks_to_run */ 1);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
task_tracker_.RegisterTaskSource(task_source)));
// Enqueuing the task source again shouldn't affect the number of time it's
// run.
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
task_tracker_.RegisterTaskSource(task_source)));
thread_running.Wait();
thread_continue.Signal();
// Once the worker task ran, enqueuing the task source has no effect.
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
task_tracker_.RegisterTaskSource(task_source)));
// Flush the task tracker to be sure that no local variables are accessed by
// tasks after the end of the scope.
task_tracker_.FlushForTesting();
}
// Verify that Cancel() on a job stops running the worker task and causes
// current workers to yield.
TEST_F(ThreadGroupTest, CancelJobTaskSource) {
StartThreadGroup();
CheckedLock tasks_running_lock;
ConditionVariable tasks_running_cv =
tasks_running_lock.CreateConditionVariable();
bool tasks_running = false;
// Schedule a big number of tasks.
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting([&](JobDelegate* delegate) {
{
CheckedAutoLock auto_lock(tasks_running_lock);
tasks_running = true;
}
tasks_running_cv.Signal();
while (!delegate->ShouldYield()) {
}
}),
/* num_tasks_to_run */ kTooManyTasks);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
mock_pooled_task_runner_delegate_.EnqueueJobTaskSource(task_source);
JobHandle job_handle = internal::JobTaskSource::CreateJobHandle(task_source);
// Wait for at least 1 task to start running.
{
CheckedAutoLock auto_lock(tasks_running_lock);
while (!tasks_running) {
tasks_running_cv.Wait();
}
}
// Cancels pending tasks and unblocks running ones.
job_handle.Cancel();
// This should not block since the job got cancelled.
task_tracker_.FlushForTesting();
}
// Verify that calling JobTaskSource::NotifyConcurrencyIncrease() (re-)schedule
// tasks with the intended concurrency.
TEST_F(ThreadGroupTest, JobTaskSourceConcurrencyIncrease) {
StartThreadGroup();
TestWaitableEvent threads_running_a;
TestWaitableEvent threads_continue;
// Initially schedule half the tasks.
RepeatingClosure threads_running_barrier = BarrierClosure(
kMaxTasks / 2,
BindOnce(&TestWaitableEvent::Signal, Unretained(&threads_running_a)));
auto job_state = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting(
[&threads_running_barrier, &threads_continue](JobDelegate*) {
threads_running_barrier.Run();
threads_continue.Wait();
}),
/* num_tasks_to_run */ kMaxTasks / 2);
auto task_source = job_state->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
auto registered_task_source = task_tracker_.RegisterTaskSource(task_source);
EXPECT_TRUE(registered_task_source);
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
std::move(registered_task_source)));
threads_running_a.Wait();
// Reset |threads_running_barrier| for the remaining tasks.
TestWaitableEvent threads_running_b;
threads_running_barrier = BarrierClosure(
kMaxTasks / 2,
BindOnce(&TestWaitableEvent::Signal, Unretained(&threads_running_b)));
job_state->SetNumTasksToRun(kMaxTasks);
// Unblocks tasks to let them racily wait for NotifyConcurrencyIncrease() to
// be called.
threads_continue.Signal();
task_source->NotifyConcurrencyIncrease();
// Wait for the remaining tasks. This should not block forever.
threads_running_b.Wait();
// Flush the task tracker to be sure that no local variables are accessed by
// tasks after the end of the scope.
task_tracker_.FlushForTesting();
}
// Verify that a JobTaskSource that becomes empty while in the queue eventually
// gets discarded.
TEST_F(ThreadGroupTest, ScheduleEmptyJobTaskSource) {
StartThreadGroup();
task_tracker_.SetCanRunPolicy(CanRunPolicy::kNone);
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindRepeating([](JobDelegate*) { ShouldNotRun(); }),
/* num_tasks_to_run */ 1);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
auto registered_task_source =
task_tracker_.RegisterTaskSource(std::move(task_source));
EXPECT_TRUE(registered_task_source);
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
std::move(registered_task_source)));
// The worker task will never run.
job_task->SetNumTasksToRun(0);
task_tracker_.SetCanRunPolicy(CanRunPolicy::kAll);
thread_group_->DidUpdateCanRunPolicy();
// This should not block since there's no task to run.
task_tracker_.FlushForTesting();
}
// Verify that Join() on a job contributes to max concurrency and waits for all
// workers to return.
TEST_F(ThreadGroupTest, JoinJobTaskSource) {
StartThreadGroup();
TestWaitableEvent threads_continue;
RepeatingClosure threads_continue_barrier = BarrierClosure(
kMaxTasks + 1,
BindOnce(&TestWaitableEvent::Signal, Unretained(&threads_continue)));
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting([&](JobDelegate*) {
threads_continue_barrier.Run();
threads_continue.Wait();
}),
/* num_tasks_to_run */ kMaxTasks + 1);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {}, &mock_pooled_task_runner_delegate_);
mock_pooled_task_runner_delegate_.EnqueueJobTaskSource(task_source);
JobHandle job_handle = internal::JobTaskSource::CreateJobHandle(task_source);
job_handle.Join();
// All worker tasks should complete before Join() returns.
EXPECT_EQ(0U, job_task->GetMaxConcurrency(0));
thread_group_->JoinForTesting();
EXPECT_EQ(1U, task_source->HasOneRef());
// Prevent TearDown() from calling JoinForTesting() again.
mock_pooled_task_runner_delegate_.SetThreadGroup(nullptr);
thread_group_ = nullptr;
}
// Verify that finishing work outside of a job unblocks workers with a stale
// max concurrency.
TEST_F(ThreadGroupTest, JoinJobTaskSourceStaleConcurrency) {
StartThreadGroup();
TestWaitableEvent thread_running;
std::atomic_size_t max_concurrency(1);
auto task_source = MakeRefCounted<JobTaskSource>(
FROM_HERE, TaskTraits{},
BindLambdaForTesting([&](JobDelegate*) { thread_running.Signal(); }),
BindLambdaForTesting(
[&](size_t /*worker_count*/) -> size_t { return max_concurrency; }),
&mock_pooled_task_runner_delegate_);
mock_pooled_task_runner_delegate_.EnqueueJobTaskSource(task_source);
JobHandle job_handle = internal::JobTaskSource::CreateJobHandle(task_source);
thread_running.Wait();
// Racily update max concurrency to unblock the task that was waiting on
// NotifyMaxConcurrency().
max_concurrency = 0;
job_handle.Join();
// This should not block since the job was joined.
task_tracker_.FlushForTesting();
}
// Verify that cancelling a job unblocks workers with a stale max concurrency.
TEST_F(ThreadGroupTest, CancelJobTaskSourceWithStaleConcurrency) {
StartThreadGroup();
TestWaitableEvent thread_running;
auto task_source = MakeRefCounted<JobTaskSource>(
FROM_HERE, TaskTraits{},
BindLambdaForTesting([&](JobDelegate*) { thread_running.Signal(); }),
BindRepeating([](size_t /*worker_count*/) -> size_t { return 1; }),
&mock_pooled_task_runner_delegate_);
mock_pooled_task_runner_delegate_.EnqueueJobTaskSource(task_source);
JobHandle job_handle = internal::JobTaskSource::CreateJobHandle(task_source);
thread_running.Wait();
job_handle.Cancel();
// This should not block since the job got cancelled.
task_tracker_.FlushForTesting();
}
// Verify that the maximum number of BEST_EFFORT tasks that can run concurrently
// in a thread group does not affect JobTaskSource with a priority that was
// increased from BEST_EFFORT to USER_BLOCKING.
TEST_F(ThreadGroupTest, JobTaskSourceUpdatePriority) {
StartThreadGroup();
CheckedLock num_tasks_running_lock;
ConditionVariable num_tasks_running_cv =
num_tasks_running_lock.CreateConditionVariable();
num_tasks_running_cv.declare_only_used_while_idle();
size_t num_tasks_running = 0;
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting([&](JobDelegate*) {
// Increment the number of tasks running.
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
++num_tasks_running;
}
num_tasks_running_cv.Broadcast();
// Wait until all posted tasks are running.
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxTasks) {
num_tasks_running_cv.Wait();
}
}),
/* num_tasks_to_run */ kMaxTasks);
scoped_refptr<JobTaskSource> task_source =
job_task->GetJobTaskSource(FROM_HERE, {TaskPriority::BEST_EFFORT},
&mock_pooled_task_runner_delegate_);
auto registered_task_source = task_tracker_.RegisterTaskSource(task_source);
EXPECT_TRUE(registered_task_source);
thread_group_->PushTaskSourceAndWakeUpWorkers(
RegisteredTaskSourceAndTransaction::FromTaskSource(
std::move(registered_task_source)));
// Wait until |kMaxBestEffort| tasks start running.
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxBestEffortTasks) {
num_tasks_running_cv.Wait();
}
}
// Update the priority to USER_BLOCKING.
auto transaction = task_source->BeginTransaction();
transaction.UpdatePriority(TaskPriority::USER_BLOCKING);
thread_group_->UpdateSortKey(std::move(transaction));
// Wait until all posted tasks start running. This should not block forever,
// even in a thread group that enforces a maximum number of concurrent
// BEST_EFFORT tasks lower than |kMaxTasks|.
static_assert(kMaxBestEffortTasks < kMaxTasks, "");
{
CheckedAutoLock auto_lock(num_tasks_running_lock);
while (num_tasks_running < kMaxTasks) {
num_tasks_running_cv.Wait();
}
}
// Flush the task tracker to be sure that no local variables are accessed by
// tasks after the end of the scope.
task_tracker_.FlushForTesting();
}
INSTANTIATE_TEST_SUITE_P(GenericParallel,
ThreadGroupTestAllExecutionModes,
::testing::Values(TaskSourceExecutionMode::kParallel));
INSTANTIATE_TEST_SUITE_P(
GenericSequenced,
ThreadGroupTestAllExecutionModes,
::testing::Values(TaskSourceExecutionMode::kSequenced));
INSTANTIATE_TEST_SUITE_P(GenericJob,
ThreadGroupTestAllExecutionModes,
::testing::Values(TaskSourceExecutionMode::kJob));
} // namespace base::internal
|