1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/threading/hang_watcher.h"
#include <atomic>
#include <memory>
#include <optional>
#include "base/barrier_closure.h"
#include "base/containers/fixed_flat_map.h"
#include "base/feature_list.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/metrics/field_trial_params.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/power_monitor_test.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/simple_test_tick_clock.h"
#include "base/test/task_environment.h"
#include "base/test/test_timeouts.h"
#include "base/threading/platform_thread.h"
#include "base/threading/thread_checker.h"
#include "base/threading/threading_features.h"
#include "base/time/tick_clock.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace {
using ::base::test::ScopedFeatureList;
using ::base::test::SingleThreadTaskEnvironment;
using ::base::test::TaskEnvironment;
using ::testing::ElementsAre;
using ::testing::IsEmpty;
using ::testing::Pair;
using ::testing::TestWithParam;
using ::testing::UnorderedElementsAre;
using ::testing::ValuesIn;
// Use this value to mark things very far off in the future. Adding this
// to TimeTicks::Now() gives a point that will never be reached during the
// normal execution of a test.
constexpr TimeDelta kVeryLongDelta{base::Days(365)};
// A relatively small time delta to ensure ordering of hung threads list.
constexpr TimeDelta kSmallCPUQuantum{base::Milliseconds(1)};
constexpr uint64_t kArbitraryDeadline = 0x0000C0FFEEC0FFEEu;
constexpr uint64_t kAllOnes = 0xFFFFFFFFFFFFFFFFu;
constexpr uint64_t kAllZeros = 0x0000000000000000u;
constexpr uint64_t kOnesThenZeroes = 0xAAAAAAAAAAAAAAAAu;
constexpr uint64_t kZeroesThenOnes = 0x5555555555555555u;
// Waits on provided WaitableEvent before executing and signals when done.
class BlockedThread : public DelegateSimpleThread::Delegate {
public:
BlockedThread(HangWatcher::ThreadType thread_type, TimeDelta timeout)
: thread_(this, "BlockedThread"),
thread_type_(thread_type),
timeout_(timeout) {
StartAndWaitForScopeEntered();
}
~BlockedThread() override {
Unblock();
thread_.Join();
}
void Run() override {
// Open a scope so that `unregister_closure` is destroyed before signaling
// `run_event_`.
{
// (Un)Register the thread here instead of in ctor/dtor so that the action
// happens on the right thread.
base::ScopedClosureRunner unregister_closure =
base::HangWatcher::RegisterThread(thread_type_);
WatchHangsInScope scope(timeout_);
wait_until_entered_scope_.Signal();
unblock_thread_.Wait();
}
run_event_.Signal();
}
bool IsDone() { return run_event_.IsSignaled(); }
void StartAndWaitForScopeEntered() {
thread_.Start();
// Block until this thread registered itself for hang watching and has
// entered a WatchHangsInScope.
wait_until_entered_scope_.Wait();
}
void Unblock() { unblock_thread_.Signal(); }
void WaitDone() { run_event_.Wait(); }
PlatformThreadId GetId() { return thread_.tid(); }
private:
base::DelegateSimpleThread thread_;
// Will be signaled once the thread is properly registered for watching and
// the WatchHangsInScope has been entered.
WaitableEvent wait_until_entered_scope_;
// Will be signaled once ThreadMain has run.
WaitableEvent run_event_;
// Used to unblock the monitored thread. Signaled from the test main thread.
base::WaitableEvent unblock_thread_;
const HangWatcher::ThreadType thread_type_;
const base::TimeDelta timeout_;
};
// Scope object starting a BlockedThread for all thread types monitored by the
// HangWatcher. Threads are started by the constructor and joined in the
// destructor.
class BlockedThreadsForAllTypes {
public:
explicit BlockedThreadsForAllTypes(base::TimeDelta timeout)
: main_(HangWatcher::ThreadType::kMainThread, timeout),
compositor_(HangWatcher::ThreadType::kCompositorThread, timeout),
io_(HangWatcher::ThreadType::kIOThread, timeout),
pool_(HangWatcher::ThreadType::kThreadPoolThread, timeout) {}
private:
BlockedThread main_;
BlockedThread compositor_;
BlockedThread io_;
BlockedThread pool_;
};
// A hang watcher that only does monitoring when requested via
// `TriggerSynchronousMonitoring` instead of periodically via a timer.
class ManualHangWatcher : public HangWatcher {
public:
explicit ManualHangWatcher(ProcessType process_type) {
HangWatcher::InitializeOnMainThread(process_type, /*emit_crashes=*/true);
SetAfterMonitorClosureForTesting(base::BindRepeating(
&WaitableEvent::Signal, base::Unretained(&monitor_event_)));
SetOnHangClosureForTesting(base::BindLambdaForTesting([this] {
hang_count_.fetch_add(1, std::memory_order_relaxed);
if (on_hang_closure_) {
on_hang_closure_.Run();
}
}));
// Disable periodic monitoring by setting a very very long monitoring
// period. Monitoring will be started manually by calling
// `TriggerSynchronousMonitoring()`.
SetMonitoringPeriodForTesting(base::Days(365));
// Start the monitoring loop.
Start();
}
~ManualHangWatcher() override { UninitializeOnMainThreadForTesting(); }
void SetOnHangClosure(base::RepeatingClosure closure) {
on_hang_closure_ = std::move(closure);
}
// Signal the `HangWatcher` to start a monitoring and wait for that monitoring
// to be done.
void TriggerSynchronousMonitoring() {
monitor_event_.Reset();
SignalMonitorEventForTesting();
monitor_event_.Wait();
}
int GetHangCount() const {
return hang_count_.load(std::memory_order_relaxed);
}
private:
// Used to wait for monitoring. Will be signaled by the HangWatcher thread and
// so needs to outlive it.
WaitableEvent monitor_event_;
// Count the number of time the HangWatcher thread detected a hang.
std::atomic<int> hang_count_ = 0;
// If specified by a test, this closure is invoked when a hang is detected.
RepeatingClosure on_hang_closure_;
};
class HangWatcherTest : public testing::Test {
protected:
base::test::ScopedFeatureList feature_list_{base::kEnableHangWatcher};
// Used exclusively for MOCK_TIME. No tasks will be run on the environment.
// Single threaded to avoid ThreadPool WorkerThreads registering.
test::SingleThreadTaskEnvironment task_environment_{
test::TaskEnvironment::TimeSource::MOCK_TIME};
};
TEST_F(HangWatcherTest, InvalidatingExpectationsPreventsCapture) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// Create a hang.
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// de-activate hang watching,
base::HangWatcher::InvalidateActiveExpectations();
// Trigger a monitoring on HangWatcher thread and verify results.
// Hang is not detected.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 0);
}
TEST_F(HangWatcherTest, MultipleInvalidateExpectationsDoNotCancelOut) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// Create a hang.
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// de-activate hang watching,
base::HangWatcher::InvalidateActiveExpectations();
// Redundantly de-activate hang watching.
base::HangWatcher::InvalidateActiveExpectations();
// Trigger a monitoring on HangWatcher thread and verify results.
// Hang is not detected.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 0);
}
// TODO(crbug.com/385732561): Test is flaky.
TEST_F(HangWatcherTest,
DISABLED_NewInnerWatchHangsInScopeAfterInvalidationDetectsHang) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// De-activate hang watching.
base::HangWatcher::InvalidateActiveExpectations();
{
WatchHangsInScope also_expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// Trigger a monitoring on HangWatcher thread and verify results.
hang_watcher.TriggerSynchronousMonitoring();
// Hang is detected since the new WatchHangsInScope temporarily
// re-activated hang_watching.
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
// Trigger a monitoring on HangWatcher thread and verify results.
hang_watcher.TriggerSynchronousMonitoring();
// No new hang is detected since execution is back to being covered by
// |expires_instantly| for which expectations were invalidated.
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
TEST_F(HangWatcherTest,
NewSeparateWatchHangsInScopeAfterInvalidationDetectsHang) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
{
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// De-activate hang watching.
base::HangWatcher::InvalidateActiveExpectations();
}
WatchHangsInScope also_expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// Trigger a monitoring on HangWatcher thread and verify results.
hang_watcher.TriggerSynchronousMonitoring();
// Hang is detected since the new WatchHangsInScope did not have its
// expectations invalidated.
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
// Test that invalidating expectations from inner WatchHangsInScope will also
// prevent hang detection in outer scopes.
TEST_F(HangWatcherTest, ScopeDisabledObjectInnerScope) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// Start a WatchHangsInScope that expires right away. Then advance
// time to make sure no hang is detected.
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
{
WatchHangsInScope also_expires_instantly(base::TimeDelta{});
// De-activate hang watching.
base::HangWatcher::InvalidateActiveExpectations();
task_environment_.FastForwardBy(base::Seconds(1));
}
// Trigger a monitoring on HangWatcher thread and verify results.
hang_watcher.TriggerSynchronousMonitoring();
// Hang is ignored since it concerns a scope for which one of the inner scope
// was ignored.
EXPECT_EQ(hang_watcher.GetHangCount(), 0);
}
TEST_F(HangWatcherTest, NewScopeAfterDisabling) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// Start a WatchHangsInScope that expires right away. Then advance
// time to make sure no hang is detected.
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
{
WatchHangsInScope also_expires_instantly(base::TimeDelta{});
// De-activate hang watching.
base::HangWatcher::InvalidateActiveExpectations();
task_environment_.FastForwardBy(base::Seconds(1));
}
// New scope for which expectations are never invalidated.
WatchHangsInScope also_expires_instantly(base::TimeDelta{});
task_environment_.FastForwardBy(base::Seconds(1));
// Trigger a monitoring on HangWatcher thread and verify results.
hang_watcher.TriggerSynchronousMonitoring();
// Hang is detected because it's unrelated to the hangs that were disabled.
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
TEST_F(HangWatcherTest, NestedScopes) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Create a state object for the test thread since this test is single
// threaded.
auto current_hang_watch_state =
base::internal::HangWatchState::CreateHangWatchStateForCurrentThread(
HangWatcher::ThreadType::kMainThread);
ASSERT_FALSE(current_hang_watch_state->IsOverDeadline());
base::TimeTicks original_deadline = current_hang_watch_state->GetDeadline();
constexpr base::TimeDelta kFirstTimeout(base::Milliseconds(500));
base::TimeTicks first_deadline = base::TimeTicks::Now() + kFirstTimeout;
constexpr base::TimeDelta kSecondTimeout(base::Milliseconds(250));
base::TimeTicks second_deadline = base::TimeTicks::Now() + kSecondTimeout;
// At this point we have not set any timeouts.
{
// Create a first timeout which is more restrictive than the default.
WatchHangsInScope first_scope(kFirstTimeout);
// We are on mock time. There is no time advancement and as such no hangs.
EXPECT_FALSE(current_hang_watch_state->IsOverDeadline());
EXPECT_EQ(current_hang_watch_state->GetDeadline(), first_deadline);
{
// Set a yet more restrictive deadline. Still no hang.
WatchHangsInScope second_scope(kSecondTimeout);
EXPECT_FALSE(current_hang_watch_state->IsOverDeadline());
EXPECT_EQ(current_hang_watch_state->GetDeadline(), second_deadline);
}
// First deadline we set should be restored.
EXPECT_FALSE(current_hang_watch_state->IsOverDeadline());
EXPECT_EQ(current_hang_watch_state->GetDeadline(), first_deadline);
}
// Original deadline should now be restored.
EXPECT_FALSE(current_hang_watch_state->IsOverDeadline());
EXPECT_EQ(current_hang_watch_state->GetDeadline(), original_deadline);
}
// Checks that histograms are recorded on the right threads for the browser
// process.
TEST_F(HangWatcherTest, HistogramsLoggedOnBrowserProcessHang) {
base::HistogramTester histogram_tester;
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start blocked threads for all thread types and simulate hangs.
BlockedThreadsForAllTypes threads(/*timeout=*/base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// Check that histograms are only recorded for the expected threads.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix(
"HangWatcher.IsThreadHung.BrowserProcess"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.BrowserProcess.UIThread.Normal",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.BrowserProcess.IOThread.Normal",
BucketsAre(Bucket(true, /*count=*/1)))));
}
struct AnyCriticalTestParam {
std::string test_name;
HangWatcher::ProcessType process_type;
HangWatcher::ThreadType thread_type;
bool is_critical;
};
// Spot check critical and non-critical process and thread types. We can't do a
// full cross product because some processes types don't support some thread
// types.
using HangWatcherAnyCriticalThreadTests = TestWithParam<AnyCriticalTestParam>;
INSTANTIATE_TEST_SUITE_P(
CriticalProcessAndThreadSpotChecks,
HangWatcherAnyCriticalThreadTests,
ValuesIn<AnyCriticalTestParam>({
// Test at least one critical thread per process types:
{.test_name = "BrowserProcessIsCritical",
.process_type = HangWatcher::ProcessType::kBrowserProcess,
.thread_type = HangWatcher::ThreadType::kMainThread,
.is_critical = true},
{.test_name = "RendererProcessIsCritical",
.process_type = HangWatcher::ProcessType::kRendererProcess,
.thread_type = HangWatcher::ThreadType::kMainThread,
.is_critical = true},
{.test_name = "UtilityProcessIsCritical",
.process_type = HangWatcher::ProcessType::kUtilityProcess,
.thread_type = HangWatcher::ThreadType::kMainThread,
.is_critical = true},
// Test each critical thread types for one process type:
{.test_name = "MainThreadIsCritical",
.process_type = HangWatcher::ProcessType::kBrowserProcess,
.thread_type = HangWatcher::ThreadType::kMainThread,
.is_critical = true},
{.test_name = "IOThreadIsCritical",
.process_type = HangWatcher::ProcessType::kBrowserProcess,
.thread_type = HangWatcher::ThreadType::kIOThread,
.is_critical = true},
{.test_name = "CompositorThreadIsCritical",
.process_type = HangWatcher::ProcessType::kRendererProcess,
.thread_type = HangWatcher::ThreadType::kCompositorThread,
.is_critical = true},
// Test non critical threads:
{.test_name = "ThreadPoolIsNotCritical",
.process_type = HangWatcher::ProcessType::kBrowserProcess,
.thread_type = HangWatcher::ThreadType::kThreadPoolThread,
.is_critical = false},
}),
[](const auto& info) { return info.param.test_name; });
// Checks that Any and AnyCritical are correctly recorded for different process
// and thread types.
TEST_P(HangWatcherAnyCriticalThreadTests, AnyCriticalThreadHung) {
ScopedFeatureList feature_list_(kEnableHangWatcher);
SingleThreadTaskEnvironment task_env(TaskEnvironment::TimeSource::MOCK_TIME);
base::HistogramTester histogram_tester;
ManualHangWatcher hang_watcher(GetParam().process_type);
// Start a blocked thread and simulate a hang.
BlockedThread thread(GetParam().thread_type, base::Seconds(10));
task_env.FastForwardBy(base::Seconds(11));
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix("HangWatcher.IsThreadHung.Any"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.Any",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.AnyCritical",
BucketsAre(Bucket(GetParam().is_critical, /*count=*/1)))));
}
// Checks that only a single Any/AnyCritical histogram is recorded even if
// multiple threads hang.
TEST_F(HangWatcherTest, AnyRecordedOnlyOnceEvenIfMultipleThreadsHang) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
base::HistogramTester histogram_tester;
// Start and hang multiple threads.
BlockedThread main(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
BlockedThread io(HangWatcher::ThreadType::kIOThread, base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// A single Any/AnyCritical should be recorded, even if multiple threads hung.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix("HangWatcher.IsThreadHung.Any"),
UnorderedElementsAre(Pair("HangWatcher.IsThreadHung.Any",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.AnyCritical",
BucketsAre(Bucket(true, /*count=*/1)))));
}
// Checks that histograms with `false` buckets are recorded if there's no hang.
TEST_F(HangWatcherTest, HistogramsLoggedWithoutHangs) {
base::HistogramTester histogram_tester;
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start a blocked thread with a 10 seconds hang limit, but don't fastforward
// time.
BlockedThread thread(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
// No hang to catch so nothing is recorded.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 0);
// A thread of type ThreadForTesting was monitored but didn't hang. This is
// logged.
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix("HangWatcher.IsThreadHung"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.BrowserProcess.UIThread.Normal",
BucketsAre(Bucket(false, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.Any",
BucketsAre(Bucket(false, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.AnyCritical",
BucketsAre(Bucket(false, /*count=*/1)))));
}
// Histograms should be recorded on each monitoring.
TEST_F(HangWatcherTest, HistogramsLoggedOnEachHang) {
base::HistogramTester histogram_tester;
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start a blocked thread and simulate a hang.
BlockedThread thread(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// First monitoring catches the hang and emits the histogram.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix("HangWatcher.IsThreadHung"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.BrowserProcess.UIThread.Normal",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.Any",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.AnyCritical",
BucketsAre(Bucket(true, /*count=*/1)))));
// Hang is logged again even if it would not trigger a crash dump.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix("HangWatcher.IsThreadHung"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.BrowserProcess.UIThread.Normal",
BucketsAre(Bucket(true, /*count=*/2))),
Pair("HangWatcher.IsThreadHung.Any",
BucketsAre(Bucket(true, /*count=*/2))),
Pair("HangWatcher.IsThreadHung.AnyCritical",
BucketsAre(Bucket(true, /*count=*/2)))));
}
// Checks that the browser process emits Shutdown histograms on shutdown.
TEST_F(HangWatcherTest, HistogramsLoggedWithShutdownFlag) {
base::HistogramTester histogram_tester;
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start blocked threads for all thread types and simulate hangs.
BlockedThreadsForAllTypes threads(/*timeout=*/base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// Make this process emit *.Shutdown instead of *.Normal histograms.
base::HangWatcher::SetShuttingDown();
// Check that histograms are only recorded for the expected threads.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_THAT(
histogram_tester.GetAllSamplesForPrefix(
"HangWatcher.IsThreadHung.BrowserProcess"),
UnorderedElementsAre(
Pair("HangWatcher.IsThreadHung.BrowserProcess.UIThread.Shutdown",
BucketsAre(Bucket(true, /*count=*/1))),
Pair("HangWatcher.IsThreadHung.BrowserProcess.IOThread.Shutdown",
BucketsAre(Bucket(true, /*count=*/1)))));
}
TEST_F(HangWatcherTest, Hang) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start a blocked thread and simulate a hang.
BlockedThread thread(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// First monitoring catches and records the hang.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
TEST_F(HangWatcherTest, HangAlreadyRecorded) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start a blocked thread and simulate a hang.
BlockedThread thread(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
task_environment_.FastForwardBy(base::Seconds(11));
// First monitoring catches and records the hang.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
// Attempt capture again. Second monitoring does not record a new hang because
// a hang that was already recorded is still live.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 1);
}
TEST_F(HangWatcherTest, NoHang) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Start a blocked thread with a 10 seconds hang limit, but don't fastforward
// time.
BlockedThread thread(HangWatcher::ThreadType::kMainThread, base::Seconds(10));
// No hang to catch so nothing is recorded.
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(hang_watcher.GetHangCount(), 0);
}
class HangWatcherSnapshotTest : public testing::Test {
protected:
// Verify that a capture takes place and that at the time of the capture the
// list of hung thread ids is correct.
void TestIDList(ManualHangWatcher& hang_watcher, const std::string& id_list) {
list_of_hung_thread_ids_during_capture_ = id_list;
task_environment_.AdvanceClock(kSmallCPUQuantum);
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(++reference_capture_count_, hang_watcher.GetHangCount());
}
// Verify that even if hang monitoring takes place no hangs are detected.
void ExpectNoCapture(ManualHangWatcher& hang_watcher) {
int old_capture_count = hang_watcher.GetHangCount();
task_environment_.AdvanceClock(kSmallCPUQuantum);
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(old_capture_count, hang_watcher.GetHangCount());
}
std::string ConcatenateThreadIds(
const std::vector<base::PlatformThreadId>& ids) const {
std::string result;
constexpr char kSeparator{'|'};
for (PlatformThreadId id : ids) {
result += base::NumberToString(id.raw()) + kSeparator;
}
return result;
}
const PlatformThreadId test_thread_id_ = PlatformThread::CurrentId();
// This is written to by the test main thread and read from the hang watching
// thread. It does not need to be protected because access to it is
// synchronized by always setting before triggering the execution of the
// reading code through HangWatcher::SignalMonitorEventForTesting().
std::string list_of_hung_thread_ids_during_capture_;
// Increases at the same time as |hang_capture_count_| to test that capture
// actually took place.
int reference_capture_count_ = 0;
base::test::ScopedFeatureList feature_list_{base::kEnableHangWatcher};
// Used exclusively for MOCK_TIME.
test::SingleThreadTaskEnvironment task_environment_{
test::TaskEnvironment::TimeSource::MOCK_TIME};
};
// Verify that the hang capture fails when marking a thread for blocking fails.
// This simulates a WatchHangsInScope completing between the time the hang
// was detected and the time it is recorded which would create a non-actionable
// report.
TEST_F(HangWatcherSnapshotTest, NonActionableReport) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
{
// Start a WatchHangsInScope that expires right away. Ensures that
// the first monitor will detect a hang.
WatchHangsInScope expires_instantly(base::TimeDelta{});
internal::HangWatchState* current_hang_watch_state =
internal::HangWatchState::GetHangWatchStateForCurrentThread();
// Simulate the deadline changing concurrently during the capture. This
// makes the capture fail since marking of the deadline fails.
ASSERT_NE(current_hang_watch_state->GetDeadline(),
base::TimeTicks::FromInternalValue(kArbitraryDeadline));
current_hang_watch_state->GetHangWatchDeadlineForTesting()
->SetSwitchBitsClosureForTesting(
base::BindLambdaForTesting([] { return kArbitraryDeadline; }));
ExpectNoCapture(hang_watcher);
// Marking failed.
EXPECT_FALSE(current_hang_watch_state->IsFlagSet(
internal::HangWatchDeadline::Flag::kShouldBlockOnHang));
current_hang_watch_state->GetHangWatchDeadlineForTesting()
->ResetSwitchBitsClosureForTesting();
}
}
TEST_F(HangWatcherSnapshotTest, HungThreadIDs) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// During hang capture the list of hung threads should be populated.
// When hang capture is over the list should be empty.
hang_watcher.SetOnHangClosure(base::BindLambdaForTesting([&] {
EXPECT_EQ(hang_watcher.GetHungThreadListCrashKeyForTesting(),
list_of_hung_thread_ids_during_capture_);
}));
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
BlockedThread blocked_thread(HangWatcher::ThreadType::kMainThread,
/*timeout=*/base::TimeDelta{});
{
// Ensure the blocking thread entered the scope before the main thread. This
// will guarantee an ordering while reporting the list of hung threads.
task_environment_.AdvanceClock(kSmallCPUQuantum);
// Start a WatchHangsInScope that expires right away. Ensures that
// the first monitor will detect a hang. This scope will naturally have a
// later deadline than the one in |blocked_thread_| since it was created
// after.
WatchHangsInScope expires_instantly(base::TimeDelta{});
// Hung thread list should contain the id the blocking thread and then the
// id of the test main thread since that is the order of increasing
// deadline.
TestIDList(hang_watcher,
ConcatenateThreadIds({blocked_thread.GetId(), test_thread_id_}));
// |expires_instantly| and the scope from |blocked_thread| are still live
// but already recorded so should be ignored.
ExpectNoCapture(hang_watcher);
// Unblock and join the thread to close the scope in |blocked_thread|.
blocked_thread.Unblock();
blocked_thread.WaitDone();
// |expires_instantly| is still live but already recorded so should be
// ignored.
ExpectNoCapture(hang_watcher);
}
// All HangWatchScopeEnables are over. There should be no capture.
ExpectNoCapture(hang_watcher);
// Once all recorded scopes are over creating a new one and monitoring will
// trigger a hang detection.
WatchHangsInScope expires_instantly(base::TimeDelta{});
TestIDList(hang_watcher, ConcatenateThreadIds({test_thread_id_}));
}
TEST_F(HangWatcherSnapshotTest, TimeSinceLastSystemPowerResumeCrashKey) {
ManualHangWatcher hang_watcher(HangWatcher::ProcessType::kBrowserProcess);
// Override the capture of hangs. Simulate a crash key capture.
std::string seconds_since_last_power_resume_crash_key;
hang_watcher.SetOnHangClosure(base::BindLambdaForTesting([&] {
seconds_since_last_power_resume_crash_key =
hang_watcher.GetTimeSinceLastSystemPowerResumeCrashKeyValue();
}));
// Register the main test thread for hang watching.
auto unregister_thread_closure =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
{
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.AdvanceClock(kSmallCPUQuantum);
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(1, hang_watcher.GetHangCount());
EXPECT_EQ("Never suspended", seconds_since_last_power_resume_crash_key);
}
{
test::ScopedPowerMonitorTestSource power_monitor_source;
power_monitor_source.Suspend();
task_environment_.AdvanceClock(kSmallCPUQuantum);
{
WatchHangsInScope expires_instantly(base::TimeDelta{});
task_environment_.AdvanceClock(kSmallCPUQuantum);
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(2, hang_watcher.GetHangCount());
EXPECT_EQ("Power suspended", seconds_since_last_power_resume_crash_key);
}
power_monitor_source.Resume();
constexpr TimeDelta kAfterResumeTime{base::Seconds(5)};
task_environment_.AdvanceClock(kAfterResumeTime);
{
WatchHangsInScope expires_instantly(base::TimeDelta{});
hang_watcher.TriggerSynchronousMonitoring();
EXPECT_EQ(3, hang_watcher.GetHangCount());
EXPECT_EQ(base::NumberToString(kAfterResumeTime.InSeconds()),
seconds_since_last_power_resume_crash_key);
}
}
}
// Determines how long the HangWatcher will wait between calls to
// Monitor(). Choose a low value so that that successive invocations happens
// fast. This makes tests that wait for monitoring run fast and makes tests that
// expect no monitoring fail fast.
const base::TimeDelta kMonitoringPeriod = base::Milliseconds(1);
// Test if and how often the HangWatcher periodically monitors for hangs.
class HangWatcherPeriodicMonitoringTest : public testing::Test {
public:
HangWatcherPeriodicMonitoringTest() {
hang_watcher_.InitializeOnMainThread(
HangWatcher::ProcessType::kBrowserProcess, /*emit_crashes=*/true);
hang_watcher_.SetMonitoringPeriodForTesting(kMonitoringPeriod);
hang_watcher_.SetOnHangClosureForTesting(base::BindRepeating(
&WaitableEvent::Signal, base::Unretained(&hang_event_)));
// HangWatcher uses a TickClock to detect how long it slept in between calls
// to Monitor(). Override that clock to control its subjective passage of
// time.
hang_watcher_.SetTickClockForTesting(&test_clock_);
}
void TearDown() override {
hang_watcher_.UninitializeOnMainThreadForTesting();
}
protected:
// Setup the callback invoked after waiting in HangWatcher to advance the
// tick clock by the desired time delta.
void InstallAfterWaitCallback(base::TimeDelta time_delta) {
hang_watcher_.SetAfterWaitCallbackForTesting(base::BindLambdaForTesting(
[this, time_delta](base::TimeTicks time_before_wait) {
test_clock_.Advance(time_delta);
}));
}
base::SimpleTestTickClock test_clock_;
// Single threaded to avoid ThreadPool WorkerThreads registering. Will run
// delayed tasks created by the tests.
test::SingleThreadTaskEnvironment task_environment_;
HangWatcher hang_watcher_;
// Signaled when a hang is detected.
WaitableEvent hang_event_;
base::ScopedClosureRunner unregister_thread_closure_;
};
// Don't register any threads for hang watching. HangWatcher should not monitor.
TEST_F(HangWatcherPeriodicMonitoringTest,
NoPeriodicMonitoringWithoutRegisteredThreads) {
RunLoop run_loop;
// If a call to HangWatcher::Monitor() takes place the test will instantly
// fail.
hang_watcher_.SetAfterMonitorClosureForTesting(
base::BindLambdaForTesting([&run_loop] {
ADD_FAILURE() << "Monitoring took place!";
run_loop.Quit();
}));
// Make the HangWatcher tick clock advance by exactly the monitoring period
// after waiting so it will never detect oversleeping between attempts to call
// Monitor(). This would inhibit monitoring and make the test pass for the
// wrong reasons.
InstallAfterWaitCallback(kMonitoringPeriod);
hang_watcher_.Start();
// Unblock the test thread. No thread ever registered after the HangWatcher
// was created in the test's constructor. No monitoring should have taken
// place.
task_environment_.GetMainThreadTaskRunner()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(), TestTimeouts::tiny_timeout());
run_loop.Run();
// NOTE:
// A lack of calls could technically also be caused by the HangWatcher thread
// executing too slowly / being descheduled. This is a known limitation.
// It's expected for |TestTimeouts::tiny_timeout()| to be large enough that
// this is rare.
}
// During normal execution periodic monitoring should take place.
TEST_F(HangWatcherPeriodicMonitoringTest, PeriodicCallsTakePlace) {
// HangWatcher::Monitor() will run once right away on thread registration.
// We want to make sure it runs at a couple more times from being scheduled.
constexpr int kMinimumMonitorCount = 3;
RunLoop run_loop;
// Setup the HangWatcher to unblock run_loop when the Monitor() has been
// invoked enough times.
hang_watcher_.SetAfterMonitorClosureForTesting(BarrierClosure(
kMinimumMonitorCount, base::BindLambdaForTesting([&run_loop] {
// This should only run if there are threads to watch.
EXPECT_TRUE(base::FeatureList::IsEnabled(kEnableHangWatcher));
// Test condition are confirmed, stop monitoring.
HangWatcher::StopMonitoringForTesting();
// Unblock the test main thread.
run_loop.Quit();
})));
// Make the HangWatcher tick clock advance by exactly the monitoring period
// after waiting so it will never detect oversleeping between attempts to call
// Monitor(). This would inhibit monitoring.
InstallAfterWaitCallback(kMonitoringPeriod);
hang_watcher_.Start();
// Register a thread,
unregister_thread_closure_ =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// The "after monitor" closure only runs if there are threads to watch.
if (base::FeatureList::IsEnabled(kEnableHangWatcher)) {
run_loop.Run();
}
// No monitored scope means no possible hangs.
EXPECT_FALSE(hang_event_.IsSignaled());
}
// If the HangWatcher detects it slept for longer than expected it will not
// monitor.
TEST_F(HangWatcherPeriodicMonitoringTest, NoMonitorOnOverSleep) {
RunLoop run_loop;
// If a call to HangWatcher::Monitor() takes place the test will instantly
// fail.
hang_watcher_.SetAfterMonitorClosureForTesting(
base::BindLambdaForTesting([&run_loop] {
ADD_FAILURE() << "Monitoring took place!";
run_loop.Quit();
}));
// Make the HangWatcher tick clock advance so much after waiting that it will
// detect oversleeping every time. This will keep it from monitoring.
InstallAfterWaitCallback(base::Minutes(1));
hang_watcher_.Start();
// Register a thread.
unregister_thread_closure_ =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
// Unblock the test thread. All waits were perceived as oversleeping so all
// monitoring was inhibited.
task_environment_.GetMainThreadTaskRunner()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(), TestTimeouts::tiny_timeout());
run_loop.Run();
// NOTE: A lack of calls could technically also be caused by the HangWatcher
// thread executing too slowly / being descheduled. This is a known
// limitation. It's expected for |TestTimeouts::tiny_timeout()| to be large
// enough that this happens rarely.
}
class WatchHangsInScopeBlockingTest : public testing::Test {
public:
WatchHangsInScopeBlockingTest() {
HangWatcher::InitializeOnMainThread(
HangWatcher::ProcessType::kBrowserProcess, /*emit_crashes=*/true);
hang_watcher_.SetOnHangClosureForTesting(base::BindLambdaForTesting([&] {
capture_started_.Signal();
// Simulate capturing that takes a long time.
PlatformThread::Sleep(base::Milliseconds(500));
continue_capture_.Wait();
completed_capture_ = true;
}));
hang_watcher_.SetAfterMonitorClosureForTesting(
base::BindLambdaForTesting([&] {
// Simulate monitoring that takes a long time.
PlatformThread::Sleep(base::Milliseconds(500));
completed_monitoring_.Signal();
}));
// Make sure no periodic monitoring takes place.
hang_watcher_.SetMonitoringPeriodForTesting(kVeryLongDelta);
hang_watcher_.Start();
// Register the test main thread for hang watching.
unregister_thread_closure_ =
HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kMainThread);
}
void TearDown() override {
HangWatcher::UninitializeOnMainThreadForTesting();
}
void VerifyScopesDontBlock() {
// Start a WatchHangsInScope that cannot possibly cause a hang to be
// detected.
{
WatchHangsInScope long_scope(kVeryLongDelta);
// Manually trigger a monitoring.
hang_watcher_.SignalMonitorEventForTesting();
// Execution has to continue freely here as no capture is in progress.
}
// Monitoring should not be over yet because the test code should execute
// faster when not blocked.
EXPECT_FALSE(completed_monitoring_.IsSignaled());
// Wait for the full monitoring process to be complete. This is to prove
// that monitoring truly executed and that we raced the signaling.
completed_monitoring_.Wait();
// No hang means no capture.
EXPECT_FALSE(completed_capture_);
}
protected:
base::WaitableEvent capture_started_;
base::WaitableEvent completed_monitoring_;
// The HangWatcher waits on this event via the "on hang" closure when a hang
// is detected.
base::WaitableEvent continue_capture_;
bool completed_capture_{false};
base::test::ScopedFeatureList feature_list_{base::kEnableHangWatcher};
HangWatcher hang_watcher_;
base::ScopedClosureRunner unregister_thread_closure_;
};
// Tests that execution is unimpeded by ~WatchHangsInScope() when no capture
// ever takes place.
TEST_F(WatchHangsInScopeBlockingTest, ScopeDoesNotBlocksWithoutCapture) {
// No capture should take place so |continue_capture_| is not signaled to
// create a test hang if one ever does.
VerifyScopesDontBlock();
}
// Test that execution blocks in ~WatchHangsInScope() for a thread under
// watch during the capturing of a hang.
TEST_F(WatchHangsInScopeBlockingTest, ScopeBlocksDuringCapture) {
// The capture completing is not dependent on any test event. Signal to make
// sure the test is not blocked.
continue_capture_.Signal();
// Start a WatchHangsInScope that expires in the past already. Ensures
// that the first monitor will detect a hang.
{
// Start a WatchHangsInScope that expires right away. Ensures that the
// first monitor will detect a hang.
WatchHangsInScope expires_right_away(base::TimeDelta{});
// Manually trigger a monitoring.
hang_watcher_.SignalMonitorEventForTesting();
// Ensure that the hang capturing started.
capture_started_.Wait();
// Execution will get stuck in the outer scope because it can't escape
// ~WatchHangsInScope() if a hang capture is under way.
}
// A hang was in progress so execution should have been blocked in
// BlockWhileCaptureInProgress() until capture finishes.
EXPECT_TRUE(completed_capture_);
completed_monitoring_.Wait();
// Reset expectations
completed_monitoring_.Reset();
capture_started_.Reset();
completed_capture_ = false;
// Verify that scopes don't block just because a capture happened in the past.
VerifyScopesDontBlock();
}
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM64)
// Flaky hangs on arm64 Macs: https://crbug.com/1140207
#define MAYBE_NewScopeDoesNotBlockDuringCapture \
DISABLED_NewScopeDoesNotBlockDuringCapture
#else
#define MAYBE_NewScopeDoesNotBlockDuringCapture \
NewScopeDoesNotBlockDuringCapture
#endif
// Test that execution does not block in ~WatchHangsInScope() when the scope
// was created after the start of a capture.
TEST_F(WatchHangsInScopeBlockingTest, MAYBE_NewScopeDoesNotBlockDuringCapture) {
// Start a WatchHangsInScope that expires right away. Ensures that the
// first monitor will detect a hang.
WatchHangsInScope expires_right_away(base::TimeDelta{});
// Manually trigger a monitoring.
hang_watcher_.SignalMonitorEventForTesting();
// Ensure that the hang capturing started.
capture_started_.Wait();
// A scope started once a capture is already under way should not block
// execution.
{ WatchHangsInScope also_expires_right_away(base::TimeDelta{}); }
// Wait for the new WatchHangsInScope to be destroyed to let the capture
// finish. If the new scope block waiting for the capture to finish this would
// create a deadlock and the test would hang.
continue_capture_.Signal();
}
} // namespace
namespace internal {
namespace {
// Matcher validating that the specified `HangWatchDeadline` has no flag set.
MATCHER(HasNoFlagSet, /*description=*/"") {
static constexpr auto kAllFlags =
base::MakeFixedFlatMap<HangWatchDeadline::Flag, std::string_view>({
{HangWatchDeadline::Flag::kMinValue, "kMinValue"},
{HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope,
"kIgnoreCurrentWatchHangsInScope"},
{HangWatchDeadline::Flag::kShouldBlockOnHang, "kShouldBlockOnHang"},
});
for (const auto& [flag, description] : kAllFlags) {
if (arg.IsFlagSet(flag)) {
*result_listener << "where flag " << description << " is set";
return false;
}
}
return true;
}
class HangWatchDeadlineTest : public testing::Test {
protected:
// Return a flag mask without one of the flags for test purposes. Use to
// ignore that effect of setting a flag that was just set.
uint64_t FlagsMinus(uint64_t flags, HangWatchDeadline::Flag flag) {
return flags & ~(static_cast<uint64_t>(flag));
}
HangWatchDeadline deadline_;
};
} // namespace
// Verify that the extract functions don't mangle any bits.
TEST_F(HangWatchDeadlineTest, BitsPreservedThroughExtract) {
for (auto bits : {kAllOnes, kAllZeros, kOnesThenZeroes, kZeroesThenOnes}) {
EXPECT_TRUE((HangWatchDeadline::ExtractFlags(bits) |
HangWatchDeadline::ExtractDeadline(bits)) == bits);
}
}
namespace {
// Verify that setting and clearing a persistent flag works and has no unwanted
// side-effects. Neither the flags nor the deadline change concurrently in this
// test.
TEST_F(HangWatchDeadlineTest, SetAndClearPersistentFlag) {
ASSERT_THAT(deadline_, HasNoFlagSet());
// Grab the original values for flags and deadline.
auto [old_flags, old_deadline] = deadline_.GetFlagsAndDeadline();
// Set the flag. Operation cannot fail.
deadline_.SetIgnoreCurrentWatchHangsInScope();
// Get new flags and deadline.
auto [new_flags, new_deadline] = deadline_.GetFlagsAndDeadline();
// Flag was set properly.
EXPECT_TRUE(HangWatchDeadline::IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope, new_flags));
// No side-effect on deadline.
EXPECT_EQ(new_deadline, old_deadline);
// No side-effect on other flags.
EXPECT_EQ(
FlagsMinus(new_flags,
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope),
old_flags);
// Clear the flag, operation cannot fail.
deadline_.UnsetIgnoreCurrentWatchHangsInScope();
// Update new values.
std::tie(new_flags, new_deadline) = deadline_.GetFlagsAndDeadline();
// All flags back to original state.
EXPECT_EQ(new_flags, old_flags);
// Deadline still unaffected.
EXPECT_EQ(new_deadline, old_deadline);
}
// Verify setting the TimeTicks value works and has no unwanted side-effects.
TEST_F(HangWatchDeadlineTest, SetDeadline) {
TimeTicks ticks;
ASSERT_THAT(deadline_, HasNoFlagSet());
ASSERT_NE(deadline_.GetDeadline(), ticks);
// Set the deadline and verify it stuck.
deadline_.SetDeadline(ticks);
EXPECT_EQ(deadline_.GetDeadline(), ticks);
// Only the value was modified, no flags should be set.
EXPECT_THAT(deadline_, HasNoFlagSet());
}
// Verify that setting a non-persistent flag (kShouldBlockOnHang)
// when the TimeTicks value changed since calling the flag setting
// function fails and has no side-effects.
TEST_F(HangWatchDeadlineTest, SetShouldBlockOnHangDeadlineChanged) {
ASSERT_THAT(deadline_, HasNoFlagSet());
auto [flags, deadline] = deadline_.GetFlagsAndDeadline();
// Simulate value change. Flags are constant.
const base::TimeTicks new_deadline =
base::TimeTicks::FromInternalValue(kArbitraryDeadline);
ASSERT_NE(deadline, new_deadline);
deadline_.SetSwitchBitsClosureForTesting(
base::BindLambdaForTesting([] { return kArbitraryDeadline; }));
// kShouldBlockOnHangs does not persist through value change.
EXPECT_FALSE(deadline_.SetShouldBlockOnHang(flags, deadline));
// Flag was not applied.
EXPECT_FALSE(
deadline_.IsFlagSet(HangWatchDeadline::Flag::kShouldBlockOnHang));
// New value that was changed concurrently is preserved.
EXPECT_EQ(deadline_.GetDeadline(), new_deadline);
}
// Verify that clearing a persistent (kIgnoreCurrentWatchHangsInScope) when
// the value changed succeeds and has non side-effects.
TEST_F(HangWatchDeadlineTest, ClearIgnoreHangsDeadlineChanged) {
ASSERT_THAT(deadline_, HasNoFlagSet());
auto [flags, deadline] = deadline_.GetFlagsAndDeadline();
deadline_.SetIgnoreCurrentWatchHangsInScope();
std::tie(flags, deadline) = deadline_.GetFlagsAndDeadline();
ASSERT_TRUE(HangWatchDeadline::IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope, flags));
// Simulate deadline change. Flags are constant.
const base::TimeTicks new_deadline =
base::TimeTicks::FromInternalValue(kArbitraryDeadline);
ASSERT_NE(deadline, new_deadline);
deadline_.SetSwitchBitsClosureForTesting(base::BindLambdaForTesting([] {
return static_cast<uint64_t>(HangWatchDeadline::Flag::kShouldBlockOnHang) |
kArbitraryDeadline;
}));
// Clearing kIgnoreHang is unaffected by deadline or flags change.
deadline_.UnsetIgnoreCurrentWatchHangsInScope();
EXPECT_FALSE(deadline_.IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope));
// New deadline that was changed concurrently is preserved.
EXPECT_TRUE(deadline_.IsFlagSet(HangWatchDeadline::Flag::kShouldBlockOnHang));
EXPECT_EQ(deadline_.GetDeadline(), new_deadline);
}
// Verify that setting a persistent (kIgnoreCurrentWatchHangsInScope) when
// the deadline or flags changed succeeds and has non side-effects.
TEST_F(HangWatchDeadlineTest,
SetIgnoreCurrentHangWatchScopeEnableDeadlineChanged) {
ASSERT_THAT(deadline_, HasNoFlagSet());
auto [flags, deadline] = deadline_.GetFlagsAndDeadline();
// Simulate deadline change. Flags are constant.
const base::TimeTicks new_deadline =
base::TimeTicks::FromInternalValue(kArbitraryDeadline);
ASSERT_NE(deadline, new_deadline);
deadline_.SetSwitchBitsClosureForTesting(base::BindLambdaForTesting([] {
return static_cast<uint64_t>(HangWatchDeadline::Flag::kShouldBlockOnHang) |
kArbitraryDeadline;
}));
// kIgnoreHang persists through value change.
deadline_.SetIgnoreCurrentWatchHangsInScope();
EXPECT_TRUE(deadline_.IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope));
// New deadline and flags that changed concurrently are preserved.
EXPECT_TRUE(deadline_.IsFlagSet(HangWatchDeadline::Flag::kShouldBlockOnHang));
EXPECT_EQ(deadline_.GetDeadline(), new_deadline);
}
// Setting a new deadline should wipe flags that a not persistent.
// Persistent flags should not be disturbed.
TEST_F(HangWatchDeadlineTest, SetDeadlineWipesFlags) {
auto [flags, deadline] = deadline_.GetFlagsAndDeadline();
ASSERT_TRUE(deadline_.SetShouldBlockOnHang(flags, deadline));
ASSERT_TRUE(deadline_.IsFlagSet(HangWatchDeadline::Flag::kShouldBlockOnHang));
std::tie(flags, deadline) = deadline_.GetFlagsAndDeadline();
deadline_.SetIgnoreCurrentWatchHangsInScope();
ASSERT_TRUE(deadline_.IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope));
// Change the deadline.
deadline_.SetDeadline(TimeTicks{});
EXPECT_EQ(deadline_.GetDeadline(), TimeTicks{});
// Verify the persistent flag stuck and the non-persistent one was unset.
EXPECT_FALSE(
deadline_.IsFlagSet(HangWatchDeadline::Flag::kShouldBlockOnHang));
EXPECT_TRUE(deadline_.IsFlagSet(
HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope));
}
} // namespace
} // namespace internal
} // namespace base
|