1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/threading/post_task_and_reply_impl.h"
#include <utility>
#include "base/auto_reset.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/task/sequenced_task_runner.h"
#include "base/test/test_mock_time_task_runner.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::_;
namespace base::internal {
namespace {
class ObjectToDelete : public RefCounted<ObjectToDelete> {
public:
// `delete_flag` is set to true when this object is deleted
explicit ObjectToDelete(bool* delete_flag) : delete_flag_(delete_flag) {
EXPECT_FALSE(*delete_flag_);
}
ObjectToDelete(const ObjectToDelete&) = delete;
ObjectToDelete& operator=(const ObjectToDelete&) = delete;
private:
friend class RefCounted<ObjectToDelete>;
~ObjectToDelete() { *delete_flag_ = true; }
const raw_ptr<bool> delete_flag_;
};
class MockObject {
public:
MockObject() = default;
MockObject(const MockObject&) = delete;
MockObject& operator=(const MockObject&) = delete;
MOCK_METHOD1(Task, void(scoped_refptr<ObjectToDelete>));
MOCK_METHOD1(Reply, void(scoped_refptr<ObjectToDelete>));
WeakPtr<MockObject> GetWeakPtr() { return weak_factory_.GetWeakPtr(); }
void InvalidateWeakPtrs() { weak_factory_.InvalidateWeakPtrs(); }
private:
WeakPtrFactory<MockObject> weak_factory_{this};
};
class MockRunsTasksInCurrentSequenceTaskRunner : public TestMockTimeTaskRunner {
public:
explicit MockRunsTasksInCurrentSequenceTaskRunner(
TestMockTimeTaskRunner::Type type =
TestMockTimeTaskRunner::Type::kStandalone)
: TestMockTimeTaskRunner(type) {}
MockRunsTasksInCurrentSequenceTaskRunner(
const MockRunsTasksInCurrentSequenceTaskRunner&) = delete;
MockRunsTasksInCurrentSequenceTaskRunner& operator=(
const MockRunsTasksInCurrentSequenceTaskRunner&) = delete;
void StopAcceptingTasks() { accepts_tasks_ = false; }
void RunUntilIdleWithRunsTasksInCurrentSequence() {
AutoReset<bool> reset(&runs_tasks_in_current_sequence_, true);
RunUntilIdle();
}
void ClearPendingTasksWithRunsTasksInCurrentSequence() {
AutoReset<bool> reset(&runs_tasks_in_current_sequence_, true);
ClearPendingTasks();
}
// TestMockTimeTaskRunner:
bool RunsTasksInCurrentSequence() const override {
return runs_tasks_in_current_sequence_;
}
bool PostDelayedTask(const Location& from_here,
OnceClosure task,
TimeDelta delay) override {
if (!accepts_tasks_) {
return false;
}
return TestMockTimeTaskRunner::PostDelayedTask(from_here, std::move(task),
delay);
}
private:
~MockRunsTasksInCurrentSequenceTaskRunner() override = default;
bool accepts_tasks_ = true;
bool runs_tasks_in_current_sequence_ = false;
};
class PostTaskAndReplyImplTest : public testing::Test {
public:
PostTaskAndReplyImplTest(const PostTaskAndReplyImplTest&) = delete;
PostTaskAndReplyImplTest& operator=(const PostTaskAndReplyImplTest&) = delete;
protected:
PostTaskAndReplyImplTest() = default;
bool PostTaskAndReplyToMockObject(bool task_uses_weak_ptr = false) {
OnceClosure task;
if (task_uses_weak_ptr) {
task = BindOnce(&MockObject::Task, mock_object_.GetWeakPtr(),
MakeRefCounted<ObjectToDelete>(&delete_task_flag_));
} else {
task = BindOnce(&MockObject::Task, Unretained(&mock_object_),
MakeRefCounted<ObjectToDelete>(&delete_task_flag_));
}
return PostTaskAndReplyImpl(
[this](const Location& location, OnceClosure task) {
return post_runner_->PostTask(location, std::move(task));
},
FROM_HERE, std::move(task),
BindOnce(&MockObject::Reply, Unretained(&mock_object_),
MakeRefCounted<ObjectToDelete>(&delete_reply_flag_)));
}
void ExpectPostTaskAndReplyToMockObjectSucceeds(
bool task_uses_weak_ptr = false) {
// Expect the post to succeed.
EXPECT_TRUE(PostTaskAndReplyToMockObject(task_uses_weak_ptr));
// Expect the first task to be posted to `post_runner_`.
EXPECT_TRUE(post_runner_->HasPendingTask());
EXPECT_FALSE(reply_runner_->HasPendingTask());
EXPECT_FALSE(delete_task_flag_);
EXPECT_FALSE(delete_reply_flag_);
}
scoped_refptr<MockRunsTasksInCurrentSequenceTaskRunner> post_runner_ =
MakeRefCounted<MockRunsTasksInCurrentSequenceTaskRunner>();
scoped_refptr<MockRunsTasksInCurrentSequenceTaskRunner> reply_runner_ =
MakeRefCounted<MockRunsTasksInCurrentSequenceTaskRunner>(
TestMockTimeTaskRunner::Type::kBoundToThread);
testing::StrictMock<MockObject> mock_object_;
bool delete_task_flag_ = false;
bool delete_reply_flag_ = false;
};
} // namespace
TEST_F(PostTaskAndReplyImplTest, PostTaskAndReply) {
ExpectPostTaskAndReplyToMockObjectSucceeds();
EXPECT_CALL(mock_object_, Task(_));
post_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
testing::Mock::VerifyAndClear(&mock_object_);
// The task should have been deleted right after being run.
EXPECT_TRUE(delete_task_flag_);
EXPECT_FALSE(delete_reply_flag_);
// Expect the reply to be posted to `reply_runner_`.
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_TRUE(reply_runner_->HasPendingTask());
EXPECT_CALL(mock_object_, Reply(_));
reply_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
testing::Mock::VerifyAndClear(&mock_object_);
EXPECT_TRUE(delete_task_flag_);
// The reply should have been deleted right after being run.
EXPECT_TRUE(delete_reply_flag_);
// Expect no pending task in `post_runner_` and `reply_runner_`.
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_FALSE(reply_runner_->HasPendingTask());
}
TEST_F(PostTaskAndReplyImplTest, TaskDoesNotRun) {
ExpectPostTaskAndReplyToMockObjectSucceeds();
// Clear the `post_runner_`. Both callbacks should be scheduled for deletion
// on the `reply_runner_`.
post_runner_->ClearPendingTasksWithRunsTasksInCurrentSequence();
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_TRUE(reply_runner_->HasPendingTask());
EXPECT_FALSE(delete_task_flag_);
EXPECT_FALSE(delete_reply_flag_);
// Run the `reply_runner_`. Both callbacks should be deleted.
reply_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
EXPECT_TRUE(delete_task_flag_);
EXPECT_TRUE(delete_reply_flag_);
}
TEST_F(PostTaskAndReplyImplTest, ReplyDoesNotRun) {
ExpectPostTaskAndReplyToMockObjectSucceeds();
EXPECT_CALL(mock_object_, Task(_));
post_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
testing::Mock::VerifyAndClear(&mock_object_);
// The task should have been deleted right after being run.
EXPECT_TRUE(delete_task_flag_);
EXPECT_FALSE(delete_reply_flag_);
// Expect the reply to be posted to `reply_runner_`.
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_TRUE(reply_runner_->HasPendingTask());
// Clear the `reply_runner_` queue without running tasks. The reply callback
// should be deleted.
reply_runner_->ClearPendingTasksWithRunsTasksInCurrentSequence();
EXPECT_TRUE(delete_task_flag_);
EXPECT_TRUE(delete_reply_flag_);
}
// This is a regression test for crbug.com/922938.
TEST_F(PostTaskAndReplyImplTest,
PostTaskToStoppedTaskRunnerWithoutSequencedContext) {
reply_runner_.reset();
EXPECT_FALSE(SequencedTaskRunner::HasCurrentDefault());
post_runner_->StopAcceptingTasks();
// Expect the post to return false, but not to crash.
EXPECT_FALSE(PostTaskAndReplyToMockObject());
// Expect all tasks to be deleted.
EXPECT_TRUE(delete_task_flag_);
EXPECT_TRUE(delete_reply_flag_);
}
// Demonstrate that even if a task is not run because a weak pointer is
// invalidated, the reply still runs.
TEST_F(PostTaskAndReplyImplTest, ReplyStilRunsAfterInvalidatedWeakPtrTask) {
ExpectPostTaskAndReplyToMockObjectSucceeds(/*task_uses_weak_ptr=*/true);
// The task will not run when the provided weak pointer is invalidated.
EXPECT_CALL(mock_object_, Task(_)).Times(0);
mock_object_.InvalidateWeakPtrs();
post_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
testing::Mock::VerifyAndClear(&mock_object_);
// The task should have been deleted as part of dropping the run because of
// invalidated weak pointer.
EXPECT_TRUE(delete_task_flag_);
EXPECT_FALSE(delete_reply_flag_);
// Still expect a reply to be posted to `reply_runner_`.
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_TRUE(reply_runner_->HasPendingTask());
EXPECT_CALL(mock_object_, Reply(_)).Times(1);
reply_runner_->RunUntilIdleWithRunsTasksInCurrentSequence();
testing::Mock::VerifyAndClear(&mock_object_);
EXPECT_TRUE(delete_task_flag_);
// The reply should have been deleted right after being run.
EXPECT_TRUE(delete_reply_flag_);
// Expect no pending task in `post_runner_` and `reply_runner_`.
EXPECT_FALSE(post_runner_->HasPendingTask());
EXPECT_FALSE(reply_runner_->HasPendingTask());
}
} // namespace base::internal
|