1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
#pragma allow_unsafe_buffers
#endif
#include "base/threading/scoped_blocking_call_internal.h"
#include <algorithm>
#include <utility>
#include "base/check_op.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/no_destructor.h"
#include "base/numerics/safe_conversions.h"
#include "base/scoped_clear_last_error.h"
#include "base/task/scoped_set_task_priority_for_current_thread.h"
#include "base/task/thread_pool.h"
#include "base/task/thread_pool/environment_config.h"
#include "base/task/thread_pool/thread_pool_instance.h"
#include "base/threading/scoped_blocking_call.h"
#include "build/build_config.h"
namespace base {
namespace internal {
namespace {
constinit thread_local BlockingObserver* blocking_observer = nullptr;
// Last ScopedBlockingCall instantiated on this thread.
constinit thread_local UncheckedScopedBlockingCall* last_scoped_blocking_call =
nullptr;
// These functions can be removed, and the calls below replaced with direct
// variable accesses, once the MSAN workaround is not necessary.
BlockingObserver* GetBlockingObserver() {
// Workaround false-positive MSAN use-of-uninitialized-value on
// thread_local storage for loaded libraries:
// https://github.com/google/sanitizers/issues/1265
MSAN_UNPOISON(&blocking_observer, sizeof(BlockingObserver*));
return blocking_observer;
}
UncheckedScopedBlockingCall* GetLastScopedBlockingCall() {
// Workaround false-positive MSAN use-of-uninitialized-value on
// thread_local storage for loaded libraries:
// https://github.com/google/sanitizers/issues/1265
MSAN_UNPOISON(&last_scoped_blocking_call,
sizeof(UncheckedScopedBlockingCall*));
return last_scoped_blocking_call;
}
// Set to true by scoped_blocking_call_unittest to ensure unrelated threads
// entering ScopedBlockingCalls don't affect test outcomes.
bool g_only_monitor_observed_threads = false;
bool IsBackgroundPriorityWorker() {
return GetTaskPriorityForCurrentThread() == TaskPriority::BEST_EFFORT &&
CanUseBackgroundThreadTypeForWorkerThread();
}
} // namespace
void SetBlockingObserverForCurrentThread(
BlockingObserver* new_blocking_observer) {
DCHECK(!GetBlockingObserver());
blocking_observer = new_blocking_observer;
}
void ClearBlockingObserverForCurrentThread() {
blocking_observer = nullptr;
}
IOJankMonitoringWindow::ScopedMonitoredCall::ScopedMonitoredCall()
: call_start_(TimeTicks::Now()),
assigned_jank_window_(MonitorNextJankWindowIfNecessary(call_start_)) {
if (assigned_jank_window_ &&
call_start_ < assigned_jank_window_->start_time_) {
// Sampling |call_start_| and being assigned an IOJankMonitoringWindow is
// racy. It is possible that |call_start_| is sampled near the very end of
// the current window; meanwhile, another ScopedMonitoredCall on another
// thread samples a |call_start_| which lands in the next window. If that
// thread beats this one to MonitorNextJankWindowIfNecessary(), this thread
// will incorrectly be assigned that window (in the future w.r.t. to its
// |call_start_|). To avoid OOB-indexing in AddJank(), crbug.com/1209622, it
// is necessary to correct this by bumping |call_start_| to the received
// window's |start_time_|.
//
// Note: The alternate approach of getting |assigned_jank_window_| before
// |call_start_| has the opposite problem where |call_start_| can be more
// than kNumIntervals ahead of |start_time_| when sampling across the window
// boundary, resulting in OOB-indexing the other way. To solve that a loop
// would be required (re-getting the latest window and re-sampling
// |call_start_| until the condition holds). The loopless solution is thus
// preferred.
//
// A lock covering this entire constructor is also undesired because of the
// lock-free logic at the end of MonitorNextJankWindowIfNecessary().
call_start_ = assigned_jank_window_->start_time_;
}
}
IOJankMonitoringWindow::ScopedMonitoredCall::~ScopedMonitoredCall() {
if (assigned_jank_window_) {
assigned_jank_window_->OnBlockingCallCompleted(call_start_,
TimeTicks::Now());
}
}
void IOJankMonitoringWindow::ScopedMonitoredCall::Cancel() {
assigned_jank_window_ = nullptr;
}
IOJankMonitoringWindow::IOJankMonitoringWindow(TimeTicks start_time)
: start_time_(start_time) {}
// static
void IOJankMonitoringWindow::CancelMonitoringForTesting() {
g_only_monitor_observed_threads = false;
AutoLock lock(current_jank_window_lock());
current_jank_window_storage() = nullptr;
reporting_callback_storage() = NullCallback();
}
// static
constexpr TimeDelta IOJankMonitoringWindow::kIOJankInterval;
// static
constexpr TimeDelta IOJankMonitoringWindow::kMonitoringWindow;
// static
constexpr TimeDelta IOJankMonitoringWindow::kTimeDiscrepancyTimeout;
// static
constexpr int IOJankMonitoringWindow::kNumIntervals;
// static
scoped_refptr<IOJankMonitoringWindow>
IOJankMonitoringWindow::MonitorNextJankWindowIfNecessary(TimeTicks recent_now) {
DCHECK_GE(TimeTicks::Now(), recent_now);
scoped_refptr<IOJankMonitoringWindow> next_jank_window;
{
AutoLock lock(current_jank_window_lock());
if (!reporting_callback_storage()) {
return nullptr;
}
scoped_refptr<IOJankMonitoringWindow>& current_jank_window_ref =
current_jank_window_storage();
// Start the next window immediately after the current one (rather than
// based on Now() to avoid uncovered gaps). Only use Now() for the very
// first window in a monitoring chain.
TimeTicks next_window_start_time =
current_jank_window_ref
? current_jank_window_ref->start_time_ + kMonitoringWindow
: recent_now;
if (next_window_start_time > recent_now) {
// Another thread beat us to constructing the next monitoring window and
// |current_jank_window_ref| already covers |recent_now|.
return current_jank_window_ref;
}
if (recent_now - next_window_start_time >= kTimeDiscrepancyTimeout) {
// If the delayed task runs on a regular heartbeat, |recent_now| should be
// roughly equal to |next_window_start_time|. If we miss by more than
// kTimeDiscrepancyTimeout, we likely hit machine sleep, cancel sampling
// that window in that case.
//
// Note: It is safe to touch |canceled_| without a lock here as this is
// the only time it's set and it naturally happens-before
// |current_jank_window_ref|'s destructor reads it.
current_jank_window_ref->canceled_ = true;
next_window_start_time = recent_now;
}
next_jank_window =
MakeRefCounted<IOJankMonitoringWindow>(next_window_start_time);
if (current_jank_window_ref && !current_jank_window_ref->canceled_) {
// If there are still IO operations in progress within
// |current_jank_window_ref|, they have a ref to it and will be the ones
// triggering ~IOJankMonitoringWindow(). When doing so, they will overlap
// into the |next_jank_window| we are setting up (|next_| will also own a
// ref so a very long jank can safely unwind across a chain of pending
// |next_|'s).
DCHECK(!current_jank_window_ref->next_);
current_jank_window_ref->next_ = next_jank_window;
}
// Make |next_jank_window| the new current before releasing the lock.
current_jank_window_ref = next_jank_window;
}
// Post a task to kick off the next monitoring window if no monitored thread
// beats us to it. Adjust the timing to alleviate any drift in the timer. Do
// this outside the lock to avoid scheduling tasks while holding it.
ThreadPool::PostDelayedTask(
FROM_HERE, BindOnce([] {
IOJankMonitoringWindow::MonitorNextJankWindowIfNecessary(
TimeTicks::Now());
}),
kMonitoringWindow - (recent_now - next_jank_window->start_time_));
return next_jank_window;
}
// NO_THREAD_SAFETY_ANALYSIS because ~RefCountedThreadSafe() guarantees we're
// the last ones to access this state (and ordered after all other accesses).
IOJankMonitoringWindow::~IOJankMonitoringWindow() NO_THREAD_SAFETY_ANALYSIS {
if (canceled_) {
return;
}
int janky_intervals_count = 0;
int total_jank_count = 0;
for (size_t interval_jank_count : intervals_jank_count_) {
if (interval_jank_count > 0) {
++janky_intervals_count;
total_jank_count += interval_jank_count;
}
}
// reporting_callback_storage() is safe to access without lock because an
// IOJankMonitoringWindow existing means we're after the call to
// EnableIOJankMonitoringForProcess() and it will not change after that call.
DCHECK(reporting_callback_storage());
reporting_callback_storage().Run(janky_intervals_count, total_jank_count);
}
void IOJankMonitoringWindow::OnBlockingCallCompleted(TimeTicks call_start,
TimeTicks call_end) {
// Confirm we never hit a case of TimeTicks going backwards on the same thread
// nor of TimeTicks rolling over the int64_t boundary (which would break
// comparison operators).
DCHECK_LE(call_start, call_end);
if (call_end - call_start < kIOJankInterval) {
return;
}
// Make sure the chain of |next_| pointers is sufficient to reach
// |call_end| (e.g. if this runs before the delayed task kicks in)
if (call_end >= start_time_ + kMonitoringWindow) {
MonitorNextJankWindowIfNecessary(call_end);
}
// Begin attributing jank to the first interval in which it appeared, no
// matter how far into the interval the jank began.
const int jank_start_index =
ClampFloor((call_start - start_time_) / kIOJankInterval);
// Round the jank duration so the total number of intervals marked janky is as
// close as possible to the actual jank duration.
const int num_janky_intervals =
ClampRound((call_end - call_start) / kIOJankInterval);
AddJank(jank_start_index, num_janky_intervals);
}
void IOJankMonitoringWindow::AddJank(int local_jank_start_index,
int num_janky_intervals) {
DCHECK_GE(local_jank_start_index, 0);
DCHECK_LT(local_jank_start_index, kNumIntervals);
// Increment jank counts for intervals in this window. If
// |num_janky_intervals| lands beyond kNumIntervals, the additional intervals
// will be reported to |next_|.
const int jank_end_index = local_jank_start_index + num_janky_intervals;
const int local_jank_end_index = std::min(kNumIntervals, jank_end_index);
{
// Note: while this window could be |canceled| here we must add our count
// unconditionally as it is only thread-safe to read |canceled| in
// ~IOJankMonitoringWindow().
AutoLock lock(intervals_lock_);
for (int i = local_jank_start_index; i < local_jank_end_index; ++i) {
++intervals_jank_count_[i];
}
}
if (jank_end_index != local_jank_end_index) {
// OnBlockingCallCompleted() should have already ensured there's a |next_|
// chain covering |num_janky_intervals| unless it caused this to be
// |canceled_|. Exceptionally for this check, reading these fields when
// they're expected to be true is thread-safe as their only modification
// happened-before this point.
DCHECK(next_ || canceled_);
if (next_) {
// If |next_| is non-null, it means |this| wasn't canceled and it implies
// |next_| covers the time range starting immediately after this window.
DCHECK_EQ(next_->start_time_, start_time_ + kMonitoringWindow);
next_->AddJank(0, jank_end_index - local_jank_end_index);
}
}
}
// static
Lock& IOJankMonitoringWindow::current_jank_window_lock() {
static NoDestructor<Lock> current_jank_window_lock;
return *current_jank_window_lock;
}
// static
scoped_refptr<IOJankMonitoringWindow>&
IOJankMonitoringWindow::current_jank_window_storage() {
static NoDestructor<scoped_refptr<IOJankMonitoringWindow>>
current_jank_window;
return *current_jank_window;
}
// static
IOJankReportingCallback& IOJankMonitoringWindow::reporting_callback_storage() {
static NoDestructor<IOJankReportingCallback> reporting_callback;
return *reporting_callback;
}
UncheckedScopedBlockingCall::UncheckedScopedBlockingCall(
BlockingType blocking_type,
BlockingCallType blocking_call_type)
: blocking_observer_(GetBlockingObserver()),
previous_scoped_blocking_call_(GetLastScopedBlockingCall()),
resetter_(&last_scoped_blocking_call, this),
is_will_block_(blocking_type == BlockingType::WILL_BLOCK ||
(previous_scoped_blocking_call_ &&
previous_scoped_blocking_call_->is_will_block_)) {
// Only monitor non-nested ScopedBlockingCall(MAY_BLOCK) calls on foreground
// threads. Cancels() any pending monitored call when a WILL_BLOCK or
// ScopedBlockingCallWithBaseSyncPrimitives nests into a
// ScopedBlockingCall(MAY_BLOCK).
if (!IsBackgroundPriorityWorker() &&
(!g_only_monitor_observed_threads || blocking_observer_)) {
const bool is_monitored_type =
blocking_call_type == BlockingCallType::kRegular && !is_will_block_;
if (is_monitored_type && !previous_scoped_blocking_call_) {
monitored_call_.emplace();
} else if (!is_monitored_type && previous_scoped_blocking_call_ &&
previous_scoped_blocking_call_->monitored_call_) {
previous_scoped_blocking_call_->monitored_call_->Cancel();
}
}
if (blocking_observer_) {
if (!previous_scoped_blocking_call_) {
blocking_observer_->BlockingStarted(blocking_type);
} else if (blocking_type == BlockingType::WILL_BLOCK &&
!previous_scoped_blocking_call_->is_will_block_) {
blocking_observer_->BlockingTypeUpgraded();
}
}
}
UncheckedScopedBlockingCall::~UncheckedScopedBlockingCall() {
// TLS affects result of GetLastError() on Windows. ScopedClearLastError
// prevents side effect.
ScopedClearLastError save_last_error;
DCHECK_EQ(this, GetLastScopedBlockingCall());
if (blocking_observer_ && !previous_scoped_blocking_call_) {
blocking_observer_->BlockingEnded();
}
}
} // namespace internal
void EnableIOJankMonitoringForProcess(
IOJankReportingCallback reporting_callback,
OnlyObservedThreadsForTest only_observed_threads) {
{
AutoLock lock(internal::IOJankMonitoringWindow::current_jank_window_lock());
DCHECK(internal::IOJankMonitoringWindow::reporting_callback_storage()
.is_null());
internal::IOJankMonitoringWindow::reporting_callback_storage() =
std::move(reporting_callback);
}
if (only_observed_threads) {
internal::g_only_monitor_observed_threads = true;
} else {
// Do not set it to `false` when it already is as that causes data races in
// browser tests (which EnableIOJankMonitoringForProcess after ThreadPool is
// already running).
DCHECK(!internal::g_only_monitor_observed_threads);
}
// Make sure monitoring starts now rather than randomly at the next
// ScopedMonitoredCall construction.
internal::IOJankMonitoringWindow::MonitorNextJankWindowIfNecessary(
TimeTicks::Now());
}
} // namespace base
|