1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
# Copyright 2013 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for android buildbot.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
details on the presubmit API built into depot_tools.
"""
def CommonChecks(input_api, output_api, *, is_upload):
# These tools don't run on Windows so these tests don't work and give many
# verbose and cryptic failure messages. Linting the code is also skipped on
# Windows because it will fail due to os differences.
if input_api.sys.platform == 'win32':
return []
build_android_dir = input_api.PresubmitLocalPath()
def J(*dirs):
"""Returns a path relative to presubmit directory."""
return input_api.os_path.join(build_android_dir, *dirs)
build_pys = [
r'gyp/.*\.py$',
r'.*create_unwind_table\.py',
r'.*create_unwind_table_tests\.py',
]
tests = []
# yapf likes formatting the extra_paths_list to be less readable.
# yapf: disable
tests.extend(
input_api.canned_checks.GetPylint(
input_api,
output_api,
pylintrc='pylintrc',
files_to_skip=[
r'.*_pb2\.py'
] + build_pys,
extra_paths_list=[
J(),
J('gyp'),
J('buildbot'),
J('..'),
J('..', 'util'),
J('..', '..', 'third_party', 'catapult', 'common',
'py_trace_event'),
J('..', '..', 'third_party', 'catapult', 'common', 'py_utils'),
J('..', '..', 'third_party', 'catapult', 'devil'),
J('..', '..', 'third_party', 'catapult', 'tracing'),
J('..', '..', 'third_party', 'depot_tools'),
J('..', '..', 'third_party', 'colorama', 'src'),
],
version='2.7'))
tests.extend(
input_api.canned_checks.GetPylint(
input_api,
output_api,
pylintrc='pylintrc-3.2',
files_to_check=build_pys,
files_to_skip=[
r'.*_pb2\.py',
r'.*_pb2\.py',
r'.*create_unwind_table\.py',
r'.*create_unwind_table_tests\.py',
],
extra_paths_list=[
J(),
J('..'),
J('..', 'gn_ast'),
J('..', 'util'),
J('..', '..', 'google_apis'),
J('..', '..', 'third_party'),
J('gyp'),
J('gyp', 'util'),
],
version='3.2'))
# yapf: enable
pylib_test_env = dict(input_api.environ)
pylib_test_env.update({
'PYTHONPATH': build_android_dir,
'PYTHONDONTWRITEBYTECODE': '1',
})
pytests = [
J('.', 'convert_dex_profile_tests.py'),
J('.', 'list_class_verification_failures_test.py'),
J('.', 'test_runner_test.py'),
J('gyp', 'compile_java_tests.py'),
J('gyp', 'create_unwind_table_tests.py'),
J('gyp', 'dex_test.py'),
J('gyp', 'extract_unwind_tables_tests.py'),
J('gyp', 'gcc_preprocess_tests.py'),
J('gyp', 'java_cpp_enum_tests.py'),
J('gyp', 'java_cpp_features_tests.py'),
J('gyp', 'java_cpp_strings_tests.py'),
J('gyp', 'java_google_api_keys_tests.py'),
J('gyp', 'util', 'build_utils_test.py'),
J('gyp', 'util', 'manifest_utils_test.py'),
J('gyp', 'util', 'md5_check_test.py'),
J('gyp', 'util', 'resource_utils_test.py'),
J('pylib', 'base', 'output_manager_test_case.py'),
J('pylib', 'constants', 'host_paths_unittest.py'),
J('pylib', 'gtest', 'gtest_test_instance_test.py'),
J('pylib', 'instrumentation', 'instrumentation_parser_test.py'),
J('pylib', 'instrumentation', 'instrumentation_test_instance_test.py'),
J('pylib', 'local', 'device', 'local_device_gtest_run_test.py'),
J('pylib', 'local', 'device',
'local_device_instrumentation_test_run_test.py'),
J('pylib', 'local', 'device', 'local_device_test_run_test.py'),
J('pylib', 'local', 'emulator', 'ini_test.py'),
J('pylib', 'local', 'machine', 'local_machine_junit_test_run_test.py'),
J('pylib', 'output', 'local_output_manager_test.py'),
J('pylib', 'output', 'noop_output_manager_test.py'),
J('pylib', 'output', 'remote_output_manager_test.py'),
J('pylib', 'results', 'flakiness_dashboard',
'json_results_generator_unittest.py'),
J('pylib', 'results', 'json_results_test.py'),
J('pylib', 'utils', 'chrome_proxy_utils_test.py'),
J('pylib', 'utils', 'code_coverage_utils_test.py'),
J('pylib', 'utils', 'device_dependencies_test.py'),
J('pylib', 'utils', 'dexdump_test.py'),
J('pylib', 'utils', 'gold_utils_test.py'),
J('pylib', 'utils', 'test_filter_test.py'),
]
if is_upload:
pytests += [J('.', 'fast_local_dev_server_test.py')]
# Build server tests are flaky on bots.
# E.g.: https://ci.chromium.org/ui/p/chromium/builders/try/chromium_presubmit/3085167/overview
tests.extend(
input_api.canned_checks.GetUnitTests(input_api,
output_api,
unit_tests=pytests,
env=pylib_test_env))
return input_api.RunTests(tests)
def CheckChangeOnUpload(input_api, output_api):
return CommonChecks(input_api, output_api, is_upload=True)
def CheckChangeOnCommit(input_api, output_api):
return CommonChecks(input_api, output_api, is_upload=False)
|
