1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/351564777): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "cc/metrics/frame_sequence_tracker.h"
#include <string>
#include <utility>
#include <vector>
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "cc/metrics/compositor_frame_reporting_controller.h"
#include "cc/metrics/frame_sequence_tracker_collection.h"
#include "cc/metrics/frame_sorter.h"
#include "cc/trees/layer_tree_host_impl.h"
#include "components/viz/common/frame_sinks/begin_frame_args.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/presentation_feedback.h"
namespace cc {
namespace {
const char* ParseNumber(const char* str, uint64_t* retvalue) {
uint64_t number = 0;
for (; *str >= '0' && *str <= '9'; ++str) {
number *= 10;
number += *str - '0';
}
*retvalue = number;
return str;
}
} // namespace
// Mock FrameSorter class in order to test the number of times that
// frames get backfilled. This is necessary since `WillBeginImplFrame` creates
// `CompositorFrameReporter`s for backfilled frames which submit to FrameSorter
// without a good interim spot to analyze the frame info contents.
class FrameSorterMock : public FrameSorter {
public:
MOCK_METHOD2(AddFrameResult,
void(const viz::BeginFrameArgs&, const FrameInfo&));
};
class FrameSequenceTrackerTest : public testing::Test,
public FrameSorterObserver {
public:
const uint32_t kImplDamage = 0x1;
const uint32_t kMainDamage = 0x2;
FrameSequenceTrackerTest()
: sorter_(FrameSorterMock()),
collection_(/*is_single_threaded=*/false),
compositor_frame_reporting_controller_(
std::make_unique<CompositorFrameReportingController>(
/*should_report_histograms=*/true,
/*should_report_ukm=*/false,
/*layer_tree_host_id=*/1)) {
compositor_frame_reporting_controller_->SetFrameSorter(&sorter_);
sorter_.AddObserver(this);
tracker_ = collection_.StartScrollSequence(
FrameSequenceTrackerType::kTouchScroll,
FrameInfo::SmoothEffectDrivingThread::kCompositor);
}
~FrameSequenceTrackerTest() override = default;
void CreateNewTracker(FrameInfo::SmoothEffectDrivingThread thread_type =
FrameInfo::SmoothEffectDrivingThread::kCompositor) {
tracker_ = collection_.StartScrollSequence(
FrameSequenceTrackerType::kTouchScroll, thread_type);
}
viz::BeginFrameArgs CreateBeginFrameArgs(
uint64_t source_id,
uint64_t sequence_number,
base::TimeTicks now = base::TimeTicks::Now()) {
auto interval = base::Milliseconds(16);
auto deadline = now + interval;
return viz::BeginFrameArgs::Create(BEGINFRAME_FROM_HERE, source_id,
sequence_number, now, deadline, interval,
viz::BeginFrameArgs::NORMAL);
}
void StartFrames(const viz::BeginFrameArgs& args) {
collection_.NotifyBeginImplFrame(args);
}
uint32_t DispatchCompleteFrame(const viz::BeginFrameArgs& args,
uint32_t damage_type,
bool has_missing_content = false) {
StartFrames(args);
if (damage_type & kImplDamage) {
uint32_t frame_token = NextFrameToken();
collection_.NotifyFrameEnd(args, args);
return frame_token;
} else {
collection_.NotifyFrameEnd(args, args);
}
return 0;
}
uint32_t NextFrameToken() {
static uint32_t frame_token = 0;
return ++frame_token;
}
// Check whether a type of tracker exists in |frame_trackers_| or not.
bool TrackerExists(FrameSequenceTrackerType type) const {
auto key =
std::make_pair(type, FrameInfo::SmoothEffectDrivingThread::kUnknown);
if (type == FrameSequenceTrackerType::kTouchScroll ||
type == FrameSequenceTrackerType::kWheelScroll ||
type == FrameSequenceTrackerType::kScrollbarScroll) {
key = std::make_pair(type,
FrameInfo::SmoothEffectDrivingThread::kCompositor);
if (!collection_.frame_trackers_.contains(key))
key = std::make_pair(type, FrameInfo::SmoothEffectDrivingThread::kMain);
}
return collection_.frame_trackers_.contains(key);
}
void GenerateSequence(const char* str) {
const uint64_t source_id = 1;
viz::BeginFrameArgs last_activated_main_args;
while (*str) {
const char command = *str++;
uint64_t sequence = 0, dummy = 0, last_activated_main = 0;
switch (command) {
case 'b':
case 'd':
case 'D':
case 'p':
case 'P':
case 'n':
case 's':
case 'r':
ASSERT_EQ(*str, '(') << command;
str = ParseNumber(++str, &sequence);
ASSERT_EQ(*str, ')');
++str;
break;
case 'N':
ASSERT_EQ(*str, '(');
str = ParseNumber(++str, &dummy);
ASSERT_EQ(*str, ',');
str = ParseNumber(++str, &sequence);
ASSERT_EQ(*str, ')');
++str;
break;
case 'e':
ASSERT_EQ(*str, '(');
str = ParseNumber(++str, &sequence);
ASSERT_EQ(*str, ',');
str = ParseNumber(++str, &last_activated_main);
ASSERT_EQ(*str, ')');
++str;
break;
case 'R':
break;
default:
NOTREACHED() << command << str;
}
switch (command) {
case 'b':
collection_.NotifyBeginImplFrame(
CreateBeginFrameArgs(source_id, sequence));
break;
case 'd': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kDropped;
frame_info.final_state_raster_property =
FrameInfo::FrameFinalState::kDropped;
frame_info.final_state_raster_scroll =
FrameInfo::FrameFinalState::kDropped;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothCompositor;
frame_info.smooth_thread_raster_property =
FrameInfo::SmoothThread::kSmoothCompositor;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'D': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kDropped;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothMain;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'p': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kPresentedAll;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothCompositor;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'P': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kPresentedAll;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothMain;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'R':
collection_.NotifyPauseFrameProduction();
break;
case 'n': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kNoUpdateDesired;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'e': {
auto args = CreateBeginFrameArgs(source_id, sequence);
collection_.NotifyFrameEnd(args, args);
break;
}
case 'N': {
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kNoUpdateDesired;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothMain;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 's': {
// V3 metric codepath marks frames as no update desired when they
// should have been marked as dropped, meaning there should be a
// difference between V3 and V4 percent dropped frames metrics.
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kNoUpdateDesired;
frame_info.final_state_raster_property =
FrameInfo::FrameFinalState::kDropped;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothCompositor;
frame_info.smooth_thread_raster_property =
FrameInfo::SmoothThread::kSmoothCompositor;
collection_.AddSortedFrame(args, frame_info);
break;
}
case 'r': {
// Raster scrolls should be accounted for separately from other
// scroll types.
auto args = CreateBeginFrameArgs(source_id, sequence);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kNoUpdateDesired;
frame_info.scroll_thread =
FrameInfo::SmoothEffectDrivingThread::kRaster;
frame_info.final_state_raster_scroll =
FrameInfo::FrameFinalState::kDropped;
collection_.AddSortedFrame(args, frame_info);
break;
}
default:
NOTREACHED();
}
}
}
base::TimeDelta TimeDeltaToReport() const {
return tracker_->time_delta_to_report_;
}
unsigned NumberOfTrackers() const {
return collection_.frame_trackers_.size();
}
unsigned NumberOfCustomTrackers() const {
return collection_.custom_frame_trackers_.size();
}
unsigned NumberOfRemovalTrackers() const {
return collection_.removal_trackers_.size();
}
void IncrementFramesExpected(uint32_t frames) {
tracker_->metrics_->v3_.frames_expected += frames;
}
uint32_t frames_expected() const {
return tracker_->metrics_->v3_.frames_expected;
}
uint32_t frames_produced() const {
return tracker_->metrics_->v3_.frames_expected -
tracker_->metrics_->v3_.frames_dropped;
}
uint32_t frames_produced_v4() const {
return tracker_->metrics_->v3_.frames_expected -
tracker_->metrics_->v4_.frames_dropped;
}
FrameSequenceTracker::TerminationStatus GetTerminationStatus(
FrameSequenceTracker* tracker) {
return tracker->termination_status_;
}
// FrameSorter observer function.
void AddSortedFrame(const viz::BeginFrameArgs& args,
const FrameInfo& frame_info) override {
collection_.AddSortedFrame(args, frame_info);
}
protected:
FrameSorterMock sorter_;
FrameSequenceTrackerCollection collection_;
// Since CFRC destructor cleans up the FrameSorter's
// registered observers (in this case FSTC)
// it needs to be declared last so that it will be
// cleaned up first.
std::unique_ptr<CompositorFrameReportingController>
compositor_frame_reporting_controller_;
raw_ptr<FrameSequenceTracker> tracker_;
};
// Tests that the tracker works correctly when the source-id for the
// begin-frames change.
TEST_F(FrameSequenceTrackerTest, SourceIdChangeDuringSequence) {
const uint64_t source_1 = 1;
uint64_t sequence_1 = 0;
// Dispatch some frames, both causing damage to impl/main, and both impl and
// main providing damage to the frame.
auto args_1 = CreateBeginFrameArgs(source_1, ++sequence_1);
DispatchCompleteFrame(args_1, kImplDamage | kMainDamage);
args_1 = CreateBeginFrameArgs(source_1, ++sequence_1);
DispatchCompleteFrame(args_1, kImplDamage | kMainDamage);
// Start a new tracker.
CreateNewTracker();
// Change the source-id, and start an impl frame. This time, the main-frame
// does not provide any damage.
const uint64_t source_2 = 2;
uint64_t sequence_2 = 0;
auto args_2 = CreateBeginFrameArgs(source_2, ++sequence_2);
collection_.NotifyBeginImplFrame(args_2);
}
TEST_F(FrameSequenceTrackerTest, TestNotifyFramePresented) {
collection_.StartSequence(
FrameSequenceTrackerType::kCompositorNativeAnimation);
collection_.StartSequence(FrameSequenceTrackerType::kMainThreadAnimation);
EXPECT_EQ(NumberOfTrackers(), 3u);
collection_.StopSequence(
FrameSequenceTrackerType::kCompositorNativeAnimation);
EXPECT_EQ(NumberOfTrackers(), 2u);
EXPECT_TRUE(TrackerExists(FrameSequenceTrackerType::kMainThreadAnimation));
EXPECT_TRUE(TrackerExists(FrameSequenceTrackerType::kTouchScroll));
// StopSequence should have destroyed all trackers because there is no frame
// awaiting presentation.
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
}
TEST_F(FrameSequenceTrackerTest, ReportMetricsAtFixedInterval) {
const uint64_t source = 1;
uint64_t sequence = 0;
base::TimeDelta first_time_delta = base::Seconds(1);
auto args = CreateBeginFrameArgs(source, ++sequence,
base::TimeTicks::Now() + first_time_delta);
// args.frame_time is less than 5s of the tracker creation time, so won't
// schedule this tracker to report its throughput.
collection_.NotifyBeginImplFrame(args);
collection_.NotifyFrameEnd(args, args);
EXPECT_EQ(NumberOfTrackers(), 1u);
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
IncrementFramesExpected(101u);
// Now args.frame_time is 5s since the tracker creation time, so this tracker
// should be scheduled to report its throughput.
args = CreateBeginFrameArgs(source, ++sequence,
args.frame_time + TimeDeltaToReport());
collection_.NotifyBeginImplFrame(args);
collection_.NotifyFrameEnd(args, args);
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kPresentedAll;
// AddSortedFrame triggers metrics reporting and then calls `DestroyTrackers`,
// which also destroys tracker_.
tracker_ = nullptr;
collection_.AddSortedFrame(args, frame_info);
EXPECT_EQ(NumberOfTrackers(), 1u);
// At NotifyFrameEnd, the tracker is removed from removal_tracker_ list.
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
}
TEST_F(FrameSequenceTrackerTest, MainFrameNoDamageTracking) {
const uint64_t source = 1;
uint64_t sequence = 0;
const auto first_args = CreateBeginFrameArgs(source, ++sequence);
DispatchCompleteFrame(first_args, kImplDamage | kMainDamage);
// Now, start the next frame, but for main, respond with the previous args.
const auto second_args = CreateBeginFrameArgs(source, ++sequence);
StartFrames(second_args);
collection_.NotifyFrameEnd(second_args, second_args);
// Start and submit the next frame, with no damage from main.
auto args = CreateBeginFrameArgs(source, ++sequence);
collection_.NotifyBeginImplFrame(args);
collection_.NotifyFrameEnd(args, args);
// Now, submit a frame with damage from main from |second_args|.
args = CreateBeginFrameArgs(source, ++sequence);
StartFrames(args);
collection_.NotifyFrameEnd(args, args);
}
TEST_F(FrameSequenceTrackerTest, CompositorDroppedFramesV3vsV4Metrics) {
// Begin, present frame 1, drop it 3 times and the present
// frame 2, at which point we drop it 4 times.
// Total dropped frames should be 7, but only 3 counted by frames_produced V3
// while all 7 are counted by V4.
const char sequence[] = "b(1)p(1)d(1)d(1)d(1)p(2)s(2)s(2)s(2)s(2)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 9u);
EXPECT_EQ(frames_produced(), 6u); // 9 expected - 3 dropped = 6
EXPECT_EQ(frames_produced_v4(), 2u); // 9 expected - 7 dropped = 2
}
TEST_F(FrameSequenceTrackerTest, RasterScrollDroppedFramesIsSeparate) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kRaster);
// Begin, present frame 1, drop it once.
// Present frame 2, and trigger a raster scroll that
// drops 2 frames. Total dropped frames should be 3.
const char sequence[] = "b(1)p(1)d(2)p(3)r(4)r(5)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 5u);
EXPECT_EQ(frames_produced_v4(), 2u); // 5 expected - 3 dropped = 2
}
TEST_F(FrameSequenceTrackerTest, SimpleSequenceOneFrame) {
const char sequence[] = "b(1)e(1,0)P(1)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 1u);
EXPECT_EQ(frames_produced(), 1u);
}
TEST_F(FrameSequenceTrackerTest, SimpleSequenceOneFrameNoDamage) {
const char sequence[] = "b(1)N(1,1)n(1)e(1,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 2u);
EXPECT_EQ(frames_produced(), 2u);
const char second_sequence[] = "b(2)n(2)N(2,2)e(2,0)";
GenerateSequence(second_sequence);
EXPECT_EQ(frames_expected(), 4u);
EXPECT_EQ(frames_produced(), 4u);
}
TEST_F(FrameSequenceTrackerTest, MultipleNoDamageNotifications) {
const char sequence[] = "b(1)n(1)n(1)e(1,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 2u);
EXPECT_EQ(frames_produced(), 2u);
}
TEST_F(FrameSequenceTrackerTest, MultipleNoDamageNotificationsFromMain) {
const char sequence[] = "b(1)N(1,1)n(1)N(0,1)e(1,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 3u);
EXPECT_EQ(frames_produced(), 3u);
}
TEST_F(FrameSequenceTrackerTest, DelayedMainFrameNoDamage) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)n(1)e(1,0)b(2)n(2)e(2,0)b(3)N(0,1)n(3)e(3,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 0u);
EXPECT_EQ(frames_produced(), 0u);
}
TEST_F(FrameSequenceTrackerTest, DelayedMainFrameNoDamageFromOlderFrame) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
// Start a sequence, and receive a 'no damage' from an earlier frame.
const char second_sequence[] = "b(2)N(2,1)n(2)N(2,2)e(2,0)";
GenerateSequence(second_sequence);
EXPECT_EQ(frames_expected(), 0u);
EXPECT_EQ(frames_produced(), 0u);
}
// This tests when a BeginMainFrame leads to No Damage, after the next Main
// Frame has started. This should not crash.
TEST_F(FrameSequenceTrackerTest, DelayedMainFrameNoDamageAfterNextMainFrame) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)n(1)e(1,0)b(2)N(0,1)n(2)N(0,2)e(2,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 0u);
EXPECT_EQ(frames_produced(), 0u);
}
TEST_F(FrameSequenceTrackerTest, StateResetDuringSequence) {
const char sequence[] = "b(1)n(1)N(1,1)Re(1,0)b(2)n(2)e(2,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 3u);
EXPECT_EQ(frames_produced(), 3u);
}
TEST_F(FrameSequenceTrackerTest, SequenceStateResetsDuringFrame) {
const char sequence[] = "b(1)Rn(1)e(1,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 1u);
EXPECT_EQ(frames_produced(), 1u);
GenerateSequence("b(2)e(2,0)P(1)b(4)");
EXPECT_EQ(frames_expected(), 2u);
EXPECT_EQ(frames_produced(), 2u);
}
// b(2417)B(0,2417)E(2417)n(2417)N(2417,2417)
TEST_F(FrameSequenceTrackerTest, SequenceNumberReset) {
const char sequence[] = "b(6)n(6)e(6,0)Rb(1)N(1,1)n(1)e(1,0)b(2)n(2)e(2,0)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 1u);
}
TEST_F(FrameSequenceTrackerTest, MainThroughputWithHighLatency) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)n(1)e(1,0)b(2)e(2,1)P(1)D(1)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 2u);
EXPECT_EQ(frames_produced(), 1u);
}
TEST_F(FrameSequenceTrackerTest, TrackLastImplFrame1) {
GenerateSequence("b(1)e(1,0)b(4)e(4,0)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
FrameSequenceTracker* removal_tracker =
collection_.GetRemovalTrackerForTesting(
FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
GenerateSequence("P(1)");
// There is still one impl-frame not processed not, so the tracker is not yet
// ready for termination.
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
}
// All the following cases are for one complete impl + one incomplete:
// b(1)e(1,0)xxxxxxxxP(1)
// The 'xxxxx' is an incomplete impl frame that has no damage, it could be
// 1. b(2)e(2,0)P(1)n(2), and StopSequence happens anywhere after e and
// before P.
// 2. b(2)e(2,0)P(1)n(2), and StopSequence can happen anywhere after e and
// before P. In this case, the tracker is not ready for termination yet at P
// because the sorted n(2) has not been called yet.
TEST_F(FrameSequenceTrackerTest, TrackLastImplFrame10) {
GenerateSequence("b(1)e(1,0)b(2)e(2,0)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
FrameSequenceTracker* removal_tracker =
collection_.GetRemovalTrackerForTesting(
FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
GenerateSequence("P(1)");
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
}
TEST_F(FrameSequenceTrackerTest, TrackLastImplFrame11) {
GenerateSequence("b(1)e(1,0)b(2)e(2,0)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
FrameSequenceTracker* removal_tracker =
collection_.GetRemovalTrackerForTesting(
FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
GenerateSequence("P(1)");
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
}
// This test ensure that the tracker would terminate at e.
TEST_F(FrameSequenceTrackerTest, TrackLastImplFrame24) {
GenerateSequence("b(1)P(1)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
// GenerateSequence processes presentation events that complete the stopped
// tracker, tracker_, and destroys it.
tracker_ = nullptr;
GenerateSequence("e(1,0)p(1)");
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
}
// Termination is triggered after a new tree is committed and activated. Due to
// this we will have started a BeginImplFrame that is not actually a part of the
// sequence. When this occurs we terminate as soon as the most recently
// submitted frame has bee processed.
TEST_F(FrameSequenceTrackerTest, IgnoreImplFrameBeforeTermination) {
GenerateSequence("b(1)e(1,0)b(2)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
FrameSequenceTracker* removal_tracker =
collection_.GetRemovalTrackerForTesting(
FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
GenerateSequence("e(2,0)");
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
EXPECT_EQ(GetTerminationStatus(removal_tracker),
FrameSequenceTracker::TerminationStatus::kScheduledForTermination);
// GenerateSequence will processes presentation events that will complete and
// destroy the scheduled-for-termination tracker, tracker_.
tracker_ = nullptr;
GenerateSequence("P(1)");
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
}
TEST_F(FrameSequenceTrackerTest, TerminationWithNullPresentationTimeStamp) {
GenerateSequence("b(1)");
collection_.StopSequence(FrameSequenceTrackerType::kTouchScroll);
EXPECT_EQ(NumberOfRemovalTrackers(), 1u);
// GenerateSequence will process and delete trackers on the removal list,
// including tracker_.
tracker_ = nullptr;
// Even if the presentation timestamp is null, as long as this presentation
// is acking the last impl frame, we consider that impl frame completed and
// so the tracker is ready for termination.
GenerateSequence("e(1,0)p(1)");
EXPECT_EQ(NumberOfRemovalTrackers(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage1) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)n(1)e(1,0)b(2)n(2)e(2,1)b(3)n(3)e(3,2)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 0u);
// At E(2), B(0,1) is treated no damage.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage2) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(1)n(1)e(1,0)b(2)n(2)e(2,1)b(3)n(3)e(3,1)b(4)n(4)e(4,1)b(8)n(8)e(8,2)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 0u);
// At E(2), B(0,1) is treated as no damage.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage3) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(34)n(34)e(34,0)b(35)n(35)e(35,0)b(36)n(36)e(36,34)b(39)e(39,34)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage4) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(9)n(9)Re(9,0)b(11)n(11)e(11,9)b(12)e(12,11)b(13)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage5) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(1)e(1,0)b(2)n(2)e(2,0)b(3)n(3)e(3,0)b(4)n(4)e(4,3)";
GenerateSequence(sequence);
// At E(4), we treat B(1,3) as if it had no damage.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage6) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)e(1,1)b(2)n(2)N(2,2)e(2,2)b(3)n(3)N(3,3)e(3,3)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage7) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(8)n(8)e(8,0)b(9)e(9,9)b(10)e(10,9)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage8) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(18)n(18)N(18,18)Re(18,18)b(20)N(20,20)n(20)N(0,20)e(20,18)b(21)e(21,"
"21)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage9) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(78)n(78)Re(78,0)Rb(82)n(82)N(82,82)Re(82,82)b(86)n(86)e(86,86)b(87)e("
"87,86)";
GenerateSequence(sequence);
// No damage frames are not expected.
EXPECT_EQ(frames_expected(), 0u);
}
TEST_F(FrameSequenceTrackerTest, OffScreenMainDamage10) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] =
"b(2)n(2)N(2,2)e(2,2)b(3)n(3)N(3,3)e(3,3)b(4)n(4)N(4,4)e(4,4)b(5)n(5)N(5,"
"5)e(5,5)b(6)n(6)e(6,5)Rb(8)n(8)N(8,8)e(8,8)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 0u);
}
// A presentation with a frame token that is > the main frame token submitted.
TEST_F(FrameSequenceTrackerTest, MainThreadPresentWithNonMatchedToken) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)e(1,0)b(2)e(2,1)P(2)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 1u);
EXPECT_EQ(frames_produced(), 1u);
}
TEST_F(FrameSequenceTrackerTest, CoalescedMainThreadPresent) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)e(1,1)b(2)e(2,2)D(1)P(2)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 2u);
EXPECT_EQ(frames_produced(), 1u);
}
TEST_F(FrameSequenceTrackerTest, MainThreadPresentWithNullTimeStamp) {
CreateNewTracker(FrameInfo::SmoothEffectDrivingThread::kMain);
const char sequence[] = "b(1)e(1,1)D(1)";
GenerateSequence(sequence);
EXPECT_EQ(frames_expected(), 1u);
// No presentation, no main frame produced.
EXPECT_EQ(frames_produced(), 0u);
GenerateSequence("b(2)e(2,0)P(2)");
// We are creating a second frame, it will be expected
EXPECT_EQ(frames_expected(), 2u);
// The main frame update is caught up here.
EXPECT_EQ(frames_produced(), 1u);
}
TEST_F(FrameSequenceTrackerTest, TrackerTypeEncoding) {
// The test begins with a kTouchScroll tracker
EXPECT_EQ(NumberOfTrackers(), 1u);
ActiveFrameSequenceTrackers active_encoded =
collection_.FrameSequenceTrackerActiveTypes();
EXPECT_EQ(active_encoded, 16); // 1 << 4
}
TEST_F(FrameSequenceTrackerTest, CustomTrackers) {
CustomTrackerResults results;
collection_.set_custom_tracker_results_added_callback(
base::BindLambdaForTesting([&](const CustomTrackerResults& reported) {
for (const auto& pair : reported)
results[pair.first] = pair.second;
}));
// Start custom tracker 1.
collection_.StartCustomSequence(1);
EXPECT_EQ(1u, NumberOfCustomTrackers());
// No reports.
EXPECT_EQ(0u, results.size());
// Start custom tracker 2 and 3 in addition to 1.
collection_.StartCustomSequence(2);
collection_.StartCustomSequence(3);
EXPECT_EQ(3u, NumberOfCustomTrackers());
// All custom trackers are running. No reports.
EXPECT_EQ(0u, results.size());
// Tracker 2 is stopped and scheduled to terminate.
collection_.StopCustomSequence(2);
EXPECT_EQ(2u, NumberOfCustomTrackers());
// Tracker 2 has zero expected frames.
EXPECT_EQ(1u, results.size());
EXPECT_EQ(0u, results[2].frames_expected_v3);
// Simple sequence of one frame.
const char sequence[] = "b(1)e(1,0)P(1)";
GenerateSequence(sequence);
// Stop all custom trackers.
collection_.StopCustomSequence(1);
collection_.StopCustomSequence(3);
EXPECT_EQ(0u, NumberOfCustomTrackers());
// Tracker 1 and 3 and should report.
EXPECT_EQ(3u, results.size());
EXPECT_EQ(0u, results[1].frames_dropped_v3);
EXPECT_EQ(1u, results[1].frames_expected_v3);
EXPECT_EQ(0u, results[2].frames_dropped_v3);
EXPECT_EQ(0u, results[2].frames_expected_v3);
EXPECT_EQ(0u, results[3].frames_dropped_v3);
EXPECT_EQ(1u, results[3].frames_expected_v3);
}
TEST_F(FrameSequenceTrackerTest, CustomTrackerOutOfOrderFramesMissingV3Data) {
CustomTrackerResults results;
// Override the FrameSorter mock
FrameSorter frame_sorter;
compositor_frame_reporting_controller_->SetFrameSorter(&frame_sorter);
frame_sorter.AddObserver(this);
collection_.set_custom_tracker_results_added_callback(
base::BindLambdaForTesting([&](const CustomTrackerResults& reported) {
for (const auto& pair : reported) {
results[pair.first] = pair.second;
}
}));
// Start custom tracker 1.
collection_.StartCustomSequence(1);
EXPECT_EQ(1u, NumberOfCustomTrackers());
const uint64_t source = 1;
uint64_t sequence = 0;
// Dispatch 2 frames: frame 0 and frame 1.
auto frame0_args = CreateBeginFrameArgs(source, ++sequence);
DispatchCompleteFrame(frame0_args, kImplDamage | kMainDamage);
frame_sorter.AddNewFrame(frame0_args);
auto frame1_args = CreateBeginFrameArgs(source, ++sequence);
DispatchCompleteFrame(frame1_args, kImplDamage | kMainDamage);
frame_sorter.AddNewFrame(frame1_args);
// Frame 1 gets its result before frame 0.
FrameInfo frame_info;
frame_info.final_state = FrameInfo::FrameFinalState::kPresentedAll;
frame_info.smooth_thread = FrameInfo::SmoothThread::kSmoothMain;
frame_info.scroll_thread = FrameInfo::SmoothEffectDrivingThread::kMain;
frame_info.sequence_number = frame1_args.frame_id.sequence_number;
frame_sorter.AddFrameResult(frame1_args, frame_info);
// Stop the tracker.
collection_.StopCustomSequence(1);
// Frame 0 gets its result after tracker is stopped. FrameSorter flushes all
// frames and metrics for both frames should be recorded for v3.
frame_sorter.AddFrameResult(frame0_args, frame_info);
// Frame 2 is dispatched after the tracker is stopped and should be ignored.
auto frame2_args = CreateBeginFrameArgs(source, ++sequence);
DispatchCompleteFrame(frame2_args, kImplDamage | kMainDamage);
frame_sorter.AddNewFrame(frame2_args);
frame_sorter.AddFrameResult(frame2_args, frame_info);
// The upcoming call to ClearAll will destroy tracker_.
tracker_ = nullptr;
// Trigger metrics report.
collection_.ClearAll();
// There is one report for tracker id 1 and 2 expected frames (frame 0 and 1).
ASSERT_EQ(1u, results.size());
EXPECT_EQ(2u, results[1].frames_expected_v3);
}
TEST_F(FrameSequenceTrackerTest,
FrameTrackerSkippedFramesPreservesSmoothThread) {
const uint64_t source = 1;
uint64_t sequence = 0;
const uint64_t kNumFramesSkipped = 5;
sorter_.OnFirstContentfulPaintReceived();
// Expect that kNumFramesSkipped are backfilled with the appropriate smooth
// thread set.
EXPECT_CALL(sorter_, AddFrameResult(testing::_, testing::_))
.Times(kNumFramesSkipped)
.WillRepeatedly([=](const viz::BeginFrameArgs& args,
const FrameInfo& frame_info) {
EXPECT_EQ(frame_info.final_state, FrameInfo::FrameFinalState::kDropped);
EXPECT_EQ(frame_info.scroll_thread,
FrameInfo::SmoothEffectDrivingThread::kCompositor);
});
compositor_frame_reporting_controller_->SetFrameSequenceTrackerCollection(
&collection_);
auto frame0_args = CreateBeginFrameArgs(source, ++sequence);
compositor_frame_reporting_controller_->WillBeginImplFrame(frame0_args);
compositor_frame_reporting_controller_->OnFinishImplFrame(
frame0_args.frame_id);
// Starting frame 5 will trigger the callback expectation.
auto frame5_args =
CreateBeginFrameArgs(source, sequence + kNumFramesSkipped,
base::TimeTicks::Now() /*+ base::Seconds(5)*/);
compositor_frame_reporting_controller_->WillBeginImplFrame(frame5_args);
// Clear the expectation before simulating finishing the frame.
testing::Mock::VerifyAndClearExpectations(&sorter_);
compositor_frame_reporting_controller_->WillBeginMainFrame(frame5_args);
compositor_frame_reporting_controller_->NotifyReadyToCommit(nullptr);
compositor_frame_reporting_controller_->WillCommit();
compositor_frame_reporting_controller_->DidCommit();
compositor_frame_reporting_controller_->WillActivate();
compositor_frame_reporting_controller_->DidActivate();
SubmitInfo submit_info;
compositor_frame_reporting_controller_->DidSubmitCompositorFrame(
submit_info, frame5_args.frame_id, frame5_args.frame_id);
compositor_frame_reporting_controller_->OnFinishImplFrame(
frame5_args.frame_id);
viz::FrameTimingDetails ftd;
compositor_frame_reporting_controller_->DidPresentCompositorFrame(
submit_info.frame_token, ftd);
}
} // namespace cc
|