File: async_layer_tree_frame_sink_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (686 lines) | stat: -rw-r--r-- 28,037 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "cc/mojo_embedder/async_layer_tree_frame_sink.h"

#include <cstdint>
#include <memory>
#include <utility>

#include "base/feature_list.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/scoped_refptr.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_mock_time_task_runner.h"
#include "base/threading/thread.h"
#include "cc/base/features.h"
#include "cc/test/fake_layer_tree_frame_sink_client.h"
#include "components/viz/common/features.h"
#include "components/viz/common/frame_timing_details.h"
#include "components/viz/common/frame_timing_details_map.h"
#include "components/viz/common/performance_hint_utils.h"
#include "components/viz/common/quads/compositor_render_pass_draw_quad.h"
#include "components/viz/common/quads/solid_color_draw_quad.h"
#include "components/viz/common/quads/surface_draw_quad.h"
#include "components/viz/common/surfaces/surface_range.h"
#include "components/viz/test/begin_frame_args_test.h"
#include "components/viz/test/compositor_frame_helpers.h"
#include "components/viz/test/fake_delay_based_time_source.h"
#include "components/viz/test/test_context_provider.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "services/viz/public/mojom/compositing/compositor_frame_sink.mojom.h"
#include "services/viz/public/mojom/compositing/layer_context.mojom.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace cc {
namespace mojo_embedder {
namespace {

// Used to track the thread DidLoseLayerTreeFrameSink() is called on (and quit
// a RunLoop).
class ThreadTrackingLayerTreeFrameSinkClient
    : public FakeLayerTreeFrameSinkClient {
 public:
  ThreadTrackingLayerTreeFrameSinkClient(
      base::PlatformThreadId* called_thread_id,
      base::RunLoop* run_loop)
      : called_thread_id_(called_thread_id), run_loop_(run_loop) {}
  ThreadTrackingLayerTreeFrameSinkClient(
      const ThreadTrackingLayerTreeFrameSinkClient&) = delete;
  ~ThreadTrackingLayerTreeFrameSinkClient() override = default;

  ThreadTrackingLayerTreeFrameSinkClient& operator=(
      const ThreadTrackingLayerTreeFrameSinkClient&) = delete;

  // FakeLayerTreeFrameSinkClient:
  void DidLoseLayerTreeFrameSink() override {
    EXPECT_FALSE(did_lose_layer_tree_frame_sink_called());
    FakeLayerTreeFrameSinkClient::DidLoseLayerTreeFrameSink();
    *called_thread_id_ = base::PlatformThread::CurrentId();
    run_loop_->Quit();
  }

 private:
  raw_ptr<base::PlatformThreadId> called_thread_id_;
  raw_ptr<base::RunLoop> run_loop_;
};

TEST(AsyncLayerTreeFrameSinkTest,
     DidLoseLayerTreeFrameSinkCalledOnConnectionError) {
  base::Thread bg_thread("BG Thread");
  bg_thread.Start();

  scoped_refptr<viz::TestContextProvider> provider =
      viz::TestContextProvider::CreateRaster();

  mojo::PendingRemote<viz::mojom::CompositorFrameSink> sink_remote;
  mojo::PendingReceiver<viz::mojom::CompositorFrameSink> sink_receiver =
      sink_remote.InitWithNewPipeAndPassReceiver();
  mojo::PendingRemote<viz::mojom::CompositorFrameSinkClient> client;

  AsyncLayerTreeFrameSink::InitParams init_params;
  init_params.compositor_task_runner = bg_thread.task_runner();
  init_params.pipes.compositor_frame_sink_remote = std::move(sink_remote);
  init_params.pipes.client_receiver = client.InitWithNewPipeAndPassReceiver();
  auto layer_tree_frame_sink = std::make_unique<AsyncLayerTreeFrameSink>(
      std::move(provider), nullptr, /*shared_image_interface=*/nullptr,
      &init_params);

  base::PlatformThreadId called_thread_id = base::kInvalidThreadId;
  base::RunLoop close_run_loop;
  ThreadTrackingLayerTreeFrameSinkClient frame_sink_client(&called_thread_id,
                                                           &close_run_loop);

  auto bind_in_background =
      [](AsyncLayerTreeFrameSink* layer_tree_frame_sink,
         ThreadTrackingLayerTreeFrameSinkClient* frame_sink_client) {
        layer_tree_frame_sink->BindToClient(frame_sink_client);
      };
  bg_thread.task_runner()->PostTask(
      FROM_HERE, base::BindOnce(bind_in_background,
                                base::Unretained(layer_tree_frame_sink.get()),
                                base::Unretained(&frame_sink_client)));
  // Closes the pipe, which should trigger calling DidLoseLayerTreeFrameSink()
  // (and quitting the RunLoop). There is no need to wait for BindToClient()
  // to complete as mojo::Receiver error callbacks are processed asynchronously.
  sink_receiver.reset();
  close_run_loop.Run();

  EXPECT_NE(base::kInvalidThreadId, called_thread_id);
  EXPECT_EQ(called_thread_id, bg_thread.GetThreadId());

  // DetachFromClient() has to be called on the background thread.
  base::RunLoop detach_run_loop;
  auto detach_in_background =
      [](std::unique_ptr<AsyncLayerTreeFrameSink> layer_tree_frame_sink,
         base::RunLoop* detach_run_loop) {
        layer_tree_frame_sink->DetachFromClient();
        detach_run_loop->Quit();
      };
  bg_thread.task_runner()->PostTask(
      FROM_HERE,
      base::BindOnce(detach_in_background, std::move(layer_tree_frame_sink),
                     base::Unretained(&detach_run_loop)));
  detach_run_loop.Run();
}

// Used to track the client begin frame when connect/disconnect to Viz.
class BeginFrameTrackingLayerTreeFrameSinkClient
    : public FakeLayerTreeFrameSinkClient,
      public viz::BeginFrameObserverBase {
 public:
  BeginFrameTrackingLayerTreeFrameSinkClient() {}
  BeginFrameTrackingLayerTreeFrameSinkClient(
      const ThreadTrackingLayerTreeFrameSinkClient&) = delete;
  ~BeginFrameTrackingLayerTreeFrameSinkClient() override = default;

  BeginFrameTrackingLayerTreeFrameSinkClient& operator=(
      const BeginFrameTrackingLayerTreeFrameSinkClient&) = delete;

  void SetBeginFrameSource(viz::BeginFrameSource* source) override {
    if (begin_frame_source() && observing_begin_frame_) {
      begin_frame_source()->RemoveObserver(this);
    }
    FakeLayerTreeFrameSinkClient::SetBeginFrameSource(source);
    if (begin_frame_source() && observing_begin_frame_) {
      begin_frame_source()->AddObserver(this);
    }
  }

  void SetObservingBeginFrame(bool observing) {
    if (observing_begin_frame_ == observing) {
      return;
    }
    observing_begin_frame_ = observing;
    if (begin_frame_source()) {
      if (observing_begin_frame_) {
        begin_frame_source()->AddObserver(this);
      } else {
        begin_frame_source()->RemoveObserver(this);
      }
    }
  }

  void OnBeginFrameSourcePausedChanged(bool paused) override {}

  void DidPresentCompositorFrame(
      uint32_t frame_token,
      const viz::FrameTimingDetails& details) override {
    last_frame_token_ = frame_token;
  }

  uint32_t begin_frame_count() const { return begin_frame_count_; }
  uint32_t last_frame_token() const { return last_frame_token_; }

 private:
  bool OnBeginFrameDerivedImpl(const viz::BeginFrameArgs& args) override {
    begin_frame_count_++;
    return true;
  }
  uint32_t begin_frame_count_ = 0;
  uint32_t last_frame_token_ = 0;
  bool observing_begin_frame_ = true;
};

// A CompositorFrameSink for inspecting.
class MockCompositorFrameSink : public viz::mojom::CompositorFrameSink {
 public:
  MockCompositorFrameSink(
      mojo::PendingReceiver<viz::mojom::CompositorFrameSink> receiver,
      scoped_refptr<base::SequencedTaskRunner> task_runner) {
    receiver_.Bind(std::move(receiver), task_runner);
  }

  MockCompositorFrameSink(const MockCompositorFrameSink&) = delete;
  MockCompositorFrameSink& operator=(const MockCompositorFrameSink&) = delete;

  // viz::mojom::blink::CompositorFrameSink implementation
  MOCK_METHOD1(SetNeedsBeginFrame, void(bool));
  MOCK_METHOD0(SetWantsAnimateOnlyBeginFrames, void(void));
  MOCK_METHOD0(SetWantsBeginFrameAcks, void(void));
  MOCK_METHOD0(SetAutoNeedsBeginFrame, void(void));
  void SubmitCompositorFrame(
      const viz::LocalSurfaceId&,
      viz::CompositorFrame frame,
      std::optional<viz::HitTestRegionList> hit_test_region_list,
      uint64_t) override {}
  void SubmitCompositorFrameSync(
      const viz::LocalSurfaceId&,
      viz::CompositorFrame frame,
      std::optional<viz::HitTestRegionList> hit_test_region_list,
      uint64_t,
      SubmitCompositorFrameSyncCallback cb) override {
    std::move(cb).Run(std::vector<viz::ReturnedResource>());
  }
  MOCK_METHOD1(DidNotProduceFrame, void(const viz::BeginFrameAck&));
  MOCK_METHOD1(SetPreferredFrameInterval, void(base::TimeDelta));
  MOCK_METHOD2(BindLayerContext,
               void(viz::mojom::PendingLayerContextPtr, bool));
  MOCK_METHOD1(SetThreads, void(const std::vector<viz::Thread>&));
  MOCK_METHOD0(NotifyNewLocalSurfaceIdExpectedWhilePaused, void(void));

 private:
  mojo::Receiver<viz::mojom::CompositorFrameSink> receiver_{this};
};

}  // namespace

// Mocks DidPresentCompositorFrame class in order to test at what point
// in the frame lifecycle the method gets called.
class MockFakeLayerTreeFrameSinkClient : public FakeLayerTreeFrameSinkClient {
 public:
  MOCK_METHOD2(DidPresentCompositorFrame,
               void(uint32_t frame_token,
                    const viz::FrameTimingDetails& details));
};

// Boilerplate code for simple AsyncLayerTreeFrameSink. Friend of
// AsyncLayerTreeFrameSink.
class AsyncLayerTreeFrameSinkSimpleTest : public testing::TestWithParam<bool> {
 public:
  AsyncLayerTreeFrameSinkSimpleTest()
      : task_runner_(base::MakeRefCounted<base::TestMockTimeTaskRunner>(
            base::TestMockTimeTaskRunner::Type::kStandalone)),
        display_rect_(1, 1),
        layer_tree_frame_sink_client_(MockFakeLayerTreeFrameSinkClient()) {
    client_to_bind_ = &layer_tree_frame_sink_client_;
  }

  void SetUp() override {
    auto context_provider = viz::TestContextProvider::CreateRaster();

    mojo::PendingRemote<viz::mojom::CompositorFrameSink> sink_remote;
    mojo::PendingReceiver<viz::mojom::CompositorFrameSink> sink_receiver =
        sink_remote.InitWithNewPipeAndPassReceiver();
    mojo::PendingRemote<viz::mojom::CompositorFrameSinkClient> client;

    init_params_.compositor_task_runner = task_runner_;
    init_params_.pipes.compositor_frame_sink_remote = std::move(sink_remote);
    init_params_.pipes.client_receiver =
        client.InitWithNewPipeAndPassReceiver();

    layer_tree_frame_sink_ = std::make_unique<AsyncLayerTreeFrameSink>(
        std::move(context_provider), nullptr,
        /*shared_image_interface=*/nullptr, &init_params_);

    viz::LocalSurfaceId local_surface_id(1, base::UnguessableToken::Create());
    layer_tree_frame_sink_->SetLocalSurfaceId(local_surface_id);
    layer_tree_frame_sink_->BindToClient(client_to_bind_);

    client_remote_.Bind(std::move(client), task_runner_);
    mock_compositor_frame_sink_ = std::make_unique<MockCompositorFrameSink>(
        std::move(sink_receiver), task_runner_);
  }

  void SendRenderPassList(viz::CompositorRenderPassList* pass_list,
                          bool hit_test_data_changed) {
    auto frame = viz::CompositorFrameBuilder()
                     .SetRenderPassList(std::move(*pass_list))
                     .Build();
    pass_list->clear();
    layer_tree_frame_sink_->SubmitCompositorFrame(std::move(frame),
                                                  hit_test_data_changed);
  }

  void OnBeginFrame(const viz::BeginFrameArgs& args,
                    const viz::FrameTimingDetailsMap& timing_details,
                    std::vector<viz::ReturnedResource> resources) {
    layer_tree_frame_sink_->OnBeginFrame(args, timing_details,
                                         std::move(resources));
  }

  void DidNotProduceFrame(const viz::BeginFrameAck& ack,
                          FrameSkippedReason reason) {
    layer_tree_frame_sink_->DidNotProduceFrame(ack, reason);
  }

  void SubmitCompositorFrame(viz::CompositorFrame frame,
                             bool hit_test_data_changed) {
    layer_tree_frame_sink_->SubmitCompositorFrame(std::move(frame),
                                                  hit_test_data_changed);
  }

  void SetNeedsBeginFrame() {
    layer_tree_frame_sink_->OnNeedsBeginFrames(true);
  }

  const viz::HitTestRegionList& GetHitTestData() const {
    return layer_tree_frame_sink_->get_last_hit_test_data_for_testing();
  }

  AsyncLayerTreeFrameSink::InitParams init_params_;

  scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
  gfx::Rect display_rect_;
  std::unique_ptr<AsyncLayerTreeFrameSink> layer_tree_frame_sink_;
  MockFakeLayerTreeFrameSinkClient layer_tree_frame_sink_client_;
  raw_ptr<LayerTreeFrameSinkClient> client_to_bind_;
  mojo::Remote<viz::mojom::CompositorFrameSinkClient> client_remote_;
  std::unique_ptr<MockCompositorFrameSink> mock_compositor_frame_sink_;
};

TEST_F(AsyncLayerTreeFrameSinkSimpleTest, HitTestRegionListEmpty) {
  viz::CompositorRenderPassList pass_list;
  auto pass = viz::CompositorRenderPass::Create();
  pass->id = viz::CompositorRenderPassId{1};
  pass->output_rect = display_rect_;
  pass_list.push_back(std::move(pass));

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();

  EXPECT_TRUE(viz::HitTestRegionList::IsEqual(viz::HitTestRegionList(),
                                              GetHitTestData()));
}

TEST_F(AsyncLayerTreeFrameSinkSimpleTest, HitTestRegionListDuplicate) {
  viz::CompositorRenderPassList pass_list;
  // Initial submission.
  auto pass1 = viz::CompositorRenderPass::Create();
  pass1->id = viz::CompositorRenderPassId{1};
  pass1->output_rect = display_rect_;
  pass_list.push_back(std::move(pass1));

  viz::HitTestRegionList region_list1;
  region_list1.flags = viz::HitTestRegionFlags::kHitTestMine;
  region_list1.bounds.SetRect(0, 0, 1024, 768);
  layer_tree_frame_sink_client_.set_hit_test_region_list(region_list1);

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();
  const viz::HitTestRegionList hit_test_region_list = GetHitTestData();

  // Identical submission.
  auto pass2 = viz::CompositorRenderPass::Create();
  pass2->id = viz::CompositorRenderPassId{2};
  pass2->output_rect = display_rect_;
  pass_list.push_back(std::move(pass2));

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();

  EXPECT_TRUE(
      viz::HitTestRegionList::IsEqual(hit_test_region_list, GetHitTestData()));

  // Different submission.
  auto pass3 = viz::CompositorRenderPass::Create();
  pass3->id = viz::CompositorRenderPassId{3};
  pass3->output_rect = display_rect_;
  pass_list.push_back(std::move(pass3));

  viz::HitTestRegionList region_list2;
  region_list2.flags = viz::HitTestRegionFlags::kHitTestMine;
  region_list2.bounds.SetRect(0, 0, 800, 600);
  layer_tree_frame_sink_client_.set_hit_test_region_list(region_list2);

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();
  EXPECT_FALSE(
      viz::HitTestRegionList::IsEqual(hit_test_region_list, GetHitTestData()));
}

TEST_F(AsyncLayerTreeFrameSinkSimpleTest,
       HitTestRegionListDuplicateChangedFlip) {
  viz::CompositorRenderPassList pass_list;

  // Initial submission.
  auto pass1 = viz::CompositorRenderPass::Create();
  pass1->id = viz::CompositorRenderPassId{1};
  pass1->output_rect = display_rect_;
  pass_list.push_back(std::move(pass1));

  viz::HitTestRegionList region_list1;
  region_list1.flags = viz::HitTestRegionFlags::kHitTestMine;
  region_list1.bounds.SetRect(0, 0, 1024, 768);
  layer_tree_frame_sink_client_.set_hit_test_region_list(region_list1);

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();
  viz::HitTestRegionList hit_test_region_list = GetHitTestData();

  // Different submission with |hit_test_data_changed| set to true.
  auto pass2 = viz::CompositorRenderPass::Create();
  pass2->id = viz::CompositorRenderPassId{2};
  pass2->output_rect = display_rect_;
  pass_list.push_back(std::move(pass2));

  viz::HitTestRegionList region_list2;
  region_list2.flags = viz::HitTestRegionFlags::kHitTestMine;
  region_list2.bounds.SetRect(0, 0, 800, 600);
  layer_tree_frame_sink_client_.set_hit_test_region_list(region_list2);

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/true);
  task_runner_->RunUntilIdle();

  EXPECT_FALSE(
      viz::HitTestRegionList::IsEqual(hit_test_region_list, GetHitTestData()));
  hit_test_region_list = GetHitTestData();

  // Different submission with |hit_test_data_changed| set back to false. We
  // expect the hit-data to still have been sent.
  auto pass3 = viz::CompositorRenderPass::Create();
  pass3->id = viz::CompositorRenderPassId{3};
  pass3->output_rect = display_rect_;
  pass_list.push_back(std::move(pass3));

  viz::HitTestRegionList region_list3;
  region_list3.flags = viz::HitTestRegionFlags::kHitTestChildSurface;
  region_list3.bounds.SetRect(0, 0, 800, 600);
  layer_tree_frame_sink_client_.set_hit_test_region_list(region_list3);

  SendRenderPassList(&pass_list, /*hit_test_data_changed=*/false);
  task_runner_->RunUntilIdle();

  EXPECT_FALSE(
      viz::HitTestRegionList::IsEqual(hit_test_region_list, GetHitTestData()));
}

class AsyncLayerTreeFrameSinkMetricsRefactorTest
    : public AsyncLayerTreeFrameSinkSimpleTest {
 public:
  AsyncLayerTreeFrameSinkMetricsRefactorTest() {
    if (!GetParam()) {
      scoped_feature_list_.InitAndDisableFeature(
          features::kExportFrameTimingAfterFrameDone);
    }
  }
  ~AsyncLayerTreeFrameSinkMetricsRefactorTest() override = default;

  viz::BeginFrameArgs CreateAndDispatchNewBeginFrame() {
    viz::BeginFrameArgs args = viz::CreateBeginFrameArgsForTesting(
        BEGINFRAME_FROM_HERE, viz::BeginFrameArgs::kManualSourceId, 1,
        base::TimeTicks() + base::Milliseconds(1));
    viz::FrameTimingDetailsMap timing_details_map;
    viz::FrameTimingDetails timing_details;
    timing_details.presentation_feedback.timestamp = base::TimeTicks::Now();
    timing_details_map[++frame_token_] = timing_details;
    SetNeedsBeginFrame();
    OnBeginFrame(args, timing_details_map,
                 std::vector<viz::ReturnedResource>());
    return args;
  }

  base::test::ScopedFeatureList scoped_feature_list_;
  uint32_t frame_token_ = 0;
};

INSTANTIATE_TEST_SUITE_P(AsyncLayerTreeFrameSinkRefactorTest,
                         AsyncLayerTreeFrameSinkMetricsRefactorTest,
                         testing::Bool(),
                         [](auto& param) {
                           return (param.param) ? "MetricExportOnEndFrame"
                                                : "MetricExportOnBeginFrame";
                         });

TEST_P(AsyncLayerTreeFrameSinkMetricsRefactorTest, DroppedFrameExportsMetrics) {
  // Establish that DidPresentCompositorFrame should be called exactly once.
  EXPECT_CALL(layer_tree_frame_sink_client_,
              DidPresentCompositorFrame(testing::_, testing::_))
      .Times(GetParam() ? 0 : 1);

  // Simulate an OnBeginFrame call from viz.
  viz::BeginFrameArgs args = CreateAndDispatchNewBeginFrame();
  testing::Mock::VerifyAndClearExpectations(&layer_tree_frame_sink_client_);

  // Check that that either the OnBeginFrame call or the subsequent
  // DidNotProduceFrame call has exported timing metrics to the client,
  // depending on test params.
  if (GetParam()) {
    EXPECT_CALL(layer_tree_frame_sink_client_,
                DidPresentCompositorFrame(testing::_, testing::_))
        .Times(1);
    DidNotProduceFrame(viz::BeginFrameAck(args, false),
                       FrameSkippedReason::kDrawThrottled);
    testing::Mock::VerifyAndClearExpectations(&layer_tree_frame_sink_client_);
  }
}

TEST_P(AsyncLayerTreeFrameSinkMetricsRefactorTest, SubmitFrameExportsMetrics) {
  // Establish that DidPresentCompositorFrame should be called exactly once.
  EXPECT_CALL(layer_tree_frame_sink_client_,
              DidPresentCompositorFrame(testing::_, testing::_))
      .Times(GetParam() ? 0 : 1);

  // Simulate an OnBeginFrame call from viz.
  viz::BeginFrameArgs args = CreateAndDispatchNewBeginFrame();
  testing::Mock::VerifyAndClearExpectations(&layer_tree_frame_sink_client_);

  // Check that that either the OnBeginFrame call or the subsequent
  // SubmitCompositorFrame call has exported timing metrics to the client,
  // depending on test params.
  if (GetParam()) {
    EXPECT_CALL(layer_tree_frame_sink_client_,
                DidPresentCompositorFrame(testing::_, testing::_))
        .Times(1);
    // Valid frame requires a pass list.
    viz::CompositorRenderPassList pass_list;
    auto pass = viz::CompositorRenderPass::Create();
    pass->id = viz::CompositorRenderPassId{1};
    pass->output_rect = display_rect_;
    pass_list.push_back(std::move(pass));
    SubmitCompositorFrame(viz::CompositorFrameBuilder()
                              .SetRenderPassList(std::move(pass_list))
                              .Build(),
                          false);
    testing::Mock::VerifyAndClearExpectations(&layer_tree_frame_sink_client_);
  }
}

// Boilerplate code for begin frame test of AsyncLayerTreeFrameSink.
class AsyncLayerTreeFrameSinkBeginFrameTest
    : public AsyncLayerTreeFrameSinkSimpleTest {
 public:
  AsyncLayerTreeFrameSinkBeginFrameTest() {
    client_to_bind_ = &frame_tracking_client_;
  }

  void SetUp() override {
    init_params_.num_did_not_produce_frame_before_internal_begin_frame_source =
        1;
    init_params_.auto_needs_begin_frame = true;
    AsyncLayerTreeFrameSinkSimpleTest::SetUp();

    std::unique_ptr<viz::DelayBasedTimeSource> fake_source =
        std::make_unique<viz::FakeDelayBasedTimeSource>(
            task_runner_->GetMockTickClock(), task_runner_.get());
    layer_tree_frame_sink_->SetTimeSourceOfInternalBeginFrameForTesting(
        std::move(fake_source));
  }

  uint64_t last_received_begin_frame_sequence_number() const {
    return frame_tracking_client_.LastUsedBeginFrameArgs()
        .frame_id.sequence_number;
  }

  void SendCompositorFrame() {
    viz::CompositorRenderPassList pass_list;
    auto pass = viz::CompositorRenderPass::Create();
    pass->id = viz::CompositorRenderPassId{1};
    pass->output_rect = gfx::Rect(1, 1);
    pass_list.push_back(std::move(pass));
    viz::CompositorFrame frame = viz::CompositorFrameBuilder()
                                     .SetRenderPassList(std::move(pass_list))
                                     .Build();
    layer_tree_frame_sink_->SubmitCompositorFrame(std::move(frame), false);
  }

  BeginFrameTrackingLayerTreeFrameSinkClient frame_tracking_client_;
};

TEST_F(AsyncLayerTreeFrameSinkBeginFrameTest,
       OnBeginFrameFromVizWhenDisconnectForInternalBeginFrameSource) {
  // At the beginning, we have 1 internal begin frame and connect viz.
  // Then we have 4 begin frames from Viz(sequcence number 10, 11, 12, 13).
  // We will disconnect Viz after 1st frame and reconnect before the 3rd.
  // Vsync 0: internal frame (submit to connect)
  // Vsync 1: 1st viz frame (receive and didNotProduceFrame * 2 to disconnect)
  // Vsync 2: 2rd viz frame (skip when using internal frame)
  // Vsync 2: internal frame (submit to connect)
  // Vsync 2: 3rd viz frame (drop within last vsync interval)
  // Vsync 3: 4th viz frame (receive)
  base::TimeTicks start_time = task_runner_->NowTicks();
  viz::BeginFrameArgs args1 = viz::CreateBeginFrameArgsForTesting(
      BEGINFRAME_FROM_HERE, 0, 10,
      start_time + viz::BeginFrameArgs::DefaultInterval());
  viz::BeginFrameArgs args2 = viz::CreateBeginFrameArgsForTesting(
      BEGINFRAME_FROM_HERE, 0, 11,
      start_time + viz::BeginFrameArgs::DefaultInterval() * 2);
  viz::BeginFrameArgs args3 = viz::CreateBeginFrameArgsForTesting(
      BEGINFRAME_FROM_HERE, 0, 12,
      start_time + viz::BeginFrameArgs::DefaultInterval() * 2);
  viz::BeginFrameArgs args4 = viz::CreateBeginFrameArgsForTesting(
      BEGINFRAME_FROM_HERE, 0, 13,
      start_time + viz::BeginFrameArgs::DefaultInterval() * 3);

  viz::FrameTimingDetailsMap empty_details;
  viz::FrameTimingDetailsMap test_details;
  uint32_t frame_token = 1;
  test_details.emplace(frame_token, viz::FrameTimingDetails());
  uint64_t internal_sequence = 1;

  // Start with 1 internal begin frame.
  task_runner_->RunUntilIdle();
  EXPECT_TRUE(
      layer_tree_frame_sink_->use_internal_begin_frame_source_for_testing());
  if (!base::FeatureList::IsEnabled(features::kNoLateBeginFrames)) {
    EXPECT_EQ(internal_sequence, last_received_begin_frame_sequence_number());
  }

  SendCompositorFrame();
  task_runner_->FastForwardBy(viz::BeginFrameArgs::DefaultInterval());
  internal_sequence++;

  // Connected after first compositor frame.
  EXPECT_FALSE(
      layer_tree_frame_sink_->use_internal_begin_frame_source_for_testing());
  client_remote_->OnBeginFrame(args1, empty_details,
                               std::vector<viz::ReturnedResource>());
  task_runner_->RunUntilIdle();
  // Client should receive 1st viz begin frame.
  EXPECT_EQ(args1.frame_id.sequence_number,
            last_received_begin_frame_sequence_number());

  // Will disconnect after 2 DidNotProduceFrame, since here init with
  // num_did_not_produce_frame_before_internal_begin_frame_source = 1.
  layer_tree_frame_sink_->DidNotProduceFrame(viz::BeginFrameAck(args1, false),
                                             FrameSkippedReason::kNoDamage);
  layer_tree_frame_sink_->DidNotProduceFrame(viz::BeginFrameAck(args1, false),
                                             FrameSkippedReason::kNoDamage);
  task_runner_->RunUntilIdle();
  EXPECT_TRUE(
      layer_tree_frame_sink_->use_internal_begin_frame_source_for_testing());

  client_remote_->OnBeginFrame(args2, test_details,
                               std::vector<viz::ReturnedResource>());
  task_runner_->RunUntilIdle();
  // Proceed timing details.
  EXPECT_EQ(frame_tracking_client_.last_frame_token(), frame_token);
  // Client won't receive 2nd begin frame.
  EXPECT_NE(args2.frame_id.sequence_number,
            last_received_begin_frame_sequence_number());

  // Internal begin frame source should generate begin frame after disconnect.
  task_runner_->FastForwardBy(viz::BeginFrameArgs::DefaultInterval());
  internal_sequence++;
  // Client should receive begin frame from internal begin frame source.
  EXPECT_EQ(internal_sequence, last_received_begin_frame_sequence_number());

  // Connect after SubmitCompositorFrame before 3rd viz begin frame.
  SendCompositorFrame();
  task_runner_->RunUntilIdle();
  EXPECT_FALSE(
      layer_tree_frame_sink_->use_internal_begin_frame_source_for_testing());

  // Should drop 3rd begin frame within last internal begin frame's interval.
  EXPECT_CALL(*mock_compositor_frame_sink_,
              DidNotProduceFrame(viz::BeginFrameAck(args3, false)));
  client_remote_->OnBeginFrame(args3, empty_details,
                               std::vector<viz::ReturnedResource>());
  task_runner_->RunUntilIdle();
  EXPECT_EQ(
      internal_sequence,
      frame_tracking_client_.LastUsedBeginFrameArgs().frame_id.sequence_number);

  // 4th viz begin frame.
  task_runner_->FastForwardBy(viz::BeginFrameArgs::DefaultInterval());
  client_remote_->OnBeginFrame(args4, empty_details,
                               std::vector<viz::ReturnedResource>());
  task_runner_->RunUntilIdle();
  // Client should receive 4th begin frame.
  EXPECT_EQ(args4.frame_id.sequence_number,
            last_received_begin_frame_sequence_number());
  // Receive 2 from internal and 2 from viz.
  EXPECT_EQ(
      base::FeatureList::IsEnabled(features::kNoLateBeginFrames) ? 3u : 4u,
      frame_tracking_client_.begin_frame_count());
  layer_tree_frame_sink_->DetachFromClient();
}

}  // namespace mojo_embedder
}  // namespace cc