1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/trees/presentation_time_callback_buffer.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
std::vector<cc::PresentationTimeCallbackBuffer::Callback> GenerateCallbacks(
int num_callbacks) {
std::vector<cc::PresentationTimeCallbackBuffer::Callback> result;
while (num_callbacks-- > 0) {
// `PresentationTimeCallbackBuffer` isn't supposed to invoke any callbacks.
// We can check for that by passing callbacks which cause test failure.
result.push_back(base::BindOnce([](const gfx::PresentationFeedback&) {
FAIL() << "Callbacks should not be directly invoked by "
"PresentationTimeCallbackBuffer";
}));
}
return result;
}
std::vector<cc::PresentationTimeCallbackBuffer::SuccessfulCallback>
GenerateSuccessfulCallbacks(int num_callbacks) {
std::vector<cc::PresentationTimeCallbackBuffer::SuccessfulCallback> result;
while (num_callbacks-- > 0) {
// `PresentationTimeCallbackBuffer` isn't supposed to invoke any callbacks.
// We can check for that by passing callbacks which cause test failure.
result.push_back(base::BindOnce([](base::TimeTicks presentation_timestamp) {
FAIL() << "Callbacks should not be directly invoked by "
"PresentationTimeCallbackBuffer";
}));
}
return result;
}
std::vector<cc::PresentationTimeCallbackBuffer::SuccessfulCallbackWithDetails>
GenerateSuccessfulCallbackWithDetails(int num_callbacks) {
std::vector<cc::PresentationTimeCallbackBuffer::SuccessfulCallbackWithDetails>
result;
while (num_callbacks-- > 0) {
// `PresentationTimeCallbackBuffer` isn't supposed to invoke any callbacks.
// We can check for that by passing callbacks which cause test failure.
result.push_back(base::BindOnce([](const viz::FrameTimingDetails& details) {
FAIL() << "Callbacks should not be directly invoked by "
"PresentationTimeCallbackBuffer";
}));
}
return result;
}
constexpr uint32_t kFrameToken1 = 234;
constexpr uint32_t kFrameToken2 = 345;
constexpr uint32_t kFrameToken3 = 456;
constexpr uint32_t kFrameToken4 = 567;
} // namespace
namespace cc {
TEST(PresentationTimeCallbackBufferTest, TestNoCallbacks) {
PresentationTimeCallbackBuffer buffer;
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
TEST(PresentationTimeCallbackBufferTest, TestMainThreadCallbackOnSuccess) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterMainThreadCallbacks(kFrameToken2, GenerateCallbacks(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is returned on a successful presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_EQ(result.main_callbacks.size(), 1ull);
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure that the buffer has removed the registration since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest, TestMainThreadCallbackOnFailure) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterMainThreadCallbacks(kFrameToken2, GenerateCallbacks(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is returned on a failed presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/true);
EXPECT_EQ(result.main_callbacks.size(), 1ull);
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure that the buffer has removed the registration since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest, TestMainThreadSuccessfulCallback) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterMainThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbackWithDetails(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is not returned on a failed presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/true);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is returned on a successful presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_EQ(result.main_successful_callbacks.size(), 1ull);
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure that the buffer has removed the registration since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest,
TestCompositorThreadSuccessfulCallback) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterCompositorThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbacks(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is not returned on a failed presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/true);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure the callback is returned on a successful presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_EQ(result.compositor_successful_callbacks.size(), 1ull);
}
// Make sure that the buffer has removed the registration since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest, TestMixedCallbacksOnSuccess) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterMainThreadCallbacks(kFrameToken2, GenerateCallbacks(1));
buffer.RegisterMainThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbackWithDetails(1));
buffer.RegisterCompositorThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbacks(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure all callbacks are returned on a successful presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_EQ(result.main_callbacks.size(), 1ull);
EXPECT_EQ(result.main_successful_callbacks.size(), 1ull);
EXPECT_EQ(result.compositor_successful_callbacks.size(), 1ull);
}
// Make sure that the buffer has removed the registrations since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest, TestMixedCallbacksOnFailure) {
PresentationTimeCallbackBuffer buffer;
buffer.RegisterMainThreadCallbacks(kFrameToken2, GenerateCallbacks(1));
buffer.RegisterMainThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbackWithDetails(1));
buffer.RegisterCompositorThreadSuccessfulCallbacks(
kFrameToken2, GenerateSuccessfulCallbacks(1));
// Make sure that popping early frame tokens doesn't return irrelevant
// entries.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken1, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure only feedback callbacks are returned on a failed presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/true);
EXPECT_EQ(result.main_callbacks.size(), 1ull);
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
// Make sure time callbacks are returned on a successful presentation.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_EQ(result.main_successful_callbacks.size(), 1ull);
EXPECT_EQ(result.compositor_successful_callbacks.size(), 1ull);
}
// Make sure that the buffer has removed the registrations since the "pop".
{
auto result =
buffer.PopPendingCallbacks(kFrameToken2, /*presentation_failed=*/false);
EXPECT_TRUE(result.main_callbacks.empty());
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
TEST(PresentationTimeCallbackBufferTest, TestCallbackBatching) {
PresentationTimeCallbackBuffer buffer;
// Register one callback for frame1, two for frame2 and two for frame4.
buffer.RegisterMainThreadCallbacks(kFrameToken1, GenerateCallbacks(1));
buffer.RegisterMainThreadCallbacks(kFrameToken2, GenerateCallbacks(2));
buffer.RegisterMainThreadCallbacks(kFrameToken4, GenerateCallbacks(2));
// Pop callbacks up to and including frame3. Should be three in total; one
// from frame1 and two from frame2.
{
auto result =
buffer.PopPendingCallbacks(kFrameToken3, /*presentation_failed=*/false);
EXPECT_EQ(result.main_callbacks.size(), 3ull);
EXPECT_TRUE(result.main_successful_callbacks.empty());
EXPECT_TRUE(result.compositor_successful_callbacks.empty());
}
}
} // namespace cc
|
