1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/prefs/pref_service.h"
#include "content/public/test/browser_test.h"
#include "ui/native_theme/native_theme.h"
class PageColorsBrowserTest : public InProcessBrowserTest {
public:
PageColorsBrowserTest() = default;
PageColorsBrowserTest(const PageColorsBrowserTest&) = delete;
PageColorsBrowserTest& operator=(const PageColorsBrowserTest&) = delete;
};
// Changing the kPageColors pref should affect the state of Page Colors in the
// NativeTheme.
IN_PROC_BROWSER_TEST_F(PageColorsBrowserTest, PageColorsPrefChange) {
ui::NativeTheme::PageColors page_colors_pref =
static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
auto* native_theme = ui::NativeTheme::GetInstanceForNativeUi();
ui::NativeTheme::PageColors page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_state, page_colors_pref);
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kDusk);
#if BUILDFLAG(IS_WIN)
// On Windows, `kApplyPageColorsOnlyOnIncreasedContrast` is initially true, so
// we enable forced colors and increased contrast to test this feature. If we
// did this on other OSes, we would lose test coverage because page colors are
// applied even when forced colors is off, which we want to verify.
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
#endif
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_state, ui::NativeTheme::PageColors::kDusk);
}
// TODO(crbug.com/40779801): This test is failing on ChromeOS - appears to be a
// result of MultiDeviceSetupClientHolder leading to multiple Prefs getting
// created. May need to look into TestingProfile.
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_PageColorsCalculationWithIncreasedContrastToggle \
DISABLED_PageColorsCalculationWithIncreasedContrastToggle
#else
#define MAYBE_PageColorsCalculationWithIncreasedContrastToggle \
PageColorsCalculationWithIncreasedContrastToggle
#endif // BUILDFLAG(IS_CHROMEOS)
// When `kApplyPageColorsOnlyOnIncreasedContrast` is true but the OS is not in
// increased contrast, the page colors pref shouldn't be honored.
IN_PROC_BROWSER_TEST_F(PageColorsBrowserTest,
MAYBE_PageColorsCalculationWithIncreasedContrastToggle) {
auto* native_theme = ui::NativeTheme::GetInstanceForNativeUi();
ui::NativeTheme::PageColors page_colors_pref =
static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
// Should not honor the page colors pref if
// `kApplyPageColorsOnlyOnIncreasedContrast` is true and we're not in
// increased contrast.
native_theme->SetPreferredContrast(
ui::NativeTheme::PreferredContrast::kNoPreference);
EXPECT_FALSE(native_theme->UserHasContrastPreference());
browser()->profile()->GetPrefs()->SetBoolean(
prefs::kApplyPageColorsOnlyOnIncreasedContrast, true);
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kDusk);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
ui::NativeTheme::PageColors page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kDusk);
EXPECT_EQ(page_colors_state, ui::NativeTheme::PageColors::kOff);
// Page colors should be honored when
// `kApplyPageColorsOnlyOnIncreasedContrast` is true and we're in an increased
// contrast.
#if BUILDFLAG(IS_WIN)
native_theme->set_forced_colors(true);
#endif
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
native_theme->NotifyOnNativeThemeUpdated();
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, page_colors_state);
// Switching increased contrast back off should lead to us not honoring page
// colors since `kApplyPageColorsOnlyOnIncreasedContrast` is still true.
#if BUILDFLAG(IS_WIN)
native_theme->set_forced_colors(false);
#endif
native_theme->SetPreferredContrast(
ui::NativeTheme::PreferredContrast::kNoPreference);
native_theme->NotifyOnNativeThemeUpdated();
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kDusk);
EXPECT_EQ(page_colors_state, ui::NativeTheme::PageColors::kOff);
// Setting `kApplyPageColorsOnlyOnIncreasedContrast` to false should lead to
// us honoring page colors.
browser()->profile()->GetPrefs()->SetBoolean(
prefs::kApplyPageColorsOnlyOnIncreasedContrast, false);
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, page_colors_state);
}
#if BUILDFLAG(IS_WIN)
// Test default behaviour only for Windows when High Contrast gets switched
// on and page colors 'Off'. Default should be High contrast initially, unless
// the user changes it to 'Off' while in a HC state.
IN_PROC_BROWSER_TEST_F(PageColorsBrowserTest, PageColorsWithHighContrast) {
// Initially, expect kIsDefaultPageColorsOnHighContrast to be true.
ui::NativeTheme::PageColors page_colors_pref =
static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
auto* native_theme = ui::NativeTheme::GetInstanceForNativeUi();
auto* native_theme_web = ui::NativeTheme::GetInstanceForWeb();
ui::NativeTheme::PageColors page_colors_state = native_theme->GetPageColors();
bool is_default_page_colors_on_high_contrast =
browser()->profile()->GetPrefs()->GetBoolean(
prefs::kIsDefaultPageColorsOnHighContrast);
EXPECT_EQ(page_colors_state, page_colors_pref);
EXPECT_TRUE(is_default_page_colors_on_high_contrast);
// When the OS High Contrast is turned on and Page Colors is 'Off', the used
// Page Colors should be 'High Contrast'.
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
is_default_page_colors_on_high_contrast =
browser()->profile()->GetPrefs()->GetBoolean(
prefs::kIsDefaultPageColorsOnHighContrast);
EXPECT_TRUE(is_default_page_colors_on_high_contrast);
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kHighContrast);
EXPECT_EQ(page_colors_state, page_colors_pref);
// When the OS High Contrast is turned off and Page Colors is 'High Contrast',
// the used Page Colors should be 'Off'.
native_theme->set_forced_colors(false);
native_theme->SetPreferredContrast(
ui::NativeTheme::PreferredContrast::kNoPreference);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
is_default_page_colors_on_high_contrast =
browser()->profile()->GetPrefs()->GetBoolean(
prefs::kIsDefaultPageColorsOnHighContrast);
EXPECT_TRUE(is_default_page_colors_on_high_contrast);
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kOff);
EXPECT_EQ(page_colors_state, page_colors_pref);
// When `kPageColors` is 'Off' while High Contrast is on,
// `kIsDefaultPageColorsOnHighContrast` should be false and forced_colors for
// the NativeTheme web instance should be false (i.e. page colors supersedes
// OS for web content).
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kOff);
is_default_page_colors_on_high_contrast =
browser()->profile()->GetPrefs()->GetBoolean(
prefs::kIsDefaultPageColorsOnHighContrast);
EXPECT_FALSE(is_default_page_colors_on_high_contrast);
EXPECT_FALSE(native_theme_web->InForcedColorsMode());
native_theme->set_forced_colors(false);
native_theme->SetPreferredContrast(
ui::NativeTheme::PreferredContrast::kNoPreference);
// When the OS High Contrast is turned on next, and Page Colors is 'Off', the
// used Page Colors should remain 'Off' since
// `kIsDefaultPageColorsOnHighContrast` is false.
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
EXPECT_FALSE(native_theme_web->InForcedColorsMode());
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kOff);
EXPECT_EQ(page_colors_state, page_colors_pref);
}
#endif // BUILDFLAG(IS_WIN)
// When Page colors is changed, the states such as `forced_colors`,
// `should_use_dark_colors`, `preferred_color_scheme` and `preferred_contrast`
// for the NativeTheme web instance should be updated appropriately.
IN_PROC_BROWSER_TEST_F(PageColorsBrowserTest, PageColorsWithNativeTheme) {
// Initially expect Page colors to be 'Off', forced colors to be false, uses
// dark colors to be false and preferred contrast to be kNoPreference.
ui::NativeTheme::PageColors page_colors_pref =
static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
auto* native_theme = ui::NativeTheme::GetInstanceForNativeUi();
auto* native_theme_web = ui::NativeTheme::GetInstanceForWeb();
native_theme_web->set_forced_colors(false);
native_theme_web->set_use_dark_colors(false);
native_theme_web->SetPreferredContrast(
ui::NativeTheme::PreferredContrast::kNoPreference);
ui::NativeTheme::PageColors page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kOff);
EXPECT_EQ(page_colors_pref, page_colors_state);
EXPECT_FALSE(native_theme_web->InForcedColorsMode());
EXPECT_FALSE(native_theme_web->ShouldUseDarkColors());
EXPECT_FALSE(native_theme_web->UserHasContrastPreference());
// Setting Page colors to 'kHighContrast' while forced colors is false should
// not affect any state.
browser()->profile()->GetPrefs()->SetBoolean(
prefs::kApplyPageColorsOnlyOnIncreasedContrast, false);
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kHighContrast);
EXPECT_FALSE(native_theme_web->InForcedColorsMode());
EXPECT_FALSE(native_theme_web->UserHasContrastPreference());
#if BUILDFLAG(IS_WIN)
// On Windows, `kApplyPageColorsOnlyOnIncreasedContrast` is initially true, so
// we enable forced colors and increased contrast to test this feature. If we
// did this on other OSes, we would lose test coverage because page colors are
// applied even when forced colors is off, which we want to verify.
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
#endif
// Changing Page colors to a dark theme (e.g. 'Dusk') should make forced
// colors to be true, uses dark colors to be true, contrast preference to be
// 'kMore' for the native theme web instance.
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kDusk);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kDusk);
EXPECT_EQ(page_colors_pref, page_colors_state);
EXPECT_TRUE(native_theme_web->InForcedColorsMode());
EXPECT_TRUE(native_theme_web->ShouldUseDarkColors());
EXPECT_TRUE(native_theme_web->UserHasContrastPreference());
// Changing Page colors to be a light theme (e.g. 'White') should make forced
// colors to be true, uses dark colors to be false, contrast preference to be
// 'kMore' for the native theme web instance.
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kWhite);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kWhite);
EXPECT_EQ(page_colors_pref, page_colors_state);
EXPECT_TRUE(native_theme_web->InForcedColorsMode());
EXPECT_FALSE(native_theme_web->ShouldUseDarkColors());
EXPECT_TRUE(native_theme_web->UserHasContrastPreference());
// Setting Page colors to 'Off' while in an increased contrast state should
// make the native theme instance for web's forced colors to be false,
// contrast preference to be 'kNone', and uses dark colors to be same with the
// native theme instance for ui.
native_theme->set_forced_colors(true);
native_theme->SetPreferredContrast(ui::NativeTheme::PreferredContrast::kMore);
browser()->profile()->GetPrefs()->SetInteger(
prefs::kPageColors, ui::NativeTheme::PageColors::kOff);
page_colors_pref = static_cast<ui::NativeTheme::PageColors>(
browser()->profile()->GetPrefs()->GetInteger(prefs::kPageColors));
page_colors_state = native_theme->GetPageColors();
EXPECT_EQ(page_colors_pref, ui::NativeTheme::PageColors::kOff);
EXPECT_EQ(page_colors_pref, page_colors_state);
EXPECT_FALSE(native_theme_web->InForcedColorsMode());
EXPECT_FALSE(native_theme_web->UserHasContrastPreference());
EXPECT_EQ(native_theme_web->ShouldUseDarkColors(),
native_theme->ShouldUseDarkColors());
// Changing the color scheme for native theme ui while Page colors is 'Off'
// and increased contrast is on should be respected and reflected in the
// native theme instance for web.
native_theme->set_preferred_color_scheme(
ui::NativeTheme::PreferredColorScheme::kDark);
native_theme->NotifyOnNativeThemeUpdated();
EXPECT_EQ(native_theme_web->GetPreferredColorScheme(),
ui::NativeTheme::PreferredColorScheme::kDark);
}
|
