1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/apps/link_capturing/link_capturing_navigation_throttle.h"
#include "base/strings/strcat.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "chrome/browser/apps/app_service/app_registry_cache_waiter.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/web_applications/os_integration/os_integration_manager.h"
#include "chrome/browser/web_applications/test/os_integration_test_override_impl.h"
#include "chrome/browser/web_applications/test/web_app_test_observers.h"
#include "chrome/browser/web_applications/web_app_tab_helper.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_features.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
#include "third_party/blink/public/common/switches.h"
#include "url/url_constants.h"
namespace apps {
namespace {
enum class NavCaptureVersion { kV1, kV2 };
std::string NavCaptureVersionToString(
const testing::TestParamInfo<NavCaptureVersion>& version) {
switch (version.param) {
case NavCaptureVersion::kV1:
return "V1";
case NavCaptureVersion::kV2:
return "V2";
}
}
// TODO(https://issues.chromium.org/329174385): Test more end-to-end the state
// of browser tabs rather than relying on testing callbacks, this requires
// resolving flakiness with awaiting web app launches.
class LinkCapturingNavigationThrottleBrowserTest
: public InProcessBrowserTest,
public testing::WithParamInterface<NavCaptureVersion> {
public:
LinkCapturingNavigationThrottleBrowserTest() {
feature_list_.InitWithFeaturesAndParameters(
/*enabled_features=*/{base::test::FeatureRefAndParams(
features::kPwaNavigationCapturing,
{{"link_capturing_state",
IsV1() ? "on_by_default" : "reimpl_default_on"}})},
/*disabled_features=*/{});
}
bool IsV1() { return GetParam() == NavCaptureVersion::kV1; }
void SetUpOnMainThread() override {
#if (BUILDFLAG(IS_LINUX) && defined(MEMORY_SANITIZER)) || BUILDFLAG(IS_MAC) || \
(BUILDFLAG(IS_WIN) && defined(ADDRESS_SANITIZER))
// TODO(https://issues.chromium.org/329174385): Deflake tests in
// Linux MSan Tests / Mac Tests / Win ASan Tests.
GTEST_SKIP();
#else
InProcessBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
// Set up web app as link capturing target.
start_url_ = embedded_test_server()->GetURL("/web_apps/basic.html");
app_id_ =
web_app::InstallWebAppFromPageAndCloseAppBrowser(browser(), start_url_);
apps::AppReadinessWaiter(browser()->profile(), app_id_).Await();
ASSERT_TRUE(test::EnableLinkCapturingByUser(browser()->profile(), app_id_)
.has_value());
// Set up simple page browser tab with a "fill-page" CSS class available for
// tests to use. This class makes elements fill the page making it easy to
// click on.
simple_url_ = embedded_test_server()->GetURL("/simple.html");
ASSERT_TRUE(content::NavigateToURL(GetBrowserTab(), simple_url_));
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), R"(
const style = document.createElement('style');
style.textContent = `
.fill-page {
position: absolute;
left: 0;
top: 0;
width: 100vw;
height: 100vh;
}
`;
document.head.append(style);
)"));
#endif
}
void SetUpDefaultCommandLine(base::CommandLine* command_line) override {
InProcessBrowserTest::SetUpDefaultCommandLine(command_line);
command_line->AppendSwitch(blink::switches::kAllowPreCommitInput);
}
content::WebContents* GetBrowserTab() {
return browser()->tab_strip_model()->GetWebContentsAt(0);
}
content::WebContents* ClickPageAndWaitForStartUrlLoad() {
test::NavigationCommittedForUrlObserver load_observer(start_url_);
content::SimulateMouseClick(GetBrowserTab(), /*modifiers=*/0,
blink::WebMouseEvent::Button::kLeft);
load_observer.Wait();
return load_observer.web_contents();
}
protected:
GURL simple_url_;
GURL start_url_;
webapps::AppId app_id_;
base::test::ScopedFeatureList feature_list_;
web_app::OsIntegrationTestOverrideBlockingRegistration faked_os_integration_;
};
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByAHrefClick) {
// Insert an <a href> link to click on.
std::string script = base::StringPrintf(
R"(
const link = document.createElement('a');
link.className = 'fill-page';
link.href = '%s';
document.body.append(link);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByAHrefClickTargetBlank) {
// Insert an <a href target="_blank"> link to click on.
std::string script = base::StringPrintf(
R"(
const link = document.createElement('a');
link.className = 'fill-page';
link.href = '%s';
link.target = '_blank';
document.body.append(link);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
EXPECT_TRUE(web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByAHrefClickServerRedirect) {
// Insert an <a href> server redirect link to click on.
std::string script = base::StringPrintf(
R"(
const link = document.createElement('a');
link.className = 'fill-page';
link.href = '%s';
document.body.append(link);
)",
embedded_test_server()
->GetURL("/server-redirect?" + start_url_.spec())
.spec()
.c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
bool expected_open_in_pwa_window = IsV1();
ASSERT_TRUE(loaded_contents);
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByAHrefClickTargetBlankServerRedirect) {
// Insert an <a href target="_blank"> server redirect link to click on.
std::string script = base::StringPrintf(
R"(
const link = document.createElement('a');
link.className = 'fill-page';
link.href = '%s';
link.target = '_blank';
document.body.append(link);
)",
embedded_test_server()
->GetURL("/server-redirect?" + start_url_.spec())
.spec()
.c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
EXPECT_TRUE(web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByAHrefClickTargetBlankJavaScriptRedirect) {
// Insert an <a href target="_blank"> JavaScript redirect link to click on.
std::string script = base::StringPrintf(
R"(
const link = document.createElement('a');
link.className = 'fill-page';
link.href = '/navigate_to.html?%s';
link.target = '_blank';
document.body.append(link);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByButtonClickJavaScriptWindowOpen) {
// Insert a window.open(url) button to click on.
std::string script = base::StringPrintf(
R"(
const button = document.createElement('button');
button.className = 'fill-page';
button.addEventListener('click', event => {
window.open('%s');
});
document.body.append(button);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(
LinkCapturingNavigationThrottleBrowserTest,
TriggeredByButtonClickJavaScriptWindowOpenAboutBlankLocationHrefUrl) {
// Insert a window.open('about:blank').location.href = url button to click on.
std::string script = base::StringPrintf(
R"(
const button = document.createElement('button');
button.className = 'fill-page';
button.addEventListener('click', event => {
window.open('about:blank').location.href = '%s';
});
document.body.append(button);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByButtonClickJavaScriptLocationHrefUrl) {
// Insert a location.href = url button to click on.
std::string script = base::StringPrintf(
R"(
const button = document.createElement('button');
button.className = 'fill-page';
button.addEventListener('click', event => {
location.href = '%s';
});
document.body.append(button);
)",
start_url_.spec().c_str());
ASSERT_TRUE(content::ExecJs(GetBrowserTab(), script));
content::WebContents* loaded_contents = ClickPageAndWaitForStartUrlLoad();
ASSERT_TRUE(loaded_contents);
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(loaded_contents)
->is_in_app_window());
}
IN_PROC_BROWSER_TEST_P(LinkCapturingNavigationThrottleBrowserTest,
TriggeredByNoClickJavaScriptWindowOpen) {
ui_test_utils::UrlLoadObserver load_observer(start_url_);
ASSERT_TRUE(content::ExecJs(
GetBrowserTab(),
base::StringPrintf("window.open('%s')", start_url_.spec().c_str())));
load_observer.Wait();
ASSERT_TRUE(load_observer.web_contents());
bool expected_open_in_pwa_window = IsV1();
EXPECT_EQ(
expected_open_in_pwa_window,
web_app::WebAppTabHelper::FromWebContents(load_observer.web_contents())
->is_in_app_window());
}
INSTANTIATE_TEST_SUITE_P(,
LinkCapturingNavigationThrottleBrowserTest,
testing::Values(NavCaptureVersion::kV1,
NavCaptureVersion::kV2),
NavCaptureVersionToString);
} // namespace
} // namespace apps
|
