1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/child_accounts/family_user_app_metrics.h"
#include <memory>
#include <vector>
#include "base/files/file_path.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
#include "chrome/browser/apps/app_service/app_service_test.h"
#include "chrome/browser/extensions/extension_service_test_with_install.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/supervised_user/supervised_user_extensions_delegate_impl.h"
#include "chrome/browser/supervised_user/supervised_user_test_util.h"
#include "components/services/app_service/public/cpp/app_types.h"
#include "components/services/app_service/public/cpp/instance.h"
#include "components/services/app_service/public/cpp/instance_registry.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/api/management/management_api.h"
#include "extensions/browser/supervised_user_extensions_delegate.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/manifest.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/window.h"
#include "ui/compositor/layer_type.h"
namespace ash {
namespace {
constexpr base::TimeDelta kOneDay = base::Days(1);
constexpr char kStartTime[] = "1 Jan 2020 21:15";
apps::AppPtr MakeApp(const char* app_id,
const char* name,
base::Time last_launch_time,
apps::AppType app_type) {
apps::AppPtr app = std::make_unique<apps::App>(app_type, app_id);
app->name = name;
app->last_launch_time = last_launch_time;
return app;
}
// Safer cast to AppType from an integer.
// Casiting an invalid value (such as removed value) will return std::nullopt.
inline constexpr std::optional<apps::AppType> ToAppType(int value) {
switch (auto app_type = static_cast<apps::AppType>(value); app_type) {
case apps::AppType::kUnknown:
case apps::AppType::kArc:
case apps::AppType::kCrostini:
case apps::AppType::kChromeApp:
case apps::AppType::kWeb:
case apps::AppType::kPluginVm:
case apps::AppType::kRemote:
case apps::AppType::kBorealis:
case apps::AppType::kSystemWeb:
case apps::AppType::kExtension:
case apps::AppType::kBruschetta:
return app_type;
}
return std::nullopt;
}
// Holds all valid AppType values.
constexpr auto kAllAppTypes = []() {
constexpr size_t kSize = []() {
size_t result = 0;
for (int i = 0; i <= static_cast<int>(apps::AppType::kMaxValue); ++i) {
if (ToAppType(i).has_value()) {
++result;
}
}
return result;
}();
std::array<apps::AppType, kSize> result;
size_t current = 0;
for (int i = 0; i <= static_cast<int>(apps::AppType::kMaxValue); ++i) {
if (auto app_type = ToAppType(i); app_type.has_value()) {
result[current++] = *app_type;
}
}
return result;
}();
} // namespace
class FamilyUserAppMetricsDerivedForTest : public FamilyUserAppMetrics {
public:
explicit FamilyUserAppMetricsDerivedForTest(Profile* profile)
: FamilyUserAppMetrics(profile) {}
~FamilyUserAppMetricsDerivedForTest() override = default;
void OnNewDay() override { FamilyUserAppMetrics::OnNewDay(); }
void InitializeAppTypes() {
for (auto app_type : kAllAppTypes) {
InitializeAppType(app_type);
}
}
void InitializeAppType(apps::AppType app_type) {
if (!IsAppTypeReady(app_type))
OnAppTypeInitialized(app_type);
}
};
// Tests for family user app metrics.
class FamilyUserAppMetricsTest
: public extensions::ExtensionServiceTestWithInstall,
public testing::WithParamInterface</*IsFamilyLink=*/bool> {
public:
FamilyUserAppMetricsTest()
: extensions::ExtensionServiceTestWithInstall(
std::make_unique<content::BrowserTaskEnvironment>(
base::test::TaskEnvironment::MainThreadType::IO,
content::BrowserTaskEnvironment::TimeSource::MOCK_TIME)) {}
void SetUp() override {
base::Time start_time;
EXPECT_TRUE(base::Time::FromString(kStartTime, &start_time));
base::TimeDelta forward_by = start_time - base::Time::Now();
EXPECT_LT(base::TimeDelta(), forward_by);
task_environment()->AdvanceClock(forward_by);
ExtensionServiceInitParams params;
params.profile_is_supervised = IsFamilyLink();
InitializeExtensionService(std::move(params));
WaitForAppServiceProxyReady(
apps::AppServiceProxyFactory::GetForProfile(profile()));
EXPECT_EQ(IsFamilyLink(), profile()->IsChild());
supervised_user_extensions_delegate_ =
std::make_unique<extensions::SupervisedUserExtensionsDelegateImpl>(
profile());
supervised_user_test_util::
SetSupervisedUserExtensionsMayRequestPermissionsPref(profile(), true);
family_user_app_metrics_ =
std::make_unique<FamilyUserAppMetricsDerivedForTest>(profile());
}
void InstallExtensions() {
// Install and enable a theme, which doesn't require parent approval.
base::FilePath path = data_dir().AppendASCII("theme.crx");
const extensions::Extension* extension1 = InstallCRX(path, INSTALL_NEW);
ASSERT_TRUE(extension1);
EXPECT_TRUE(registry()->enabled_extensions().Contains(extension1->id()));
EXPECT_FALSE(
extensions::Manifest::IsComponentLocation(extension1->location()));
// Install an extension, but keep it disabled pending parent approval if the
// current user is supervised.
path = data_dir().AppendASCII("good.crx");
InstallState expected_state =
IsFamilyLink() ? INSTALL_WITHOUT_LOAD : INSTALL_NEW;
const extensions::Extension* extension2 = InstallCRX(path, expected_state);
ASSERT_TRUE(extension2);
EXPECT_EQ(IsFamilyLink(),
registry()->disabled_extensions().Contains(extension2->id()));
EXPECT_NE(IsFamilyLink(),
registry()->enabled_extensions().Contains(extension2->id()));
EXPECT_FALSE(
extensions::Manifest::IsComponentLocation(extension2->location()));
// Install an extension, and approve it if the current user is supervised.
path = data_dir().AppendASCII("good2048.crx");
const extensions::Extension* extension3 = InstallCRX(path, expected_state);
ASSERT_TRUE(extension3);
if (IsFamilyLink()) {
supervised_user_extensions_delegate()->AddExtensionApproval(*extension3);
}
EXPECT_TRUE(registry()->enabled_extensions().Contains(extension3->id()));
EXPECT_FALSE(
extensions::Manifest::IsComponentLocation(extension3->location()));
}
void InstallApps() {
std::vector<apps::AppPtr> deltas;
apps::AppServiceProxy* proxy =
apps::AppServiceProxyFactory::GetForProfile(profile());
deltas.push_back(MakeApp(/*app_id=*/"u", /*app_name=*/"unknown",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kUnknown));
deltas.push_back(
MakeApp(/*app_id=*/"a", /*app_name=*/"arc",
/*last_launch_time=*/base::Time::Now() - 28 * kOneDay,
apps::AppType::kArc));
deltas.push_back(MakeApp(/*app_id=*/"c", /*app_name=*/"crostini",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kCrostini));
deltas.push_back(MakeApp(/*app_id=*/"e", /*app_name=*/"extension",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kChromeApp));
deltas.push_back(MakeApp(/*app_id=*/"w", /*app_name=*/"web",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kWeb));
deltas.push_back(MakeApp(
/*app_id=*/"p", /*app_name=*/"pluginvm",
/*last_launch_time=*/base::Time::Now() - kOneDay,
apps::AppType::kPluginVm));
deltas.push_back(MakeApp(
/*app_id=*/"r", /*app_name=*/"remote",
/*last_launch_time=*/base::Time::Now() - kOneDay,
apps::AppType::kRemote));
deltas.push_back(MakeApp(/*app_id=*/"bo", /*app_name=*/"borealis",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kBorealis));
deltas.push_back(MakeApp(/*app_id=*/"s", /*app_name=*/"systemweb",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kSystemWeb));
deltas.push_back(MakeApp(/*app_id=*/"e", /*app_name=*/"extension",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kExtension));
deltas.push_back(MakeApp(/*app_id=*/"br", /*app_name=*/"bruschetta",
/*last_launch_time=*/base::Time::Now(),
apps::AppType::kBruschetta));
proxy->OnApps(std::move(deltas), apps::AppType::kUnknown,
false /* should_notify_initialized */);
apps::InstanceRegistry& instance_registry = proxy->InstanceRegistry();
window_ = std::make_unique<aura::Window>(nullptr);
window_->Init(ui::LAYER_NOT_DRAWN);
instance_registry.CreateOrUpdateInstance(
apps::InstanceParams(/*app_id=*/"a", window_.get()));
}
extensions::SupervisedUserExtensionsDelegate*
supervised_user_extensions_delegate() {
return supervised_user_extensions_delegate_.get();
}
bool IsFamilyLink() const { return GetParam(); }
std::unique_ptr<FamilyUserAppMetricsDerivedForTest> family_user_app_metrics_;
std::unique_ptr<aura::Window> window_;
std::unique_ptr<extensions::SupervisedUserExtensionsDelegate>
supervised_user_extensions_delegate_;
};
// Tests the UMA metrics that count the number of installed and enabled
// extensions and themes.
TEST_P(FamilyUserAppMetricsTest, CountInstalledAndEnabledExtensions) {
base::HistogramTester histogram_tester;
InstallExtensions();
family_user_app_metrics_->OnNewDay();
// There should be 2 installed extensions and one theme.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetInstalledExtensionsCountHistogramNameForTest(),
/*sample=*/3, /*expected_count=*/1);
if (IsFamilyLink()) {
// There should be 1 enabled extension and a theme. The other extension
// lacks parent approval.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetEnabledExtensionsCountHistogramNameForTest(),
/*sample=*/2, /*expected_count=*/1);
} else {
// Regular user case.
// There should be 2 enabled extensions and a theme.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetEnabledExtensionsCountHistogramNameForTest(),
/*sample=*/3, /*expected_count=*/1);
}
}
// Tests the UMA metrics that count the number of recently used apps for
// supervised and regular users.
TEST_P(FamilyUserAppMetricsTest, CountRecentlyUsedApps) {
base::HistogramTester histogram_tester;
InstallApps();
family_user_app_metrics_->OnNewDay();
family_user_app_metrics_->InitializeAppTypes();
for (auto app_type : kAllAppTypes) {
const std::string histogram_name =
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(app_type);
histogram_tester.ExpectUniqueSample(histogram_name, /*sample=*/1,
/*expected_count=*/1);
}
}
// Tests that uninitialized app types are not reported on new day.
TEST_P(FamilyUserAppMetricsTest, UninitializedAppTypeNotReportedOnNewDay) {
base::HistogramTester histogram_tester;
InstallApps();
family_user_app_metrics_->OnNewDay();
for (auto app_type : kAllAppTypes) {
const std::string histogram_name =
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(app_type);
histogram_tester.ExpectTotalCount(histogram_name, /*expected_count=*/0);
}
}
// Tests that apps with stale launch dates too far in the past are not counted.
TEST_P(FamilyUserAppMetricsTest, FastForwardOneDay) {
base::HistogramTester histogram_tester;
InstallExtensions();
InstallApps();
family_user_app_metrics_->InitializeAppTypes();
// End time is 2 Jan 2020 21:15.
task_environment()->FastForwardBy(kOneDay);
family_user_app_metrics_->OnNewDay();
// One snapshot recorded.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetInstalledExtensionsCountHistogramNameForTest(),
/*sample=*/3, /*expected_count=*/1);
if (IsFamilyLink()) {
// There should be 1 enabled extension and a theme.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetEnabledExtensionsCountHistogramNameForTest(),
/*sample=*/2, /*expected_count=*/1);
} else {
// Regular user case.
// There should be 2 enabled extensions and a theme.
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetEnabledExtensionsCountHistogramNameForTest(),
/*sample=*/3, /*expected_count=*/1);
}
constexpr apps::AppType fresh_app_types[] = {
apps::AppType::kUnknown, apps::AppType::kArc, apps::AppType::kCrostini,
apps::AppType::kChromeApp, apps::AppType::kWeb, apps::AppType::kBorealis,
};
// Launched over 28 days ago and dropped from the count.
constexpr apps::AppType stale_app_types[] = {
apps::AppType::kPluginVm,
apps::AppType::kRemote,
};
for (apps::AppType app_type : fresh_app_types) {
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(app_type),
/*sample=*/1,
/*expected_count=*/1);
}
for (apps::AppType app_type : stale_app_types) {
histogram_tester.ExpectUniqueSample(
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(app_type),
/*sample=*/0,
/*expected_count=*/1);
}
}
// Tests that initializing a single app type only reports metrics for that app
// type, and not other app types.
TEST_P(FamilyUserAppMetricsTest, OnlyReportSingleInitilizedAppTypeOnNewDay) {
InstallApps();
family_user_app_metrics_->OnNewDay();
for (auto app_type : kAllAppTypes) {
// Extensions are recorded separately.
if (app_type == apps::AppType::kExtension) {
continue;
}
base::HistogramTester histogram_tester;
// Only report one app type.
family_user_app_metrics_->InitializeAppType(app_type);
{
std::string reported_app_type =
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(app_type);
ASSERT_FALSE(reported_app_type.empty());
histogram_tester.ExpectUniqueSample(reported_app_type, /*sample=*/1,
/*expected_count=*/1);
}
for (auto other_app_type : kAllAppTypes) {
if (static_cast<int>(app_type) <= static_cast<int>(other_app_type)) {
break;
}
std::string reported_app_type =
FamilyUserAppMetrics::GetAppsCountHistogramNameForTest(
other_app_type);
ASSERT_FALSE(reported_app_type.empty());
histogram_tester.ExpectTotalCount(reported_app_type,
/*expected_count=*/0);
}
}
}
INSTANTIATE_TEST_SUITE_P(,
FamilyUserAppMetricsTest,
/*IsFamilyLink=*/testing::Bool());
} // namespace ash
|