1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/concierge_helper/concierge_helper_service.h"
#include <memory>
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "chrome/test/base/testing_profile.h"
#include "chromeos/ash/components/dbus/concierge/fake_concierge_client.h"
#include "chromeos/ash/components/dbus/vm_concierge/concierge_service.pb.h"
#include "content/public/test/browser_task_environment.h"
#include "dbus/bus.h"
#include "dbus/object_proxy.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash {
class TestConciergeClient : public FakeConciergeClient {
public:
static void Initialize() { new TestConciergeClient(); }
TestConciergeClient(const TestConciergeClient&) = delete;
TestConciergeClient& operator=(const TestConciergeClient&) = delete;
~TestConciergeClient() override = default;
void SetVmCpuRestriction(
const vm_tools::concierge::SetVmCpuRestrictionRequest& request,
chromeos::DBusMethodCallback<
vm_tools::concierge::SetVmCpuRestrictionResponse> callback) override {
requests_.push_back(request);
FakeConciergeClient::SetVmCpuRestriction(request, std::move(callback));
}
// Runs callback when service becomes available. If service is already
// available, runs callback immediately.
void WaitForServiceToBeAvailable(
dbus::ObjectProxy::WaitForServiceToBeAvailableCallback callback)
override {
if (!service_is_available_) {
callbacks_.push_back(std::move(callback));
} else {
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE,
base::BindOnce(std::move(callback), service_is_available_));
}
}
// Sets whether service is available or not. If service_is_available is
// true, all callbacks waiting for service to be available will be run.
void SetServiceIsAvailable(bool service_is_available) {
service_is_available_ = service_is_available;
if (service_is_available_ && !callbacks_.empty()) {
for (auto& callback : callbacks_)
WaitForServiceToBeAvailable(std::move(callback));
}
}
const std::vector<vm_tools::concierge::SetVmCpuRestrictionRequest>& requests()
const {
return requests_;
}
private:
TestConciergeClient()
: FakeConciergeClient(/*fake_cicerone_client=*/nullptr) {}
std::vector<vm_tools::concierge::SetVmCpuRestrictionRequest> requests_;
std::vector<dbus::ObjectProxy::WaitForServiceToBeAvailableCallback>
callbacks_;
bool service_is_available_ = true;
};
class ConciergeHelperServiceTest : public testing::Test {
public:
ConciergeHelperServiceTest() = default;
ConciergeHelperServiceTest(const ConciergeHelperServiceTest&) = delete;
ConciergeHelperServiceTest& operator=(const ConciergeHelperServiceTest&) =
delete;
~ConciergeHelperServiceTest() override = default;
// testing::Test:
void SetUp() override {
TestConciergeClient::Initialize();
service_ = ConciergeHelperService::GetForBrowserContext(&profile_);
}
void TearDown() override {
ConciergeClient::Shutdown(); // deletes the client created in SetUp().
}
protected:
ConciergeHelperService* service() { return service_; }
TestConciergeClient* fake_concierge_client() {
return static_cast<TestConciergeClient*>(ConciergeClient::Get());
}
content::BrowserTaskEnvironment* task_environment() {
return &task_environment_;
}
private:
content::BrowserTaskEnvironment task_environment_;
TestingProfile profile_;
raw_ptr<ConciergeHelperService> service_;
};
// Tests that ConciergeHelperService makes cpu restriction requests correctly.
TEST_F(ConciergeHelperServiceTest, TestSetVmCpuRestriction) {
vm_tools::concierge::SetVmCpuRestrictionResponse response;
response.set_success(true);
fake_concierge_client()->set_set_vm_cpu_restriction_response(response);
service()->SetArcVmCpuRestriction(true);
service()->SetArcVmCpuRestriction(false);
service()->SetTerminaVmCpuRestriction(true);
service()->SetTerminaVmCpuRestriction(false);
service()->SetPluginVmCpuRestriction(true);
service()->SetPluginVmCpuRestriction(false);
task_environment()->RunUntilIdle();
std::vector<vm_tools::concierge::SetVmCpuRestrictionRequest> requests(
fake_concierge_client()->requests());
EXPECT_EQ(6U, requests.size());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_ARCVM, requests[0].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_BACKGROUND,
requests[0].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_ARCVM, requests[1].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_FOREGROUND,
requests[1].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_TERMINA, requests[2].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_BACKGROUND,
requests[2].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_TERMINA, requests[3].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_FOREGROUND,
requests[3].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_PLUGINVM, requests[4].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_BACKGROUND,
requests[4].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_PLUGINVM, requests[5].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_FOREGROUND,
requests[5].cpu_restriction_state());
}
// Tests that ConciergeHelperService requests cpu restriction immediately when
// dbus service is available, but waits until service is ready when it is not
// available.
TEST_F(ConciergeHelperServiceTest, TestWaitForServiceAvailable) {
// Service is available, so request is made immediately.
vm_tools::concierge::SetVmCpuRestrictionResponse response;
response.set_success(true);
fake_concierge_client()->set_set_vm_cpu_restriction_response(response);
fake_concierge_client()->SetServiceIsAvailable(true);
service()->SetArcVmCpuRestriction(true);
task_environment()->RunUntilIdle();
EXPECT_EQ(1U, fake_concierge_client()->requests().size());
// Service is unavailable, so request is queued until it is.
fake_concierge_client()->SetServiceIsAvailable(false);
service()->SetArcVmCpuRestriction(true);
task_environment()->RunUntilIdle();
EXPECT_EQ(1U, fake_concierge_client()->requests().size());
fake_concierge_client()->SetServiceIsAvailable(true);
task_environment()->RunUntilIdle();
EXPECT_EQ(2U, fake_concierge_client()->requests().size());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_ARCVM,
fake_concierge_client()->requests()[0].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_CGROUP_ARCVM,
fake_concierge_client()->requests()[1].cpu_cgroup());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_BACKGROUND,
fake_concierge_client()->requests()[0].cpu_restriction_state());
EXPECT_EQ(vm_tools::concierge::CPU_RESTRICTION_BACKGROUND,
fake_concierge_client()->requests()[1].cpu_restriction_state());
}
} // namespace ash
|
