1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/extensions/install_limiter.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/memory/raw_ptr.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "chrome/browser/ash/login/demo_mode/demo_mode_test_helper.h"
#include "chrome/browser/ash/login/demo_mode/demo_session.h"
#include "chrome/browser/ash/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/mock_crx_installer.h"
#include "chromeos/ash/components/install_attributes/stub_install_attributes.h"
#include "components/user_manager/scoped_user_manager.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/crx_file_info.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/verifier_formats.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using extensions::CrxInstaller;
using extensions::CrxInstallError;
using extensions::InstallLimiter;
using testing::_;
using testing::Field;
using testing::Invoke;
using testing::Mock;
namespace {
constexpr char kRandomExtensionId[] = "abacabadabacabaeabacabadabacabaf";
constexpr int kLargeExtensionSize = 2000000;
constexpr int kSmallExtensionSize = 200000;
constexpr char kLargeExtensionCrx[] = "large.crx";
constexpr char kSmallExtensionCrx[] = "small.crx";
constexpr base::TimeDelta kLessThanExpectedWaitTime = base::Seconds(4);
constexpr base::TimeDelta kTimeDeltaUntilExpectedWaitTime = base::Seconds(1);
} // namespace
class InstallLimiterShouldDeferInstallTest
: public testing::TestWithParam<ash::DemoSession::DemoModeConfig> {
public:
InstallLimiterShouldDeferInstallTest()
: scoped_user_manager_(std::make_unique<ash::FakeChromeUserManager>()) {}
InstallLimiterShouldDeferInstallTest(
const InstallLimiterShouldDeferInstallTest&) = delete;
InstallLimiterShouldDeferInstallTest& operator=(
const InstallLimiterShouldDeferInstallTest&) = delete;
~InstallLimiterShouldDeferInstallTest() override = default;
protected:
ash::ScopedStubInstallAttributes test_install_attributes_;
private:
content::BrowserTaskEnvironment task_environment_;
user_manager::ScopedUserManager scoped_user_manager_;
};
TEST_P(InstallLimiterShouldDeferInstallTest, ShouldDeferInstall) {
const std::vector<std::string> screensaver_ids = {
extension_misc::kScreensaverAppId, extension_misc::kNewAttractLoopAppId};
ash::DemoModeTestHelper demo_mode_test_helper;
if (GetParam() != ash::DemoSession::DemoModeConfig::kNone) {
test_install_attributes_.Get()->SetDemoMode();
demo_mode_test_helper.InitializeSession(GetParam());
}
// In demo mode, all apps larger than 1MB except for the screensaver
// should be deferred.
for (const std::string& id : screensaver_ids) {
bool expected_defer_install =
GetParam() == ash::DemoSession::DemoModeConfig::kNone ||
id != ash::DemoSession::GetScreensaverAppId();
EXPECT_EQ(expected_defer_install,
InstallLimiter::ShouldDeferInstall(kLargeExtensionSize, id));
}
EXPECT_TRUE(InstallLimiter::ShouldDeferInstall(kLargeExtensionSize,
kRandomExtensionId));
EXPECT_FALSE(InstallLimiter::ShouldDeferInstall(kSmallExtensionSize,
kRandomExtensionId));
}
INSTANTIATE_TEST_SUITE_P(
DemoModeConfig,
InstallLimiterShouldDeferInstallTest,
::testing::Values(ash::DemoSession::DemoModeConfig::kNone,
ash::DemoSession::DemoModeConfig::kOnline));
class InstallLimiterTest : public extensions::ExtensionServiceTestBase {
public:
InstallLimiterTest()
: extensions::ExtensionServiceTestBase(
std::make_unique<content::BrowserTaskEnvironment>(
base::test::TaskEnvironment::MainThreadType::IO,
content::BrowserTaskEnvironment::TimeSource::MOCK_TIME)) {}
InstallLimiterTest(const InstallLimiterTest&) = delete;
InstallLimiterTest& operator=(const InstallLimiterTest&) = delete;
~InstallLimiterTest() override = default;
protected:
void SetUp() override {
extensions::ExtensionServiceTestBase::SetUp();
ExtensionServiceInitParams params;
params.enable_install_limiter = true;
InitializeExtensionService(std::move(params));
install_limiter_ = InstallLimiter::Get(profile());
mock_installer_ =
base::MakeRefCounted<extensions::MockCrxInstaller>(profile());
}
extensions::CRXFileInfo CreateTestExtensionCrx(const base::FilePath& path,
int extension_size) {
const std::string data(extension_size, 0);
EXPECT_TRUE(base::WriteFile(path, data));
extensions::CRXFileInfo crx_info(path, extensions::GetTestVerifierFormat());
crx_info.extension_id = kRandomExtensionId;
return crx_info;
}
raw_ptr<InstallLimiter> install_limiter_;
scoped_refptr<extensions::MockCrxInstaller> mock_installer_;
};
// Test that small extensions are installed immediately.
TEST_F(InstallLimiterTest, DontDeferSmallExtensionInstallation) {
const base::FilePath path =
extensions_install_dir().AppendASCII(kSmallExtensionCrx);
extensions::CRXFileInfo crx_info_small =
CreateTestExtensionCrx(path, kSmallExtensionSize);
EXPECT_CALL(*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, path)));
install_limiter_->Add(mock_installer_, crx_info_small);
task_environment()->RunUntilIdle();
Mock::VerifyAndClearExpectations(mock_installer_.get());
}
// Test that large extension installations are deferred.
TEST_F(InstallLimiterTest, DeferLargeExtensionInstallation) {
const base::FilePath path =
extensions_install_dir().AppendASCII(kLargeExtensionCrx);
extensions::CRXFileInfo crx_info_large =
CreateTestExtensionCrx(path, kLargeExtensionSize);
// Check that the large extension will not be installed immediately.
EXPECT_CALL(*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, path)))
.Times(0);
install_limiter_->Add(mock_installer_, crx_info_large);
task_environment()->FastForwardBy(kLessThanExpectedWaitTime);
task_environment()->RunUntilIdle();
Mock::VerifyAndClearExpectations(mock_installer_.get());
// The installation starts only after the wait time is elapsed.
EXPECT_CALL(*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, path)));
task_environment()->FastForwardBy(kTimeDeltaUntilExpectedWaitTime);
task_environment()->RunUntilIdle();
Mock::VerifyAndClearExpectations(mock_installer_.get());
}
// Test that deferred installations are run before the wait time expires if the
// OnAllExternalProvidersReady() signal was called.
TEST_F(InstallLimiterTest, RunDeferredInstallsWhenAllExternalProvidersReady) {
const base::FilePath path =
extensions_install_dir().AppendASCII(kLargeExtensionCrx);
extensions::CRXFileInfo crx_info_large =
CreateTestExtensionCrx(path, kLargeExtensionSize);
// Check that the large extension will not be installed immediately.
EXPECT_CALL(*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, path)))
.Times(0);
install_limiter_->Add(mock_installer_, crx_info_large);
task_environment()->FastForwardBy(kLessThanExpectedWaitTime);
task_environment()->RunUntilIdle();
Mock::VerifyAndClearExpectations(mock_installer_.get());
// The installation starts before the wait time is elapsed if
// OnAllExternalProvidersReady() is called.
EXPECT_CALL(*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, path)));
install_limiter_->OnAllExternalProvidersReady();
task_environment()->RunUntilIdle();
Mock::VerifyAndClearExpectations(mock_installer_.get());
}
// Test that small extensions are installed before large extensions.
TEST_F(InstallLimiterTest, InstallSmallBeforeLargeExtensions) {
// Create a large test extension crx file.
const base::FilePath crx_path_large =
extensions_install_dir().AppendASCII(kLargeExtensionCrx);
extensions::CRXFileInfo crx_info_large =
CreateTestExtensionCrx(crx_path_large, kLargeExtensionSize);
// Create a small test extension crx file.
const base::FilePath crx_path_small =
extensions_install_dir().AppendASCII(kSmallExtensionCrx);
extensions::CRXFileInfo crx_info_small =
CreateTestExtensionCrx(crx_path_small, kSmallExtensionSize);
CrxInstaller::InstallerResultCallback installer_callback;
base::RunLoop run_loop;
// When adding a large extension and then a small extension, the small
// extension will be installed first. The mock function call will trigger a
// installer_callback which will notify the install limiter to
// continue with any deferred installations. This will then start the
// installation of the large extension.
{
testing::InSequence s;
EXPECT_CALL(*mock_installer_, AddInstallerCallback(_))
.WillOnce(Invoke([&](CrxInstaller::InstallerResultCallback callback) {
installer_callback = std::move(callback);
}));
EXPECT_CALL(
*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, crx_path_small)))
.WillOnce(Invoke([&] {
std::optional<CrxInstallError> error;
task_environment()->GetMainThreadTaskRunner()->PostTask(
FROM_HERE, base::BindOnce(std::move(installer_callback), error));
}));
EXPECT_CALL(*mock_installer_, AddInstallerCallback(_));
EXPECT_CALL(
*mock_installer_,
InstallCrxFile(Field(&extensions::CRXFileInfo::path, crx_path_large)))
.WillOnce(Invoke(&run_loop, &base::RunLoop::Quit));
}
install_limiter_->Add(mock_installer_, crx_info_large);
// Ensure that AddWithSize() is called for the large extension before also
// adding the small extension.
task_environment()->RunUntilIdle();
install_limiter_->Add(mock_installer_, crx_info_small);
run_loop.Run();
Mock::VerifyAndClearExpectations(mock_installer_.get());
}
|