1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "chrome/browser/ash/file_system_provider/fileapi/file_stream_reader.h"
#include <stddef.h>
#include <stdint.h>
#include <memory>
#include <string>
#include <vector>
#include "base/files/file.h"
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/numerics/safe_math.h"
#include "base/run_loop.h"
#include "chrome/browser/ash/file_system_provider/fake_extension_provider.h"
#include "chrome/browser/ash/file_system_provider/fake_provided_file_system.h"
#include "chrome/browser/ash/file_system_provider/service.h"
#include "chrome/browser/ash/file_system_provider/service_factory.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/extension_registry.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "storage/browser/file_system/async_file_util.h"
#include "storage/browser/file_system/external_mount_points.h"
#include "storage/browser/file_system/file_system_url.h"
#include "storage/browser/test/test_file_system_context.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/storage_key/storage_key.h"
namespace ash::file_system_provider {
namespace {
const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
const char kFileSystemId[] = "testing-file-system";
const ProviderId kProviderId = ProviderId::CreateFromExtensionId(kExtensionId);
// Logs callbacks invocations on the file stream reader.
class EventLogger {
public:
EventLogger() = default;
EventLogger(const EventLogger&) = delete;
EventLogger& operator=(const EventLogger&) = delete;
virtual ~EventLogger() = default;
void OnRead(int result) { results_.push_back(result); }
void OnGetLength(int64_t result) { results_.push_back(result); }
base::WeakPtr<EventLogger> GetWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();
}
const std::vector<int64_t>& results() const { return results_; }
private:
std::vector<int64_t> results_;
base::WeakPtrFactory<EventLogger> weak_ptr_factory_{this};
};
// Creates a cracked FileSystemURL for tests.
storage::FileSystemURL CreateFileSystemURL(const std::string& mount_point_name,
const base::FilePath& file_path) {
const std::string origin = std::string("chrome-extension://") + kExtensionId;
const storage::ExternalMountPoints* const mount_points =
storage::ExternalMountPoints::GetSystemInstance();
return mount_points->CreateCrackedFileSystemURL(
blink::StorageKey::CreateFromStringForTesting(origin),
storage::kFileSystemTypeExternal,
base::FilePath::FromUTF8Unsafe(mount_point_name).Append(file_path));
}
} // namespace
class FileSystemProviderFileStreamReader : public testing::Test {
protected:
FileSystemProviderFileStreamReader()
: profile_(nullptr), fake_file_(nullptr) {}
~FileSystemProviderFileStreamReader() override = default;
void SetUp() override {
ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
profile_manager_ = std::make_unique<TestingProfileManager>(
TestingBrowserProcess::GetGlobal());
ASSERT_TRUE(profile_manager_->SetUp());
profile_ = profile_manager_->CreateTestingProfile("testing-profile");
Service* service = Service::Get(profile_); // Owned by its factory.
service->RegisterProvider(FakeExtensionProvider::Create(kExtensionId));
const base::File::Error result = service->MountFileSystem(
kProviderId, MountOptions(kFileSystemId, "Testing File System"));
ASSERT_EQ(base::File::FILE_OK, result);
FakeProvidedFileSystem* provided_file_system =
static_cast<FakeProvidedFileSystem*>(
service->GetProvidedFileSystem(kProviderId, kFileSystemId));
ASSERT_TRUE(provided_file_system);
fake_file_ = provided_file_system->GetEntry(base::FilePath(kFakeFilePath));
ASSERT_TRUE(fake_file_);
const ProvidedFileSystemInfo& file_system_info =
service->GetProvidedFileSystem(kProviderId, kFileSystemId)
->GetFileSystemInfo();
const std::string mount_point_name =
file_system_info.mount_path().BaseName().AsUTF8Unsafe();
file_url_ = CreateFileSystemURL(mount_point_name,
base::FilePath(kFakeFilePath + 1));
ASSERT_TRUE(file_url_.is_valid());
wrong_file_url_ = CreateFileSystemURL(
mount_point_name, base::FilePath(FILE_PATH_LITERAL("im-not-here.txt")));
ASSERT_TRUE(wrong_file_url_.is_valid());
}
content::BrowserTaskEnvironment task_environment_;
base::ScopedTempDir data_dir_;
std::unique_ptr<TestingProfileManager> profile_manager_;
raw_ptr<TestingProfile> profile_; // Owned by TestingProfileManager.
raw_ptr<const FakeEntry> fake_file_; // Owned by FakePRovidedFileSystem.
storage::FileSystemURL file_url_;
storage::FileSystemURL wrong_file_url_;
};
TEST_F(FileSystemProviderFileStreamReader, Read_AllAtOnce) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset,
*fake_file_->metadata->modification_time);
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(
base::checked_cast<size_t>(*fake_file_->metadata->size));
const int result =
reader.Read(io_buffer.get(), *fake_file_->metadata->size,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_LT(0, logger.results()[0]);
EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
EXPECT_EQ(fake_file_->contents, buffer_as_string);
}
TEST_F(FileSystemProviderFileStreamReader, Read_WrongFile) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, wrong_file_url_, initial_offset,
*fake_file_->metadata->modification_time);
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(
base::checked_cast<size_t>(*fake_file_->metadata->size));
const int result =
reader.Read(io_buffer.get(), *fake_file_->metadata->size,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]);
}
TEST_F(FileSystemProviderFileStreamReader, Read_InChunks) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset,
*fake_file_->metadata->modification_time);
for (int64_t offset = 0; offset < *fake_file_->metadata->size; ++offset) {
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(1);
const int result =
reader.Read(io_buffer.get(), 1,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(offset + 1, static_cast<int64_t>(logger.results().size()));
EXPECT_EQ(1, logger.results()[offset]);
EXPECT_EQ(fake_file_->contents[offset], io_buffer->data()[0]);
}
}
TEST_F(FileSystemProviderFileStreamReader, Read_Slice) {
EventLogger logger;
// Trim first 3 and last 3 characters.
const int64_t initial_offset = 3;
const int length = *fake_file_->metadata->size - initial_offset - 3;
ASSERT_GT(*fake_file_->metadata->size, initial_offset);
ASSERT_LT(0, length);
FileStreamReader reader(nullptr, file_url_, initial_offset,
*fake_file_->metadata->modification_time);
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(length);
const int result =
reader.Read(io_buffer.get(), length,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(length, logger.results()[0]);
std::string buffer_as_string(io_buffer->data(), length);
std::string expected_buffer(fake_file_->contents.data() + initial_offset,
length);
EXPECT_EQ(expected_buffer, buffer_as_string);
}
TEST_F(FileSystemProviderFileStreamReader, Read_Beyond) {
EventLogger logger;
// Request reading 1KB more than available.
const int64_t initial_offset = 0;
const int length = *fake_file_->metadata->size + 1024;
FileStreamReader reader(nullptr, file_url_, initial_offset,
*fake_file_->metadata->modification_time);
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(length);
const int result =
reader.Read(io_buffer.get(), length,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_LT(0, logger.results()[0]);
EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
EXPECT_EQ(fake_file_->contents, buffer_as_string);
}
TEST_F(FileSystemProviderFileStreamReader, Read_ModifiedFile) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset,
base::Time::Max());
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(
base::checked_cast<size_t>(*fake_file_->metadata->size));
const int result =
reader.Read(io_buffer.get(), *fake_file_->metadata->size,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]);
}
TEST_F(FileSystemProviderFileStreamReader, Read_ExpectedModificationTimeNull) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset, base::Time());
auto io_buffer = base::MakeRefCounted<net::IOBufferWithSize>(
base::checked_cast<size_t>(*fake_file_->metadata->size));
const int result =
reader.Read(io_buffer.get(), *fake_file_->metadata->size,
base::BindOnce(&EventLogger::OnRead, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
EXPECT_EQ(fake_file_->contents, buffer_as_string);
}
TEST_F(FileSystemProviderFileStreamReader, GetLength) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset,
*fake_file_->metadata->modification_time);
const int result = reader.GetLength(
base::BindOnce(&EventLogger::OnGetLength, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_LT(0, logger.results()[0]);
EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
}
TEST_F(FileSystemProviderFileStreamReader, GetLength_WrongFile) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, wrong_file_url_, initial_offset,
*fake_file_->metadata->modification_time);
const int result = reader.GetLength(
base::BindOnce(&EventLogger::OnGetLength, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]);
}
TEST_F(FileSystemProviderFileStreamReader, GetLength_ModifiedFile) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset,
base::Time::Max());
const int result = reader.GetLength(
base::BindOnce(&EventLogger::OnGetLength, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]);
}
TEST_F(FileSystemProviderFileStreamReader,
GetLength_ExpectedModificationTimeNull) {
EventLogger logger;
const int64_t initial_offset = 0;
FileStreamReader reader(nullptr, file_url_, initial_offset, base::Time());
const int result = reader.GetLength(
base::BindOnce(&EventLogger::OnGetLength, logger.GetWeakPtr()));
EXPECT_EQ(net::ERR_IO_PENDING, result);
base::RunLoop().RunUntilIdle();
ASSERT_EQ(1u, logger.results().size());
EXPECT_LT(0, logger.results()[0]);
EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
}
} // namespace ash::file_system_provider
|
