1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/geolocation/system_geolocation_source.h"
#include <utility>
#include "ash/constants/ash_pref_names.h"
#include "ash/constants/geolocation_access_level.h"
#include "ash/session/session_controller_impl.h"
#include "ash/shell.h"
#include "ash/system/privacy_hub/privacy_hub_controller.h"
#include "ash/test/ash_test_base.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "chrome/browser/ash/login/login_manager_test.h"
#include "chrome/browser/ash/login/test/login_manager_mixin.h"
#include "chrome/browser/ui/ash/login/user_adding_screen.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/prefs/pref_service.h"
#include "content/public/test/browser_test.h"
#include "services/device/public/cpp/geolocation/geolocation_system_permission_manager.h"
#include "services/device/public/cpp/geolocation/location_system_permission_status.h"
#include "testing/gmock/include/gmock/gmock.h"
namespace {
class Observer
: public device::GeolocationSystemPermissionManager::PermissionObserver {
public:
// device::GeolocationSystemPermissionManager::PermissionObserver:
void OnSystemPermissionUpdated(
device::LocationSystemPermissionStatus status) override {
status_.GetRepeatingCallback().Run(std::move(status));
}
base::test::TestFuture<device::LocationSystemPermissionStatus> status_;
};
class MockObserver
: public device::GeolocationSystemPermissionManager::PermissionObserver {
public:
MOCK_METHOD(void,
OnSystemPermissionUpdated,
(device::LocationSystemPermissionStatus status),
(override));
};
} // namespace
namespace ash {
class SystemGeolocationSourceTestBase {
protected:
void SetActiveUserPref(GeolocationAccessLevel access_level) {
Shell::Get()->session_controller()->GetActivePrefService()->SetInteger(
prefs::kUserGeolocationAccessLevel, static_cast<int>(access_level));
}
void SetPrimaryUserPref(GeolocationAccessLevel access_level) {
Shell::Get()->session_controller()->GetPrimaryUserPrefService()->SetInteger(
prefs::kUserGeolocationAccessLevel, static_cast<int>(access_level));
}
GeolocationAccessLevel GetActiveUserPref() {
return static_cast<GeolocationAccessLevel>(
Shell::Get()->session_controller()->GetActivePrefService()->GetInteger(
prefs::kUserGeolocationAccessLevel));
}
};
class SystemGeolocationSourceTestsGeolocationOn
: public SystemGeolocationSourceTestBase,
public InProcessBrowserTest {
protected:
SystemGeolocationSourceTestsGeolocationOn() {
scoped_feature_list_.InitWithFeatures({features::kCrosPrivacyHub}, {});
}
base::test::ScopedFeatureList scoped_feature_list_;
};
class SystemGeolocationSourceTestsGeolocationOff
: public SystemGeolocationSourceTestBase,
public InProcessBrowserTest {
protected:
SystemGeolocationSourceTestsGeolocationOff() {
// Disables the geolocation part of the PrivacyHub
scoped_feature_list_.InitWithFeatures({}, {ash::features::kCrosPrivacyHub});
}
base::test::ScopedFeatureList scoped_feature_list_;
};
class SystemGeolocationSourceTestMultiUser
: public SystemGeolocationSourceTestBase,
public LoginManagerTest {
public:
SystemGeolocationSourceTestMultiUser() {
scoped_feature_list_.InitWithFeatures({features::kCrosPrivacyHub}, {});
login_mixin_.AppendRegularUsers(2);
primary_user_ = login_mixin_.users()[0].account_id;
secondary_user_ = login_mixin_.users()[1].account_id;
}
protected:
base::test::ScopedFeatureList scoped_feature_list_;
LoginManagerMixin login_mixin_{&mixin_host_};
AccountId primary_user_;
AccountId secondary_user_;
};
IN_PROC_BROWSER_TEST_F(SystemGeolocationSourceTestsGeolocationOn,
ObservationInBrowser) {
device::GeolocationSystemPermissionManager* manager =
device::GeolocationSystemPermissionManager::GetInstance();
ASSERT_TRUE(manager);
Observer observer;
manager->AddObserver(&observer);
// Initial value should be to allow.
EXPECT_EQ(GetActiveUserPref(), ash::GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kDisallowed);
// Check that the change in pref was registered.
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
observer.status_.Take());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kAllowed);
// Check that the change in pref was registered.
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
observer.status_.Take());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kOnlyAllowedForSystem);
// Check that the change in pref was registered.
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
observer.status_.Take());
// Observer needs to be removed here because it is allocated on stack.
manager->RemoveObserver(&observer);
}
IN_PROC_BROWSER_TEST_F(SystemGeolocationSourceTestMultiUser,
SecondaryUserObservation) {
// Sign in with the primary user.
LoginUser(primary_user_);
device::GeolocationSystemPermissionManager* manager =
device::GeolocationSystemPermissionManager::GetInstance();
ASSERT_TRUE(manager);
Observer observer;
manager->AddObserver(&observer);
// Initial value should be to allow.
EXPECT_EQ(GetActiveUserPref(), ash::GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
// Set pref to `kDisallowed`.
SetActiveUserPref(ash::GeolocationAccessLevel::kDisallowed);
// Check that the change in primary user pref affected the system location
// state.
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
observer.status_.Take());
// Add second user to the session and sign in.
ash::UserAddingScreen::Get()->Start();
AddUser(secondary_user_);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
// This observer is used to test that the secondary user pref changes below
// will not trigger the system location updates.
MockObserver NoOpObserver;
manager->AddObserver(&NoOpObserver);
// `OnSystemPermissionUpdated` hook shall not not be executed.
EXPECT_CALL(NoOpObserver, OnSystemPermissionUpdated(testing::_)).Times(0);
// Update secondary user pref for location pref and check it has no effect.
// Location setting should still follow the the primary user preference.
SetActiveUserPref(GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
// Ditto.
SetActiveUserPref(GeolocationAccessLevel::kOnlyAllowedForSystem);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
// Ditto.
SetActiveUserPref(GeolocationAccessLevel::kDisallowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
// Observers need to be removed here because it is allocated on stack.
manager->RemoveObserver(&NoOpObserver);
manager->RemoveObserver(&observer);
}
IN_PROC_BROWSER_TEST_F(SystemGeolocationSourceTestMultiUser,
SecondaryUserObserversPrimaryPrefUpdate) {
// Sign in with the primary user.
LoginUser(primary_user_);
device::GeolocationSystemPermissionManager* manager =
device::GeolocationSystemPermissionManager::GetInstance();
ASSERT_TRUE(manager);
Observer observer;
manager->AddObserver(&observer);
// Initial value should be to allow.
EXPECT_EQ(GetActiveUserPref(), ash::GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
// Add second user to the session and sign in.
ash::UserAddingScreen::Get()->Start();
AddUser(secondary_user_);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
// Update primary user's location preference while secondary user is active
// and check it affects the system permission.
SetPrimaryUserPref(ash::GeolocationAccessLevel::kDisallowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
observer.status_.Take());
SetPrimaryUserPref(ash::GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
observer.status_.Take());
SetPrimaryUserPref(ash::GeolocationAccessLevel::kOnlyAllowedForSystem);
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kDenied,
observer.status_.Take());
// Observer needs to be removed here because it is allocated on stack.
manager->RemoveObserver(&observer);
}
IN_PROC_BROWSER_TEST_F(SystemGeolocationSourceTestsGeolocationOff,
ObservationInBrowser) {
device::GeolocationSystemPermissionManager* manager =
device::GeolocationSystemPermissionManager::GetInstance();
ASSERT_TRUE(manager);
Observer observer;
manager->AddObserver(&observer);
// Initial value should be to allow.
EXPECT_EQ(GetActiveUserPref(), ash::GeolocationAccessLevel::kAllowed);
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kDisallowed);
// Check that the permission is not changed.
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
observer.status_.Take());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kAllowed);
// Check that the change in pref was registered.
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
observer.status_.Take());
// Change the pref value
SetActiveUserPref(ash::GeolocationAccessLevel::kOnlyAllowedForSystem);
// Check that the change in pref was registered.
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
manager->GetSystemPermission());
EXPECT_EQ(device::LocationSystemPermissionStatus::kAllowed,
observer.status_.Take());
// Observer needs to be removed here because it is allocated on stack.
manager->RemoveObserver(&observer);
}
} // namespace ash
|
