1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/input_method/autocorrect_prefs.h"
#include "ash/constants/ash_features.h"
#include "ash/constants/ash_pref_names.h"
#include "base/feature_list.h"
#include "base/strings/strcat.h"
#include "base/values.h"
#include "chrome/browser/ash/input_method/autocorrect_enums.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash::input_method {
namespace {
constexpr char kUsEnglish[] = "xkb:us::eng";
constexpr char kBrazilPortuguese[] = "xkb:br::por";
constexpr char kLatinAmericaSpanish[] = "xkb:latam::spa";
constexpr char kFranceFrench[] = "xkb:fr::fra";
void SetManagedPkAutocorrectAllowed(Profile& profile, bool allowed) {
profile.GetPrefs()->SetBoolean(
prefs::kManagedPhysicalKeyboardAutocorrectAllowed, allowed);
}
void SetAutocorrectLevelTo(Profile& profile,
const std::string& pref_name,
const std::string& engine_id,
int autocorrect_level) {
base::Value::Dict input_method_setting;
input_method_setting.SetByDottedPath(
base::StrCat({engine_id, ".", pref_name}), autocorrect_level);
profile.GetPrefs()->Set(::prefs::kLanguageInputMethodSpecificSettings,
base::Value(std::move(input_method_setting)));
}
void SetPkAutocorrectLevelTo(Profile& profile,
const std::string& engine_id,
int autocorrect_level) {
SetAutocorrectLevelTo(/*profile=*/profile,
/*pref_name=*/"physicalKeyboardAutoCorrectionLevel",
/*engine_id=*/engine_id,
/*autocorrect_level=*/autocorrect_level);
}
void SetVkAutocorrectLevelTo(Profile& profile,
const std::string& engine_id,
int autocorrect_level) {
SetAutocorrectLevelTo(/*profile=*/profile,
/*pref_name=*/"virtualKeyboardAutoCorrectionLevel",
/*engine_id=*/engine_id,
/*autocorrect_level=*/autocorrect_level);
}
class AutocorrectPrefsTest : public ::testing::Test {
protected:
content::BrowserTaskEnvironment task_environment_;
base::test::ScopedFeatureList feature_list_;
TestingProfile profile_;
};
TEST_F(AutocorrectPrefsTest,
FetchesTheCorrectPkValueWhenAutocorrectLevelIsNotSet) {
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
AutocorrectPreference::kDefault);
}
TEST_F(AutocorrectPrefsTest,
FetchesTheCorrectVkValueWhenAutocorrectLevelIsNotSet) {
EXPECT_EQ(
GetVirtualKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
AutocorrectPreference::kDefault);
}
struct AutocorrectPrefCase {
std::string test_name;
int autocorrect_level;
AutocorrectPreference autocorrect_pref;
};
class FetchesAutocorrectPreference
: public AutocorrectPrefsTest,
public testing::WithParamInterface<AutocorrectPrefCase> {};
TEST_P(FetchesAutocorrectPreference, AndReturnsCorrectPkPref) {
const AutocorrectPrefCase& test_case = GetParam();
SetPkAutocorrectLevelTo(profile_,
/*engine_id=*/kUsEnglish,
/*autocorrect_level=*/test_case.autocorrect_level);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
test_case.autocorrect_pref);
}
TEST_P(FetchesAutocorrectPreference, AndScopesReturnedPkPreferenceToEngineId) {
const AutocorrectPrefCase& test_case = GetParam();
SetPkAutocorrectLevelTo(profile_,
/*engine_id=*/kUsEnglish,
/*autocorrect_level=*/test_case.autocorrect_level);
// The above preference is set for the US English engine only. Queries for
// the autocorrect level on any other engine should return the default.
EXPECT_EQ(GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()),
kBrazilPortuguese),
AutocorrectPreference::kDefault);
}
TEST_P(FetchesAutocorrectPreference, AndReturnsCorrectVkPref) {
const AutocorrectPrefCase& test_case = GetParam();
SetVkAutocorrectLevelTo(profile_,
/*engine_id=*/kUsEnglish,
/*autocorrect_level=*/test_case.autocorrect_level);
EXPECT_EQ(
GetVirtualKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
test_case.autocorrect_pref);
}
TEST_P(FetchesAutocorrectPreference, AndScopesReturnedVkPreferenceToEngineId) {
const AutocorrectPrefCase& test_case = GetParam();
SetVkAutocorrectLevelTo(profile_,
/*engine_id=*/kUsEnglish,
/*autocorrect_level=*/test_case.autocorrect_level);
// The above preference is set for the US English engine only. Queries for
// the autocorrect level on any other engine should return the default.
EXPECT_EQ(GetVirtualKeyboardAutocorrectPref(*(profile_.GetPrefs()),
kBrazilPortuguese),
AutocorrectPreference::kDefault);
}
INSTANTIATE_TEST_SUITE_P(
AutocorrectPrefsTest,
FetchesAutocorrectPreference,
testing::ValuesIn<AutocorrectPrefCase>({
AutocorrectPrefCase{
"ForAutocorrectLevelZero",
/*autocorrect_level=*/0,
/*autocorrect_pref=*/AutocorrectPreference::kDisabled},
AutocorrectPrefCase{
"ForAutocorrectLevelNegativeOne",
/*autocorrect_level=*/-1,
/*autocorrect_pref=*/AutocorrectPreference::kDisabled},
AutocorrectPrefCase{
"ForAutocorrectLevelOne",
/*autocorrect_level=*/1,
/*autocorrect_pref=*/AutocorrectPreference::kEnabled},
AutocorrectPrefCase{
"ForAutocorrectLevelTwo",
/*autocorrect_level=*/1,
/*autocorrect_pref=*/AutocorrectPreference::kEnabled},
}),
[](const testing::TestParamInfo<AutocorrectPrefCase> info) {
return info.param.test_name;
});
TEST_F(AutocorrectPrefsTest, MarksUsersPrefAsEnabledByDefault) {
feature_list_.InitWithFeatures({features::kAutocorrectByDefault}, {});
SetPhysicalKeyboardAutocorrectAsEnabledByDefault(profile_.GetPrefs(),
kUsEnglish);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
AutocorrectPreference::kEnabledByDefault);
}
TEST_F(AutocorrectPrefsTest, EnabledByDefaultIsScopedToSingleLanguage) {
feature_list_.InitWithFeatures({features::kAutocorrectByDefault}, {});
SetPhysicalKeyboardAutocorrectAsEnabledByDefault(profile_.GetPrefs(),
kBrazilPortuguese);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), kUsEnglish),
AutocorrectPreference::kDefault);
EXPECT_EQ(GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()),
kBrazilPortuguese),
AutocorrectPreference::kEnabledByDefault);
}
class AutocorrectAdminPolicy : public AutocorrectPrefsTest,
public testing::WithParamInterface<std::string> {
};
TEST_P(AutocorrectAdminPolicy,
WhenAdminPolicyDisallowsAutocorrectItIsAlwaysDisabled) {
const std::string& engine_id = GetParam();
SetPkAutocorrectLevelTo(profile_, engine_id, 1);
SetManagedPkAutocorrectAllowed(profile_, false);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), engine_id),
AutocorrectPreference::kDisabled);
}
TEST_P(AutocorrectAdminPolicy, WhenAdminPolicyAllowsAutocorrectItCanBeEnabled) {
const std::string& engine_id = GetParam();
SetPkAutocorrectLevelTo(profile_, engine_id, 1);
SetManagedPkAutocorrectAllowed(profile_, true);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), engine_id),
AutocorrectPreference::kEnabled);
}
TEST_P(AutocorrectAdminPolicy, WhenAdminPolicyIsNotSetAutocorrectCanBeEnabled) {
const std::string& engine_id = GetParam();
SetPkAutocorrectLevelTo(profile_, engine_id, 1);
EXPECT_EQ(
GetPhysicalKeyboardAutocorrectPref(*(profile_.GetPrefs()), engine_id),
AutocorrectPreference::kEnabled);
}
INSTANTIATE_TEST_SUITE_P(AutocorrectPrefsTest,
AutocorrectAdminPolicy,
testing::ValuesIn<std::string>({
kBrazilPortuguese,
kFranceFrench,
kLatinAmericaSpanish,
kUsEnglish,
}));
} // namespace
} // namespace ash::input_method
|
