1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/input_method/grammar_manager.h"
#include "ash/constants/ash_features.h"
#include "base/feature_list.h"
#include "base/metrics/histogram_functions.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/sequenced_task_runner.h"
#include "base/timer/timer.h"
#include "chrome/browser/ash/input_method/assistive_window_properties.h"
#include "chrome/browser/ui/ash/input_method/suggestion_details.h"
#include "ui/base/ime/ash/ime_bridge.h"
#include "ui/base/ime/ash/text_input_target.h"
#include "ui/events/keycodes/dom/dom_code.h"
namespace ash {
namespace input_method {
namespace {
constexpr base::TimeDelta kCheckDelay = base::Seconds(2);
const uint64_t HashMultiplier = 1LL << 32;
const char16_t kShowGrammarSuggestionMessage[] =
u"Grammar correction suggested. Press tab to access; escape to dismiss.";
const char16_t kDismissGrammarSuggestionMessage[] = u"Suggestion dismissed.";
const char16_t kAcceptGrammarSuggestionMessage[] = u"Suggestion accepted.";
const char16_t kIgnoreGrammarSuggestionMessage[] = u"Suggestion ignored.";
const char kSuggestionButtonMessageTemplate[] =
"Suggestion %s. Button. Press enter to accept; escape to dismiss.";
const char16_t kIgnoreButtonMessage[] =
u"Ignore suggestion. Button. Press enter to ignore the suggestion; escape "
u"to dismiss.";
void RecordGrammarAction(GrammarActions action) {
base::UmaHistogramEnumeration("InputMethod.Assistive.Grammar.Actions",
action);
}
bool IsValidSentence(const std::u16string& text, const Sentence& sentence) {
uint32_t start = sentence.original_range.start();
uint32_t end = sentence.original_range.end();
if (start >= end || start >= text.size() || end > text.size()) {
return false;
}
return FindCurrentSentence(text, start) == sentence;
}
uint64_t RangeHash(const gfx::Range& range) {
return range.start() * HashMultiplier + range.end();
}
} // namespace
GrammarManager::GrammarManager(
Profile* profile,
std::unique_ptr<GrammarServiceClient> grammar_client,
SuggestionHandlerInterface* suggestion_handler)
: profile_(profile),
grammar_client_(std::move(grammar_client)),
suggestion_handler_(suggestion_handler),
current_fragment_(gfx::Range(), std::string()),
suggestion_button_(ui::ime::AssistiveWindowButton{
.id = ui::ime::ButtonId::kSuggestion,
.window_type = ash::ime::AssistiveWindowType::kGrammarSuggestion,
.announce_string = u"",
}),
ignore_button_(ui::ime::AssistiveWindowButton{
.id = ui::ime::ButtonId::kIgnoreSuggestion,
.window_type = ash::ime::AssistiveWindowType::kGrammarSuggestion,
.announce_string = kIgnoreButtonMessage,
}) {}
GrammarManager::~GrammarManager() = default;
bool GrammarManager::IsOnDeviceGrammarEnabled() {
return base::FeatureList::IsEnabled(features::kOnDeviceGrammarCheck);
}
void GrammarManager::OnFocus(int context_id, SpellcheckMode spellcheck_mode) {
if (context_id != context_id_) {
current_text_ = u"";
last_sentence_ = Sentence();
new_to_context_ = true;
delay_timer_.Stop();
ignored_marker_hashes_.clear();
recorded_marker_hashes_.clear();
}
context_id_ = context_id;
spellcheck_mode_ = spellcheck_mode;
}
bool GrammarManager::OnKeyEvent(const ui::KeyEvent& event) {
if (!suggestion_shown_ || event.type() != ui::EventType::kKeyPressed) {
return false;
}
if (event.code() == ui::DomCode::ESCAPE) {
DismissSuggestion();
suggestion_handler_->Announce(kDismissGrammarSuggestionMessage);
return true;
}
switch (highlighted_button_) {
case ui::ime::ButtonId::kNone:
if (event.code() == ui::DomCode::TAB ||
event.code() == ui::DomCode::ARROW_UP) {
highlighted_button_ = ui::ime::ButtonId::kSuggestion;
SetButtonHighlighted(suggestion_button_, true);
return true;
}
break;
case ui::ime::ButtonId::kSuggestion:
switch (event.code()) {
case ui::DomCode::TAB:
highlighted_button_ = ui::ime::ButtonId::kIgnoreSuggestion;
SetButtonHighlighted(ignore_button_, true);
return true;
case ui::DomCode::ARROW_DOWN:
highlighted_button_ = ui::ime::ButtonId::kNone;
SetButtonHighlighted(suggestion_button_, false);
return true;
case ui::DomCode::ENTER:
// SetComposingRange and CommitText in AcceptSuggestion will not be
// executed immediately if we are in middle of handling a key event,
// instead they will be delayed and CommitText will always be executed
// first. So we need to call AcceptSuggestion in a post task.
// TODO(crbug.com/1230961): remove PostTask after we remove the delay
// logics.
base::SequencedTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, base::BindOnce(&GrammarManager::AcceptSuggestion,
base::Unretained(this)));
return true;
default:
break;
}
break;
case ui::ime::ButtonId::kIgnoreSuggestion:
if (event.code() == ui::DomCode::ENTER) {
IgnoreSuggestion();
return true;
}
break;
default:
break;
}
return false;
}
bool GrammarManager::HandleSurroundingTextChange(
const std::u16string& text,
const gfx::Range selection_range) {
if (spellcheck_mode_ == SpellcheckMode::kDisabled) {
return false;
}
// TODO(b/269385926): Investigate if `selection_range.start()` needs to be
// inspected as well.
const int cursor_pos = selection_range.end();
bool text_updated = text != current_text_;
current_text_ = text;
current_sentence_ = FindCurrentSentence(text, cursor_pos);
if (new_to_context_) {
new_to_context_ = false;
return false;
}
if (text_updated) {
TextInputTarget* input_context = IMEBridge::Get()->GetInputContextHandler();
if (!input_context) {
return false;
}
// Grammar check is cpu consuming, so we only send request to ml service
// when the user has finished a sentence or stopped typing for some time.
Sentence last_sentence = FindLastSentence(text, cursor_pos);
if (last_sentence_ != last_sentence) {
last_sentence_ = last_sentence;
input_context->ClearGrammarFragments(last_sentence.original_range);
Check(last_sentence);
}
input_context->ClearGrammarFragments(current_sentence_.original_range);
delay_timer_.Start(
FROM_HERE, kCheckDelay,
base::BindOnce(&GrammarManager::Check, base::Unretained(this),
current_sentence_));
return false;
}
// Do not show the suggestion when the user is selecting a range of text, so
// that we will not show conflict with the system copy/paste popup.
if (!selection_range.is_empty()) {
return false;
}
TextInputTarget* input_context = IMEBridge::Get()->GetInputContextHandler();
if (!input_context) {
return false;
}
// Do not show suggestion when the cursor is within an auto correct range.
const gfx::Range range = input_context->GetAutocorrectRange();
if (!range.is_empty() &&
cursor_pos >= base::checked_cast<int32_t>(range.start()) &&
cursor_pos <= base::checked_cast<int32_t>(range.end())) {
return false;
}
std::optional<ui::GrammarFragment> grammar_fragment_opt =
input_context->GetGrammarFragmentAtCursor();
if (!grammar_fragment_opt) {
return false;
}
if (current_fragment_ != grammar_fragment_opt.value()) {
current_fragment_ = grammar_fragment_opt.value();
RecordGrammarAction(GrammarActions::kWindowShown);
}
std::string error;
AssistiveWindowProperties properties;
properties.type = ash::ime::AssistiveWindowType::kGrammarSuggestion;
properties.candidates = {base::UTF8ToUTF16(current_fragment_.suggestion)};
properties.visible = true;
properties.announce_string = kShowGrammarSuggestionMessage;
suggestion_button_.announce_string = base::UTF8ToUTF16(base::StringPrintf(
kSuggestionButtonMessageTemplate, current_fragment_.suggestion.c_str()));
suggestion_handler_->SetAssistiveWindowProperties(context_id_, properties,
&error);
if (!error.empty()) {
LOG(ERROR) << "Fail to show suggestion. " << error;
}
highlighted_button_ = ui::ime::ButtonId::kNone;
suggestion_shown_ = true;
return true;
}
void GrammarManager::OnSurroundingTextChanged(
const std::u16string& text,
const gfx::Range selection_range) {
if (!HandleSurroundingTextChange(text, selection_range)) {
DismissSuggestion();
}
}
void GrammarManager::Check(const Sentence& sentence) {
if (!IsValidSentence(current_text_, sentence)) {
return;
}
grammar_client_->RequestTextCheck(
profile_, sentence.text,
base::BindOnce(&GrammarManager::OnGrammarCheckDone,
base::Unretained(this), sentence));
}
void GrammarManager::OnGrammarCheckDone(
const Sentence& sentence,
bool success,
const std::vector<ui::GrammarFragment>& results) {
if (!success || !IsValidSentence(current_text_, sentence) ||
results.empty()) {
return;
}
std::vector<ui::GrammarFragment> corrected_results;
auto it = ignored_marker_hashes_.find(sentence.text);
for (const ui::GrammarFragment& fragment : results) {
if (it == ignored_marker_hashes_.end() ||
it->second.find(RangeHash(fragment.range)) == it->second.end()) {
corrected_results.emplace_back(
gfx::Range(fragment.range.start() + sentence.original_range.start(),
fragment.range.end() + sentence.original_range.start()),
fragment.suggestion);
}
}
TextInputTarget* input_context = IMEBridge::Get()->GetInputContextHandler();
if (!input_context) {
return;
}
if (input_context->AddGrammarFragments(corrected_results)) {
for (const ui::GrammarFragment& fragment : corrected_results) {
uint64_t hashValue = RangeHash(fragment.range);
// The de-dup could be incorrect in some cases but it is good enough for
// collecting metrics.
if (recorded_marker_hashes_.find(hashValue) ==
recorded_marker_hashes_.end()) {
recorded_marker_hashes_.insert(hashValue);
RecordGrammarAction(GrammarActions::kUnderlined);
}
}
}
}
void GrammarManager::DismissSuggestion() {
if (!suggestion_shown_) {
return;
}
std::string error;
suggestion_handler_->DismissSuggestion(context_id_, &error);
if (!error.empty()) {
LOG(ERROR) << "Failed to dismiss suggestion. " << error;
return;
}
suggestion_shown_ = false;
}
void GrammarManager::AcceptSuggestion() {
if (!suggestion_shown_) {
return;
}
DismissSuggestion();
TextInputTarget* input_context = IMEBridge::Get()->GetInputContextHandler();
if (!input_context) {
LOG(ERROR) << "Failed to commit grammar suggestion.";
}
if (input_context->HasCompositionText()) {
input_context->SetComposingRange(current_fragment_.range.start(),
current_fragment_.range.end(), {});
input_context->CommitText(
base::UTF8ToUTF16(current_fragment_.suggestion),
ui::TextInputClient::InsertTextCursorBehavior::kMoveCursorAfterText);
} else {
// NOTE: GetSurroundingTextInfo() could return a stale cache that no
// longer reflects reality, due to async-ness between IMF and
// TextInputClient.
// TODO(crbug/1194424): Work around the issue or fix
// GetSurroundingTextInfo().
const SurroundingTextInfo surrounding_text =
input_context->GetSurroundingTextInfo();
// Convert selection_range from surrounding_text relative to absolute.
const gfx::Range selection_range(
surrounding_text.selection_range.start() + surrounding_text.offset,
surrounding_text.selection_range.end() + surrounding_text.offset);
// Delete the incorrect grammar fragment.
DCHECK(current_fragment_.range.Contains(selection_range));
const uint32_t before =
selection_range.start() - current_fragment_.range.start();
const uint32_t after =
current_fragment_.range.end() - selection_range.end();
input_context->DeleteSurroundingText(before, after);
// Insert the suggestion and put cursor after it.
input_context->CommitText(
base::UTF8ToUTF16(current_fragment_.suggestion),
ui::TextInputClient::InsertTextCursorBehavior::kMoveCursorAfterText);
}
suggestion_handler_->Announce(kAcceptGrammarSuggestionMessage);
RecordGrammarAction(GrammarActions::kAccepted);
}
void GrammarManager::IgnoreSuggestion() {
if (!suggestion_shown_) {
return;
}
DismissSuggestion();
TextInputTarget* input_context = IMEBridge::Get()->GetInputContextHandler();
if (!input_context) {
return;
}
input_context->ClearGrammarFragments(current_fragment_.range);
if (ignored_marker_hashes_.find(current_sentence_.text) ==
ignored_marker_hashes_.end()) {
ignored_marker_hashes_[current_sentence_.text] =
std::unordered_set<uint64_t>();
}
ignored_marker_hashes_[current_sentence_.text].insert(
RangeHash(gfx::Range(current_fragment_.range.start() -
current_sentence_.original_range.start(),
current_fragment_.range.end() -
current_sentence_.original_range.start())));
suggestion_handler_->Announce(kIgnoreGrammarSuggestionMessage);
RecordGrammarAction(GrammarActions::kIgnored);
}
void GrammarManager::SetButtonHighlighted(
const ui::ime::AssistiveWindowButton& button,
bool highlighted) {
std::string error;
suggestion_handler_->SetButtonHighlighted(context_id_, button, highlighted,
&error);
if (!error.empty()) {
LOG(ERROR) << "Failed to set button highlighted. " << error;
}
}
} // namespace input_method
} // namespace ash
|