1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/input_method/suggestions_collector.h"
#include <vector>
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/test/bind.h"
#include "chrome/browser/ash/input_method/suggestions_source.h"
#include "chromeos/ash/services/ime/public/cpp/assistive_suggestions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash {
namespace input_method {
namespace {
using ime::AssistiveSuggestion;
using ime::AssistiveSuggestionMode;
using ime::AssistiveSuggestionType;
using ime::DecoderCompletionCandidate;
class FakeAssistiveSuggester : public SuggestionsSource {
public:
std::vector<AssistiveSuggestion> GetSuggestions() override {
return suggestions_;
}
void SetSuggestions(std::vector<AssistiveSuggestion> suggestions) {
suggestions_ = std::move(suggestions);
}
private:
std::vector<AssistiveSuggestion> suggestions_;
};
class FakeSuggestionsService : public AsyncSuggestionsSource {
public:
void RequestSuggestions(
const std::string& preceding_text,
const ime::AssistiveSuggestionMode& suggestion_mode,
const std::vector<DecoderCompletionCandidate>& completion_candidates,
RequestSuggestionsCallback callback) override {
std::move(callback).Run(suggestions_);
}
bool IsAvailable() override { return is_available_; }
void SetSuggestions(std::vector<AssistiveSuggestion> suggestions) {
suggestions_ = std::move(suggestions);
}
void SetIsAvailable(bool is_available) { is_available_ = is_available; }
private:
std::vector<AssistiveSuggestion> suggestions_;
bool is_available_ = true;
};
class SuggestionsCollectorTest : public ::testing::Test {
public:
void SetUp() override {
multi_word_result_ =
AssistiveSuggestion{.mode = AssistiveSuggestionMode::kCompletion,
.type = AssistiveSuggestionType::kMultiWord,
.text = "hello there"};
personal_info_name_result_ = AssistiveSuggestion{
.mode = AssistiveSuggestionMode::kCompletion,
.type = AssistiveSuggestionType::kAssistivePersonalInfo,
.text = "my name is Mr Robot"};
personal_info_address_result_ = AssistiveSuggestion{
.mode = AssistiveSuggestionMode::kCompletion,
.type = AssistiveSuggestionType::kAssistivePersonalInfo,
.text = "my address is 123 Fake St"};
}
std::vector<AssistiveSuggestion> suggestions_returned() {
return suggestions_returned_;
}
AssistiveSuggestion multi_word_result() { return multi_word_result_; }
AssistiveSuggestion personal_info_name_result() {
return personal_info_name_result_;
}
AssistiveSuggestion personal_info_address_result() {
return personal_info_address_result_;
}
void OnSuggestionsReturned(ime::mojom::SuggestionsResponsePtr response) {
suggestions_returned_ = response->candidates;
}
private:
std::vector<AssistiveSuggestion> suggestions_returned_;
AssistiveSuggestion multi_word_result_;
AssistiveSuggestion personal_info_name_result_;
AssistiveSuggestion personal_info_address_result_;
};
TEST_F(SuggestionsCollectorTest, ReturnsResultsFromAssistiveSuggester) {
FakeAssistiveSuggester suggester;
auto requestor = std::make_unique<FakeSuggestionsService>();
auto expected_results = std::vector<AssistiveSuggestion>{
personal_info_name_result(),
personal_info_address_result(),
};
suggester.SetSuggestions(expected_results);
SuggestionsCollector collector(&suggester, std::move(requestor));
collector.GatherSuggestions(
ime::mojom::SuggestionsRequest::New(),
base::BindOnce(&SuggestionsCollectorTest::OnSuggestionsReturned,
base::Unretained(this)));
EXPECT_EQ(suggestions_returned(), expected_results);
}
TEST_F(SuggestionsCollectorTest, ReturnsResultsFromSuggestionsRequestor) {
FakeAssistiveSuggester suggester;
auto requestor = std::make_unique<FakeSuggestionsService>();
auto expected_results = std::vector<AssistiveSuggestion>{multi_word_result()};
requestor->SetSuggestions(expected_results);
SuggestionsCollector collector(&suggester, std::move(requestor));
collector.GatherSuggestions(
ime::mojom::SuggestionsRequest::New(),
base::BindOnce(&SuggestionsCollectorTest::OnSuggestionsReturned,
base::Unretained(this)));
EXPECT_EQ(suggestions_returned(), expected_results);
}
TEST_F(SuggestionsCollectorTest, ReturnsCombinedResultsIfAvailable) {
FakeAssistiveSuggester assistive_suggester;
auto suggestions_requestor = std::make_unique<FakeSuggestionsService>();
suggestions_requestor->SetSuggestions({multi_word_result()});
assistive_suggester.SetSuggestions(
{personal_info_name_result(), personal_info_address_result()});
SuggestionsCollector collector(&assistive_suggester,
std::move(suggestions_requestor));
auto expected_results = std::vector<AssistiveSuggestion>{
personal_info_name_result(),
personal_info_address_result(),
multi_word_result(),
};
collector.GatherSuggestions(
ime::mojom::SuggestionsRequest::New(),
base::BindOnce(&SuggestionsCollectorTest::OnSuggestionsReturned,
base::Unretained(this)));
EXPECT_EQ(suggestions_returned(), expected_results);
}
TEST_F(SuggestionsCollectorTest,
OnlyReturnsAssistiveResultsIfRequestorNotAvailable) {
FakeAssistiveSuggester assistive_suggester;
auto suggestions_requestor = std::make_unique<FakeSuggestionsService>();
suggestions_requestor->SetSuggestions({multi_word_result()});
suggestions_requestor->SetIsAvailable(false);
assistive_suggester.SetSuggestions(
{personal_info_name_result(), personal_info_address_result()});
SuggestionsCollector collector(&assistive_suggester,
std::move(suggestions_requestor));
auto expected_results = std::vector<AssistiveSuggestion>{
personal_info_name_result(),
personal_info_address_result(),
};
collector.GatherSuggestions(
ime::mojom::SuggestionsRequest::New(),
base::BindOnce(&SuggestionsCollectorTest::OnSuggestionsReturned,
base::Unretained(this)));
EXPECT_EQ(suggestions_returned(), expected_results);
}
} // namespace
} // namespace input_method
} // namespace ash
|
