File: secure_dns_manager.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (533 lines) | stat: -rw-r--r-- 20,575 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ash/net/secure_dns_manager.h"

#include <algorithm>
#include <map>
#include <string>
#include <string_view>

#include "ash/constants/ash_pref_names.h"
#include "base/check_is_test.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/values.h"
#include "chrome/browser/ash/net/ash_dns_over_https_config_source.h"
#include "chrome/browser/ash/net/dns_over_https/templates_uri_resolver_impl.h"
#include "chrome/browser/net/secure_dns_config.h"
#include "chrome/browser/net/secure_dns_util.h"
#include "chrome/browser/net/stub_resolver_config_reader.h"
#include "chrome/browser/net/system_network_context_manager.h"
#include "chrome/common/pref_names.h"
#include "chromeos/ash/components/network/device_state.h"
#include "chromeos/ash/components/network/network_configuration_handler.h"
#include "chromeos/ash/components/network/network_event_log.h"
#include "chromeos/ash/components/network/network_handler.h"
#include "chromeos/ash/components/network/network_metadata_store.h"
#include "chromeos/ash/components/network/network_state.h"
#include "components/country_codes/country_codes.h"
#include "net/dns/public/doh_provider_entry.h"
#include "third_party/cros_system_api/dbus/shill/dbus-constants.h"

namespace {
void MigratePrefIfNecessary(const std::string& pref_name,
                            PrefService* from_local_state,
                            PrefService* to_profile_prefs) {
  const base::Value* user_pref_value =
      to_profile_prefs->GetUserPrefValue(pref_name);
  // If there's already a user-set value in the profile prefs, do not override
  // it.
  if (user_pref_value) {
    return;
  }
  const base::Value* pref_value = from_local_state->GetUserPrefValue(pref_name);
  if (!pref_value) {
    return;
  }
  to_profile_prefs->Set(pref_name, *pref_value);

  // TODO(b/323547098): Clear the DoH user-set local state pref once the
  // migration code has ran for a couple of milestones.
  //  from_local_state->ClearPref(pref_name);
}

bool IsUserSetSecureDnsConfigInvalid(const PrefService* local_state) {
  const base::Value* secure_dns_mode =
      local_state->GetUserPrefValue(::prefs::kDnsOverHttpsMode);

  // Can be missing in tests.
  if (!secure_dns_mode) {
    return false;
  }
  if (*secure_dns_mode != base::Value(SecureDnsConfig::kModeSecure)) {
    return false;
  }

  const base::Value* secure_dns_template =
      local_state->GetUserPrefValue(::prefs::kDnsOverHttpsTemplates);
  if (!secure_dns_template || *secure_dns_template == base::Value()) {
    return true;
  }

  return false;
}

// Although DNS configurations are user specific, the initial implementation
// stored the secure DNS config to local_state, making it available to all users
// of the device. Part of restricting the user-set secure DNS preference to the
// user session is migrating the related preferences from local_state to profile
// prefs. See b/323547098 for details.
void MigrateDnsOverHttpsPrefs(PrefService* from_local_state,
                              PrefService* to_profile_prefs) {
  if (IsUserSetSecureDnsConfigInvalid(from_local_state)) {
    // Remove the invalid config. See b/335400734.
    from_local_state->ClearPref(::prefs::kDnsOverHttpsMode);
    return;
  }
  // Migrate local state to user pref.
  MigratePrefIfNecessary(::prefs::kDnsOverHttpsTemplates, from_local_state,
                         to_profile_prefs);
  MigratePrefIfNecessary(::prefs::kDnsOverHttpsMode, from_local_state,
                         to_profile_prefs);
}
}  // namespace
namespace ash {

SecureDnsManager::SecureDnsManager(PrefService* local_state,
                                   user_manager::User& user,
                                   bool is_profile_managed)
    : local_state_(local_state),
      user_(user),
      is_profile_managed_(is_profile_managed) {
  auto* profile_prefs = user.GetProfilePrefs();
  if (!is_profile_managed) {
    CHECK(profile_prefs) << "Profile prefs cannot be empty for unmanaged users";
    MigrateDnsOverHttpsPrefs(local_state, profile_prefs);
  }
  doh_templates_uri_resolver_ =
      std::make_unique<dns_over_https::TemplatesUriResolverImpl>();

  LoadProviders();

  if (is_profile_managed) {
    MonitorLocalStatePrefs();
    OnLocalStatePrefsChanged();
    OnDoHIncludedDomainsPrefChanged();
    OnDoHExcludedDomainsPrefChanged();
  } else {
    MonitorUserPrefs();
    OnPrefChanged();
  }

  // The DNS-over-HTTPS config source is reset in the destructor of the
  // `SecureDnsManager`. This means the `SecureDnsManager` instance should
  // outlive the `AshDnsOverHttpsConfigSource` instance.
  SystemNetworkContextManager::GetStubResolverConfigReader()
      ->SetOverrideDnsOverHttpsConfigSource(
          std::make_unique<AshDnsOverHttpsConfigSource>(this, local_state));
}

void SecureDnsManager::SetPrimaryProfilePropertiesForTesting(
    PrefService* profile_prefs,
    bool is_profile_managed) {
  profile_prefs_registrar_.Reset();
  local_state_registrar_.Reset();
  is_profile_managed_ = is_profile_managed;

  if (is_profile_managed) {
    MonitorLocalStatePrefs();
    OnLocalStatePrefsChanged();
    OnDoHIncludedDomainsPrefChanged();
    OnDoHExcludedDomainsPrefChanged();
  } else {
    MonitorUserPrefs();
    OnPrefChanged();
  }
}

void SecureDnsManager::MonitorUserPrefs() {
  auto* profile_prefs = user_->GetProfilePrefs();
  profile_prefs->SetDefaultPrefValue(
      ::prefs::kDnsOverHttpsMode,
      local_state_->GetDefaultPrefValue(::prefs::kDnsOverHttpsMode)->Clone());

  profile_prefs_registrar_.Init(profile_prefs);
  profile_prefs_registrar_.Add(
      ::prefs::kDnsOverHttpsMode,
      base::BindRepeating(&SecureDnsManager::OnPrefChanged,
                          base::Unretained(this)));
  profile_prefs_registrar_.Add(
      ::prefs::kDnsOverHttpsTemplates,
      base::BindRepeating(&SecureDnsManager::OnPrefChanged,
                          base::Unretained(this)));
}
void SecureDnsManager::MonitorLocalStatePrefs() {
  local_state_registrar_.Init(local_state_);
  static constexpr std::array<const char*, 4> secure_dns_pref_names = {
      ::prefs::kDnsOverHttpsMode, ::prefs::kDnsOverHttpsTemplates,
      ::prefs::kDnsOverHttpsTemplatesWithIdentifiers,
      ::prefs::kDnsOverHttpsSalt};
  for (auto* const pref_name : secure_dns_pref_names) {
    local_state_registrar_.Add(
        pref_name,
        base::BindRepeating(&SecureDnsManager::OnLocalStatePrefsChanged,
                            base::Unretained(this)));
  }
  local_state_registrar_.Add(
      prefs::kDnsOverHttpsIncludedDomains,
      base::BindRepeating(&SecureDnsManager::OnDoHIncludedDomainsPrefChanged,
                          base::Unretained(this)));
  local_state_registrar_.Add(
      prefs::kDnsOverHttpsExcludedDomains,
      base::BindRepeating(&SecureDnsManager::OnDoHExcludedDomainsPrefChanged,
                          base::Unretained(this)));
}

SecureDnsManager::~SecureDnsManager() {
  for (auto& observer : observers_) {
    observer.OnSecureDnsManagerShutdown();
  }

  SystemNetworkContextManager::GetStubResolverConfigReader()
      ->SetOverrideDnsOverHttpsConfigSource(nullptr);

  // `local_state_` outlives the SecureDnsManager instance. The value of
  // `::prefs::kDnsOverHttpsEffectiveTemplatesChromeOS` should not outlive the
  // current instance of SecureDnsManager.
  local_state_->ClearPref(::prefs::kDnsOverHttpsEffectiveTemplatesChromeOS);

  // Reset Shill's state in order for the secure DNS configuration to not leak
  // to the login screen.
  ResetShillState();
}

void SecureDnsManager::SetDoHTemplatesUriResolverForTesting(
    std::unique_ptr<dns_over_https::TemplatesUriResolver>
        doh_templates_uri_resolver) {
  CHECK_IS_TEST();
  doh_templates_uri_resolver_ = std::move(doh_templates_uri_resolver);
}

void SecureDnsManager::LoadProviders() {
  // Note: Check whether each provider is enabled *after* filtering based on
  // country code so that if we are doing experimentation via Finch for a
  // regional provider, the experiment groups will be less likely to include
  // users from other regions unnecessarily (since a client will be included in
  // the experiment if the provider feature flag is checked).
  const net::DohProviderEntry::List local_providers =
      chrome_browser_net::secure_dns::SelectEnabledProviders(
          chrome_browser_net::secure_dns::ProvidersForCountry(
              net::DohProviderEntry::GetList(),
              country_codes::GetCurrentCountryID()));

  for (const net::DohProviderEntry* provider : local_providers) {
    std::vector<std::string> ip_addrs;
    std::ranges::transform(provider->ip_addresses, std::back_inserter(ip_addrs),
                           &net::IPAddress::ToString);
    local_doh_providers_[provider->doh_server_config] =
        base::JoinString(ip_addrs, ",");
  }
}

base::Value::Dict SecureDnsManager::GetProviders(
    const std::string& mode,
    const std::string& templates) const {
  base::Value::Dict doh_providers;

  if (mode == SecureDnsConfig::kModeOff) {
    return doh_providers;
  }

  // If there are templates then use them. In secure mode, the values, which
  // hold the IP addresses of the name servers, are left empty. In secure DNS
  // mode with fallback to plain-text nameservers, the values are stored as a
  // wildcard character denoting that it matches any IP addresses. In automatic
  // upgrade mode, the corresponding name servers will be populated using the
  // applicable providers.
  const std::string_view addr =
      mode == SecureDnsConfig::kModeSecure
          ? ""
          : shill::kDNSProxyDOHProvidersMatchAnyIPAddress;
  for (const auto& doh_template : base::SplitString(
           templates, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY)) {
    doh_providers.Set(doh_template, addr);
  }
  if (mode == SecureDnsConfig::kModeSecure) {
    return doh_providers;
  }
  if (!doh_providers.empty()) {
    return doh_providers;
  }

  // No specified DoH providers, relay all DoH provider upgrade configuration
  // for dns-proxy to switch providers whenever the network or its settings
  // change.
  for (const auto& provider : local_doh_providers_) {
    doh_providers.Set(provider.first.server_template(), provider.second);
  }
  return doh_providers;
}

void SecureDnsManager::AddObserver(Observer* observer) {
  observer->OnModeChanged(cached_chrome_mode_);
  observer->OnTemplateUrisChanged(cached_chrome_template_uris_);
  observers_.AddObserver(observer);
}

void SecureDnsManager::RemoveObserver(Observer* observer) {
  observers_.RemoveObserver(observer);
}

void SecureDnsManager::DefaultNetworkChanged(const NetworkState* network) {
  const std::string& mode = local_state_->GetString(::prefs::kDnsOverHttpsMode);
  if (mode == SecureDnsConfig::kModeOff) {
    return;
  }

  // Network updates are only relevant for determining the effective DoH
  // template URI if the admin has configured the
  // DnsOverHttpsTemplatesWithIdentifiers policy to include the IP addresses.
  std::string templates_with_identifiers =
      local_state_->GetString(::prefs::kDnsOverHttpsTemplatesWithIdentifiers);
  if (!dns_over_https::TemplatesUriResolverImpl::
          IsDeviceIpAddressIncludedInUriTemplate(templates_with_identifiers)) {
    return;
  }
  UpdateTemplateUri();
}

void SecureDnsManager::OnPrefChanged() {
  const auto* profile_prefs = user_->GetProfilePrefs();
  UpdateDoHConfig(profile_prefs->GetString(::prefs::kDnsOverHttpsMode),
                  profile_prefs->GetString(::prefs::kDnsOverHttpsTemplates));
}

void SecureDnsManager::OnLocalStatePrefsChanged() {
  UpdateTemplateUri();
  ToggleNetworkMonitoring();
}

void SecureDnsManager::ToggleNetworkMonitoring() {
  // If DoH with identifiers are active, verify if network changes need to be
  // observed for URI template placeholder replacement.
  std::string templates_with_identifiers =
      local_state_->GetString(::prefs::kDnsOverHttpsTemplatesWithIdentifiers);

  bool template_uri_includes_network_identifiers =
      doh_templates_uri_resolver_->GetDohWithIdentifiersActive() &&
      dns_over_https::TemplatesUriResolverImpl::
          IsDeviceIpAddressIncludedInUriTemplate(templates_with_identifiers);

  bool should_observe_default_network_changes =
      template_uri_includes_network_identifiers &&
      (local_state_->GetString(::prefs::kDnsOverHttpsMode) !=
       SecureDnsConfig::kModeOff);

  if (!should_observe_default_network_changes) {
    network_state_handler_observer_.Reset();
    return;
  }
  // Already observing default network changes.
  if (network_state_handler_observer_.IsObserving()) {
    return;
  }
  network_state_handler_observer_.Observe(
      NetworkHandler::Get()->network_state_handler());
}

void SecureDnsManager::OnDoHIncludedDomainsPrefChanged() {
  base::Value::List included_domains =
      local_state_->GetList(prefs::kDnsOverHttpsIncludedDomains).Clone();
  NetworkHandler::Get()->network_configuration_handler()->SetManagerProperty(
      shill::kDOHIncludedDomainsProperty,
      base::Value(std::move(included_domains)));
  UpdateCachedDomainConfigSet();
}

void SecureDnsManager::OnDoHExcludedDomainsPrefChanged() {
  base::Value::List excluded_domains =
      local_state_->GetList(prefs::kDnsOverHttpsExcludedDomains).Clone();
  NetworkHandler::Get()->network_configuration_handler()->SetManagerProperty(
      shill::kDOHExcludedDomainsProperty,
      base::Value(std::move(excluded_domains)));
  UpdateCachedDomainConfigSet();
}

void SecureDnsManager::UpdateCachedDomainConfigSet() {
  bool domain_config_set =
      !local_state_->GetList(prefs::kDnsOverHttpsIncludedDomains).empty() ||
      !local_state_->GetList(prefs::kDnsOverHttpsExcludedDomains).empty();
  if (domain_config_set == cached_domain_config_set_) {
    return;
  }
  cached_domain_config_set_ = domain_config_set;

  // If DoH domain config changed, force a DoH config update in order for the UI
  // to be updated.
  UpdateDoHConfig(cached_mode_, cached_template_uris_, /*force_update=*/true);
}

void SecureDnsManager::UpdateDoHConfig(const std::string& new_mode,
                                       const std::string& new_template_uris,
                                       bool force_update) {
  UpdateShillDoHConfig(new_mode, new_template_uris);

  // When DoH included or excluded domains policy is set. DoH must be disabled
  // for Chrome in order for the DNS traffic to reach ChromeOS DNS proxy. At the
  // same time, broadcast the changes to force the UI to be updated.
  std::string new_chrome_mode = new_mode;
  std::string new_chrome_template_uris = new_template_uris;
  if (cached_domain_config_set_) {
    new_chrome_mode = SecureDnsConfig::kModeOff;
    new_chrome_template_uris = std::string();
    force_update = true;
  }
  UpdateChromeDoHConfig(new_chrome_mode, new_chrome_template_uris,
                        force_update);
}

void SecureDnsManager::UpdateShillDoHConfig(
    const std::string& new_mode,
    const std::string& new_template_uris) {
  bool mode_changed = new_mode != cached_mode_;
  bool template_uris_changed = new_template_uris != cached_template_uris_;
  if (!mode_changed && !template_uris_changed) {
    // The secure DNS configuration has not changed
    return;
  }

  // Update cached DoH configs.
  cached_mode_ = new_mode;
  cached_template_uris_ = new_template_uris;

  // Set the DoH URI templae shill property which is synced with platform
  // daemons (shill, dns-proxy etc).
  NetworkHandler::Get()->network_configuration_handler()->SetManagerProperty(
      shill::kDNSProxyDOHProvidersProperty,
      base::Value(GetProviders(cached_mode_, cached_template_uris_)));
}

void SecureDnsManager::UpdateChromeDoHConfig(
    const std::string& new_mode,
    const std::string& new_template_uris,
    bool force_update) {
  bool mode_changed = new_mode != cached_chrome_mode_;
  bool template_uris_changed =
      new_template_uris != cached_chrome_template_uris_;
  if (!mode_changed && !template_uris_changed && !force_update) {
    // The secure DNS configuration has not changed
    return;
  }

  // Update cached DoH configs.
  cached_chrome_mode_ = new_mode;
  cached_chrome_template_uris_ = new_template_uris;

  // Broadcast DoH config updates for Chrome.
  for (auto& observer : observers_) {
    if (template_uris_changed || force_update) {
      observer.OnTemplateUrisChanged(cached_chrome_template_uris_);
    }
    if (mode_changed || force_update) {
      observer.OnModeChanged(cached_chrome_mode_);
    }
  }

  // Set the DoH URI template pref which is synced with Lacros and the
  // NetworkService.
  // TODO(acostinas, b/331903009): Storing the effective DoH providers in a
  // local_state pref on Chrome OS has downsides. Replace this pref with an
  // in-memory mechanism to sync effective DoH prefs.
  local_state_->SetString(::prefs::kDnsOverHttpsEffectiveTemplatesChromeOS,
                          cached_chrome_template_uris_);
}

void SecureDnsManager::UpdateTemplateUri() {
  doh_templates_uri_resolver_->Update(*local_state_, user_.get());

  std::string new_templates =
      doh_templates_uri_resolver_->GetEffectiveTemplates();
  std::string new_mode = local_state_->GetString(::prefs::kDnsOverHttpsMode);

  // The DoH config is stored in the local_state only when controlled by policy.
  // If the local_state DoH pref is user-set, it should be ignored.
  if (!local_state_->IsManagedPreference(::prefs::kDnsOverHttpsMode)) {
    new_mode = SecureDnsConfig::kModeOff;
    new_templates = std::string();
  }

  bool prev_is_config_managed = cached_is_config_managed_;
  cached_is_config_managed_ =
      local_state_->FindPreference(::prefs::kDnsOverHttpsMode)->IsManaged();

  // Force DoH config update if the managedness of the config changed.
  UpdateDoHConfig(new_mode, new_templates,
                  cached_is_config_managed_ != prev_is_config_managed);

  // May be missing in tests.
  if (NetworkHandler::Get()->network_metadata_store()) {
    // TODO(b/323547098): Remove the pref management check. In older OS
    // versions, user DoH settings were in local_state, but DoH with identifiers
    // is enterprise-only feature.
    NetworkHandler::Get()
        ->network_metadata_store()
        ->SetSecureDnsTemplatesWithIdentifiersActive(
            doh_templates_uri_resolver_->GetDohWithIdentifiersActive() &&
            local_state_->IsManagedPreference(::prefs::kDnsOverHttpsMode));
  }
}

void SecureDnsManager::ResetShillState() {
  if (!NetworkHandler::IsInitialized()) {
    return;
  }
  auto* handler = NetworkHandler::Get()->network_configuration_handler();
  handler->SetManagerProperty(shill::kDOHIncludedDomainsProperty,
                              base::Value(base::Value::List()));
  handler->SetManagerProperty(shill::kDOHExcludedDomainsProperty,
                              base::Value(base::Value::List()));
  handler->SetManagerProperty(
      shill::kDNSProxyDOHProvidersProperty,
      base::Value(GetProviders(SecureDnsConfig::kModeOff, /*templates=*/"")));
}

// static
void SecureDnsManager::RegisterProfilePrefs(PrefRegistrySimple* registry) {
  registry->RegisterStringPref(::prefs::kDnsOverHttpsMode, std::string());
  registry->RegisterStringPref(::prefs::kDnsOverHttpsTemplates, std::string());
}
// static
void SecureDnsManager::RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
  registry->RegisterStringPref(::prefs::kDnsOverHttpsSalt, std::string());
  registry->RegisterStringPref(::prefs::kDnsOverHttpsTemplatesWithIdentifiers,
                               std::string());
}

std::optional<std::string>
SecureDnsManager::GetDohWithIdentifiersDisplayServers() const {
  if (doh_templates_uri_resolver_->GetDohWithIdentifiersActive()) {
    return doh_templates_uri_resolver_->GetDisplayTemplates();
  }
  return std::nullopt;
}

net::DnsOverHttpsConfig SecureDnsManager::GetOsDohConfig() const {
  net::DnsOverHttpsConfig doh_config;
  if (cached_mode_ != SecureDnsConfig::kModeOff) {
    doh_config = net::DnsOverHttpsConfig::FromStringLax(cached_template_uris_);
  }
  return doh_config;
}

net::SecureDnsMode SecureDnsManager::GetOsDohMode() const {
  return SecureDnsConfig::ParseMode(cached_mode_)
      .value_or(net::SecureDnsMode::kOff);
}

}  // namespace ash