1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/system_logs/single_log_file_log_source.h"
#include <memory>
#include <string>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/run_loop.h"
#include "base/strings/string_split.h"
#include "base/time/time.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace system_logs {
class SingleLogFileLogSourceTest : public ::testing::Test {
public:
SingleLogFileLogSourceTest() : num_callback_calls_(0) {
InitializeTestLogDir();
}
SingleLogFileLogSourceTest(const SingleLogFileLogSourceTest&) = delete;
SingleLogFileLogSourceTest& operator=(const SingleLogFileLogSourceTest&) =
delete;
~SingleLogFileLogSourceTest() override {
SingleLogFileLogSource::SetChromeStartTimeForTesting(nullptr);
}
protected:
// Sets up a dummy system log directory.
void InitializeTestLogDir() {
ASSERT_TRUE(log_dir_.CreateUniqueTempDir());
// Create file "messages".
const base::FilePath messages_path = log_dir_.GetPath().Append("messages");
base::WriteFile(messages_path, "");
EXPECT_TRUE(base::PathExists(messages_path)) << messages_path.value();
// Create file "ui/ui.LATEST".
const base::FilePath ui_dir_path = log_dir_.GetPath().Append("ui");
ASSERT_TRUE(base::CreateDirectory(ui_dir_path)) << ui_dir_path.value();
const base::FilePath ui_latest_path = ui_dir_path.Append("ui.LATEST");
base::WriteFile(ui_latest_path, "");
ASSERT_TRUE(base::PathExists(ui_latest_path)) << ui_latest_path.value();
}
// Initializes the unit under test, |source_| to read a file from the dummy
// system log directory.
void InitializeSource(SingleLogFileLogSource::SupportedSource source_type) {
source_ = std::make_unique<SingleLogFileLogSource>(source_type);
source_->log_file_dir_path_ = log_dir_.GetPath();
log_file_path_ = source_->log_file_dir_path_.Append(source_->source_name());
ASSERT_TRUE(base::PathExists(log_file_path_)) << log_file_path_.value();
}
// Overrides the max read size for testing.
void SetMaxReadSize(int64_t max_read_size) {
source_->SetMaxReadSizeForTesting(max_read_size);
}
// Writes/appends (respectively) a string |input| to file indicated by
// |relative_path| under |log_dir_|.
bool WriteFile(const base::FilePath& relative_path,
const std::string& input) {
return base::WriteFile(log_dir_.GetPath().Append(relative_path), input);
}
bool AppendToFile(const base::FilePath& relative_path,
const std::string& input) {
return base::AppendToFile(log_dir_.GetPath().Append(relative_path), input);
}
// Moves source file to destination path, then creates an empty file at the
// path of the original source file.
//
// |src_relative_path|: Source file path relative to |log_dir_|.
// |dest_relative_path|: Destination path relative to |log_dir_|.
bool RotateFile(const base::FilePath& src_relative_path,
const base::FilePath& dest_relative_path) {
return base::Move(log_dir_.GetPath().Append(src_relative_path),
log_dir_.GetPath().Append(dest_relative_path)) &&
WriteFile(src_relative_path, "");
}
// Calls source_.Fetch() to start a logs fetch operation. Passes in
// OnFileRead() as a callback. Runs until Fetch() has completed.
void FetchFromSource() {
source_->Fetch(base::BindOnce(&SingleLogFileLogSourceTest::OnFileRead,
base::Unretained(this)));
task_environment_.RunUntilIdle();
}
// Callback for fetching logs from |source_|. Overwrites the previous stored
// value of |latest_response_|.
void OnFileRead(std::unique_ptr<SystemLogsResponse> response) {
++num_callback_calls_;
if (response->empty())
return;
// Since |source_| represents a single log source, it should only return a
// single string result.
EXPECT_EQ(1U, response->size());
latest_response_ = std::move(response->begin()->second);
}
int num_callback_calls() const { return num_callback_calls_; }
const std::string& latest_response() const { return latest_response_; }
const base::FilePath& log_file_path() const { return log_file_path_; }
private:
// Creates the necessary browser threads.
content::BrowserTaskEnvironment task_environment_;
// Unit under test.
std::unique_ptr<SingleLogFileLogSource> source_;
// Counts the number of times that |source_| has invoked the callback.
int num_callback_calls_;
// Stores the string response returned from |source_| the last time it invoked
// OnFileRead.
std::string latest_response_;
// Temporary dir for creating a dummy log file.
base::ScopedTempDir log_dir_;
// Path to the dummy log file in |log_dir_|.
base::FilePath log_file_path_;
};
TEST_F(SingleLogFileLogSourceTest, EmptyFile) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, SingleRead) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kUiLatest);
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "Hello world!\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("Hello world!\n", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, IncrementalReads) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Hello world!\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("Hello world!\n", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"),
"The quick brown fox jumps over the lazy dog\n"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("The quick brown fox jumps over the lazy dog\n", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"),
"Some like it hot.\nSome like it cold\n"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
EXPECT_EQ("Some like it hot.\nSome like it cold\n", latest_response());
// As a sanity check, read entire contents of file separately to make sure it
// was written incrementally, and hence read incrementally.
std::string file_contents;
EXPECT_TRUE(base::ReadFileToString(log_file_path(), &file_contents));
EXPECT_EQ(
"Hello world!\nThe quick brown fox jumps over the lazy dog\n"
"Some like it hot.\nSome like it cold\n",
file_contents);
}
// The log files read by SingleLogFileLogSource are not expected to be
// overwritten. This test is just to ensure that the SingleLogFileLogSource
// class is robust enough not to break in the event of an overwrite.
TEST_F(SingleLogFileLogSourceTest, FileOverwrite) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kUiLatest);
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "0123456789\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("0123456789\n", latest_response());
// Overwrite the file.
EXPECT_TRUE(WriteFile(base::FilePath("ui/ui.LATEST"), "abcdefg\n"));
FetchFromSource();
// Should re-read from the beginning.
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("abcdefg\n", latest_response());
// Append to the file to make sure incremental read still works.
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "hijk\n"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
EXPECT_EQ("hijk\n", latest_response());
// Overwrite again, this time with a longer length than the existing file.
// Previous contents:
// abcdefg~hijk~ <-- "~" is a single-char representation of newline.
// New contents:
// lmnopqrstuvwxyz~ <-- excess text beyond end of prev contents: "yz~"
EXPECT_TRUE(WriteFile(base::FilePath("ui/ui.LATEST"), "lmnopqrstuvwxyz\n"));
FetchFromSource();
EXPECT_EQ(4, num_callback_calls());
EXPECT_EQ("yz\n", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, IncompleteLines) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "0123456789"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "abcdefg"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "hijk\n"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
// All the previously written text should be read this time.
EXPECT_EQ("0123456789abcdefghijk\n", latest_response());
// Check ability to read whole lines while leaving the remainder for later.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Hello world\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Goodbye world"));
FetchFromSource();
EXPECT_EQ(4, num_callback_calls());
EXPECT_EQ("Hello world\n", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "\n"));
FetchFromSource();
EXPECT_EQ(5, num_callback_calls());
EXPECT_EQ("Goodbye world\n", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, HandleLogFileRotation) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "1st log file\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("1st log file\n", latest_response());
// Rotate file. Make sure the rest of the old file and the contents of the new
// file are both read.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "More 1st log file\n"));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "2nd log file\n"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("More 1st log file\n2nd log file\n", latest_response());
// Rotate again, but this time omit the newline before rotating.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "No newline here..."));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "3rd log file\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Also no newline here"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
// Make sure the rotation didn't break anything: the last part of the new file
// does not end with a newline; thus the new file should not be read.
EXPECT_EQ("No newline here...3rd log file\n", latest_response());
// Finish the previous read attempt by adding the missing newline.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "...yet\n"));
FetchFromSource();
EXPECT_EQ(4, num_callback_calls());
EXPECT_EQ("Also no newline here...yet\n", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, ReadAtMaxReadSizeNotLimited) {
// Technically other tests exercise this case as well, but this is to be
// explicit and test the edge case.
InitializeSource(SingleLogFileLogSource::SupportedSource::kUiLatest);
SetMaxReadSize(5);
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "1234\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("1234\n", latest_response());
}
TEST_F(SingleLogFileLogSourceTest, ReadOverMaxReadSizeLimitedToTail) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kUiLatest);
SetMaxReadSize(20);
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "Line 1\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "Line 2\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "Line 3\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("ui/ui.LATEST"), "Line 4\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ(
"<earlier logs truncated>\n<partial line>ine 2\n"
"Line 3\n"
"Line 4\n",
latest_response());
}
TEST_F(SingleLogFileLogSourceTest, ReadOverMaxReadSizeBeforeRotate) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
SetMaxReadSize(14);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "1st log file\n"));
EXPECT_TRUE(
AppendToFile(base::FilePath("messages"), "Exceeds max read size\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line>max read size\n",
latest_response());
// Rotate file. Make sure the rest of the old file and the contents of the new
// file are both read.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "More\n"));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "2nd file\n"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("More\n2nd file\n", latest_response());
// Rotate again, but this time omit the newline before rotating.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"),
"Long line without a newline ... "));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "ended\n"));
// Partial line counted against max read size.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "partial"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line> ended\n",
latest_response());
}
TEST_F(SingleLogFileLogSourceTest, ReadOverMaxReadSizeAfterRotate) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
SetMaxReadSize(14);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "1st\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("1st\n", latest_response());
// Rotate file. Make sure the rest of the old file and the contents of the new
// file are both read.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "More\n"));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "2nd file\n"));
EXPECT_TRUE(
AppendToFile(base::FilePath("messages"), "More data in 2nd file\n"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line>a in 2nd file\n",
latest_response());
// Rotate again, but this time omit the newline before rotating.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Start ... "));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"),
"ended here but is a long line\n"));
// Partial line counted against max read size.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "partial"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line>g line\n",
latest_response());
}
TEST_F(SingleLogFileLogSourceTest, ReadOverMaxReadSizeBeforeAndAfterRotate) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
SetMaxReadSize(14);
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "1st log file\n"));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("1st log file\n", latest_response());
EXPECT_TRUE(
AppendToFile(base::FilePath("messages"), "Exceeds max read size 1\n"));
EXPECT_TRUE(
RotateFile(base::FilePath("messages"), base::FilePath("messages.1")));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "2nd file\n"));
EXPECT_TRUE(
AppendToFile(base::FilePath("messages"), "Exceeds max read size 2\n"));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line>x read size 2\n",
latest_response());
}
TEST_F(SingleLogFileLogSourceTest, LongPartialLineEventuallySkipped) {
InitializeSource(SingleLogFileLogSource::SupportedSource::kMessages);
SetMaxReadSize(14);
// A partial line shorter than the max read size.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Start ... "));
FetchFromSource();
EXPECT_EQ(1, num_callback_calls());
EXPECT_EQ("", latest_response());
// The partial line is now longer than max read size.
EXPECT_TRUE(AppendToFile(base::FilePath("messages"),
"someone is still writing this long line ... "));
FetchFromSource();
EXPECT_EQ(2, num_callback_calls());
EXPECT_EQ("", latest_response());
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "end\n"));
EXPECT_TRUE(AppendToFile(base::FilePath("messages"), "Line 2\n"));
FetchFromSource();
EXPECT_EQ(3, num_callback_calls());
EXPECT_EQ("<earlier logs truncated>\n<partial line>.. end\nLine 2\n",
latest_response());
}
} // namespace system_logs
|