1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/chromeos/gemini_app/gemini_app_tab_helper.h"
#include <map>
#include <memory>
#include <string>
#include <vector>
#include "base/containers/enum_set.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_activity_simulator.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/test_browser_window.h"
#include "chromeos/constants/chromeos_features.h"
#include "content/public/browser/site_instance.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using ::base::Bucket;
using ::base::BucketsAreArray;
using ::testing::Bool;
using ::testing::Combine;
using ::testing::WithParamInterface;
} // namespace
// GeminiAppTabHelperTest ------------------------------------------------------
// Base class for tests of the `GeminiAppTabHelper` parameterized by:
// (a) whether the Gemini app preinstallation feature is enabled.
// (b) whether the profile is off the record.
class GeminiAppTabHelperTest
: public ChromeRenderViewHostTestHarness,
public WithParamInterface<
std::tuple</*is_gemini_app_preinstall_enabled=*/bool,
/*is_profile_off_the_record=*/bool>> {
public:
GeminiAppTabHelperTest() {
scoped_feature_list_.InitWithFeatureState(
chromeos::features::kGeminiAppPreinstall,
IsGeminiAppPreinstallEnabled());
}
// Returns whether the Gemini app preinstallation feature is enabled given
// test parameterization.
bool IsGeminiAppPreinstallEnabled() const { return std::get<0>(GetParam()); }
// Returns whether the profile is off the record given test parameterization.
bool IsProfileOffTheRecord() const { return std::get<1>(GetParam()); }
private:
// ChromeRenderViewHostTestHarness:
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
if (IsProfileOffTheRecord()) {
Profile* const profile = Profile::FromBrowserContext(
ChromeRenderViewHostTestHarness::GetBrowserContext());
Profile* const otr_profile = profile->GetOffTheRecordProfile(
Profile::OTRProfileID::CreateUniqueForTesting(),
/*create_if_needed=*/true);
SetContents(content::WebContentsTester::CreateTestWebContents(
otr_profile, content::SiteInstance::Create(otr_profile)));
}
GeminiAppTabHelper::MaybeCreateForWebContents(web_contents());
}
// Used to conditionally enable/disable the Gemini app preinstallation
// feature based on test parameterization.
base::test::ScopedFeatureList scoped_feature_list_;
};
INSTANTIATE_TEST_SUITE_P(All,
GeminiAppTabHelperTest,
Combine(/*is_gemini_app_preinstall_enabled=*/Bool(),
/*is_profile_off_the_record=*/Bool()));
// Tests -----------------------------------------------------------------------
// Verifies that page visits are recorded to histograms as expected.
TEST_P(GeminiAppTabHelperTest, RecordsPageVisitHistograms) {
// Aliases.
using Page = GeminiAppTabHelper::Page;
// Constants.
constexpr char kBaseUrl[] = "https://example.com/";
constexpr char kHistogramName[] = "Ash.GeminiApp.Page.Visit";
constexpr char kRelativeFilename[] = "./filename";
// Pages.
const auto pages =
base::EnumSet<Page, Page::kMinValue, Page::kMaxValue>::All();
// Create multiple URLs for each page.
std::map<GURL, Page> page_urls;
for (const Page page : pages) {
const std::string page_str = base::NumberToString(static_cast<int>(page));
page_urls.emplace(GURL(base::StrCat({kBaseUrl, page_str, "/1/"})), page);
page_urls.emplace(GURL(base::StrCat({kBaseUrl, page_str, "/2/"})), page);
}
// Replace URL for each page.
base::AutoReset<std::map<uint64_t, Page>> page_urls_reset =
GeminiAppTabHelper::SetPageUrlsForTesting(page_urls);
base::HistogramTester histogram_tester;
std::vector<Bucket> histogram_buckets;
// Navigate to `kBaseUrl` and verify that no histograms are recorded.
NavigateAndCommit(GURL(kBaseUrl));
EXPECT_THAT(histogram_tester.GetAllSamples(kHistogramName),
BucketsAreArray(histogram_buckets));
// Navigate to `kRelativeFilename` and verify that no histograms are recorded.
NavigateAndCommit(GURL(kBaseUrl).Resolve(kRelativeFilename));
EXPECT_THAT(histogram_tester.GetAllSamples(kHistogramName),
BucketsAreArray(histogram_buckets));
// Navigate to each `page` `url` and verify that histograms are recorded iff:
// (a) the Gemini app preinstallation feature is enabled, and
// (b) the profile is not off the record.
bool record = IsGeminiAppPreinstallEnabled() && !IsProfileOffTheRecord();
for (const auto& [url, page] : page_urls) {
auto histogram_buckets_it = std::ranges::find(
histogram_buckets, static_cast<base::HistogramBase::Sample32>(page),
&Bucket::min);
{
// Check exact page match.
NavigateAndCommit(url);
if (record) {
if (histogram_buckets_it == histogram_buckets.end()) {
histogram_buckets_it =
histogram_buckets.emplace(histogram_buckets.end(),
/*sample=*/page, /*count=*/1u);
} else {
++(histogram_buckets_it->count);
}
}
EXPECT_THAT(histogram_tester.GetAllSamples(kHistogramName),
BucketsAreArray(histogram_buckets));
}
{
// Check page match w/o filename.
NavigateAndCommit(url.Resolve(kRelativeFilename));
if (record) {
++(histogram_buckets_it->count);
}
EXPECT_THAT(histogram_tester.GetAllSamples(kHistogramName),
BucketsAreArray(histogram_buckets));
}
}
}
|
