1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/controlled_frame/controlled_frame_menu_icon_loader.h"
#include <string_view>
#include "base/test/bind.h"
#include "base/test/gmock_expected_support.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "cc/test/pixel_comparator.h"
#include "cc/test/pixel_test_utils.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/extensions/menu_manager_factory.h"
#include "chrome/browser/ui/web_applications/test/isolated_web_app_test_utils.h"
#include "chrome/browser/web_applications/isolated_web_apps/isolated_web_app_url_info.h"
#include "chrome/browser/web_applications/isolated_web_apps/test/isolated_web_app_builder.h"
#include "chrome/browser/web_applications/test/fake_web_app_provider.h"
#include "chrome/browser/web_applications/test/fake_web_contents_manager.h"
#include "chrome/browser/web_applications/test/web_app_icon_test_utils.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/test/web_app_test.h"
#include "chrome/common/chrome_features.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_features.h"
#include "services/data_decoder/public/cpp/test_support/in_process_data_decoder.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/favicon_size.h"
#include "ui/menus/simple_menu_model.h"
namespace controlled_frame {
namespace {
constexpr std::string_view kIconPath = "/icon2.png";
const int kTestWebViewInstanceId = 1;
} // namespace
class ControlledFrameMenuIconLoaderTest : public WebAppTest {
public:
ControlledFrameMenuIconLoaderTest() {
scoped_feature_list_.InitWithFeatures(
/*enabled_features=*/{features::kIsolatedWebApps,
features::kIsolatedWebAppDevMode},
/*disabled_features=*/{});
}
void SetUp() override {
WebAppTest::SetUp();
web_app::test::AwaitStartWebAppProviderAndSubsystems(profile());
app_ = web_app::IsolatedWebAppBuilder(web_app::ManifestBuilder())
.AddIconAsPng(kIconPath, web_app::CreateSquareIcon(
gfx::kFaviconSize, SK_ColorRED))
.BuildBundle();
app_->TrustSigningKey();
app_->FakeInstallPageState(profile());
ASSERT_OK_AND_ASSIGN(web_app::IsolatedWebAppUrlInfo url_info,
app_->Install(profile()));
app_origin_url_ = url_info.origin().GetURL();
web_app::SimulateIsolatedWebAppNavigation(web_contents(), app_origin_url_);
CHECK_EQ(
web_contents()->GetPrimaryMainFrame()->GetWebExposedIsolationLevel(),
content::WebExposedIsolationLevel::kIsolatedApplication);
}
// Creates and returns a menu manager.
extensions::MenuManager* CreateMenuManager() {
return static_cast<extensions::MenuManager*>(
extensions::MenuManagerFactory::GetInstance()->SetTestingFactoryAndUse(
profile(),
base::BindRepeating(&extensions::MenuManagerFactory::
BuildServiceInstanceForTesting)));
}
// Returns a test item with the given string ID for Controlled Frame.
std::unique_ptr<extensions::MenuItem> CreateTestItem(
int webview_embedder_process_id,
int webview_embedder_frame_id,
int webview_instance_id,
const std::string& string_id,
bool visible) {
extensions::MenuItem::Id id(
false, extensions::MenuItem::ExtensionKey(
/*extension_id=*/"", webview_embedder_process_id,
webview_embedder_frame_id, webview_instance_id));
id.string_uid = string_id;
return std::make_unique<extensions::MenuItem>(
id, "test", false, visible, true, extensions::MenuItem::NORMAL,
extensions::MenuItem::ContextList(extensions::MenuItem::LAUNCHER));
}
GURL app_origin_url() { return app_origin_url_; }
web_app::FakeWebContentsManager& web_contents_manager() {
return static_cast<web_app::FakeWebContentsManager&>(
fake_provider().web_contents_manager());
}
private:
data_decoder::test::InProcessDataDecoder in_process_data_decoder_;
base::test::ScopedFeatureList scoped_feature_list_;
std::unique_ptr<web_app::ScopedBundledIsolatedWebApp> app_;
GURL app_origin_url_;
};
TEST_F(ControlledFrameMenuIconLoaderTest, LoadGetAndRemoveIcon) {
ControlledFrameMenuIconLoader menu_icon_loader;
extensions::MenuItem::ExtensionKey extension_key(
/*extension_id=*/"", main_rfh()->GetProcess()->GetDeprecatedID(),
main_rfh()->GetRoutingID(), kTestWebViewInstanceId);
base::test::TestFuture<void> future;
menu_icon_loader.SetNotifyOnLoadedCallbackForTesting(
future.GetRepeatingCallback());
menu_icon_loader.LoadIcon(browser_context(), /*extension=*/nullptr,
extension_key);
EXPECT_EQ(1u, menu_icon_loader.pending_icons_.size());
EXPECT_EQ(0u, menu_icon_loader.icons_.size());
ASSERT_TRUE(future.Wait());
EXPECT_EQ(0u, menu_icon_loader.pending_icons_.size());
EXPECT_EQ(1u, menu_icon_loader.icons_.size());
gfx::Image icon = menu_icon_loader.GetIcon(extension_key);
EXPECT_EQ(gfx::kFaviconSize, icon.Height());
EXPECT_EQ(gfx::kFaviconSize, icon.Width());
menu_icon_loader.RemoveIcon(extension_key);
EXPECT_EQ(0u, menu_icon_loader.pending_icons_.size());
EXPECT_EQ(0u, menu_icon_loader.icons_.size());
}
TEST_F(ControlledFrameMenuIconLoaderTest, MenuManager) {
extensions::MenuManager* menu_manager = CreateMenuManager();
// Check that adding a context item starts the icon loading and that the icon
// is able to be accessed through GetIcon. Also check that the icon is removed
// when the context item is removed.
std::unique_ptr<extensions::MenuItem> item = CreateTestItem(
main_rfh()->GetProcess()->GetDeprecatedID(), main_rfh()->GetRoutingID(),
/*webview_instance_id=*/kTestWebViewInstanceId, /*string_id=*/"test",
/*visible=*/true);
const extensions::MenuItem::Id& item_id = item->id();
auto menu_icon_loader = std::make_unique<ControlledFrameMenuIconLoader>();
ControlledFrameMenuIconLoader* menu_icon_loader_ptr = menu_icon_loader.get();
menu_manager->SetMenuIconLoader(item_id.extension_key,
std::move(menu_icon_loader));
base::test::TestFuture<void> future;
menu_icon_loader_ptr->SetNotifyOnLoadedCallbackForTesting(
future.GetRepeatingCallback());
menu_manager->AddContextItem(/*extension=*/nullptr, std::move(item));
ASSERT_TRUE(future.Wait());
// Ensure that grabbing the icon through the MenuManager returns the
// expected icon.
EXPECT_EQ(1u, menu_icon_loader_ptr->icons_.size());
gfx::Image loader_icon = menu_icon_loader_ptr->GetIcon(item_id.extension_key);
gfx::Image menu_manager_icon =
menu_manager->GetIconForExtensionKey(item_id.extension_key);
EXPECT_EQ(loader_icon, menu_manager_icon);
menu_manager->RemoveContextMenuItem(item_id);
EXPECT_EQ(0u, menu_icon_loader_ptr->pending_icons_.size());
EXPECT_EQ(0u, menu_icon_loader_ptr->icons_.size());
}
TEST_F(ControlledFrameMenuIconLoaderTest, ContextMenuMatcher) {
extensions::MenuManager* menu_manager = CreateMenuManager();
std::unique_ptr<extensions::MenuItem> item = CreateTestItem(
main_rfh()->GetProcess()->GetDeprecatedID(), main_rfh()->GetRoutingID(),
/*webview_instance_id=*/kTestWebViewInstanceId, /*string_id=*/"test",
/*visible=*/true);
const extensions::MenuItem::Id& item_id = item->id();
auto menu_icon_loader = std::make_unique<ControlledFrameMenuIconLoader>();
ControlledFrameMenuIconLoader* menu_icon_loader_ptr = menu_icon_loader.get();
menu_manager->SetMenuIconLoader(item_id.extension_key,
std::move(menu_icon_loader));
base::test::TestFuture<void> future;
menu_icon_loader_ptr->SetNotifyOnLoadedCallbackForTesting(
future.GetRepeatingCallback());
menu_manager->AddContextItem(/*extension=*/nullptr, std::move(item));
ASSERT_TRUE(future.Wait());
ui::SimpleMenuModel menu_model(/*delegate=*/nullptr);
auto extension_items = std::make_unique<extensions::ContextMenuMatcher>(
profile(),
/*delegate=*/nullptr, &menu_model,
base::BindLambdaForTesting(
[](const extensions::MenuItem* item) { return true; }));
int index = 0;
extension_items->AppendExtensionItems(item_id.extension_key, std::u16string(),
&index,
/*is_action_menu=*/false);
gfx::Image icon = menu_model.GetIconAt(/*index=*/0).GetImage();
EXPECT_EQ(gfx::kFaviconSize, icon.Height());
EXPECT_EQ(gfx::kFaviconSize, icon.Width());
web_app::FakeWebContentsManager::FakeIconState& icon_state =
web_contents_manager().GetOrCreateIconState(
app_origin_url().Resolve(kIconPath));
ASSERT_EQ(1u, icon_state.bitmaps.size());
EXPECT_TRUE(cc::MatchesBitmap(icon_state.bitmaps[0], icon.AsBitmap(),
cc::ExactPixelComparator()));
}
} // namespace controlled_frame
|
