1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/features.h"
#include "base/files/file.h"
#include "base/path_service.h"
#include "chrome/browser/browser_features.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/devtools/protocol/devtools_protocol_test_support.h"
#include "chrome/browser/extensions/scoped_test_mv2_enabler.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/test/browser_test.h"
#include "extensions/browser/api/storage/storage_area_namespace.h"
#include "extensions/browser/api/storage/storage_frontend.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/extension_id.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/mojom/manifest.mojom-shared.h"
#include "extensions/test/extension_background_page_waiter.h"
#include "extensions/test/extension_test_message_listener.h"
namespace {
class DevToolsExtensionsProtocolTest : public DevToolsProtocolTestBase {
public:
void SetUpOnMainThread() override {
DevToolsProtocolTestBase::SetUpOnMainThread();
AttachToBrowserTarget();
}
void SetUpCommandLine(base::CommandLine* command_line) override {
DevToolsProtocolTestBase::SetUpCommandLine(command_line);
command_line->RemoveSwitch(::switches::kEnableUnsafeExtensionDebugging);
}
const base::Value::Dict* SendLoadUnpackedCommand(const std::string& path) {
base::FilePath extension_path =
base::PathService::CheckedGet(chrome::DIR_TEST_DATA)
.AppendASCII("devtools")
.AppendASCII("extensions")
.AppendASCII(path);
base::Value::Dict params;
params.Set("path", extension_path.AsUTF8Unsafe());
return SendCommandSync("Extensions.loadUnpacked", std::move(params));
}
const base::Value::Dict* SendStorageCommand(
const std::string& command,
const extensions::Extension* extension,
base::Value::Dict extra_params) {
base::Value::Dict storage_params;
storage_params.Set("id", extension->id());
storage_params.Set("storageArea", "local");
storage_params.Merge(std::move(extra_params));
const base::Value::Dict* get_result =
SendCommandSync(command, std::move(storage_params));
return get_result;
}
private:
// TODO(https://crbug.com/40804030): Remove this when updated to use MV3.
extensions::ScopedTestMV2Enabler mv2_enabler_;
};
class DevToolsExtensionsProtocolWithUnsafeDebuggingTest
: public DevToolsExtensionsProtocolTest {
public:
DevToolsExtensionsProtocolWithUnsafeDebuggingTest() {
scoped_feature_list_.InitAndEnableFeature(
extensions_features::kExtensionDisableUnsupportedDeveloper);
}
void SetUpCommandLine(base::CommandLine* command_line) override {
DevToolsExtensionsProtocolTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(::switches::kEnableUnsafeExtensionDebugging);
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolTest, CannotInstallExtension) {
ASSERT_FALSE(SendLoadUnpackedCommand("simple_background_page"));
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolTest,
CannotUninstallExtension) {
auto extension =
extensions::ExtensionBuilder("unpacked")
.SetLocation(extensions::mojom::ManifestLocation::kUnpacked)
.Build();
extensions::ExtensionRegistrar::Get(browser()->profile())
->AddExtension(extension.get());
std::string id = extension.get()->id();
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension_before =
registry->GetInstalledExtension(id);
ASSERT_TRUE(extension_before);
base::Value::Dict params;
params.Set("id", id);
const base::Value::Dict* uninstall_result =
SendCommandSync("Extensions.uninstall", std::move(params));
ASSERT_FALSE(uninstall_result);
const extensions::Extension* extension_after =
registry->GetInstalledExtension(id);
ASSERT_TRUE(extension_after);
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CanInstallExtension) {
const base::Value::Dict* result =
SendLoadUnpackedCommand("simple_background_page");
ASSERT_TRUE(result);
ASSERT_TRUE(result->FindString("id"));
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension = registry->GetExtensionById(
*result->FindString("id"), extensions::ExtensionRegistry::ENABLED);
ASSERT_TRUE(extension);
ASSERT_EQ(extension->id(), *result->FindString("id"));
ASSERT_EQ(extension->location(),
extensions::mojom::ManifestLocation::kUnpacked);
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
ThrowsOnWrongPath) {
const base::Value::Dict* result = SendLoadUnpackedCommand("non-existent");
ASSERT_FALSE(result);
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CanUninstallExtension) {
const base::Value::Dict* install_result =
SendLoadUnpackedCommand("simple_background_page");
std::string id = *install_result->FindString("id");
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension_before =
registry->GetInstalledExtension(id);
ASSERT_TRUE(extension_before);
base::Value::Dict params;
params.Set("id", id);
const base::Value::Dict* uninstall_result =
SendCommandSync("Extensions.uninstall", std::move(params));
ASSERT_TRUE(uninstall_result);
const extensions::Extension* extension_after =
registry->GetInstalledExtension(id);
ASSERT_FALSE(extension_after);
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CannotUninstallNonUnpackedExtension) {
auto extension =
extensions::ExtensionBuilder("unpacked")
.SetLocation(extensions::mojom::ManifestLocation::kComponent)
.Build();
extensions::ExtensionRegistrar::Get(browser()->profile())
->AddExtension(extension.get());
std::string id = extension.get()->id();
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension_before =
registry->GetInstalledExtension(id);
ASSERT_TRUE(extension_before);
base::Value::Dict params;
params.Set("id", id);
const base::Value::Dict* uninstall_result =
SendCommandSync("Extensions.uninstall", std::move(params));
ASSERT_FALSE(uninstall_result);
const extensions::Extension* extension_after =
registry->GetInstalledExtension(id);
ASSERT_TRUE(extension_after);
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
FailsToUninstallNonexistentExtension) {
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
std::string id = "non-existent-id";
const extensions::Extension* extension = registry->GetInstalledExtension(id);
ASSERT_FALSE(extension);
base::Value::Dict params;
params.Set("id", id);
const base::Value::Dict* uninstallResult =
SendCommandSync("Extensions.uninstall", std::move(params));
ASSERT_FALSE(uninstallResult);
const extensions::Extension* extensionAfter =
registry->GetInstalledExtension(id);
ASSERT_FALSE(extensionAfter);
}
// Returns the `DevToolsAgentHost` associated with an extension's service
// worker if available.
scoped_refptr<content::DevToolsAgentHost> FindExtensionHost(
const std::string& id) {
for (auto& host : content::DevToolsAgentHost::GetOrCreateAll()) {
if (host->GetType() == content::DevToolsAgentHost::kTypeServiceWorker &&
host->GetURL().host() == id) {
return host;
}
}
return nullptr;
}
// Returns the `DevToolsAgentHost` associated with an extension page if
// available.
scoped_refptr<content::DevToolsAgentHost> FindBackgroundPageHost(
const std::string& path) {
for (auto& host : content::DevToolsAgentHost::GetOrCreateAll()) {
if (host->GetType() == "background_page" && host->GetURL().path() == path) {
return host;
}
}
return nullptr;
}
// Returns the `DevToolsAgentHost` associated with an extension page if
// available.
scoped_refptr<content::DevToolsAgentHost> FindPageHost(
const std::string& path) {
for (auto& host : content::DevToolsAgentHost::GetOrCreateAll()) {
if (host->GetType() == content::DevToolsAgentHost::kTypePage &&
host->GetURL().path() == path) {
return host;
}
}
return nullptr;
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CanGetStorageValues) {
ExtensionTestMessageListener activated_listener("WORKER_ACTIVATED");
const base::Value::Dict* load_result =
SendLoadUnpackedCommand("service_worker");
ASSERT_TRUE(load_result);
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension = registry->GetExtensionById(
*load_result->FindString("id"), extensions::ExtensionRegistry::ENABLED);
ASSERT_TRUE(extension);
// Ensure service worker has had time to initialize.
EXPECT_TRUE(activated_listener.WaitUntilSatisfied());
// Access to storage commands is only allowed from a target associated with
// the extension. Attach to the extension service worker to be able to test
// the method.
DetachProtocolClient();
agent_host_ = FindExtensionHost(extension->id());
agent_host_->AttachClient(this);
// Set some dummy values in storage.
ASSERT_TRUE(SendStorageCommand(
"Extensions.setStorageItems", extension,
base::Value::Dict().Set("values", base::Value::Dict()
.Set("foo", "bar")
.Set("other", "value")
.Set("remove-on-clear", "value"))));
// Check only the requested keys are returned.
const base::Value::Dict* get_result = SendStorageCommand(
"Extensions.getStorageItems", extension,
base::Value::Dict().Set("keys", base::Value::List().Append("foo")));
ASSERT_TRUE(get_result);
ASSERT_EQ(*get_result->FindDict("data")->FindString("foo"), "bar");
ASSERT_FALSE(get_result->FindDict("data")->contains("other"));
// Remove the `foo` key.
ASSERT_TRUE(SendStorageCommand(
"Extensions.removeStorageItems", extension,
base::Value::Dict().Set("keys", base::Value::List().Append("foo"))));
// Check the `foo` key no longer exists.
const base::Value::Dict* get_result_2 = SendStorageCommand(
"Extensions.getStorageItems", extension,
base::Value::Dict().Set("keys", base::Value::List().Append("foo")));
ASSERT_TRUE(get_result_2);
ASSERT_FALSE(get_result_2->FindDict("data")->contains("foo"));
// Clear the storage area.
ASSERT_TRUE(SendStorageCommand("Extensions.clearStorageItems", extension,
base::Value::Dict()));
// Check the `remove-on-clear` key no longer exists.
const base::Value::Dict* get_result_3 = SendStorageCommand(
"Extensions.getStorageItems", extension,
base::Value::Dict().Set("keys",
base::Value::List().Append("remove-on-clear")));
ASSERT_TRUE(get_result_3);
ASSERT_FALSE(get_result_3->FindDict("data")->contains("remove-on-clear"));
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CanGetStorageValuesBackgroundPage) {
const base::Value::Dict* load_result =
SendLoadUnpackedCommand("background_page_storage_access");
ASSERT_TRUE(load_result);
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension = registry->GetExtensionById(
*load_result->FindString("id"), extensions::ExtensionRegistry::ENABLED);
ASSERT_TRUE(extension);
DetachProtocolClient();
extensions::ExtensionBackgroundPageWaiter(browser()->profile(), *extension)
.WaitForBackgroundOpen();
agent_host_ = FindBackgroundPageHost("/_generated_background_page.html");
agent_host_->AttachClient(this);
ASSERT_TRUE(SendStorageCommand("Extensions.getStorageItems", extension,
base::Value::Dict()));
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CanGetStorageValuesContentScript) {
const base::Value::Dict* load_result =
SendLoadUnpackedCommand("simple_content_script");
ASSERT_TRUE(load_result);
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension = registry->GetExtensionById(
*load_result->FindString("id"), extensions::ExtensionRegistry::ENABLED);
ASSERT_TRUE(extension);
ASSERT_TRUE(embedded_test_server()->Start());
GURL url =
embedded_test_server()->GetURL("/devtools/page_with_content_script.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DetachProtocolClient();
agent_host_ = FindPageHost("/devtools/page_with_content_script.html");
agent_host_->AttachClient(this);
ASSERT_TRUE(SendStorageCommand("Extensions.getStorageItems", extension,
base::Value::Dict()));
}
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CannotGetStorageValuesWithoutContentScript) {
// Load an extension with no associated content scripts.
const base::Value::Dict* load_result =
SendLoadUnpackedCommand("service_worker");
ASSERT_TRUE(load_result);
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
const extensions::Extension* extension = registry->GetExtensionById(
*load_result->FindString("id"), extensions::ExtensionRegistry::ENABLED);
ASSERT_TRUE(extension);
ASSERT_TRUE(embedded_test_server()->Start());
GURL url =
embedded_test_server()->GetURL("/devtools/page_with_content_script.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
DetachProtocolClient();
agent_host_ = FindPageHost("/devtools/page_with_content_script.html");
agent_host_->AttachClient(this);
const base::Value::Dict* get_result = SendStorageCommand(
"Extensions.getStorageItems", extension, base::Value::Dict());
// Command should fail as extension has not injected content script.
EXPECT_FALSE(get_result);
ASSERT_EQ(*error()->FindString("message"), "Extension not found.");
}
// Test to ensure that the target associated with an extension service worker
// cannot access data from the storage associated with another extension.
IN_PROC_BROWSER_TEST_F(DevToolsExtensionsProtocolWithUnsafeDebuggingTest,
CannotGetStorageValuesUnrelatedTarget) {
ExtensionTestMessageListener activated_listener("WORKER_ACTIVATED");
const base::Value::Dict* load_result =
SendLoadUnpackedCommand("service_worker");
ASSERT_TRUE(load_result);
const std::string first_extension_id = *load_result->FindString("id");
// Ensure service worker has had time to initialize.
EXPECT_TRUE(activated_listener.WaitUntilSatisfied());
// Load a second extension.
load_result = SendLoadUnpackedCommand("simple_background_page");
ASSERT_TRUE(load_result);
const std::string second_extension_id = *load_result->FindString("id");
// Attach to first extension.
DetachProtocolClient();
agent_host_ = FindExtensionHost(first_extension_id);
agent_host_->AttachClient(this);
// Try to load data from the second extension from a context associated with
// the first extension. This should be blocked.
base::Value::Dict storage_params;
storage_params.Set("id", second_extension_id);
storage_params.Set("storageArea", "local");
const base::Value::Dict* get_result =
SendCommandSync("Extensions.getStorageItems", std::move(storage_params));
// Command should fail as target does not have access.
EXPECT_FALSE(get_result);
ASSERT_EQ(*error()->FindString("message"), "Extension not found.");
}
} // namespace
|