1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <tuple>
#include "base/test/scoped_feature_list.h"
#include "base/test/values_test_util.h"
#include "chrome/browser/devtools/protocol/devtools_protocol_test_support.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/autofill/core/common/autofill_features.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test_utils.h"
// TODO(crbug.com/40249826): Refactor tests when we start emitting issues in
// bulk, via checkFormsIssues command and FormIssuesAdded event.
namespace autofill {
using testing::Eq;
using testing::Pointee;
namespace {
class AutofillFormDevtoolsProtocolTest : public DevToolsProtocolTestBase {
public:
void NavigateToFormPageAndEnableAudits() {
Attach();
GURL test_url = content::GetTestUrl(
"autofill", "autofill_form_devtools_issues_test.html");
EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), test_url));
EXPECT_TRUE(content::WaitForLoadStop(web_contents()));
SendCommandSync("Audits.enable");
}
base::Value::Dict WaitForGenericIssueAdded(const std::string& error_type) {
auto matcher = [](const std::string& error_type,
const base::Value::Dict& params) {
const std::string* maybe_error_type = params.FindStringByDottedPath(
"issue.details.genericIssueDetails.errorType");
return maybe_error_type && *maybe_error_type == error_type;
};
base::Value::Dict notification = WaitForMatchingNotification(
"Audits.issueAdded", base::BindRepeating(matcher, error_type));
EXPECT_EQ(*notification.FindStringByDottedPath("issue.code"),
"GenericIssue");
return notification;
}
private:
base::test::ScopedFeatureList scoped_features_;
};
} // namespace
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
checkFormIssuesCommandReturnsIssuesList) {
NavigateToFormPageAndEnableAudits();
const base::Value::Dict* res = SendCommandSync("Audits.checkFormsIssues");
const base::Value::List* issues = res->FindListByDottedPath("formIssues");
ASSERT_NE(issues, nullptr);
ASSERT_EQ(issues->size(), 0ul);
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasLabelAssociatedToNameAttribute) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormLabelForNameError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasInputsWithDuplicateId) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormDuplicateIdForInputError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
EXPECT_THAT(notification.FindByDottedPath(
"issue.details.genericIssueDetails.violatingNodeAttribute"),
Pointee(Eq("id")));
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasInputWithEmptyAutocompleteAttribute) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormAutocompleteAttributeEmptyError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
EXPECT_THAT(notification.FindByDottedPath(
"issue.details.genericIssueDetails.violatingNodeAttribute"),
Pointee(Eq("autocomplete")));
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasInputWithoutIdAndName) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormEmptyIdAndNameAttributesForInputError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
}
IN_PROC_BROWSER_TEST_F(
AutofillFormDevtoolsProtocolTest,
FormHasInputWithAriaLabelledByAttributeThatLinksToNonExistingId) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormAriaLabelledByToNonExistingId");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
}
IN_PROC_BROWSER_TEST_F(
AutofillFormDevtoolsProtocolTest,
FormHasInputAssignedAutocompleteValueToIdOrNameAttributesIssue) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification = WaitForGenericIssueAdded(
"FormInputAssignedAutocompleteValueToIdOrNameAttributeError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
EXPECT_THAT(notification.FindByDottedPath(
"issue.details.genericIssueDetails.violatingNodeAttribute"),
Pointee(Eq("id")));
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasLabelWithoutNeitherForNorNestedInput) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormLabelHasNeitherForNorNestedInput");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormHasLabelAssociatedToNonExistingId) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification =
WaitForGenericIssueAdded("FormLabelForMatchesNonExistingIdError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
EXPECT_THAT(notification.FindByDottedPath(
"issue.details.genericIssueDetails.violatingNodeAttribute"),
Pointee(Eq("for")));
}
IN_PROC_BROWSER_TEST_F(AutofillFormDevtoolsProtocolTest,
FormInputHasWrongButWellIntendedAutocompleteValueError) {
NavigateToFormPageAndEnableAudits();
base::Value::Dict notification = WaitForGenericIssueAdded(
"FormInputHasWrongButWellIntendedAutocompleteValueError");
EXPECT_TRUE(notification
.FindIntByDottedPath(
"issue.details.genericIssueDetails.violatingNodeId")
.has_value());
EXPECT_THAT(notification.FindByDottedPath(
"issue.details.genericIssueDetails.violatingNodeAttribute"),
Pointee(Eq("autocomplete")));
}
} // namespace autofill
|
