1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/download/bubble/download_bubble_accessible_alerts_map.h"
#include <string>
#include <vector>
#include "base/strings/stringprintf.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using ::testing::AllOf;
using ::testing::Field;
using ::testing::IsEmpty;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;
using Alert = DownloadBubbleAccessibleAlertsMap::Alert;
using offline_items_collection::ContentId;
using Urgency = Alert::Urgency;
ContentId CreateTestContentId(const std::string& id) {
return ContentId{"test", id};
}
class DownloadBubbleAccessibleAlertsMapTest : public ::testing::Test {
public:
DownloadBubbleAccessibleAlertsMap& map() { return map_; }
void FastForwardBy(base::TimeDelta delta) {
task_environment_.FastForwardBy(delta);
}
private:
DownloadBubbleAccessibleAlertsMap map_;
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
};
TEST_F(DownloadBubbleAccessibleAlertsMapTest, AddNormalAlertToEmptyMap) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert1")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest, AddUrgentAlertToEmptyMap) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddTwoAlertsForDifferentDownloads) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert1"}));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download2"),
Alert{Urgency::kAlertWhenAppropriate, u"alert2"}));
EXPECT_THAT(
map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert1"))),
Pair(CreateTestContentId("download2"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert2")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1", u"alert2"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now),
Pair(CreateTestContentId("download2"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddTwoNormalAlertsForSameDownload) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert1"}));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert2")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert2"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddTwoUrgentAlertsForSameDownload) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert2")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert2"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddNormalThenUrgentForSameDownload) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert1"}));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert2")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert2"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddUrgentThenNormalForSameDownload) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_FALSE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
AddTwoAlertsForSameDownload_BackwardsTime) {
struct {
Alert::Urgency first_alert_urgency;
Alert::Urgency second_alert_urgency;
} kTestCases[] = {
{Urgency::kAlertSoon, Urgency::kAlertSoon},
{Urgency::kAlertSoon, Urgency::kAlertWhenAppropriate},
{Urgency::kAlertWhenAppropriate, Urgency::kAlertSoon},
{Urgency::kAlertWhenAppropriate, Urgency::kAlertWhenAppropriate},
};
for (const auto& test_case : kTestCases) {
SCOPED_TRACE(base::StringPrintf(
"first: %d second: %d", static_cast<int>(test_case.first_alert_urgency),
static_cast<int>(test_case.second_alert_urgency)));
// Make a new map so test cases are independent.
DownloadBubbleAccessibleAlertsMap map;
// Simulate system clock jumping backwards (base::Time is not guaranteed to
// be monotonic), by creating the second alert before creating the first.
Alert alert2{test_case.second_alert_urgency, u"alert2"};
FastForwardBy(base::Seconds(30));
Alert alert1{test_case.first_alert_urgency, u"alert1"};
EXPECT_TRUE(map.MaybeAddAccessibleAlert(CreateTestContentId("download1"),
std::move(alert1)));
EXPECT_FALSE(map.MaybeAddAccessibleAlert(CreateTestContentId("download1"),
std::move(alert2)));
// The first-added alert should be retained because it is "more recent" than
// the new one.
EXPECT_THAT(map.unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, test_case.first_alert_urgency),
Field(&Alert::text, u"alert1")))));
}
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest, DontAnnounceStaleAlert) {
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
// Advance time more than 1 minute to make the alert stale.
FastForwardBy(base::Minutes(2));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, IsEmpty());
EXPECT_THAT(map().last_alerted_times_for_testing(), IsEmpty());
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest,
DontAnnounceAlreadyAnnouncedTooSoon) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
// Advance time less than 3 minutes.
FastForwardBy(base::Minutes(2));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert2")))));
to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, IsEmpty());
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert2")))));
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest, AnnounceAfterIntervalPassed) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert1"));
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"), now)));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
// Advance time more than 3 minutes.
FastForwardBy(base::Minutes(4));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"),
Alert{Urgency::kAlertWhenAppropriate, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(Pair(
CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertWhenAppropriate),
Field(&Alert::text, u"alert2")))));
to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert2"));
EXPECT_THAT(map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download1"),
now + base::Minutes(4))));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
}
TEST_F(DownloadBubbleAccessibleAlertsMapTest, GarbageCollect) {
base::Time now = base::Time::Now();
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download1"), Alert{Urgency::kAlertSoon, u"alert1"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1")))));
// Advance time more than 1 minute to make the first alert stale.
FastForwardBy(base::Minutes(2));
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download2"), Alert{Urgency::kAlertSoon, u"alert2"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download1"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert1"))),
Pair(CreateTestContentId("download2"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert2")))));
// Garbage collecting should delete the stale alert.
map().GarbageCollect();
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download2"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert2")))));
// Announce the second alert to make a last-alerted-time appear for alert2.
std::vector<std::u16string> to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert2"));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
EXPECT_THAT(map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download2"),
now + base::Minutes(2))));
// Advance time by more than 6 minutes to make alert2's time stale.
FastForwardBy(base::Minutes(7));
// Add another alert that will not be stale.
EXPECT_TRUE(map().MaybeAddAccessibleAlert(
CreateTestContentId("download3"), Alert{Urgency::kAlertSoon, u"alert3"}));
EXPECT_THAT(map().unannounced_alerts_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download3"),
AllOf(Field(&Alert::urgency, Urgency::kAlertSoon),
Field(&Alert::text, u"alert3")))));
EXPECT_THAT(map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download2"),
now + base::Minutes(2))));
// Announce the third alert to make a last-alerted-time appear for alert3.
to_announce = map().TakeAlertsForAnnouncement();
EXPECT_THAT(to_announce, UnorderedElementsAre(u"alert3"));
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
EXPECT_THAT(
map().last_alerted_times_for_testing(),
UnorderedElementsAre(
Pair(CreateTestContentId("download2"), now + base::Minutes(2)),
Pair(CreateTestContentId("download3"), now + base::Minutes(2 + 7))));
// Garbage collecting should delete the stale time.
map().GarbageCollect();
EXPECT_THAT(map().unannounced_alerts_for_testing(), IsEmpty());
EXPECT_THAT(map().last_alerted_times_for_testing(),
UnorderedElementsAre(Pair(CreateTestContentId("download3"),
now + base::Minutes(2 + 7))));
}
} // namespace
|
