1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/download/download_shelf_context_menu.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/download/download_item_model.h"
#include "chrome/browser/download/download_stats.h"
#include "components/download/public/common/mock_download_item.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::NiceMock;
using testing::Return;
class DownloadShelfContextMenuTest : public testing::Test {
public:
DownloadShelfContextMenuTest() = default;
DownloadShelfContextMenu* menu() { return context_menu_.get(); }
void MakeContextMenu(DownloadUIModel* download) {
// Don't use std::make_unique because it needs friend.
context_menu_ =
base::WrapUnique(new DownloadShelfContextMenu(download->GetWeakPtr()));
}
void RunUntilIdle() { task_environment_.RunUntilIdle(); }
private:
content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<DownloadShelfContextMenu> context_menu_;
};
TEST_F(DownloadShelfContextMenuTest, InvalidDownloadWontCrashContextMenu) {
std::unique_ptr<download::MockDownloadItem> item =
std::make_unique<NiceMock<download::MockDownloadItem>>();
auto download_ui_model = DownloadItemModel::Wrap(item.get());
auto download_weak_ptr = download_ui_model->GetWeakPtr();
EXPECT_CALL(*item, IsInsecure()).WillRepeatedly(Return(true));
EXPECT_CALL(*item, IsPaused()).WillRepeatedly(Return(true));
// 1 out of 2 commands should be executed.
EXPECT_CALL(*item, OpenDownload()).Times(1);
MakeContextMenu(download_ui_model.get());
EXPECT_NE(menu()->GetMenuModel(), nullptr);
EXPECT_TRUE(menu()->IsCommandIdEnabled(DownloadCommands::KEEP));
EXPECT_TRUE(menu()->IsCommandIdChecked(DownloadCommands::PAUSE));
EXPECT_TRUE(menu()->IsCommandIdVisible(DownloadCommands::PAUSE));
menu()->ExecuteCommand(DownloadCommands::OPEN_WHEN_COMPLETE, 0);
// Weakptr should be invalidated when `download_ui_model` is released.
download_ui_model.reset();
EXPECT_EQ(menu()->GetMenuModel(), nullptr);
EXPECT_FALSE(menu()->IsCommandIdEnabled(DownloadCommands::KEEP));
EXPECT_FALSE(menu()->IsCommandIdChecked(DownloadCommands::PAUSE));
EXPECT_FALSE(menu()->IsCommandIdVisible(DownloadCommands::PAUSE));
menu()->ExecuteCommand(DownloadCommands::OPEN_WHEN_COMPLETE, 0);
}
TEST_F(DownloadShelfContextMenuTest, RecordCommandsEnabled) {
base::HistogramTester histogram_tester;
std::unique_ptr<download::MockDownloadItem> item =
std::make_unique<NiceMock<download::MockDownloadItem>>();
auto download_ui_model = DownloadItemModel::Wrap(item.get());
auto download_weak_ptr = download_ui_model->GetWeakPtr();
EXPECT_CALL(*item, IsInsecure()).WillRepeatedly(Return(true));
EXPECT_CALL(*item, IsPaused()).WillRepeatedly(Return(true));
MakeContextMenu(download_ui_model.get());
EXPECT_NE(menu()->GetMenuModel(), nullptr);
EXPECT_TRUE(menu()->IsCommandIdEnabled(DownloadCommands::KEEP));
menu()->RecordCommandsEnabled(menu()->GetMenuModel());
histogram_tester.ExpectBucketCount(
"Download.ShelfContextMenuAction",
DownloadShelfContextMenuAction::kKeepEnabled, 1);
histogram_tester.ExpectBucketCount(
"Download.ShelfContextMenuAction",
DownloadShelfContextMenuAction::kLearnMoreInsecureDownloadEnabled, 1);
histogram_tester.ExpectTotalCount("Download.ShelfContextMenuAction", 2);
}
|
