1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <array>
// Tests common functionality used by the Chrome Extensions Cookies API
// implementation.
#include "chrome/common/extensions/api/cookies.h"
#include <stddef.h>
#include <memory>
#include <optional>
#include <utility>
#include <vector>
#include "base/test/gtest_util.h"
#include "base/values.h"
#include "chrome/browser/extensions/api/cookies/cookies_helpers.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/browser_task_environment.h"
#include "net/cookies/canonical_cookie.h"
#include "net/cookies/cookie_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using extensions::api::cookies::Cookie;
using extensions::api::cookies::CookieStore;
namespace GetAll = extensions::api::cookies::GetAll;
namespace extensions {
constexpr char kDomainKey[] = "domain";
namespace {
struct DomainMatchCase {
const char* filter;
const char* domain;
const bool matches;
};
} // namespace
class ExtensionCookiesTest : public testing::Test {
private:
content::BrowserTaskEnvironment task_environment_;
};
TEST_F(ExtensionCookiesTest, StoreIdProfileConversion) {
TestingProfile::Builder profile_builder;
std::unique_ptr<TestingProfile> profile = profile_builder.Build();
// Trigger early creation of off-the-record profile.
EXPECT_TRUE(profile->GetPrimaryOTRProfile(/*create_if_needed=*/true));
EXPECT_EQ(std::string("0"),
cookies_helpers::GetStoreIdFromProfile(profile.get()));
EXPECT_EQ(profile.get(),
cookies_helpers::ChooseProfileFromStoreId(
"0", profile.get(), true));
EXPECT_EQ(profile.get(),
cookies_helpers::ChooseProfileFromStoreId(
"0", profile.get(), false));
EXPECT_EQ(
profile->GetPrimaryOTRProfile(/*create_if_needed=*/true),
cookies_helpers::ChooseProfileFromStoreId("1", profile.get(), true));
EXPECT_EQ(nullptr, cookies_helpers::ChooseProfileFromStoreId(
"1", profile.get(), false));
EXPECT_EQ(std::string("1"),
cookies_helpers::GetStoreIdFromProfile(
profile->GetPrimaryOTRProfile(/*create_if_needed=*/true)));
EXPECT_EQ(
nullptr,
cookies_helpers::ChooseProfileFromStoreId(
"0", profile->GetPrimaryOTRProfile(/*create_if_needed=*/true), true));
EXPECT_EQ(nullptr,
cookies_helpers::ChooseProfileFromStoreId(
"0", profile->GetPrimaryOTRProfile(/*create_if_needed=*/true),
false));
EXPECT_EQ(
profile->GetPrimaryOTRProfile(/*create_if_needed=*/true),
cookies_helpers::ChooseProfileFromStoreId(
"1", profile->GetPrimaryOTRProfile(/*create_if_needed=*/true), true));
EXPECT_EQ(profile->GetPrimaryOTRProfile(/*create_if_needed=*/true),
cookies_helpers::ChooseProfileFromStoreId(
"1", profile->GetPrimaryOTRProfile(/*create_if_needed=*/true),
false));
}
TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
std::unique_ptr<net::CanonicalCookie> canonical_cookie1 =
net::CanonicalCookie::CreateUnsafeCookieForTesting(
"ABC", "DEF", "www.example.com", "/", base::Time(), base::Time(),
base::Time(), base::Time(), false, false,
net::CookieSameSite::NO_RESTRICTION, net::COOKIE_PRIORITY_DEFAULT);
ASSERT_NE(nullptr, canonical_cookie1.get());
Cookie cookie1 =
cookies_helpers::CreateCookie(*canonical_cookie1, "some cookie store");
EXPECT_EQ("ABC", cookie1.name);
EXPECT_EQ("DEF", cookie1.value);
EXPECT_EQ("www.example.com", cookie1.domain);
EXPECT_TRUE(cookie1.host_only);
EXPECT_EQ("/", cookie1.path);
EXPECT_FALSE(cookie1.secure);
EXPECT_FALSE(cookie1.http_only);
EXPECT_EQ(api::cookies::SameSiteStatus::kNoRestriction, cookie1.same_site);
EXPECT_TRUE(cookie1.session);
EXPECT_FALSE(cookie1.expiration_date);
EXPECT_EQ("some cookie store", cookie1.store_id);
std::unique_ptr<net::CanonicalCookie> canonical_cookie2 =
net::CanonicalCookie::CreateUnsafeCookieForTesting(
"ABC", "DEF", ".example.com", "/", base::Time(),
base::Time::FromSecondsSinceUnixEpoch(10000), base::Time(),
base::Time(), false, false, net::CookieSameSite::STRICT_MODE,
net::COOKIE_PRIORITY_DEFAULT);
ASSERT_NE(nullptr, canonical_cookie2.get());
Cookie cookie2 =
cookies_helpers::CreateCookie(*canonical_cookie2, "some cookie store");
EXPECT_FALSE(cookie2.host_only);
EXPECT_FALSE(cookie2.session);
EXPECT_EQ(api::cookies::SameSiteStatus::kStrict, cookie2.same_site);
ASSERT_TRUE(cookie2.expiration_date);
EXPECT_EQ(10000, *cookie2.expiration_date);
TestingProfile profile;
base::Value::List tab_ids_list;
std::vector<int> tab_ids;
CookieStore cookie_store =
cookies_helpers::CreateCookieStore(&profile, std::move(tab_ids_list));
EXPECT_EQ("0", cookie_store.id);
EXPECT_EQ(tab_ids, cookie_store.tab_ids);
}
TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
std::unique_ptr<net::CanonicalCookie> cookie1 =
net::CanonicalCookie::CreateUnsafeCookieForTesting(
"ABC", "DEF", ".example.com", "/", base::Time(), base::Time(),
base::Time(), base::Time(), false, false,
net::CookieSameSite::NO_RESTRICTION, net::COOKIE_PRIORITY_DEFAULT);
ASSERT_NE(nullptr, cookie1.get());
EXPECT_EQ("http://example.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie1).spec());
std::unique_ptr<net::CanonicalCookie> cookie2 =
net::CanonicalCookie::CreateUnsafeCookieForTesting(
"ABC", "DEF", ".helloworld.com", "/", base::Time(), base::Time(),
base::Time(), base::Time(), true, false,
net::CookieSameSite::NO_RESTRICTION, net::COOKIE_PRIORITY_DEFAULT);
ASSERT_NE(nullptr, cookie2.get());
EXPECT_EQ("https://helloworld.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie2).spec());
}
TEST_F(ExtensionCookiesTest, EmptyDictionary) {
base::Value::Dict dict;
auto details = GetAll::Params::Details::FromValue(dict);
ASSERT_TRUE(details);
cookies_helpers::MatchFilter filter(&details.value());
net::CanonicalCookie cookie;
EXPECT_TRUE(filter.MatchesCookie(cookie));
}
TEST_F(ExtensionCookiesTest, DomainMatching) {
constexpr static const auto tests = std::to_array<DomainMatchCase>({
{"bar.com", "bar.com", true},
{".bar.com", "bar.com", true},
{"bar.com", "food.bar.com", true},
{"bar.com", "bar.foo.com", false},
{".bar.com", ".foo.bar.com", true},
{".bar.com", "baz.foo.bar.com", true},
{"foo.bar.com", ".bar.com", false},
});
for (size_t i = 0; i < std::size(tests); ++i) {
// Build up the Params struct.
base::Value::List args;
base::Value::Dict dict;
dict.Set(kDomainKey, tests[i].filter);
args.Append(std::move(dict));
std::optional<GetAll::Params> params = GetAll::Params::Create(args);
cookies_helpers::MatchFilter filter(¶ms->details);
std::unique_ptr<net::CanonicalCookie> cookie =
net::CanonicalCookie::CreateUnsafeCookieForTesting(
"name", std::string(), tests[i].domain, "/", base::Time(),
base::Time(), base::Time(), base::Time(), false, false,
net::CookieSameSite::NO_RESTRICTION, net::COOKIE_PRIORITY_DEFAULT);
ASSERT_NE(nullptr, cookie.get());
EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie)) << " test " << i;
}
}
TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) {
std::unique_ptr<net::CanonicalCookie> canonical_cookie(
net::CanonicalCookie::CreateForTesting(
GURL("http://test.com"), "=011Q255bNX_1!yd\203e+;path=/path\203",
base::Time::Now()));
ASSERT_NE(nullptr, canonical_cookie.get());
Cookie cookie =
cookies_helpers::CreateCookie(*canonical_cookie, "some cookie store");
EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD"
"e+"),
cookie.value);
EXPECT_EQ(std::string(), cookie.path);
}
TEST_F(ExtensionCookiesTest, PartitionKeySerialization) {
std::string top_level_site = "https://toplevelsite.com";
std::optional<extensions::api::cookies::CookiePartitionKey>
partition_key_for_nonce_and_regular =
extensions::api::cookies::CookiePartitionKey();
std::optional<extensions::api::cookies::CookiePartitionKey>
partition_key_for_opaque = extensions::api::cookies::CookiePartitionKey();
partition_key_for_nonce_and_regular->top_level_site = top_level_site;
partition_key_for_opaque->top_level_site = "";
// Partition key to confirm crbug.com/1522601 is addressed.
std::optional<extensions::api::cookies::CookiePartitionKey>
partition_key_with_no_top_level_site_set =
extensions::api::cookies::CookiePartitionKey();
// Make a CanonicalCookie with a opaque top_level_site or nonce in partition
// key.
auto cookie = net::CanonicalCookie::CreateUnsafeCookieForTesting(
"__Host-A", "B", "x.y", "/", base::Time(), base::Time(), base::Time(),
base::Time(), /*secure=*/true,
/*httponly=*/false, net::CookieSameSite::UNSPECIFIED,
net::COOKIE_PRIORITY_LOW,
net::CookiePartitionKey::FromURLForTesting(GURL(top_level_site)));
EXPECT_TRUE(cookie->IsPartitioned());
EXPECT_FALSE(net::CookiePartitionKey::HasNonce(cookie->PartitionKey()));
EXPECT_TRUE(cookie->PartitionKey()->IsSerializeable());
// Make a CanonicalCookie with a opaque partition key.
auto opaque_cookie = net::CanonicalCookie::CreateUnsafeCookieForTesting(
"__Host-A", "B", "x.y", "/", base::Time(), base::Time(), base::Time(),
base::Time(), /*secure=*/true,
/*httponly=*/false, net::CookieSameSite::UNSPECIFIED,
net::COOKIE_PRIORITY_LOW,
net::CookiePartitionKey::FromURLForTesting(GURL()));
EXPECT_TRUE(opaque_cookie->IsPartitioned());
EXPECT_FALSE(opaque_cookie->PartitionKey()->IsSerializeable());
// Make a CanonicalCookie with an nonce partition key.
auto nonce_cookie = net::CanonicalCookie::CreateUnsafeCookieForTesting(
"__Host-A", "B", "x.y", "/", base::Time(), base::Time(), base::Time(),
base::Time(), /*secure=*/true,
/*httponly=*/false, net::CookieSameSite::UNSPECIFIED,
net::COOKIE_PRIORITY_LOW,
net::CookiePartitionKey::FromURLForTesting(
GURL("https://toplevelsite.com"),
net::CookiePartitionKey::AncestorChainBit::kCrossSite,
base::UnguessableToken::Create()));
EXPECT_TRUE(nonce_cookie->IsPartitioned());
EXPECT_TRUE(net::CookiePartitionKey::HasNonce(nonce_cookie->PartitionKey()));
EXPECT_FALSE(nonce_cookie->PartitionKey()->IsSerializeable());
// Confirm that to be matchable, the partition key
// must be serializable.
EXPECT_TRUE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_for_nonce_and_regular, *cookie->PartitionKey()));
EXPECT_FALSE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_for_nonce_and_regular, *nonce_cookie->PartitionKey()));
EXPECT_FALSE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_for_opaque, *opaque_cookie->PartitionKey()));
EXPECT_FALSE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_with_no_top_level_site_set, *cookie->PartitionKey()));
EXPECT_FALSE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_with_no_top_level_site_set,
*nonce_cookie->PartitionKey()));
EXPECT_FALSE(
cookies_helpers::CanonicalCookiePartitionKeyMatchesApiCookiePartitionKey(
partition_key_with_no_top_level_site_set,
*opaque_cookie->PartitionKey()));
// Confirm that a CanonicalCookie with serializable partition key
// can be used to create a cookie.
auto api_cookie = cookies_helpers::CreateCookie(*cookie, "0");
EXPECT_TRUE(api_cookie.partition_key);
// Confirm that a CanonicalCookie with a non-serializable partition key
// dies when a cookie is attempted to be created.
EXPECT_CHECK_DEATH(cookies_helpers::CreateCookie(*nonce_cookie, "0"));
EXPECT_CHECK_DEATH(cookies_helpers::CreateCookie(*opaque_cookie, "0"));
}
} // namespace extensions
|
