1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/extension_action_test_util.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test.h"
#include "extensions/browser/extension_action.h"
#include "extensions/browser/extension_action_manager.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension.h"
#include "extensions/common/switches.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
namespace extensions {
namespace {
const std::string kSubscribePageAction = "subscribe_page_action_v2/src";
const std::string kFeedPage = "/feeds/feed.html";
const std::string kNoFeedPage = "/feeds/no_feed.html";
const std::string kHashPageA =
"/extensions/api_test/page_action/hash_change/test_page_A.html";
const std::string kHashPageAHash = kHashPageA + "#asdf";
const std::string kHashPageB =
"/extensions/api_test/page_action/hash_change/test_page_B.html";
using ContextType = extensions::browser_test_util::ContextType;
class PageActionBrowserTest : public ExtensionBrowserTest,
public testing::WithParamInterface<ContextType> {
public:
PageActionBrowserTest() : ExtensionBrowserTest(GetParam()) {}
~PageActionBrowserTest() override = default;
PageActionBrowserTest(const PageActionBrowserTest& other) = delete;
PageActionBrowserTest& operator=(const PageActionBrowserTest& other) = delete;
};
INSTANTIATE_TEST_SUITE_P(PersistentBackground,
PageActionBrowserTest,
::testing::Values(ContextType::kPersistentBackground));
INSTANTIATE_TEST_SUITE_P(ServiceWorker,
PageActionBrowserTest,
::testing::Values(ContextType::kServiceWorkerMV2));
IN_PROC_BROWSER_TEST_P(PageActionBrowserTest, PageActionCrash25562) {
ASSERT_TRUE(embedded_test_server()->Start());
// This page action will not show an icon, since it doesn't specify one but
// is included here to test for a crash (http://crbug.com/25562).
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("browsertest")
.AppendASCII("crash_25562")));
// Navigate to the feed page.
GURL feed_url = embedded_test_server()->GetURL(kFeedPage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
// We should now have one page action ready to go in the LocationBar.
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
}
// Tests that we can load page actions in the Omnibox.
IN_PROC_BROWSER_TEST_P(PageActionBrowserTest, PageAction) {
ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII(kSubscribePageAction)));
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(0));
// Navigate to the feed page.
GURL feed_url = embedded_test_server()->GetURL(kFeedPage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
// We should now have one page action ready to go in the LocationBar.
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
// Navigate to a page with no feed.
GURL no_feed = embedded_test_server()->GetURL(kNoFeedPage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), no_feed));
// Make sure the page action goes away.
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(0));
}
// Tests that we don't lose the page action icon on same-document navigations.
IN_PROC_BROWSER_TEST_P(PageActionBrowserTest, SameDocumentNavigation) {
ASSERT_TRUE(embedded_test_server()->Start());
base::FilePath extension_path(test_data_dir_.AppendASCII("api_test")
.AppendASCII("page_action")
.AppendASCII("hash_change"));
ASSERT_TRUE(LoadExtension(extension_path));
// Page action should become visible when we navigate here.
GURL feed_url = embedded_test_server()->GetURL(kHashPageA);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
// Same-document navigation, page action should remain.
feed_url = embedded_test_server()->GetURL(kHashPageAHash);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
// Not a same-document navigation, page action should go away.
feed_url = embedded_test_server()->GetURL(kHashPageB);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(0));
}
IN_PROC_BROWSER_TEST_P(PageActionBrowserTest, UnloadPageAction) {
ASSERT_TRUE(embedded_test_server()->Start());
base::FilePath extension_path(
test_data_dir_.AppendASCII(kSubscribePageAction));
ASSERT_TRUE(LoadExtension(extension_path));
// Navigation prompts the location bar to load page actions.
GURL feed_url = embedded_test_server()->GetURL(kFeedPage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), feed_url));
content::WebContents* tab =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_EQ(1u, extension_action_test_util::GetTotalPageActionCount(tab));
UnloadExtension(last_loaded_extension_id());
// Make sure the page action goes away when it's unloaded.
EXPECT_EQ(0u, extension_action_test_util::GetTotalPageActionCount(tab));
}
// TODO(crbug.com/417057394): Remove log statements once the flakiness has been
// figured out.
// Regression test for crbug.com/44415.
IN_PROC_BROWSER_TEST_P(PageActionBrowserTest, PageActionRefreshCrash) {
ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(browser()->profile());
size_t size_before = registry->enabled_extensions().size();
base::FilePath base_path = test_data_dir_.AppendASCII("browsertest")
.AppendASCII("crash_44415");
// Load extension A.
const Extension* extensionA = LoadExtension(base_path.AppendASCII("ExtA"));
ASSERT_TRUE(extensionA);
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
ASSERT_EQ(size_before + 1, registry->enabled_extensions().size());
// Load extension B.
const Extension* extensionB = LoadExtension(base_path.AppendASCII("ExtB"));
ASSERT_TRUE(extensionB);
ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(2));
ASSERT_EQ(size_before + 2, registry->enabled_extensions().size());
std::string idA = extensionA->id();
LOG(INFO) << "Reloading extensionA";
ReloadExtension(extensionA->id());
// ExtensionA has changed, so refetch it.
ASSERT_EQ(size_before + 2, registry->enabled_extensions().size());
extensionA = registry->enabled_extensions().GetByID(idA);
LOG(INFO) << "Reloading extensionB";
ReloadExtension(extensionB->id());
LOG(INFO) << "Reloading extensionA again";
// This is where it would crash, before http://crbug.com/44415 was fixed.
ReloadExtension(extensionA->id());
}
} // namespace
} // namespace extensions
|
