1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/content_verifier/content_verifier.h"
#include <list>
#include <memory>
#include <set>
#include <string>
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/functional/callback_helpers.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/test/test_file_util.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/extensions/chrome_content_verifier_delegate.h"
#include "chrome/browser/extensions/content_verifier_test_utils.h"
#include "chrome/browser/extensions/corrupted_extension_reinstaller.h"
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/devtools_util.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_management_test_util.h"
#include "chrome/browser/extensions/external_provider_manager.h"
#include "chrome/browser/policy/policy_test_utils.h"
#include "chrome/common/buildflags.h"
#include "chrome/common/chrome_switches.h"
#include "components/crx_file/id_util.h"
#include "components/policy/core/browser/browser_policy_connector.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/background_script_executor.h"
#include "extensions/browser/content_verifier/content_verify_job.h"
#include "extensions/browser/content_verifier/test_utils.h"
#include "extensions/browser/crx_file_info.h"
#include "extensions/browser/disable_reason.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/external_install_info.h"
#include "extensions/browser/management_policy.h"
#include "extensions/browser/mock_external_provider.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/browser/updater/extension_update_data.h"
#include "extensions/browser/updater/manifest_fetch_data.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/extension_urls.h"
#include "extensions/common/file_util.h"
#include "extensions/test/extension_test_message_listener.h"
#include "third_party/zlib/google/compression_utils.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/extensions/browsertest_util.h"
#endif
#if BUILDFLAG(ENABLE_EXTENSIONS)
#include "chrome/test/base/ui_test_utils.h"
#endif
using extensions::mojom::ManifestLocation;
namespace extensions {
namespace {
#if BUILDFLAG(ENABLE_EXTENSIONS)
constexpr char kTenMegResourceExtensionId[] =
"mibjhafkjlepkpbjleahhallgddpjgle";
#endif
constexpr char kStoragePermissionExtensionId[] =
"dmabdbcjhngdcmkfmgiogpcpiniaoddk";
constexpr char kStoragePermissionExtensionCrx[] =
"content_verifier/storage_permission.crx";
class MockUpdateService : public UpdateService {
public:
MockUpdateService() : UpdateService(nullptr, nullptr) {}
MOCK_CONST_METHOD0(IsBusy, bool());
MOCK_METHOD3(SendUninstallPing,
void(const std::string& id,
const base::Version& version,
int reason));
MOCK_METHOD(void,
StartUpdateCheck,
(const ExtensionUpdateCheckParams& params,
UpdateFoundCallback update_found_callback,
base::OnceClosure callback),
(override));
};
void ExtensionUpdateComplete(base::OnceClosure callback,
const std::optional<CrxInstallError>& error) {
// Expect success (no CrxInstallError). Assert on an error to put the error
// message into the test log to aid debugging.
ASSERT_FALSE(error.has_value()) << error->message();
std::move(callback).Run();
}
#if BUILDFLAG(ENABLE_EXTENSIONS)
// A helper override to force generation of hashes for all extensions, not just
// those from the webstore.
ChromeContentVerifierDelegate::VerifyInfo GetVerifyInfoAndForceHashes(
const Extension& extension) {
return ChromeContentVerifierDelegate::VerifyInfo(
ChromeContentVerifierDelegate::VerifyInfo::Mode::ENFORCE_STRICT,
extension.from_webstore(), /*should_repair=*/false);
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
} // namespace
class ContentVerifierTest : public ExtensionBrowserTest {
public:
ContentVerifierTest() = default;
~ContentVerifierTest() override = default;
void SetUp() override {
// Override content verification mode before ChromeExtensionSystem
// initializes ChromeContentVerifierDelegate.
ChromeContentVerifierDelegate::SetDefaultModeForTesting(
ChromeContentVerifierDelegate::VerifyInfo::Mode::ENFORCE);
ON_CALL(update_service_, StartUpdateCheck)
.WillByDefault(Invoke(this, &ContentVerifierTest::OnUpdateCheck));
UpdateService::SupplyUpdateServiceForTest(&update_service_);
ExtensionBrowserTest::SetUp();
}
void TearDown() override {
ExtensionBrowserTest::TearDown();
ChromeContentVerifierDelegate::SetDefaultModeForTesting(std::nullopt);
}
ExternalProviderManager* external_provider_manager() {
return ExternalProviderManager::Get(profile());
}
bool ShouldEnableContentVerification() override { return true; }
void AssertIsCorruptBitSetOnUpdateCheck(
const ExtensionUpdateCheckParams& params,
UpdateFoundCallback update_found_callback,
base::OnceClosure callback) {
ASSERT_FALSE(params.update_info.empty());
for (auto element : params.update_info) {
ASSERT_TRUE(element.second.is_corrupt_reinstall);
}
OnUpdateCheck(params, update_found_callback, std::move(callback));
}
virtual void OnUpdateCheck(const ExtensionUpdateCheckParams& params,
UpdateFoundCallback update_found_callback,
base::OnceClosure callback) {
scoped_refptr<CrxInstaller> installer(
CrxInstaller::CreateSilent(profile()));
installer->set_install_source(ManifestLocation::kExternalPolicyDownload);
installer->set_install_immediately(true);
installer->set_allow_silent_install(true);
installer->set_off_store_install_allow_reason(
CrxInstaller::OffStoreInstallAllowedInTest);
installer->AddInstallerCallback(
base::BindOnce(&ExtensionUpdateComplete, std::move(callback)));
installer->InstallCrx(
test_data_dir_.AppendASCII("content_verifier/v1.crx"));
}
// Types of modification used by `TestContentScriptExtension` method below.
enum class ScriptModificationAction {
// Alter script content.
kAlter,
// Delete the script file.
kDelete,
// Make the script unreadable.
kMakeUnreadable,
};
void TestContentScriptExtension(const std::string& crx_relpath,
const std::string& id,
const std::string& script_relpath,
ScriptModificationAction action) {
VerifierObserver verifier_observer;
// Install the extension with content scripts. The initial read of the
// content scripts will fail verification because they are read before the
// content verification system has completed a one-time processing of the
// expected hashes. (The extension only contains the root level hashes of
// the merkle tree, but the content verification system builds the entire
// tree and caches it in the extension install directory - see
// ContentHashFetcher for more details).
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII(crx_relpath), 1);
ASSERT_TRUE(extension);
EXPECT_EQ(id, extension->id());
// Wait for the content verification code to finish processing the hashes.
verifier_observer.EnsureFetchCompleted(id);
// Now disable the extension, since content scripts are read at enable time,
// set up our job observer, and re-enable, expecting a success this time.
DisableExtension(id);
using Result = TestContentVerifyJobObserver::Result;
TestContentVerifyJobObserver job_observer;
base::FilePath script_relfilepath =
base::FilePath().AppendASCII(script_relpath);
job_observer.ExpectJobResult(id, script_relfilepath, Result::SUCCESS);
EnableExtension(id);
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
// Now alter the contents of the content script, reload the extension, and
// expect to see a job failure due to the content script content hash not
// being what was signed by the webstore.
base::FilePath scriptfile = extension->path().AppendASCII(script_relpath);
{
base::ScopedAllowBlockingForTesting allow_blocking;
switch (action) {
case ScriptModificationAction::kAlter:
ASSERT_TRUE(
base::AppendToFile(scriptfile, "some_extra_function_call();"));
break;
case ScriptModificationAction::kDelete:
ASSERT_TRUE(base::DeleteFile(scriptfile));
break;
case ScriptModificationAction::kMakeUnreadable:
ASSERT_TRUE(base::MakeFileUnreadable(scriptfile));
break;
}
}
DisableExtension(id);
job_observer.ExpectJobResult(id, script_relfilepath, Result::FAILURE);
EnableExtension(id);
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
}
void NavigateToResourceAndExpectExtensionDisabled(
const ExtensionId& extension_id,
const GURL& extension_resource) {
TestExtensionRegistryObserver unload_observer(
ExtensionRegistry::Get(profile()), extension_id);
NavigateToURLInNewTab(extension_resource);
EXPECT_TRUE(unload_observer.WaitForExtensionUnloaded());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(extension_id);
EXPECT_THAT(
prefs->GetDisableReasons(extension_id),
testing::UnorderedElementsAre(disable_reason::DISABLE_CORRUPTED));
}
// Reads private key from |private_key_path| and generates extension id using
// it.
std::string GetExtensionIdFromPrivateKeyFile(
const base::FilePath& private_key_path) {
std::string private_key_contents;
EXPECT_TRUE(
base::ReadFileToString(private_key_path, &private_key_contents));
std::string private_key_bytes;
EXPECT_TRUE(
Extension::ParsePEMKeyBytes(private_key_contents, &private_key_bytes));
auto signing_key =
crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(std::vector<uint8_t>(
private_key_bytes.begin(), private_key_bytes.end()));
std::vector<uint8_t> public_key;
signing_key->ExportPublicKey(&public_key);
const std::string public_key_str(public_key.begin(), public_key.end());
return crx_file::id_util::GenerateId(public_key_str);
}
// Creates a random signing key and sets |extension_id| according to it.
std::unique_ptr<crypto::RSAPrivateKey> CreateExtensionSigningKey(
std::string& extension_id) {
auto signing_key = crypto::RSAPrivateKey::Create(2048);
std::vector<uint8_t> public_key;
signing_key->ExportPublicKey(&public_key);
const std::string public_key_str(public_key.begin(), public_key.end());
extension_id = crx_file::id_util::GenerateId(public_key_str);
return signing_key;
}
// Creates a CRX in a temporary directory under |temp_dir| using contents from
// |unpacked_path|. Compresses the |verified_contents| and injects these
// contents into the the header of the CRX. Creates a random signing key
// and sets |extension_id| using it. Returns path to new CRX in |crx_path|.
testing::AssertionResult CreateCrxWithVerifiedContentsInHeader(
base::ScopedTempDir* temp_dir,
const base::FilePath& unpacked_path,
crypto::RSAPrivateKey* private_key,
const std::string& verified_contents,
base::FilePath* crx_path) {
std::string compressed_verified_contents;
if (!compression::GzipCompress(verified_contents,
&compressed_verified_contents)) {
return testing::AssertionFailure();
}
if (!temp_dir->CreateUniqueTempDir()) {
return testing::AssertionFailure();
}
*crx_path = temp_dir->GetPath().AppendASCII("temp.crx");
ExtensionCreator creator;
creator.CreateCrxAndPerformCleanup(unpacked_path, *crx_path, private_key,
compressed_verified_contents);
return testing::AssertionSuccess();
}
protected:
base::test::ScopedFeatureList scoped_feature_list_;
base::AutoReset<bool> scoped_use_update_service_ =
ExtensionUpdater::GetScopedUseUpdateServiceForTesting();
testing::NiceMock<MockUpdateService> update_service_;
};
#if BUILDFLAG(ENABLE_EXTENSIONS)
// TODO(crbug.com/371432155): Port to desktop Android when the tabs API is
// supported.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, DotSlashPaths) {
TestContentVerifyJobObserver job_observer;
std::string id = "hoipipabpcoomfapcecilckodldhmpgl";
using Result = TestContentVerifyJobObserver::Result;
job_observer.ExpectJobResult(
id, base::FilePath(FILE_PATH_LITERAL("background.js")), Result::SUCCESS);
job_observer.ExpectJobResult(
id, base::FilePath(FILE_PATH_LITERAL("page.html")), Result::SUCCESS);
job_observer.ExpectJobResult(id, base::FilePath(FILE_PATH_LITERAL("page.js")),
Result::SUCCESS);
job_observer.ExpectJobResult(
id, base::FilePath(FILE_PATH_LITERAL("dir/page2.html")), Result::SUCCESS);
job_observer.ExpectJobResult(
id, base::FilePath(FILE_PATH_LITERAL("page2.js")), Result::SUCCESS);
job_observer.ExpectJobResult(id, base::FilePath(FILE_PATH_LITERAL("cs1.js")),
Result::SUCCESS);
job_observer.ExpectJobResult(id, base::FilePath(FILE_PATH_LITERAL("cs2.js")),
Result::SUCCESS);
auto verifier_observer = std::make_unique<VerifierObserver>();
// Install a test extension we copied from the webstore that has actual
// signatures, and contains paths with a leading "./" in various places.
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/dot_slash_paths.crx"), 1);
ASSERT_TRUE(extension);
ASSERT_EQ(extension->id(), id);
// The content scripts might fail verification the first time since the
// one-time processing might not be finished yet - if that's the case then
// we want to wait until that work is done.
verifier_observer->EnsureFetchCompleted(id);
// It is important to destroy |verifier_observer| here so that it doesn't see
// any fetch from EnableExtension call below (the observer pointer in
// content_verifier.cc isn't thread safe, so it might asynchronously call
// OnFetchComplete after this test's body executes).
verifier_observer.reset();
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
// Set expectations for extension enablement below.
job_observer.ExpectJobResult(id, base::FilePath(FILE_PATH_LITERAL("cs1.js")),
Result::SUCCESS);
job_observer.ExpectJobResult(id, base::FilePath(FILE_PATH_LITERAL("cs2.js")),
Result::SUCCESS);
// Now disable/re-enable the extension to cause the content scripts to be
// read again.
DisableExtension(id);
EnableExtension(id);
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
// Make sure that `VerifierObserver` doesn't crash on destruction.
//
// Regression test for https://crbug.com/353880557.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
VerifierObserverNoCrashOnDestruction) {
constexpr char kId[] = "jmllhlobpjcnnomjlipadejplhmheiif";
constexpr char kCrxRelpath[] = "content_verifier/content_script.crx";
VerifierObserver verifier_observer;
InstallExtensionFromWebstore(test_data_dir_.AppendASCII(kCrxRelpath), 1);
DisableExtension(kId);
EnableExtension(kId);
}
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, ContentScripts) {
TestContentScriptExtension("content_verifier/content_script.crx",
"jmllhlobpjcnnomjlipadejplhmheiif", "script.js",
ScriptModificationAction::kAlter);
}
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, ContentScriptsInLocales) {
TestContentScriptExtension("content_verifier/content_script_locales.crx",
"jaghonccckpcikmliipifpoodmeofoon",
"_locales/en/content_script.js",
ScriptModificationAction::kAlter);
}
// Tests that a deleted content_script results in content verification failure.
//
// Regression test for crbug.com/1296310.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
DeletedContentScriptFailsContentVerification) {
TestContentScriptExtension("content_verifier/content_script.crx",
"jmllhlobpjcnnomjlipadejplhmheiif", "script.js",
ScriptModificationAction::kDelete);
}
// Tests that an unreadable content_script results in content verification
// failure.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
UnreadableContentScriptFailsContentVerification) {
TestContentScriptExtension("content_verifier/content_script.crx",
"jmllhlobpjcnnomjlipadejplhmheiif", "script.js",
ScriptModificationAction::kMakeUnreadable);
}
#if BUILDFLAG(ENABLE_EXTENSIONS)
// A class that forces all installed extensions to generate hashes (normally,
// we'd only generate hashes for policy-installed extensions with the
// appropriate enterprise policy applied). This makes it easier to test the
// relevant bits of content verification (namely, verifying content against an
// expected set) without needing webstore-signed hashes in the test environment.
class ContentVerifierTestWithForcedHashes : public ContentVerifierTest {
public:
ContentVerifierTestWithForcedHashes()
: verify_info_override_(
base::BindRepeating(&GetVerifyInfoAndForceHashes)) {}
~ContentVerifierTestWithForcedHashes() override = default;
private:
ChromeContentVerifierDelegate::GetVerifyInfoTestOverride
verify_info_override_;
};
// Tests detection of corruption in an extension's service worker file.
// TODO(crbug.com/371432155): Port to desktop Android when the tabs API is
// supported.
IN_PROC_BROWSER_TEST_F(ContentVerifierTestWithForcedHashes,
TestServiceWorkerCorruption_DisableAndEnable) {
static constexpr char kManifest[] =
R"({
"name": "test extension",
"manifest_version": 3,
"version": "0.1",
"background": {"service_worker": "background.js"}
})";
static constexpr char kBackgroundJs[] =
R"(chrome.tabs.onCreated.addListener(() => {
console.warn('Firing listener');
chrome.test.sendMessage('listener fired');
});
chrome.test.sendMessage('ready');)";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackgroundJs);
ExtensionTestMessageListener event_listener("listener fired");
ExtensionTestMessageListener ready_listener("ready");
VerifierObserver verifier_observer;
scoped_refptr<const Extension> extension(
InstallExtension(test_dir.Pack(), 1));
ASSERT_TRUE(extension);
// Wait for the content verification code to finish processing the hashes and
// for the extension to register the listener.
verifier_observer.EnsureFetchCompleted(extension->id());
ASSERT_TRUE(ready_listener.WaitUntilSatisfied());
// Navigate to a new tab. This should fire the event listener (ensuring the
// extension was active).
NavigateToURLInNewTab(GURL("chrome://newtab"));
ASSERT_TRUE(content::WaitForLoadStop(GetActiveWebContents()));
ASSERT_TRUE(event_listener.WaitUntilSatisfied());
// Now alter the contents of the background script.
{
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(
base::AppendToFile(extension->path().AppendASCII("background.js"),
"some_extra_function_call();"));
}
// Disable and re-enable the extension. On re-enable, the extension should
// be detected as corrupted, since the contents on disk no longer match the
// contents indicated by the generated hash.
DisableExtension(extension->id());
base::HistogramTester histogram_tester;
TestContentVerifyJobObserver job_observer;
base::FilePath background_script_relative_path =
base::FilePath().AppendASCII("background.js");
job_observer.ExpectJobResult(extension->id(), background_script_relative_path,
TestContentVerifyJobObserver::Result::FAILURE);
EnableExtension(extension->id());
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
// The extension should be disabled...
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
EXPECT_FALSE(registry->enabled_extensions().Contains(extension->id()));
EXPECT_TRUE(registry->disabled_extensions().Contains(extension->id()));
// ... for the reason of being corrupted...
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(extension->id());
EXPECT_THAT(reasons,
testing::UnorderedElementsAre(disable_reason::DISABLE_CORRUPTED));
// ... And we should have recorded metrics for where we found the corruption.
histogram_tester.ExpectUniqueSample(
"Extensions.ContentVerification.VerifyFailedOnFileMV3."
"ServiceWorkerScript",
ContentVerifyJob::HASH_MISMATCH, 1);
// We hard-code the script type here to avoid exposing it publicly from the
// class.
constexpr int kServiceWorkerScriptFileType = 3;
histogram_tester.ExpectUniqueSample(
"Extensions.ContentVerification.VerifyFailedOnFileTypeMV3",
kServiceWorkerScriptFileType, 1);
}
// Tests service worker corruption detection across browser starts.
// TODO(crbug.com/371432155): Port to desktop Android when the tabs API is
// supported.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
PRE_TestServiceWorker_AcrossSession) {
// Force-enable content verification for every extension.
ChromeContentVerifierDelegate::GetVerifyInfoTestOverride verify_info_override(
base::BindRepeating([](const Extension& extension) {
return ChromeContentVerifierDelegate::VerifyInfo(
ChromeContentVerifierDelegate::VerifyInfo::Mode::ENFORCE_STRICT,
extension.from_webstore(), false);
}));
static constexpr char kManifest[] =
R"({
"name": "TestServiceWorker_AcrossSession extension",
"manifest_version": 3,
"version": "0.1",
"background": {"service_worker": "background.js"}
})";
static constexpr char kBackgroundJs[] =
R"(chrome.tabs.onCreated.addListener(() => {
chrome.test.sendMessage('listener fired');
});
chrome.test.sendMessage('ready');)";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackgroundJs);
ExtensionTestMessageListener event_listener("listener fired");
ExtensionTestMessageListener ready_listener("ready");
VerifierObserver verifier_observer;
scoped_refptr<const Extension> extension(
InstallExtension(test_dir.Pack(), /*expected_change=*/1));
ASSERT_TRUE(extension);
// Wait for the content verification code to finish processing the hashes and
// for the extension to register the listener.
verifier_observer.EnsureFetchCompleted(extension->id());
ASSERT_TRUE(ready_listener.WaitUntilSatisfied());
// Navigate to a new tab. This should fire the event listener (ensuring the
// extension was active).
NavigateToURLInNewTab(GURL("chrome://newtab"));
ASSERT_TRUE(content::WaitForLoadStop(GetActiveWebContents()));
ASSERT_TRUE(event_listener.WaitUntilSatisfied());
// Now alter the contents of the background script.
{
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(
base::AppendToFile(extension->path().AppendASCII("background.js"),
"\nself.didModifyScript = true;"));
}
// Restart Chrome...
// (This is handled by the continuation of this test below, since the profile
// is preserved by the PRE_ test.)
}
// TODO(crbug.com/371432155): Port to desktop Android when the tabs API is
// supported.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, TestServiceWorker_AcrossSession) {
// Force-enable content verification for every extension.
ChromeContentVerifierDelegate::GetVerifyInfoTestOverride verify_info_override(
base::BindRepeating([](const Extension& extension) {
return ChromeContentVerifierDelegate::VerifyInfo(
ChromeContentVerifierDelegate::VerifyInfo::Mode::ENFORCE_STRICT,
extension.from_webstore(), false);
}));
// Find the previously-installed extension.
const Extension* extension = nullptr;
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
for (const auto& e : registry->GenerateInstalledExtensionsSet()) {
if (e->name() == "TestServiceWorker_AcrossSession extension") {
extension = e.get();
break;
}
}
ASSERT_TRUE(extension);
// Currently, the extension is enabled. That's because it hasn't started
// running yet, so we haven't detected corruption in the extension.
EXPECT_TRUE(registry->enabled_extensions().Contains(extension->id()));
EXPECT_FALSE(registry->disabled_extensions().Contains(extension->id()));
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_TRUE(prefs->GetDisableReasons(extension->id()).empty());
{
// Sanity check: The file on disk was still modified.
base::ScopedAllowBlockingForTesting allow_blocking;
std::string file_contents;
ASSERT_TRUE(base::ReadFileToString(
extension->path().AppendASCII("background.js"), &file_contents));
EXPECT_TRUE(base::Contains(file_contents, "self.didModifyScript = true;"));
}
// Now for the fun part. Start up the extension by opening a new tab,
// forcing the listener to fire. This should *succeed*, and the extension
// should remain enabled. This is because the service worker is cached at
// the //content layer, so the new contents aren't read from disk -- they're
// retrieved from the cache.
ExtensionTestMessageListener listener("listener fired");
NavigateToURLInNewTab(GURL("chrome://newtab"));
ASSERT_TRUE(content::WaitForLoadStop(GetActiveWebContents()));
ASSERT_TRUE(listener.WaitUntilSatisfied());
// Verify the extension is still enabled.
EXPECT_TRUE(registry->enabled_extensions().Contains(extension->id()));
EXPECT_TRUE(prefs->GetDisableReasons(extension->id()).empty());
// Verify that the modified worker did *not* run (the original worker did).
base::Value script_value = BackgroundScriptExecutor::ExecuteScript(
profile(), extension->id(),
"chrome.test.sendScriptResult('' + self.didModifyScript);",
BackgroundScriptExecutor::ResultCapture::kSendScriptResult);
EXPECT_EQ("undefined", script_value);
// Disable and re-enable the extension. This clears the worker from the cache
// and forces it to reload from disk. When doing this, it will be detected as
// corrupted.
DisableExtension(extension->id());
base::HistogramTester histogram_tester;
TestContentVerifyJobObserver job_observer;
base::FilePath background_script_relative_path =
base::FilePath().AppendASCII("background.js");
job_observer.ExpectJobResult(extension->id(), background_script_relative_path,
TestContentVerifyJobObserver::Result::FAILURE);
EnableExtension(extension->id());
EXPECT_TRUE(job_observer.WaitForExpectedJobs());
// The extension should be disabled...
EXPECT_FALSE(registry->enabled_extensions().Contains(extension->id()));
EXPECT_TRUE(registry->disabled_extensions().Contains(extension->id()));
EXPECT_THAT(prefs->GetDisableReasons(extension->id()),
testing::UnorderedElementsAre(disable_reason::DISABLE_CORRUPTED));
// ... And we should have recorded metrics for where we found the corruption.
histogram_tester.ExpectUniqueSample(
"Extensions.ContentVerification.VerifyFailedOnFileMV3."
"ServiceWorkerScript",
ContentVerifyJob::HASH_MISMATCH, 1);
// We hard-code the script type here to avoid exposing it publicly from the
// class.
constexpr int kServiceWorkerScriptFileType = 3;
histogram_tester.ExpectUniqueSample(
"Extensions.ContentVerification.VerifyFailedOnFileTypeMV3",
kServiceWorkerScriptFileType, 1);
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
// Tests the case of a corrupt extension that is force-installed by policy and
// should not be allowed to be manually uninstalled/disabled by the user.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, PolicyCorrupted) {
ExtensionSystem* system = ExtensionSystem::Get(profile());
// The id of our test extension.
ExtensionId kExtensionId("dkjgfphccejbobpbljnpjcmhmagkdoia");
// Setup fake policy and update check objects.
content_verifier_test::ForceInstallProvider policy(kExtensionId);
system->management_policy()->RegisterProvider(&policy);
auto external_provider = std::make_unique<MockExternalProvider>(
external_provider_manager(), ManifestLocation::kExternalPolicyDownload);
external_provider->UpdateOrAddExtension(
std::make_unique<ExternalInstallInfoUpdateUrl>(
kExtensionId, std::string() /* install_parameter */,
extension_urls::GetWebstoreUpdateUrl(),
ManifestLocation::kExternalPolicyDownload, 0 /* creation_flags */,
true /* mark_acknowldged */));
external_provider_manager()->AddProviderForTesting(
std::move(external_provider));
base::FilePath crx_path =
test_data_dir_.AppendASCII("content_verifier/v1.crx");
const Extension* extension = InstallExtension(
crx_path, 1, mojom::ManifestLocation::kExternalPolicyDownload);
ASSERT_TRUE(extension);
TestExtensionRegistryObserver registry_observer(
ExtensionRegistry::Get(profile()), kExtensionId);
ContentVerifier* verifier = system->content_verifier();
verifier->VerifyFailedForTest(kExtensionId, ContentVerifyJob::HASH_MISMATCH);
// Set our mock update client to check that the corrupt bit is set on the
// data structure it receives.
ON_CALL(update_service_, StartUpdateCheck)
.WillByDefault(Invoke(
this, &ContentVerifierTest::AssertIsCorruptBitSetOnUpdateCheck));
// Make sure the extension first got disabled due to corruption.
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_TRUE(reasons.contains(disable_reason::DISABLE_CORRUPTED));
// Make sure the extension then got re-installed, and that after reinstall it
// is no longer disabled due to corruption.
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_FALSE(reasons.contains(disable_reason::DISABLE_CORRUPTED));
system->management_policy()->UnregisterProvider(&policy);
}
// Tests the case when an extension is first manually installed, then it gets
// corrupted and then it is added to force installed list. The extension should
// get reinstalled and should be enabled.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
ManualInstalledExtensionGotCorruptedThenForceInstalled) {
ExtensionSystem* system = ExtensionSystem::Get(profile());
ExtensionId kTestExtensionId("dkjgfphccejbobpbljnpjcmhmagkdoia");
base::FilePath crx_path =
test_data_dir_.AppendASCII("content_verifier/v1.crx");
const Extension* extension = InstallExtension(crx_path, 1);
ASSERT_TRUE(extension);
TestExtensionRegistryObserver registry_observer(
ExtensionRegistry::Get(profile()), kTestExtensionId);
// Explicitly corrupt the extension.
ContentVerifier* verifier = system->content_verifier();
verifier->VerifyFailedForTest(kTestExtensionId,
ContentVerifyJob::HASH_MISMATCH);
// Make sure the extension first got disabled due to corruption.
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(kTestExtensionId);
EXPECT_TRUE(reasons.contains(disable_reason::DISABLE_CORRUPTED));
VerifierObserver verifier_observer;
// Setup fake policy and update check objects.
content_verifier_test::ForceInstallProvider policy(kTestExtensionId);
system->management_policy()->RegisterProvider(&policy);
auto external_provider = std::make_unique<MockExternalProvider>(
external_provider_manager(), ManifestLocation::kExternalPolicyDownload);
external_provider->UpdateOrAddExtension(
std::make_unique<ExternalInstallInfoUpdateUrl>(
kTestExtensionId, std::string() /* install_parameter */,
extension_urls::GetWebstoreUpdateUrl(),
ManifestLocation::kExternalPolicyDownload, 0 /* creation_flags */,
true /* mark_acknowldged */));
external_provider_manager()->AddProviderForTesting(
std::move(external_provider));
external_provider_manager()->CheckForExternalUpdates();
// Set our mock update client to check that the corrupt bit is set on the
// data structure it receives.
ON_CALL(update_service_, StartUpdateCheck)
.WillByDefault(Invoke(
this, &ContentVerifierTest::AssertIsCorruptBitSetOnUpdateCheck));
// Make sure the extension then got re-installed, and that after reinstall it
// is no longer disabled due to corruption.
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
// Wait for the content verification code to finish processing the hashes.
verifier_observer.EnsureFetchCompleted(kTestExtensionId);
reasons = prefs->GetDisableReasons(kTestExtensionId);
EXPECT_FALSE(reasons.contains(disable_reason::DISABLE_CORRUPTED));
EXPECT_TRUE(extensions::ExtensionRegistry::Get(profile())
->enabled_extensions()
.GetByID(kTestExtensionId));
}
class UserInstalledContentVerifierTest : public ContentVerifierTest {
public:
void SetUpInProcessBrowserTestFixture() override {
ContentVerifierTest::SetUpInProcessBrowserTestFixture();
EXPECT_CALL(update_service_, StartUpdateCheck)
.WillRepeatedly(
Invoke(this, &UserInstalledContentVerifierTest::OnUpdateCheck));
}
protected:
void OnUpdateCheck(const ExtensionUpdateCheckParams& params,
UpdateFoundCallback update_found_callback,
base::OnceClosure callback) override {
scoped_refptr<CrxInstaller> installer(
CrxInstaller::CreateSilent(profile()));
installer->set_install_source(ManifestLocation::kInternal);
installer->set_install_immediately(true);
installer->set_allow_silent_install(true);
installer->set_off_store_install_allow_reason(
CrxInstaller::OffStoreInstallAllowedInTest);
installer->AddInstallerCallback(
base::BindOnce(&ExtensionUpdateComplete, std::move(callback)));
installer->InstallCrx(
test_data_dir_.AppendASCII(kStoragePermissionExtensionCrx));
}
CorruptedExtensionReinstaller* GetCorruptedExtensionReinstaller() {
return CorruptedExtensionReinstaller::Get(profile());
}
};
// Setup a corrupted extension by tampering with one of its source files in
// PRE to verify that it is repaired at startup.
IN_PROC_BROWSER_TEST_F(UserInstalledContentVerifierTest,
PRE_UserInstalledCorruptedResourceOnStartup) {
auto verifier_observer = std::make_unique<VerifierObserver>();
InstallExtensionFromWebstore(
test_data_dir_.AppendASCII(kStoragePermissionExtensionCrx), 1);
verifier_observer->EnsureFetchCompleted(kStoragePermissionExtensionId);
verifier_observer.reset();
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
const Extension* extension =
registry->enabled_extensions().GetByID(kStoragePermissionExtensionId);
EXPECT_TRUE(extension);
const base::FilePath kResourcePath(FILE_PATH_LITERAL("background.js"));
EXPECT_EQ("Test", ExecuteScriptInBackgroundPage(
kStoragePermissionExtensionId,
R"(chrome.storage.local.set({key: "Test"}, () =>
chrome.test.sendScriptResult("Test")))"));
EXPECT_EQ("Test", ExecuteScriptInBackgroundPage(
kStoragePermissionExtensionId,
R"(chrome.storage.local.get(['key'], ({key}) =>
chrome.test.sendScriptResult(key)))"));
// Corrupt the extension
{
base::FilePath resource_path = extension->path().Append(kResourcePath);
base::ScopedAllowBlockingForTesting allow_blocking;
// Temporarily disable extension, we don't want to tackle with resources of
// enabled one.
DisableExtension(kStoragePermissionExtensionId);
ASSERT_TRUE(base::WriteFile(resource_path, "// corrupted\n"));
EnableExtension(kStoragePermissionExtensionId);
}
TestExtensionRegistryObserver registry_observer(
registry, kStoragePermissionExtensionId);
ExtensionSystem* system = ExtensionSystem::Get(profile());
system->content_verifier()->VerifyFailedForTest(
kStoragePermissionExtensionId, ContentVerifyJob::HASH_MISMATCH);
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
// The extension should be disabled and not be in expected to be repaired yet.
EXPECT_FALSE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
EXPECT_THAT(ExtensionPrefs::Get(profile())->GetDisableReasons(
kStoragePermissionExtensionId),
testing::UnorderedElementsAre(disable_reason::DISABLE_CORRUPTED));
}
// Now actually test what happens on the next startup after the PRE test above.
// TODO(crbug.com/40776295): Test is flaky.
IN_PROC_BROWSER_TEST_F(UserInstalledContentVerifierTest,
DISABLED_UserInstalledCorruptedResourceOnStartup) {
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
DisableReasonSet disable_reasons =
prefs->GetDisableReasons(kStoragePermissionExtensionId);
// Depending on timing, the extension may have already been reinstalled
// between SetUpInProcessBrowserTestFixture and now (usually not during local
// testing on a developer machine, but sometimes on a heavily loaded system
// such as the build waterfall / trybots). If the reinstall didn't already
// happen, wait for it.
if (disable_reasons.contains(disable_reason::DISABLE_CORRUPTED)) {
EXPECT_TRUE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
TestExtensionRegistryObserver registry_observer(
registry, kStoragePermissionExtensionId);
ASSERT_TRUE(registry_observer.WaitForExtensionInstalled());
disable_reasons = prefs->GetDisableReasons(kStoragePermissionExtensionId);
}
EXPECT_FALSE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
EXPECT_TRUE(disable_reasons.empty());
const Extension* extension =
ExtensionRegistry::Get(profile())->enabled_extensions().GetByID(
kStoragePermissionExtensionId);
EXPECT_TRUE(extension);
{
const base::FilePath kResourcePath(FILE_PATH_LITERAL("background.js"));
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath resource_path = extension->path().Append(kResourcePath);
std::string contents;
ASSERT_TRUE(base::ReadFileToString(resource_path, &contents));
EXPECT_EQ(std::string::npos, contents.find("corrupted"));
}
// This ensures that the background page is loaded. There is a unload/load
// of the extension happening which crashes `ExtensionBackgroundPageWaiter`.
devtools_util::InspectBackgroundPage(extension, profile(),
DevToolsOpenedByAction::kUnknown);
WaitForExtensionViewsToLoad();
EXPECT_EQ("Test", ExecuteScriptInBackgroundPage(
kStoragePermissionExtensionId,
R"(chrome.storage.local.get(['key'], ({key}) =>
chrome.test.sendScriptResult(key)))"));
}
// Tests that verification failure during navigating to an extension resource
// correctly disables the extension.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, VerificationFailureOnNavigate) {
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/content_script.crx"), 1);
ASSERT_TRUE(extension);
const ExtensionId kExtensionId = extension->id();
const base::FilePath::CharType kResource[] = FILE_PATH_LITERAL("script.js");
{
// Modify content so that content verification fails.
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath real_path = extension->path().Append(kResource);
std::string extra = "some_extra_function_call();";
ASSERT_TRUE(base::AppendToFile(real_path, extra));
}
GURL page_url = extension->ResolveExtensionURL("script.js");
NavigateToResourceAndExpectExtensionDisabled(kExtensionId, page_url);
}
// Verifies that CRX with verified contents injected into the header is
// successfully installed and verified.
IN_PROC_BROWSER_TEST_F(
ContentVerifierTest,
VerificationSuccessfulForCrxWithVerifiedContentsInjectedInHeader) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::ScopedTempDir temp_dir;
base::FilePath extension_dir =
test_data_dir_.AppendASCII("content_verifier/storage_permission");
base::FilePath resource_path = base::FilePath().AppendASCII("background.js");
std::string extension_id;
auto signing_key = CreateExtensionSigningKey(extension_id);
extensions::content_verifier_test_utils::TestExtensionBuilder
verified_contents_builder(extension_id);
std::string resource_contents;
base::ReadFileToString(extension_dir.Append(resource_path),
&resource_contents);
verified_contents_builder.AddResource(resource_path.value(),
resource_contents);
std::string verified_contents =
verified_contents_builder.CreateVerifiedContents();
auto mock_content_verifier_delegate =
std::make_unique<MockContentVerifierDelegate>();
mock_content_verifier_delegate->SetVerifierKey(
verified_contents_builder.GetTestContentVerifierPublicKey());
ExtensionSystem::Get(profile())
->content_verifier()
->OverrideDelegateForTesting(std::move(mock_content_verifier_delegate));
base::FilePath crx_path;
ASSERT_TRUE(CreateCrxWithVerifiedContentsInHeader(
&temp_dir, extension_dir, signing_key.get(), verified_contents,
&crx_path));
TestContentVerifySingleJobObserver observer(extension_id, resource_path);
const Extension* extension = InstallExtensionFromWebstore(crx_path, 1);
ASSERT_TRUE(extension);
EXPECT_EQ(extension->id(), extension_id);
ContentHashReader::InitStatus hashes_status = observer.WaitForOnHashesReady();
EXPECT_EQ(ContentHashReader::InitStatus::SUCCESS, hashes_status);
}
// Verifies that CRX with malformed verified contents injected into the header
// is not installed.
IN_PROC_BROWSER_TEST_F(
ContentVerifierTest,
InstallationFailureForCrxWithMalformedVerifiedContentsInjectedInHeader) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::ScopedTempDir temp_dir;
base::FilePath test_dir = test_data_dir_.AppendASCII("content_verifier/v1");
std::string extension_id;
std::string verified_contents =
"Not a valid verified contents, not even a valid JSON.";
base::FilePath crx_path;
auto signing_key = CreateExtensionSigningKey(extension_id);
ASSERT_TRUE(CreateCrxWithVerifiedContentsInHeader(
&temp_dir, test_dir, signing_key.get(), verified_contents, &crx_path));
const Extension* extension = InstallExtensionFromWebstore(crx_path, 0);
EXPECT_FALSE(extension);
}
// Verifies that CRX with missing verified contents is successfully installed
// but not verified due to missing hashes.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
VerificationFailureForMissingVerifiedContents) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath unpacked_path =
test_data_dir_.AppendASCII("content_verifier/storage_permission");
base::FilePath crx_path = PackExtension(unpacked_path);
ASSERT_TRUE(base::PathExists(crx_path.DirName().AppendASCII("temp.pem")));
const std::string extension_id = GetExtensionIdFromPrivateKeyFile(
crx_path.DirName().AppendASCII("temp.pem"));
TestContentVerifySingleJobObserver observer(
extension_id, base::FilePath().AppendASCII("background.js"));
const Extension* extension = InstallExtensionFromWebstore(crx_path, 1);
ASSERT_TRUE(extension);
EXPECT_EQ(extension->id(), extension_id);
ContentHashReader::InitStatus hashes_status = observer.WaitForOnHashesReady();
EXPECT_EQ(ContentHashReader::InitStatus::HASHES_MISSING, hashes_status);
}
// Tests that tampering with a large resource fails content verification as
// expected. The size of the resource is such that it would trigger
// FileLoaderObserver::OnSeekComplete in extension_protocols.cc.
//
// Regression test for: http://crbug.com/965043.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, TamperLargeSizedResource) {
// This test extension is copied from the webstore that has actual
// signatures.
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/different_sized_files.crx"),
1);
ASSERT_TRUE(extension);
const char kResource[] = "jquery-3.2.0.min.js";
{
// Modify content so that content verification fails.
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath real_path = extension->path().AppendASCII(kResource);
ASSERT_TRUE(base::PathExists(real_path));
std::string extra = "some_extra_function_call();";
ASSERT_TRUE(base::AppendToFile(real_path, extra));
}
NavigateToResourceAndExpectExtensionDisabled(
extension->id(), extension->ResolveExtensionURL(kResource));
}
#if BUILDFLAG(ENABLE_EXTENSIONS)
// Tests that a resource reading failure due to FileURLLoader cancellation
// does not incorrectly result in content verificaton failure.
// Regression test for: http://crbug.com/977805.
// TODO(crbug.com/413122584): Port to desktop Android. The cross platform
// navigation utilities we have don't support new tab + no wait.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
PRE_ResourceReadCancellationDoesNotFailVerification) {
// This test extension is copied from the webstore that has actual
// signatures.
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/ten_meg_resource.crx"), 1);
ASSERT_TRUE(extension);
EXPECT_EQ(kTenMegResourceExtensionId, extension->id());
// Navigate to a large resource that *likely* won't complete before
// this test ends and results in FileDataPipeProducer shutdown. This results
// in FILE_ERROR_ABORT in FileDataPipeProducer::Observer::BytesRead().
//
// Note that this can produce false-positive results because if the resource
// completes loading before shutdown, this test will still pass. There
// currently isn't a way to forcefully shut down FileDataPipeProducer.
// Also, whether to pursue such effort is debatable as it feels poking into
// the implementation detail a little too much.
const char kLargeResource[] = "ten_meg_background.js";
ui_test_utils::NavigateToURLWithDisposition(
browser(), extension->ResolveExtensionURL(kLargeResource),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_NO_WAIT);
}
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
ResourceReadCancellationDoesNotFailVerification) {
// Expect the extension to not get disabled due to corruption.
extensions::ExtensionRegistry* registry =
extensions::ExtensionRegistry::Get(profile());
{
// Add a helpful hint, in case the regression reappears.
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons =
prefs->GetDisableReasons(kTenMegResourceExtensionId);
EXPECT_TRUE(reasons.empty())
<< "Unexpected disable reasons. Includes corruption: "
<< (reasons.contains(disable_reason::DISABLE_CORRUPTED));
}
const Extension* extension =
registry->enabled_extensions().GetByID(kTenMegResourceExtensionId);
ASSERT_TRUE(extension);
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
// Tests that navigating to an extension resource with '/' at end does not
// disable the extension.
//
// Regression test for: https://crbug.com/929578.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
RemainsEnabledOnNavigateToPathEndingWithSlash) {
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/content_script.crx"), 1);
ASSERT_TRUE(extension);
const ExtensionId kExtensionId = extension->id();
GURL page_url = extension->ResolveExtensionURL("script.js/");
// The page should not load.
ASSERT_FALSE(NavigateToURL(page_url));
ASSERT_FALSE(content::WaitForLoadStop(GetActiveWebContents()));
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_TRUE(reasons.empty());
}
// Tests that navigating to an extension resource with '.' at end does not
// disable the extension.
//
// Regression test for https://crbug.com/696208.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
RemainsEnabledOnNavigateToPathEndingWithDot) {
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/content_script.crx"), 1);
ASSERT_TRUE(extension);
const ExtensionId kExtensionId = extension->id();
GURL page_url = extension->ResolveExtensionURL("script.js.");
// The page should not load.
ASSERT_FALSE(NavigateToURL(page_url));
ASSERT_FALSE(content::WaitForLoadStop(GetActiveWebContents()));
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_TRUE(reasons.empty());
}
// Tests that navigating to an extension resource with incorrect case does not
// disable the extension, both in case-sensitive and case-insensitive systems.
//
// Regression test for https://crbug.com/1033294.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
RemainsEnabledOnNavigateToPathWithIncorrectCase) {
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/content_script.crx"), 1);
ASSERT_TRUE(extension);
const ExtensionId extension_id = extension->id();
// Note: the resource in `extension` is "script.js".
constexpr char kIncorrectCasePath[] = "SCRIPT.js";
TestContentVerifySingleJobObserver job_observer(
extension_id, base::FilePath().AppendASCII(kIncorrectCasePath));
GURL page_url = extension->ResolveExtensionURL(kIncorrectCasePath);
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
// Some platforms are case insensitive, load should succeed.
ASSERT_TRUE(NavigateToURL(page_url));
ASSERT_TRUE(content::WaitForLoadStop(GetActiveWebContents()));
#else
// On case-sensitive platforms, load should fail.
ASSERT_FALSE(NavigateToURL(page_url));
ASSERT_FALSE(content::WaitForLoadStop(GetActiveWebContents()));
#endif
// Ensure that ContentVerifyJob has finished checking the resource.
EXPECT_EQ(ContentVerifyJob::NONE, job_observer.WaitForJobFinished());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(extension_id);
EXPECT_TRUE(reasons.empty());
}
// Test that navigating to an extension resource with a range header does not
// disable the extension.
// Regression test for https://crbug.com/405286894.
IN_PROC_BROWSER_TEST_F(ContentVerifierTest,
RemainsEnabledOnNavigateToPathWithRangeHeader) {
// Load an extension with a large file.
const Extension* extension = InstallExtensionFromWebstore(
test_data_dir_.AppendASCII("content_verifier/long_file.crx"), 1);
ASSERT_TRUE(extension);
const ExtensionId kExtensionId = extension->id();
static constexpr char kFetchFileContent[] = R"(
(async () => {
const fileURL = chrome.runtime.getURL('page.html');
const headers = { Range: `bytes=%s` };
try {
const response = await fetch(fileURL, { headers });
const fileContent = await response.text();
chrome.test.sendScriptResult(fileContent);
} catch(err) {
chrome.test.sendScriptResult(`ERROR: ${err}`);
}
})();
)";
// Fetch the first 20 bytes of `page.html`. The script should run to
// completion since the extension should not be corrupted.
auto value = BackgroundScriptExecutor::ExecuteScript(
profile(), kExtensionId, base::StringPrintf(kFetchFileContent, "0-19"),
BackgroundScriptExecutor::ResultCapture::kSendScriptResult);
ASSERT_TRUE(value.is_string());
EXPECT_EQ(std::string(20, 'a'), value.GetString());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_TRUE(reasons.empty());
// Fetch using multiple ranges. This should fail since this is currently not
// supported by the FileURLLoader.
value = BackgroundScriptExecutor::ExecuteScript(
profile(), kExtensionId, base::StringPrintf(kFetchFileContent, "2-5,7-9"),
BackgroundScriptExecutor::ResultCapture::kSendScriptResult);
ASSERT_TRUE(value.is_string());
EXPECT_EQ("ERROR: TypeError: Failed to fetch", value.GetString());
// The fetch should fail but the extension shouldn't be disabled/corrupted.
reasons = prefs->GetDisableReasons(kExtensionId);
EXPECT_TRUE(reasons.empty());
}
#if BUILDFLAG(ENABLE_EXTENSIONS)
// TODO(crbug.com/394876083): Port these tests to desktop Android when more of
// the policy/management stack is ported.
class ContentVerifierPolicyTest : public ContentVerifierTest {
public:
// We need to do this work here because the force-install policy values are
// checked pretty early on in the startup of the ExtensionService, which
// happens between SetUpInProcessBrowserTestFixture and SetUpOnMainThread.
void SetUpInProcessBrowserTestFixture() override {
ContentVerifierTest::SetUpInProcessBrowserTestFixture();
policy_provider_.SetDefaultReturns(
/*is_initialization_complete_return=*/true,
/*is_first_policy_load_complete_return=*/true);
policy::BrowserPolicyConnector::SetPolicyProviderForTesting(
&policy_provider_);
// ExtensionManagementPolicyUpdater requires a single-threaded context to
// call RunLoop::RunUntilIdle internally, and it isn't ready at this setup
// moment.
base::test::TaskEnvironment env;
ExtensionManagementPolicyUpdater management_policy(&policy_provider_);
management_policy.SetIndividualExtensionAutoInstalled(
id_, extension_urls::kChromeWebstoreUpdateURL, true /* forced */);
}
void SetUpOnMainThread() override {
#if BUILDFLAG(IS_CHROMEOS)
extensions::browsertest_util::CreateAndInitializeLocalCache();
#endif
}
protected:
// The id of the extension we want to have force-installed.
std::string id_ = "dkjgfphccejbobpbljnpjcmhmagkdoia";
private:
testing::NiceMock<policy::MockConfigurationPolicyProvider> policy_provider_;
};
// We want to test what happens at startup with a corroption-disabled policy
// force installed extension. So we set that up in the PRE test here.
IN_PROC_BROWSER_TEST_F(ContentVerifierPolicyTest,
PRE_PolicyCorruptedOnStartup) {
// Mark as enterprise managed.
policy::ScopedDomainEnterpriseManagement scoped_domain;
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
TestExtensionRegistryObserver registry_observer(registry, id_);
// Wait for the extension to be installed by policy we set up in
// SetUpInProcessBrowserTestFixture.
if (!registry->GetInstalledExtension(id_))
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
// Simulate corruption of the extension so that we can test what happens
// at startup in the non-PRE test.
ExtensionSystem* system = ExtensionSystem::Get(profile());
ContentVerifier* verifier = system->content_verifier();
verifier->VerifyFailedForTest(id_, ContentVerifyJob::HASH_MISMATCH);
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
DisableReasonSet reasons = prefs->GetDisableReasons(id_);
EXPECT_TRUE(reasons.contains(disable_reason::DISABLE_CORRUPTED));
}
// Now actually test what happens on the next startup after the PRE test above.
// TODO(crbug.com/40805905): Flaky on mac arm64.
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM64)
#define MAYBE_PolicyCorruptedOnStartup DISABLED_PolicyCorruptedOnStartup
#else
#define MAYBE_PolicyCorruptedOnStartup PolicyCorruptedOnStartup
#endif
IN_PROC_BROWSER_TEST_F(ContentVerifierPolicyTest,
MAYBE_PolicyCorruptedOnStartup) {
// Mark as enterprise managed.
policy::ScopedDomainEnterpriseManagement scoped_domain;
// Depending on timing, the extension may have already been reinstalled
// between SetUpInProcessBrowserTestFixture and now (usually not during local
// testing on a developer machine, but sometimes on a heavily loaded system
// such as the build waterfall / trybots). If the reinstall didn't already
// happen, wait for it.
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
DisableReasonSet disable_reasons = prefs->GetDisableReasons(id_);
if (disable_reasons.contains(disable_reason::DISABLE_CORRUPTED)) {
TestExtensionRegistryObserver registry_observer(registry, id_);
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
disable_reasons = prefs->GetDisableReasons(id_);
}
EXPECT_FALSE(disable_reasons.contains(disable_reason::DISABLE_CORRUPTED));
EXPECT_TRUE(registry->enabled_extensions().Contains(id_));
}
IN_PROC_BROWSER_TEST_F(ContentVerifierPolicyTest, Backoff) {
// Mark as enterprise managed.
policy::ScopedDomainEnterpriseManagement scoped_domain;
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
ExtensionSystem* system = ExtensionSystem::Get(profile());
ContentVerifier* verifier = system->content_verifier();
// Wait for the extension to be installed by the policy we set up in
// SetUpInProcessBrowserTestFixture.
if (!registry->GetInstalledExtension(id_)) {
TestExtensionRegistryObserver registry_observer(registry, id_);
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
}
// Setup to intercept reinstall action, so we can see what the delay would
// have been for the real action.
content_verifier_test::DelayTracker delay_tracker;
// Do 4 iterations of disabling followed by reinstall.
const size_t iterations = 4;
for (size_t i = 0; i < iterations; i++) {
TestExtensionRegistryObserver registry_observer(registry, id_);
verifier->VerifyFailedForTest(id_, ContentVerifyJob::HASH_MISMATCH);
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
// Resolve the request to |delay_tracker|, so the reinstallation can
// proceed.
delay_tracker.Proceed();
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
}
const std::vector<base::TimeDelta>& calls = delay_tracker.calls();
// After |delay_tracker| resolves the 4 (|iterations|) reinstallation
// requests, it will get an additional request (right away) for retrying
// reinstallation.
// Note: the additional request in non-test environment will arrive with
// a (backoff) delay. But during test, |delay_tracker| issues the request
// immediately.
ASSERT_EQ(iterations, calls.size() - 1);
// Assert that the first reinstall action happened with a delay of 0, and
// then kept growing each additional time.
EXPECT_EQ(base::TimeDelta(), delay_tracker.calls()[0]);
for (size_t i = 1; i < delay_tracker.calls().size(); i++) {
EXPECT_LT(calls[i - 1], calls[i]);
}
}
// Tests that if CheckForExternalUpdates() fails, then we retry reinstalling
// corrupted policy extensions. For example: if network is unavailable,
// CheckForExternalUpdates() will fail.
IN_PROC_BROWSER_TEST_F(ContentVerifierPolicyTest, FailedUpdateRetries) {
// Mark as enterprise managed.
policy::ScopedDomainEnterpriseManagement scoped_domain;
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
ExtensionSystem* system = ExtensionSystem::Get(profile());
ContentVerifier* verifier = system->content_verifier();
// Wait for the extension to be installed by the policy we set up in
// SetUpInProcessBrowserTestFixture.
if (!registry->GetInstalledExtension(id_)) {
TestExtensionRegistryObserver registry_observer(registry, id_);
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
}
content_verifier_test::DelayTracker delay_tracker;
TestExtensionRegistryObserver registry_observer(registry, id_);
{
base::AutoReset<bool> disable_scope =
ExternalProviderManager::DisableExternalUpdatesForTesting();
verifier->VerifyFailedForTest(id_, ContentVerifyJob::HASH_MISMATCH);
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
const std::vector<base::TimeDelta>& calls = delay_tracker.calls();
ASSERT_EQ(1u, calls.size());
EXPECT_EQ(base::TimeDelta(), delay_tracker.calls()[0]);
delay_tracker.Proceed();
CorruptedExtensionReinstaller::set_reinstall_action_for_test(nullptr);
}
// Update ExtensionService again without disabling external updates.
// The extension should now get installed.
delay_tracker.Proceed();
EXPECT_TRUE(registry_observer.WaitForExtensionInstalled());
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
#if BUILDFLAG(ENABLE_DOWNGRADE_PROCESSING)
class ContentVerifierRepairsAllExtensionsDowngradeTest
: public UserInstalledContentVerifierTest {
public:
void SetUp() override { UserInstalledContentVerifierTest::SetUp(); }
void TearDown() override {
UserInstalledContentVerifierTest::TearDown();
if (!delete_all_extension_files_) {
return;
}
// Corrupt the extension
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(
base::DeletePathRecursively(profile_path_.AppendASCII("Extensions")));
ASSERT_TRUE(base::DeletePathRecursively(
profile_path_.AppendASCII("Extension State")));
ASSERT_TRUE(base::DeletePathRecursively(
profile_path_.AppendASCII("Extension Scripts")));
ASSERT_TRUE(base::DeletePathRecursively(
profile_path_.AppendASCII("Extension Rules")));
}
void SetUpOnMainThread() override {
UserInstalledContentVerifierTest::SetUpOnMainThread();
profile_path_ = profile()->GetPath();
}
void SetUpCommandLine(base::CommandLine* command_line) override {
UserInstalledContentVerifierTest::SetUpCommandLine(command_line);
const std::string_view test_name(
::testing::UnitTest::GetInstance()->current_test_info()->name());
if (GetTestPreCount() >= 1) {
return;
}
// Simulate a successful user data downgrade.
command_line->AppendSwitch(switches::kRepairAllValidExtensions);
command_line->AppendSwitch(switches::kUserDataMigrated);
}
protected:
CorruptedExtensionReinstaller* GetCorruptedExtensionReinstaller() {
return CorruptedExtensionReinstaller::Get(profile());
}
bool delete_all_extension_files_ = false;
base::FilePath profile_path_;
};
// Verify that all extensions are repaired while the browser is running and the
// command line switch 'repair-all-valid-extensions' is set.
IN_PROC_BROWSER_TEST_F(ContentVerifierRepairsAllExtensionsDowngradeTest,
RepairsAllValidExtensions) {
auto verifier_observer = std::make_unique<VerifierObserver>();
InstallExtensionFromWebstore(
test_data_dir_.AppendASCII(kStoragePermissionExtensionCrx), 1);
verifier_observer->EnsureFetchCompleted(kStoragePermissionExtensionId);
verifier_observer.reset();
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
const Extension* extension =
registry->enabled_extensions().GetByID(kStoragePermissionExtensionId);
EXPECT_TRUE(extension);
const base::FilePath kResourcePath(FILE_PATH_LITERAL("background.js"));
// Corrupt the extension
{
base::FilePath resource_path = extension->path().Append(kResourcePath);
base::ScopedAllowBlockingForTesting allow_blocking;
// Temporarily disable extension, we don't want to tackle with resources of
// enabled one.
DisableExtension(kStoragePermissionExtensionId);
ASSERT_TRUE(base::WriteFile(resource_path, "// corrupted\n"));
EnableExtension(kStoragePermissionExtensionId);
}
TestExtensionRegistryObserver registry_observer(
registry, kStoragePermissionExtensionId);
ExtensionSystem* system = ExtensionSystem::Get(profile());
system->content_verifier()->VerifyFailedForTest(
kStoragePermissionExtensionId, ContentVerifyJob::HASH_MISMATCH);
EXPECT_TRUE(registry_observer.WaitForExtensionUnloaded());
// The extension should be disabled and expected to be repaired.
EXPECT_THAT(ExtensionPrefs::Get(profile())->GetDisableReasons(
kStoragePermissionExtensionId),
testing::UnorderedElementsAre(disable_reason::DISABLE_CORRUPTED));
EXPECT_TRUE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
}
IN_PROC_BROWSER_TEST_F(ContentVerifierRepairsAllExtensionsDowngradeTest,
PRE_ExtensionsRepairedAtStartup) {
auto verifier_observer = std::make_unique<VerifierObserver>();
InstallExtensionFromWebstore(
test_data_dir_.AppendASCII(kStoragePermissionExtensionCrx), 1);
verifier_observer->EnsureFetchCompleted(kStoragePermissionExtensionId);
verifier_observer.reset();
ASSERT_TRUE(ExtensionRegistry::Get(profile())->enabled_extensions().GetByID(
kStoragePermissionExtensionId));
delete_all_extension_files_ = true;
}
IN_PROC_BROWSER_TEST_F(ContentVerifierRepairsAllExtensionsDowngradeTest,
ExtensionsRepairedAtStartup) {
auto& command_line = *base::CommandLine::ForCurrentProcess();
ASSERT_TRUE(command_line.HasSwitch(switches::kRepairAllValidExtensions));
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
DisableReasonSet disable_reasons =
prefs->GetDisableReasons(kStoragePermissionExtensionId);
// Depending on timing, the extension may have already been reinstalled
// between SetUpInProcessBrowserTestFixture and now (usually not during local
// testing on a developer machine, but sometimes on a heavily loaded system
// such as the build waterfall / trybots). If the reinstall didn't already
// happen, wait for it.
if (disable_reasons.contains(disable_reason::DISABLE_CORRUPTED)) {
EXPECT_TRUE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
TestExtensionRegistryObserver registry_observer(
registry, kStoragePermissionExtensionId);
ASSERT_TRUE(registry_observer.WaitForExtensionInstalled());
disable_reasons = prefs->GetDisableReasons(kStoragePermissionExtensionId);
}
EXPECT_FALSE(
GetCorruptedExtensionReinstaller()->IsReinstallForCorruptionExpected(
kStoragePermissionExtensionId));
EXPECT_TRUE(disable_reasons.empty());
const Extension* extension =
ExtensionRegistry::Get(profile())->enabled_extensions().GetByID(
kStoragePermissionExtensionId);
ASSERT_TRUE(extension);
}
#endif // BUILDFLAG(ENABLE_DOWNGRADE_PROCESSING)
} // namespace extensions
|