1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/extension_action_icon_factory.h"
#include <memory>
#include <utility>
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/json/json_file_value_serializer.h"
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "build/build_config.h"
#include "build/chromeos_buildflags.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/extension_action.h"
#include "extensions/browser/extension_action_manager.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/common/extension.h"
#include "extensions/common/image_util.h"
#include "extensions/grit/extensions_browser_resources.h"
#include "skia/ext/image_operations.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/codec/png_codec.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/image/image_skia_rep.h"
#include "ui/gfx/skia_util.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/ash/login/users/user_manager_delegate_impl.h"
#include "chrome/browser/ash/settings/scoped_cros_settings_test_helper.h"
#include "chrome/browser/browser_process.h"
#include "chromeos/ash/components/settings/cros_settings.h"
#include "components/user_manager/scoped_user_manager.h"
#include "components/user_manager/user_manager_impl.h"
#endif
using extensions::mojom::ManifestLocation;
namespace extensions {
namespace {
bool ImageRepsAreEqual(const gfx::ImageSkiaRep& image_rep1,
const gfx::ImageSkiaRep& image_rep2) {
return image_rep1.scale() == image_rep2.scale() &&
gfx::BitmapsAreEqual(image_rep1.GetBitmap(), image_rep2.GetBitmap());
}
gfx::Image EnsureImageSize(const gfx::Image& original, int size) {
const SkBitmap* original_bitmap = original.ToSkBitmap();
if (original_bitmap->width() == size && original_bitmap->height() == size)
return original;
SkBitmap resized = skia::ImageOperations::Resize(
*original.ToSkBitmap(), skia::ImageOperations::RESIZE_LANCZOS3,
size, size);
return gfx::Image::CreateFrom1xBitmap(resized);
}
gfx::ImageSkiaRep CreateBlankRep(int size_dip, float scale) {
SkBitmap bitmap;
bitmap.allocN32Pixels(static_cast<int>(size_dip * scale),
static_cast<int>(size_dip * scale));
bitmap.eraseColor(SkColorSetARGB(0, 0, 0, 0));
return gfx::ImageSkiaRep(bitmap, scale);
}
gfx::Image LoadIcon(const std::string& filename) {
base::FilePath path;
base::PathService::Get(chrome::DIR_TEST_DATA, &path);
path = path.AppendASCII("extensions/api_test").AppendASCII(filename);
std::optional<std::vector<uint8_t>> file_contents =
base::ReadFileToBytes(path);
SkBitmap bitmap = gfx::PNGCodec::Decode(file_contents.value());
CHECK(!bitmap.isNull());
return gfx::Image::CreateFrom1xBitmap(bitmap);
}
class ExtensionActionIconFactoryTest
: public testing::Test,
public ExtensionActionIconFactory::Observer {
public:
ExtensionActionIconFactoryTest() : quit_in_icon_updated_(false) {}
ExtensionActionIconFactoryTest(const ExtensionActionIconFactoryTest&) =
delete;
ExtensionActionIconFactoryTest& operator=(
const ExtensionActionIconFactoryTest&) = delete;
~ExtensionActionIconFactoryTest() override = default;
void WaitForIconUpdate() {
quit_in_icon_updated_ = true;
loop_.Run();
quit_in_icon_updated_ = false;
}
scoped_refptr<Extension> CreateExtension(const char* name,
ManifestLocation location) {
// Create and load an extension.
base::FilePath test_file;
if (!base::PathService::Get(chrome::DIR_TEST_DATA, &test_file)) {
EXPECT_FALSE(true);
return nullptr;
}
test_file = test_file.AppendASCII("extensions/api_test").AppendASCII(name);
int error_code = 0;
std::string error;
JSONFileValueDeserializer deserializer(
test_file.AppendASCII("manifest.json"));
std::unique_ptr<base::Value> valid_value =
deserializer.Deserialize(&error_code, &error);
EXPECT_EQ(0, error_code) << error;
if (error_code != 0)
return nullptr;
EXPECT_TRUE(valid_value.get() && valid_value->is_dict());
if (!valid_value || !valid_value->is_dict())
return nullptr;
scoped_refptr<Extension> extension =
Extension::Create(test_file, location, valid_value->GetDict(),
Extension::NO_FLAGS, &error);
EXPECT_TRUE(extension.get()) << error;
if (extension) {
ExtensionRegistrar::Get(profile_.get())->AddExtension(extension);
}
return extension;
}
// testing::Test overrides:
void SetUp() override {
profile_ = std::make_unique<TestingProfile>();
base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
static_cast<extensions::TestExtensionSystem*>(
extensions::ExtensionSystem::Get(profile_.get()))
->CreateExtensionService(&command_line, base::FilePath(), false);
}
void TearDown() override {
profile_.reset(); // Get all DeleteSoon calls sent to ui_loop_.
}
// ExtensionActionIconFactory::Observer overrides:
void OnIconUpdated() override {
if (quit_in_icon_updated_)
loop_.QuitWhenIdle();
}
gfx::ImageSkia GetFavicon() {
return *ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
IDR_EXTENSIONS_FAVICON);
}
ExtensionAction* GetExtensionAction(const Extension& extension) {
return ExtensionActionManager::Get(profile_.get())
->GetExtensionAction(extension);
}
private:
content::BrowserTaskEnvironment task_environment_;
bool quit_in_icon_updated_;
std::unique_ptr<TestingProfile> profile_;
base::RunLoop loop_;
#if BUILDFLAG(IS_CHROMEOS)
ash::ScopedCrosSettingsTestHelper cros_settings_test_helper_;
user_manager::ScopedUserManager user_manager_{
std::make_unique<user_manager::UserManagerImpl>(
std::make_unique<ash::UserManagerDelegateImpl>(),
g_browser_process->local_state(),
ash::CrosSettings::Get())};
#endif
};
// If there is no default icon, and the icon has not been set using |SetIcon|,
// the factory should return the placeholder icon.
TEST_F(ExtensionActionIconFactoryTest, NoIcons) {
// Load an extension that has browser action without default icon set in the
// manifest and does not call |SetIcon| by default.
scoped_refptr<Extension> extension(
CreateExtension("browser_action/no_icon", ManifestLocation::kUnpacked));
ASSERT_TRUE(extension.get() != nullptr);
ExtensionAction* action = GetExtensionAction(*extension);
ASSERT_TRUE(action);
ASSERT_FALSE(action->default_icon());
ASSERT_TRUE(action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());
ExtensionActionIconFactory icon_factory(extension.get(), action, this);
gfx::Image icon = icon_factory.GetIcon(0);
EXPECT_TRUE(ImageRepsAreEqual(
action->GetDefaultIconImage().ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
}
// If the explicitly-set icon is invisible, |ExtensionAction::GetIcon| should
// return the placeholder icon.
TEST_F(ExtensionActionIconFactoryTest, InvisibleIcon) {
// Load an extension that has browser action with a default icon set in the
// manifest, but that icon is not sufficiently visible.
scoped_refptr<Extension> extension(CreateExtension(
"browser_action/invisible_icon", ManifestLocation::kInternal));
// Check that the default icon is not sufficiently visible.
ASSERT_TRUE(extension);
ExtensionAction* action = GetExtensionAction(*extension);
ASSERT_TRUE(action);
EXPECT_TRUE(action->default_icon());
gfx::Image default_icon = action->GetDefaultIconImage();
EXPECT_FALSE(default_icon.IsEmpty());
const SkBitmap* const bitmap = default_icon.ToSkBitmap();
ASSERT_TRUE(bitmap);
EXPECT_FALSE(extensions::image_util::IsIconSufficientlyVisible(*bitmap));
// Set the flag for testing.
ExtensionActionIconFactory::SetAllowInvisibleIconsForTest(false);
ExtensionActionIconFactory icon_factory(extension.get(), action, this);
gfx::Image icon = icon_factory.GetIcon(0);
// The default icon should not be returned, since it's invisible.
// The placeholder icon should be returned instead.
EXPECT_TRUE(ImageRepsAreEqual(
action->GetPlaceholderIconImage().ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
// Reset the flag for testing.
ExtensionActionIconFactory::SetAllowInvisibleIconsForTest(true);
}
// If the icon has been set using |SetIcon|, the factory should return that
// icon.
TEST_F(ExtensionActionIconFactoryTest, AfterSetIcon) {
// Load an extension that has browser action without default icon set in the
// manifest and does not call |SetIcon| by default (but has an browser action
// icon resource).
scoped_refptr<Extension> extension(
CreateExtension("browser_action/no_icon", ManifestLocation::kUnpacked));
ASSERT_TRUE(extension.get() != nullptr);
ExtensionAction* action = GetExtensionAction(*extension);
ASSERT_TRUE(action);
ASSERT_FALSE(action->default_icon());
ASSERT_TRUE(action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());
gfx::Image set_icon = LoadIcon("browser_action/no_icon/icon.png");
ASSERT_FALSE(set_icon.IsEmpty());
action->SetIcon(0, set_icon);
ASSERT_FALSE(action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());
ExtensionActionIconFactory icon_factory(extension.get(), action, this);
gfx::Image icon = icon_factory.GetIcon(0);
EXPECT_TRUE(ImageRepsAreEqual(
set_icon.ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
// It should still return the default icon for another tab.
icon = icon_factory.GetIcon(1);
EXPECT_TRUE(ImageRepsAreEqual(
action->GetDefaultIconImage().ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
}
// If there is a default icon, and the icon has not been set using |SetIcon|,
// the factory should return the default icon.
TEST_F(ExtensionActionIconFactoryTest, DefaultIcon) {
// Load an extension that has browser action without default icon set in the
// manifest and does not call |SetIcon| by default (but has an browser action
// icon resource).
scoped_refptr<Extension> extension(
CreateExtension("browser_action/no_icon", ManifestLocation::kUnpacked));
ASSERT_TRUE(extension.get() != nullptr);
ExtensionAction* action = GetExtensionAction(*extension);
ASSERT_TRUE(action);
ASSERT_FALSE(action->default_icon());
ASSERT_TRUE(action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());
scoped_refptr<const Extension> extension_with_icon =
CreateExtension("browser_action_with_icon", ManifestLocation::kUnpacked);
ASSERT_TRUE(extension_with_icon);
int icon_size = ExtensionAction::ActionIconSize();
gfx::Image default_icon =
EnsureImageSize(LoadIcon("browser_action_with_icon/icon.png"), icon_size);
ASSERT_FALSE(default_icon.IsEmpty());
action = GetExtensionAction(*extension_with_icon);
ASSERT_TRUE(action->default_icon());
ExtensionActionIconFactory icon_factory(extension_with_icon.get(), action,
this);
gfx::Image icon = icon_factory.GetIcon(0);
// The icon should be loaded asynchronously. Initially a transparent icon
// should be returned.
EXPECT_TRUE(ImageRepsAreEqual(
CreateBlankRep(icon_size, 1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
WaitForIconUpdate();
icon = icon_factory.GetIcon(0);
// The default icon representation should be loaded at this point.
EXPECT_TRUE(ImageRepsAreEqual(
default_icon.ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
// The same icon should be returned for the other tabs.
icon = icon_factory.GetIcon(1);
EXPECT_TRUE(ImageRepsAreEqual(
default_icon.ToImageSkia()->GetRepresentation(1.0f),
icon.ToImageSkia()->GetRepresentation(1.0f)));
}
} // namespace
} // namespace extensions
|