1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_sync_data.h"
#include <memory>
#include "base/files/file_path.h"
#include "base/version.h"
#include "components/sync/model/string_ordinal.h"
#include "components/sync/protocol/app_specifics.pb.h"
#include "components/sync/protocol/entity_specifics.pb.h"
#include "components/sync/protocol/extension_specifics.pb.h"
#include "extensions/browser/disable_reason.h"
#include "extensions/buildflags/buildflags.h"
#include "extensions/common/extension.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
namespace {
const char kValidId[] = "abcdefghijklmnopabcdefghijklmnop";
const char kVersion[] = "1.0.0.1";
const char kValidUpdateUrl[] =
"https://clients2.google.com/service/update2/crx";
const int kValidDisableReasons = disable_reason::DISABLE_USER_ACTION;
// Serializes a protobuf structure (entity specifics) into an ExtensionSyncData
// and back again, and confirms that the input is the same as the output.
void ProtobufToSyncDataEqual(const sync_pb::EntitySpecifics& entity) {
syncer::SyncData sync_data =
syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
std::unique_ptr<ExtensionSyncData> extension_sync_data =
ExtensionSyncData::CreateFromSyncData(sync_data);
ASSERT_TRUE(extension_sync_data.get());
syncer::SyncData output_sync_data = extension_sync_data->GetSyncData();
const sync_pb::ExtensionSpecifics& output =
output_sync_data.GetSpecifics().extension();
const sync_pb::ExtensionSpecifics& input = entity.extension();
// Check for field-by-field quality. It'd be nice if we could use
// AssertionResults here (instead of EXPECT_EQ) so that we could get valid
// line numbers, but it's not worth the ugliness of the verbose comparison.
EXPECT_EQ(input.id(), output.id());
EXPECT_EQ(input.version(), output.version());
EXPECT_EQ(input.update_url(), output.update_url());
EXPECT_EQ(input.enabled(), output.enabled());
EXPECT_EQ(input.incognito_enabled(), output.incognito_enabled());
EXPECT_EQ(input.remote_install(), output.remote_install());
EXPECT_EQ(input.disable_reasons(), output.disable_reasons());
EXPECT_EQ(input.disable_reasons_list_size(),
output.disable_reasons_list_size());
for (int i = 0; i < input.disable_reasons_list_size(); ++i) {
EXPECT_EQ(input.disable_reasons_list(i), output.disable_reasons_list(i));
}
}
// Serializes an ExtensionSyncData into a protobuf structure and back again, and
// confirms that the input is the same as the output.
void SyncDataToProtobufEqual(const ExtensionSyncData& input) {
syncer::SyncData sync_data = input.GetSyncData();
std::unique_ptr<ExtensionSyncData> output =
ExtensionSyncData::CreateFromSyncData(sync_data);
ASSERT_TRUE(output.get());
EXPECT_EQ(input.id(), output->id());
EXPECT_EQ(input.uninstalled(), output->uninstalled());
EXPECT_EQ(input.enabled(), output->enabled());
EXPECT_EQ(input.incognito_enabled(), output->incognito_enabled());
EXPECT_EQ(input.remote_install(), output->remote_install());
EXPECT_EQ(input.version(), output->version());
EXPECT_EQ(input.update_url(), output->update_url());
EXPECT_EQ(input.name(), output->name());
}
} // namespace
class ExtensionSyncDataTest : public testing::Test {
};
// Tests the conversion process from a protobuf to an ExtensionSyncData and vice
// versa.
TEST_F(ExtensionSyncDataTest, ExtensionSyncDataForExtension) {
sync_pb::EntitySpecifics entity;
sync_pb::ExtensionSpecifics* extension_specifics = entity.mutable_extension();
extension_specifics->set_id(kValidId);
extension_specifics->set_update_url(kValidUpdateUrl);
extension_specifics->set_enabled(false);
extension_specifics->set_incognito_enabled(true);
extension_specifics->set_remote_install(false);
extension_specifics->set_version(kVersion);
// Populate disable reasons (biflag and the list).
constexpr int kDisableReasons[] = {disable_reason::DISABLE_USER_ACTION,
disable_reason::DISABLE_BLOCKED_BY_POLICY};
constexpr int kDisasbleReasonsBitflag =
kDisableReasons[0] | kDisableReasons[1];
extension_specifics->set_disable_reasons(kDisasbleReasonsBitflag);
extension_specifics->add_disable_reasons_list(kDisableReasons[0]);
extension_specifics->add_disable_reasons_list(kDisableReasons[1]);
// Check the serialize-deserialize process for proto to ExtensionSyncData.
ProtobufToSyncDataEqual(entity);
// Explicitly test that conversion to an ExtensionSyncData gets the correct
// result (otherwise we just know that conversion to/from a proto gives us
// the same result, but don't know that it's right).
ExtensionSyncData extension_sync_data;
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_EQ(kValidId, extension_sync_data.id());
EXPECT_EQ(GURL(kValidUpdateUrl), extension_sync_data.update_url());
EXPECT_FALSE(extension_sync_data.enabled());
EXPECT_EQ(true, extension_sync_data.incognito_enabled());
EXPECT_FALSE(extension_sync_data.remote_install());
EXPECT_EQ(base::Version(kVersion), extension_sync_data.version());
EXPECT_THAT(
extension_sync_data.disable_reasons(),
testing::UnorderedElementsAre(kDisableReasons[0], kDisableReasons[1]));
// Check the serialize-deserialize process for ExtensionSyncData to proto.
SyncDataToProtobufEqual(extension_sync_data);
// Flip a bit and verify the result is correct.
extension_specifics->set_incognito_enabled(false);
ProtobufToSyncDataEqual(entity);
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_FALSE(extension_sync_data.incognito_enabled());
SyncDataToProtobufEqual(extension_sync_data);
ProtobufToSyncDataEqual(entity);
}
// Tests that disable reasons are deserialized from the protobuf correctly.
TEST_F(ExtensionSyncDataTest, DisableReasonsDeserialization) {
sync_pb::EntitySpecifics entity;
sync_pb::ExtensionSpecifics* extension_specifics = entity.mutable_extension();
extension_specifics->set_id(kValidId);
extension_specifics->set_update_url(kValidUpdateUrl);
extension_specifics->set_enabled(false);
extension_specifics->set_incognito_enabled(true);
extension_specifics->set_remote_install(false);
extension_specifics->set_version(kVersion);
{
// Disable reasons set should be empty if the bitflag is not set and the
// list is empty.
ExtensionSyncData extension_sync_data;
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_TRUE(extension_sync_data.disable_reasons().empty());
}
{
// Disable reasons set should be populated with the bitflag if the list is
// empty and the bitflag is set.
extension_specifics->set_disable_reasons(
disable_reason::DISABLE_USER_ACTION |
disable_reason::DISABLE_BLOCKED_BY_POLICY);
ExtensionSyncData extension_sync_data;
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_THAT(extension_sync_data.disable_reasons(),
testing::UnorderedElementsAre(
disable_reason::DISABLE_USER_ACTION,
disable_reason::DISABLE_BLOCKED_BY_POLICY));
}
{
// Populate the list. The bitflag is already set to a different value.
extension_specifics->add_disable_reasons_list(
disable_reason::DISABLE_GREYLIST);
extension_specifics->add_disable_reasons_list(
disable_reason::DISABLE_UNSUPPORTED_DEVELOPER_EXTENSION);
// Disable reasons set should be populated with the list if both the list
// and the bitflag are set.
ExtensionSyncData extension_sync_data;
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_THAT(extension_sync_data.disable_reasons(),
testing::UnorderedElementsAre(
disable_reason::DISABLE_GREYLIST,
disable_reason::DISABLE_UNSUPPORTED_DEVELOPER_EXTENSION));
}
{
// Disable reasons set should be populated with the list if the bitflag is
// not set.
extension_specifics->clear_disable_reasons();
ExtensionSyncData extension_sync_data;
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_THAT(extension_sync_data.disable_reasons(),
testing::UnorderedElementsAre(
disable_reason::DISABLE_GREYLIST,
disable_reason::DISABLE_UNSUPPORTED_DEVELOPER_EXTENSION));
}
}
class AppSyncDataTest : public testing::Test {
public:
AppSyncDataTest() = default;
~AppSyncDataTest() override = default;
void SetRequiredExtensionValues(
sync_pb::ExtensionSpecifics* extension_specifics) {
extension_specifics->set_id(kValidId);
extension_specifics->set_update_url(kValidUpdateUrl);
extension_specifics->set_version(kVersion);
extension_specifics->set_enabled(false);
extension_specifics->set_disable_reasons(kValidDisableReasons);
extension_specifics->add_disable_reasons_list(kValidDisableReasons);
extension_specifics->set_incognito_enabled(true);
extension_specifics->set_remote_install(false);
}
};
TEST_F(AppSyncDataTest, SyncDataToExtensionSyncDataForApp) {
sync_pb::EntitySpecifics entity;
sync_pb::AppSpecifics* app_specifics = entity.mutable_app();
app_specifics->set_app_launch_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
app_specifics->set_page_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
SetRequiredExtensionValues(app_specifics->mutable_extension());
syncer::SyncData sync_data =
syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
std::unique_ptr<ExtensionSyncData> app_sync_data =
ExtensionSyncData::CreateFromSyncData(sync_data);
ASSERT_TRUE(app_sync_data.get());
EXPECT_EQ(app_specifics->app_launch_ordinal(),
app_sync_data->app_launch_ordinal().ToInternalValue());
EXPECT_EQ(app_specifics->page_ordinal(),
app_sync_data->page_ordinal().ToInternalValue());
}
TEST_F(AppSyncDataTest, ExtensionSyncDataToSyncDataForApp) {
sync_pb::EntitySpecifics entity;
sync_pb::AppSpecifics* input_specifics = entity.mutable_app();
input_specifics->set_app_launch_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
input_specifics->set_page_ordinal(
syncer::StringOrdinal::CreateInitialOrdinal().ToInternalValue());
SetRequiredExtensionValues(input_specifics->mutable_extension());
syncer::SyncData sync_data =
syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
std::unique_ptr<ExtensionSyncData> app_sync_data =
ExtensionSyncData::CreateFromSyncData(sync_data);
ASSERT_TRUE(app_sync_data.get());
syncer::SyncData output_sync_data = app_sync_data->GetSyncData();
EXPECT_TRUE(sync_data.GetSpecifics().has_app());
const sync_pb::AppSpecifics& output_specifics =
output_sync_data.GetSpecifics().app();
EXPECT_EQ(input_specifics->SerializeAsString(),
output_specifics.SerializeAsString());
}
// Ensures that invalid StringOrdinals don't break ExtensionSyncData.
TEST_F(AppSyncDataTest, ExtensionSyncDataInvalidOrdinal) {
sync_pb::EntitySpecifics entity;
sync_pb::AppSpecifics* app_specifics = entity.mutable_app();
// Set the ordinals as invalid.
app_specifics->set_app_launch_ordinal("");
app_specifics->set_page_ordinal("");
SetRequiredExtensionValues(app_specifics->mutable_extension());
syncer::SyncData sync_data =
syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
// There should be no issue loading the sync data.
std::unique_ptr<ExtensionSyncData> app_sync_data =
ExtensionSyncData::CreateFromSyncData(sync_data);
ASSERT_TRUE(app_sync_data.get());
app_sync_data->GetSyncData();
}
} // namespace extensions
|