1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_sync_service.h"
#include <utility>
#include "base/auto_reset.h"
#include "base/containers/flat_set.h"
#include "base/feature_list.h"
#include "base/functional/callback_helpers.h"
#include "base/metrics/histogram_functions.h"
#include "base/one_shot_event.h"
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/account_extension_tracker.h"
#include "chrome/browser/extensions/extension_management.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/extension_sync_service_factory.h"
#include "chrome/browser/extensions/extension_sync_util.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/extensions/permissions/permissions_updater.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/glue/sync_start_util.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/sync_helper.h"
#include "components/sync/model/sync_change.h"
#include "extensions/browser/app_sorting.h"
#include "extensions/browser/blocklist_extension_prefs.h"
#include "extensions/browser/disable_reason.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/extension_util.h"
#include "extensions/browser/launch_util.h"
#include "extensions/browser/pending_extension_manager.h"
#include "extensions/browser/uninstall_reason.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/permissions/permission_message_provider.h"
#include "extensions/common/permissions/permissions_data.h"
#if !BUILDFLAG(IS_ANDROID)
#include "chrome/browser/web_applications/preinstalled_web_apps/preinstalled_web_apps.h"
#endif
using extensions::AccountExtensionTracker;
using extensions::AppSorting;
using extensions::Extension;
using extensions::ExtensionManagement;
using extensions::ExtensionManagementFactory;
using extensions::ExtensionPrefs;
using extensions::ExtensionRegistry;
using extensions::ExtensionSet;
using extensions::ExtensionSyncData;
using extensions::ExtensionSystem;
using extensions::SyncBundle;
namespace {
// Returns true if the sync type of |extension| matches |type|.
bool IsCorrectSyncType(const Extension& extension, syncer::DataType type) {
return (type == syncer::EXTENSIONS && extension.is_extension()) ||
(type == syncer::APPS && extension.is_app());
}
// Predicate for PendingExtensionManager.
// TODO(crbug.com/41401013): The !is_theme check should be unnecessary after all
// the bad data from crbug.com/558299 has been cleaned up.
bool ShouldAllowInstall(const Extension* extension,
content::BrowserContext* context) {
return !extension->is_theme() &&
extensions::sync_util::ShouldSync(context, extension);
}
// Returns if the given extension with `id` was installed while a user was
// signed in and is thus part of their account data.
bool IsAccountExtension(Profile* profile, const extensions::ExtensionId& id) {
AccountExtensionTracker::AccountExtensionType type =
AccountExtensionTracker::Get(profile)->GetAccountExtensionType(id);
return type == AccountExtensionTracker::AccountExtensionType::
kAccountInstalledLocally ||
type == AccountExtensionTracker::AccountExtensionType::
kAccountInstalledSignedIn;
}
std::map<std::string, syncer::SyncData> ToSyncerSyncDataMap(
const std::vector<ExtensionSyncData>& data) {
std::map<std::string, syncer::SyncData> result;
for (const ExtensionSyncData& item : data)
result[item.id()] = item.GetSyncData();
return result;
}
syncer::SyncDataList ToSyncerSyncDataList(
const std::vector<ExtensionSyncData>& data) {
syncer::SyncDataList result;
result.reserve(data.size());
for (const ExtensionSyncData& item : data)
result.push_back(item.GetSyncData());
return result;
}
// Given a set of disable reasons, returns the subset of syncable disable
// reasons.
base::flat_set<int> GetSyncableDisableReasons(
const base::flat_set<int>& disable_reasons) {
static_assert(extensions::disable_reason::DISABLE_REASON_LAST == (1LL << 26),
"Please consider whether your new disable reason should be"
" syncable, and if so update the list below accordingly!");
const base::flat_set<int> kKnownSyncableDisableReasons = {
extensions::disable_reason::DISABLE_USER_ACTION,
extensions::disable_reason::DISABLE_PERMISSIONS_INCREASE,
extensions::disable_reason::DISABLE_SIDELOAD_WIPEOUT,
extensions::disable_reason::DISABLE_GREYLIST,
extensions::disable_reason::DISABLE_REMOTE_INSTALL,
};
base::flat_set<int> syncable_disable_reasons;
for (const int reason : disable_reasons) {
// Newer browser versions may send reasons that are unknown to the current
// version. We treat such reasons as syncable, in addition to the known
// syncable reasons for the current version.
if (kKnownSyncableDisableReasons.contains(reason) ||
!extensions::IsValidDisableReason(reason)) {
syncable_disable_reasons.insert(reason);
}
}
return syncable_disable_reasons;
}
base::flat_set<int> GetLocalDisableReasons(
const base::flat_set<int>& disable_reasons) {
const base::flat_set<int> syncable_disable_reasons =
GetSyncableDisableReasons(disable_reasons);
return base::STLSetDifference<base::flat_set<int>>(disable_reasons,
syncable_disable_reasons);
}
} // namespace
struct ExtensionSyncService::PendingUpdate {
PendingUpdate() : grant_permissions_and_reenable(false) {}
PendingUpdate(const base::Version& version,
bool grant_permissions_and_reenable)
: version(version),
grant_permissions_and_reenable(grant_permissions_and_reenable) {}
base::Version version;
bool grant_permissions_and_reenable;
};
ExtensionSyncService::ExtensionSyncService(Profile* profile)
: profile_(profile),
system_(ExtensionSystem::Get(profile_)),
ignore_updates_(false),
flare_(sync_start_util::GetFlareForSyncableService(profile->GetPath())) {
registry_observation_.Observe(ExtensionRegistry::Get(profile_));
prefs_observation_.Observe(ExtensionPrefs::Get(profile_));
}
ExtensionSyncService::~ExtensionSyncService() = default;
// static
ExtensionSyncService* ExtensionSyncService::Get(
content::BrowserContext* context) {
return ExtensionSyncServiceFactory::GetForBrowserContext(context);
}
void ExtensionSyncService::SyncExtensionChangeIfNeeded(
const Extension& extension) {
if (ignore_updates_ || !ShouldSync(extension)) {
return;
}
syncer::DataType type =
extension.is_app() ? syncer::APPS : syncer::EXTENSIONS;
SyncBundle* bundle = GetSyncBundle(type);
if (bundle->IsSyncing()) {
bundle->PushSyncAddOrUpdate(extension.id(),
CreateSyncData(extension).GetSyncData());
DCHECK(!ExtensionPrefs::Get(profile_)->NeedsSync(extension.id()));
} else {
ExtensionPrefs::Get(profile_)->SetNeedsSync(extension.id(), true);
if (system_->is_ready() && !flare_.is_null())
flare_.Run(type); // Tell sync to start ASAP.
}
}
void ExtensionSyncService::WaitUntilReadyToSync(base::OnceClosure done) {
// Wait for the extension system to be ready.
system_->ready().Post(FROM_HERE, std::move(done));
}
std::optional<syncer::ModelError>
ExtensionSyncService::MergeDataAndStartSyncing(
syncer::DataType type,
const syncer::SyncDataList& initial_sync_data,
std::unique_ptr<syncer::SyncChangeProcessor> sync_processor) {
CHECK(sync_processor.get());
LOG_IF(FATAL, type != syncer::EXTENSIONS && type != syncer::APPS)
<< "Got " << type << " DataType";
SyncBundle* bundle = GetSyncBundle(type);
bundle->StartSyncing(std::move(sync_processor));
// Apply the initial sync data, filtering out any items where we have more
// recent local changes. Also tell the SyncBundle the extension IDs.
for (const syncer::SyncData& sync_data : initial_sync_data) {
std::unique_ptr<ExtensionSyncData> extension_sync_data(
ExtensionSyncData::CreateFromSyncData(sync_data));
// If the extension has local state that needs to be synced, ignore this
// change (we assume the local state is more recent).
if (extension_sync_data) {
if (!ExtensionPrefs::Get(profile_)->NeedsSync(
extension_sync_data->id())) {
ApplySyncData(*extension_sync_data);
} else if (ShouldPromoteToAccountExtension(*extension_sync_data)) {
// In this case, sync data is not applied as local state takes
// precedence. However, the incoming sync data indicates that the
// extension is part of the user's account and so it should be promoted
// to an account extension.
AccountExtensionTracker::Get(profile_)->OnExtensionSyncDataReceived(
extension_sync_data->id());
}
}
}
AccountExtensionTracker::Get(profile_)->OnInitialExtensionsSyncDataReceived();
// Now push the local state to sync.
// Note: We'd like to only send out changes for extensions which have
// NeedsSync set. However, we can't tell if our changes ever made it to the
// sync server (they might not e.g. when there's a temporary auth error), so
// we couldn't safely clear the flag. So just send out everything and let the
// sync client handle no-op changes.
std::vector<ExtensionSyncData> data_list = GetLocalSyncDataList(type);
bundle->PushSyncDataMap(ToSyncerSyncDataMap(data_list));
for (const ExtensionSyncData& data : data_list)
ExtensionPrefs::Get(profile_)->SetNeedsSync(data.id(), false);
if (type == syncer::APPS)
system_->app_sorting()->FixNTPOrdinalCollisions();
return std::nullopt;
}
void ExtensionSyncService::StopSyncing(syncer::DataType type) {
GetSyncBundle(type)->Reset();
}
syncer::SyncDataList ExtensionSyncService::GetAllSyncDataForTesting(
syncer::DataType type) const {
const SyncBundle* bundle = GetSyncBundle(type);
if (!bundle->IsSyncing())
return syncer::SyncDataList();
std::vector<ExtensionSyncData> sync_data_list = GetLocalSyncDataList(type);
// Add pending data (where the local extension is not installed yet).
std::vector<ExtensionSyncData> pending_extensions =
bundle->GetPendingExtensionData();
sync_data_list.insert(sync_data_list.begin(),
pending_extensions.begin(),
pending_extensions.end());
return ToSyncerSyncDataList(sync_data_list);
}
std::optional<syncer::ModelError> ExtensionSyncService::ProcessSyncChanges(
const base::Location& from_here,
const syncer::SyncChangeList& change_list) {
for (const syncer::SyncChange& sync_change : change_list) {
std::unique_ptr<ExtensionSyncData> extension_sync_data(
ExtensionSyncData::CreateFromSyncChange(sync_change));
if (extension_sync_data)
ApplySyncData(*extension_sync_data);
}
system_->app_sorting()->FixNTPOrdinalCollisions();
return std::nullopt;
}
base::WeakPtr<syncer::SyncableService> ExtensionSyncService::AsWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();
}
ExtensionSyncData ExtensionSyncService::CreateSyncData(
const Extension& extension) const {
const std::string& id = extension.id();
ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile_);
auto passkey = ExtensionPrefs::DisableReasonRawManipulationPasskey();
base::flat_set<int> current_disable_reasons =
extension_prefs->GetRawDisableReasons(passkey, id);
base::flat_set<int> syncable_disable_reasons =
GetSyncableDisableReasons(current_disable_reasons);
// Note that we're ignoring the enabled state during ApplySyncData (we
// check for the existence of disable reasons instead), we're just setting
// it here for older Chrome versions (<M48).
bool enabled = syncable_disable_reasons.empty();
if (extensions::blocklist_prefs::IsExtensionBlocklisted(id,
extension_prefs)) {
NOTREACHED() << "Blocklisted extensions should not be getting synced.";
}
bool incognito_enabled = extensions::util::IsIncognitoEnabled(id, profile_);
bool remote_install = extension_prefs->HasDisableReason(
id, extensions::disable_reason::DISABLE_REMOTE_INSTALL);
AppSorting* app_sorting = system_->app_sorting();
ExtensionManagement* extension_management =
extensions::ExtensionManagementFactory::GetForBrowserContext(profile_);
const GURL update_url =
extension_management->GetEffectiveUpdateURL(extension);
ExtensionSyncData result =
extension.is_app()
? ExtensionSyncData(
extension, enabled, syncable_disable_reasons, incognito_enabled,
remote_install, update_url,
app_sorting->GetAppLaunchOrdinal(id),
app_sorting->GetPageOrdinal(id),
extensions::GetLaunchTypePrefValue(extension_prefs, id))
: ExtensionSyncData(extension, enabled, syncable_disable_reasons,
incognito_enabled, remote_install, update_url);
// If there's a pending update, send the new version to sync instead of the
// installed one.
auto it = pending_updates_.find(id);
if (it != pending_updates_.end()) {
const base::Version& version = it->second.version;
// If we have a pending version, it should be newer than the installed one.
DCHECK_EQ(-1, extension.version().CompareTo(version));
result.set_version(version);
// If we'll re-enable the extension once it's updated, also send that back
// to sync.
if (it->second.grant_permissions_and_reenable)
result.set_enabled(true);
}
return result;
}
void ExtensionSyncService::ApplySyncData(
const ExtensionSyncData& extension_sync_data) {
const std::string& id = extension_sync_data.id();
// Remove all deprecated bookmark apps immediately, as they aren't loaded into
// the extensions system at all (and thus cannot be looked up).
if (extension_sync_data.is_deprecated_bookmark_app()) {
GetSyncBundle(syncer::APPS)->ApplySyncData(extension_sync_data);
GetSyncBundle(syncer::APPS)
->PushSyncDeletion(id, extension_sync_data.GetSyncData());
return;
}
// Note: |extension| may be null if it hasn't been installed yet.
const Extension* extension =
ExtensionRegistry::Get(profile_)->GetInstalledExtension(id);
// If there is an existing extension that shouldn't receive sync data, don't
// apply this sync data. This can happen if the local version of an
// extension is default-installed, but the sync server has data from another
// (non-default-installed) installation. We can't apply the sync data because
// it would always override the local state (which would never get sync'd).
// See crbug.com/731824.
if (extension && !ShouldReceiveSyncData(*extension)) {
return;
}
// Ignore any pref change notifications etc. while we're applying incoming
// sync data, so that we don't end up notifying ourselves.
base::AutoReset<bool> ignore_updates(&ignore_updates_, true);
syncer::DataType type =
extension_sync_data.is_app() ? syncer::APPS : syncer::EXTENSIONS;
SyncBundle* bundle = GetSyncBundle(type);
DCHECK(bundle->IsSyncing());
if (extension && !IsCorrectSyncType(*extension, type)) {
// The installed item isn't the same type as the sync data item, so we need
// to remove the sync data item; otherwise it will be a zombie that will
// keep coming back even if the installed item with this id is uninstalled.
// First tell the bundle about the extension, so that it won't just ignore
// the deletion, then push the deletion.
bundle->ApplySyncData(extension_sync_data);
bundle->PushSyncDeletion(id, extension_sync_data.GetSyncData());
return;
}
// Forward to the bundle. This will just update the list of synced extensions.
bundle->ApplySyncData(extension_sync_data);
// Handle uninstalls first.
if (extension_sync_data.uninstalled()) {
std::u16string error;
bool uninstalled = true;
if (!extension) {
error = u"Unknown extension";
uninstalled = false;
} else {
uninstalled =
extensions::ExtensionRegistrar::Get(profile_)->UninstallExtension(
id, extensions::UNINSTALL_REASON_SYNC, &error);
}
if (!uninstalled) {
LOG(WARNING) << "Failed to uninstall extension with id '" << id
<< "' from sync: " << error;
}
return;
}
// Extension from sync was uninstalled by the user as an external extension.
// Honor user choice and skip installation/enabling.
ExtensionPrefs* extension_prefs = ExtensionPrefs::Get(profile_);
if (extension_prefs->IsExternalExtensionUninstalled(id)) {
LOG(WARNING) << "Extension with id " << id
<< " from sync was uninstalled as external extension";
return;
}
enum {
NOT_INSTALLED,
INSTALLED_OUTDATED,
INSTALLED_MATCHING,
INSTALLED_NEWER,
} state = NOT_INSTALLED;
if (extension) {
switch (extension->version().CompareTo(extension_sync_data.version())) {
case -1: state = INSTALLED_OUTDATED; break;
case 0: state = INSTALLED_MATCHING; break;
case 1: state = INSTALLED_NEWER; break;
default:
NOTREACHED();
}
}
// Figure out the resulting set of disable reasons.
auto passkey = ExtensionPrefs::DisableReasonRawManipulationPasskey();
base::flat_set<int> disable_reasons =
extension_prefs->GetRawDisableReasons(passkey, id);
// Chrome versions M37-M44 used |extension_sync_data.remote_install()| to tag
// not-yet-approved remote installs. It's redundant now that disable reasons
// are synced (DISABLE_REMOTE_INSTALL should be among them already), but some
// old sync data may still be around, and it doesn't hurt to add the reason.
// TODO(crbug.com/41240022): Deprecate and eventually remove |remote_install|.
if (extension_sync_data.remote_install()) {
disable_reasons.insert(extensions::disable_reason::DISABLE_REMOTE_INSTALL);
}
// Add/remove disable reasons based on the incoming sync data.
const base::flat_set<int> incoming_disable_reasons =
extension_sync_data.disable_reasons();
if (!incoming_disable_reasons.empty() == extension_sync_data.enabled()) {
// The enabled flag disagrees with the presence of disable reasons. This
// must either come from an old (<M45) client which doesn't sync disable
// reasons, or the extension is blocklisted (which doesn't have a
// corresponding disable reason).
// Update |disable_reasons| based on the enabled flag.
if (extension_sync_data.enabled()) {
disable_reasons = GetLocalDisableReasons(disable_reasons);
} else { // Assume the extension was likely disabled by the user.
disable_reasons.insert(extensions::disable_reason::DISABLE_USER_ACTION);
}
} else {
// Replace the syncable disable reasons:
// 1. Remove any syncable disable reasons we might have.
disable_reasons = GetLocalDisableReasons(disable_reasons);
// 2. Remove any non-syncable reasons from the incoming data because Chrome
// M45-M47 also wrote local disable reasons to sync, and we don't want
// those.
base::flat_set<int> cleaned_incoming_disable_reasons_set =
GetSyncableDisableReasons(incoming_disable_reasons);
// 3. Add the incoming disable reasons.
disable_reasons = base::STLSetUnion<base::flat_set<int>>(
disable_reasons, cleaned_incoming_disable_reasons_set);
}
// Enable/disable the extension.
bool should_be_enabled = disable_reasons.empty();
bool reenable_after_update = false;
auto* extension_registrar = extensions::ExtensionRegistrar::Get(profile_);
if (should_be_enabled && !extension_registrar->IsExtensionEnabled(id)) {
if (extension) {
// Only grant permissions if the sync data explicitly sets the disable
// reasons to extensions::disable_reason::DISABLE_NONE (as opposed to the
// legacy
// (<M45) case where they're not set at all), and if the version from sync
// matches our local one.
bool grant_permissions = extension_sync_data.supports_disable_reasons() &&
(state == INSTALLED_MATCHING);
if (grant_permissions) {
extensions::PermissionsUpdater(profile_).GrantActivePermissions(
extension);
}
// Only enable if the extension has all required permissions.
// (Even if the version doesn't match - if the new version needs more
// permissions, it'll get disabled after the update.)
bool has_all_permissions =
grant_permissions ||
!extensions::PermissionMessageProvider::Get()->IsPrivilegeIncrease(
*extension_prefs->GetGrantedPermissions(id),
extension->permissions_data()->active_permissions(),
extension->GetType());
if (has_all_permissions)
extension_registrar->EnableExtension(id);
else if (extension_sync_data.supports_disable_reasons())
reenable_after_update = true;
} else {
// The extension is not installed yet. Set it to enabled; we'll check for
// permission increase (more accurately, for a version change) when it's
// actually installed.
extension_registrar->EnableExtension(id);
}
} else if (!should_be_enabled) {
// Note that |disable_reasons| includes any pre-existing reasons that
// weren't explicitly removed above.
if (extension_registrar->IsExtensionEnabled(id)) {
extension_registrar->DisableExtensionWithRawReasons(passkey, id,
disable_reasons);
} else {
// Already disabled, just replace the disable reasons.
extension_prefs->ReplaceRawDisableReasons(passkey, id, disable_reasons);
}
}
// Update the incognito flag.
extensions::util::SetIsIncognitoEnabled(
id, profile_, extension_sync_data.incognito_enabled());
extension = nullptr; // No longer safe to use.
// Set app-specific data.
if (extension_sync_data.is_app()) {
// The corresponding validation of this value during ExtensionSyncData
// population is in ExtensionSyncData::ToAppSpecifics.
if (extension_sync_data.launch_type() >= extensions::LAUNCH_TYPE_FIRST &&
extension_sync_data.launch_type() < extensions::NUM_LAUNCH_TYPES) {
extensions::SetLaunchType(
profile_, id, extension_sync_data.launch_type());
}
if (extension_sync_data.app_launch_ordinal().IsValid() &&
extension_sync_data.page_ordinal().IsValid()) {
AppSorting* app_sorting = system_->app_sorting();
app_sorting->SetAppLaunchOrdinal(
id, extension_sync_data.app_launch_ordinal());
app_sorting->SetPageOrdinal(id, extension_sync_data.page_ordinal());
}
}
// Notify the AccountExtensionTracker of an incoming extension via sync.
if (!extension_sync_data.is_app() && state != NOT_INSTALLED) {
DCHECK(ShouldPromoteToAccountExtension(extension_sync_data));
AccountExtensionTracker::Get(profile_)->OnExtensionSyncDataReceived(id);
}
// Finally, trigger installation/update as required.
bool check_for_updates = false;
if (state == INSTALLED_OUTDATED) {
// If the extension is installed but outdated, store the new version.
pending_updates_[id] =
PendingUpdate(extension_sync_data.version(), reenable_after_update);
check_for_updates = true;
} else if (state == NOT_INSTALLED) {
if (IsMigratingPreinstalledWebApp(id)) {
// Don't install the item. It's no longer relevant and is a zombie sync
// node.
base::UmaHistogramBoolean(
"Extensions.SyncBlockedByDefaultWebAppMigration", true);
} else if (!extensions::PendingExtensionManager::Get(profile_)->AddFromSync(
id, extension_sync_data.update_url(),
extension_sync_data.version(), ShouldAllowInstall,
extension_sync_data.remote_install())) {
LOG(WARNING) << "Could not add pending extension for " << id;
// This means that the extension is already pending installation, with a
// non-INTERNAL location. Add to pending_sync_data, even though it will
// never be removed (we'll never install a syncable version of the
// extension), so that GetAllSyncData() continues to send it.
}
// Track pending extensions so that we can return them in GetAllSyncData().
bundle->AddPendingExtensionData(extension_sync_data);
check_for_updates = true;
}
if (check_for_updates)
system_->extension_service()->CheckForUpdatesSoon();
}
void ExtensionSyncService::SetSyncStartFlareForTesting(
const syncer::SyncableService::StartSyncFlare& flare) {
flare_ = flare;
}
void ExtensionSyncService::DeleteThemeDoNotUse(const Extension& theme) {
DCHECK(theme.is_theme());
GetSyncBundle(syncer::EXTENSIONS)->PushSyncDeletion(
theme.id(), CreateSyncData(theme).GetSyncData());
}
void ExtensionSyncService::OnExtensionInstalled(
content::BrowserContext* browser_context,
const Extension* extension,
bool is_update) {
DCHECK_EQ(profile_, browser_context);
// Clear pending version if the installed one has caught up.
auto it = pending_updates_.find(extension->id());
if (it != pending_updates_.end()) {
int compare_result = extension->version().CompareTo(it->second.version);
if (compare_result == 0 && it->second.grant_permissions_and_reenable) {
// The call to SyncExtensionChangeIfNeeded below will take care of syncing
// changes to this extension, so we don't want to trigger sync activity
// from the call to GrantPermissionsAndEnableExtension.
base::AutoReset<bool> ignore_updates(&ignore_updates_, true);
extensions::ExtensionRegistrar::Get(profile_)
->GrantPermissionsAndEnableExtension(*extension);
}
if (compare_result >= 0)
pending_updates_.erase(it);
}
if (!is_update) {
// Ignore updates since
// `AccountExtensionTracker::OnExtensionSyncDataReceived` should handle
// incoming sync data, and these may not trigger updates based on the
// extension's version vs the version in the sync data.
AccountExtensionTracker::Get(browser_context)
->SetAccountExtensionTypeOnExtensionInstalled(*extension);
}
SyncExtensionChangeIfNeeded(*extension);
}
void ExtensionSyncService::OnExtensionUninstalled(
content::BrowserContext* browser_context,
const Extension* extension,
extensions::UninstallReason reason) {
DCHECK_EQ(profile_, browser_context);
// Don't bother syncing if the extension will be re-installed momentarily.
if (reason == extensions::UNINSTALL_REASON_REINSTALL ||
!ShouldSync(*extension)) {
return;
}
// TODO(tim): If we get here and IsSyncing is false, this will cause
// "back from the dead" style bugs, because sync will add-back the extension
// that was uninstalled here when MergeDataAndStartSyncing is called.
// See crbug.com/256795.
// Possible fix: Set NeedsSync here, then in MergeDataAndStartSyncing, if
// NeedsSync is set but the extension isn't installed, send a sync deletion.
if (!ignore_updates_) {
syncer::DataType type =
extension->is_app() ? syncer::APPS : syncer::EXTENSIONS;
SyncBundle* bundle = GetSyncBundle(type);
if (bundle->IsSyncing()) {
bundle->PushSyncDeletion(extension->id(),
CreateSyncData(*extension).GetSyncData());
} else if (system_->is_ready() && !flare_.is_null()) {
flare_.Run(type); // Tell sync to start ASAP.
}
}
pending_updates_.erase(extension->id());
}
void ExtensionSyncService::OnExtensionDisableReasonsChanged(
const std::string& extension_id,
extensions::DisableReasonSet disabled_reasons) {
ExtensionRegistry* registry = ExtensionRegistry::Get(profile_);
const Extension* extension = registry->GetInstalledExtension(extension_id);
// We can get pref change notifications for extensions that aren't installed
// (yet). In that case, we'll pick up the change later via ExtensionRegistry
// observation (in OnExtensionInstalled).
if (extension)
SyncExtensionChangeIfNeeded(*extension);
}
void ExtensionSyncService::OnExtensionPrefsWillBeDestroyed(
ExtensionPrefs* prefs) {
DCHECK(prefs_observation_.IsObservingSource(prefs));
prefs_observation_.Reset();
}
SyncBundle* ExtensionSyncService::GetSyncBundle(syncer::DataType type) {
return const_cast<SyncBundle*>(
const_cast<const ExtensionSyncService&>(*this).GetSyncBundle(type));
}
const SyncBundle* ExtensionSyncService::GetSyncBundle(
syncer::DataType type) const {
return (type == syncer::APPS) ? &app_sync_bundle_ : &extension_sync_bundle_;
}
std::vector<ExtensionSyncData> ExtensionSyncService::GetLocalSyncDataList(
syncer::DataType type) const {
// Collect the local state.
ExtensionRegistry* registry = ExtensionRegistry::Get(profile_);
std::vector<ExtensionSyncData> data;
// Note: Maybe we should include blocklisted/blocked extensions here, i.e.
// just call registry->GeneratedInstalledExtensionsSet().
// It would be more consistent, but the danger is that the black/blocklist
// hasn't been updated on all clients by the time sync has kicked in -
// so it's safest not to. Take care to add any other extension lists here
// in the future if they are added.
FillSyncDataList(registry->enabled_extensions(), type, &data);
FillSyncDataList(registry->disabled_extensions(), type, &data);
FillSyncDataList(registry->terminated_extensions(), type, &data);
return data;
}
void ExtensionSyncService::FillSyncDataList(
const ExtensionSet& extensions,
syncer::DataType type,
std::vector<ExtensionSyncData>* sync_data_list) const {
for (const scoped_refptr<const Extension>& extension : extensions) {
if (IsCorrectSyncType(*extension, type) && ShouldSync(*extension)) {
// We should never have pending data for an installed extension.
DCHECK(!GetSyncBundle(type)->HasPendingExtensionData(extension->id()));
sync_data_list->push_back(CreateSyncData(*extension));
}
}
}
bool ExtensionSyncService::ShouldPromoteToAccountExtension(
const extensions::ExtensionSyncData& extension_sync_data) const {
// The checks for `extension` and `extension_sync_data` mirror those inside
// ApplySyncData.
if (extension_sync_data.uninstalled() || extension_sync_data.is_app() ||
extension_sync_data.is_deprecated_bookmark_app()) {
return false;
}
const Extension* extension =
ExtensionRegistry::Get(profile_)->GetInstalledExtension(
extension_sync_data.id());
return extension && extension->is_extension() &&
ShouldReceiveSyncData(*extension);
}
bool ExtensionSyncService::ShouldReceiveSyncData(
const extensions::Extension& extension) const {
if (extension.is_theme()) {
// Themes are handled by the ThemeSyncableService.
return false;
}
// Otherwise, defer to the general extension sync calculation.
return extensions::sync_util::ShouldSync(profile_, &extension);
}
bool ExtensionSyncService::ShouldSync(const Extension& extension) const {
// Only extensions associated with the signed in user's account should be
// synced for transport mode. Note that syncable component extensions are an
// exception to this, and may be synced even if they are not account
// extensions.
if (extensions::sync_util::IsSyncingExtensionsInTransportMode(profile_) &&
!IsAccountExtension(profile_, extension.id()) &&
!extensions::sync_helper::IsSyncableComponentExtension(&extension)) {
return false;
}
// Any otherwise syncable extension that can receive sync data can be synced
// or uploaded.
return ShouldReceiveSyncData(extension);
}
bool ExtensionSyncService::IsMigratingPreinstalledWebApp(
const extensions::ExtensionId& extension_id) {
#if BUILDFLAG(IS_ANDROID)
// Android does not support Chrome Apps.
return false;
#else
if (!migrating_default_chrome_app_ids_cache_) {
std::vector<web_app::PreinstalledWebAppMigration> migrations =
web_app::GetPreinstalledWebAppMigrations(*profile_);
std::vector<std::string> chrome_app_ids;
chrome_app_ids.reserve(migrations.size());
for (const web_app::PreinstalledWebAppMigration& migration : migrations) {
chrome_app_ids.push_back(migration.old_chrome_app_id);
}
migrating_default_chrome_app_ids_cache_.emplace(std::move(chrome_app_ids));
}
return migrating_default_chrome_app_ids_cache_->contains(extension_id);
#endif // BUILDFLAG(IS_ANDROID)
}
|