1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_telemetry_service_verdict_handler.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/profiles/profile.h"
#include "extensions/browser/blocklist_extension_prefs.h"
#include "extensions/test/extension_state_tester.h"
namespace extensions {
namespace {
// Extension ids used during testing.
constexpr char kTestExtensionId[] = "behllobkkfkfnphdnhnkndlbkcpglgmj";
constexpr char kUninstalledExtensionId[] = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
} // namespace
// Test suite to test Extension Telemetry service verdict handler.
class ExtensionTelemetryServiceVerdictHandlerTest
: public ExtensionServiceTestBase {
public:
ExtensionTelemetryServiceVerdictHandlerTest() {
// Set to true so the acknowledged state is not automatically set by the
// extension error controller on the first run.
ExtensionPrefs::SetRunAlertsInFirstRunForTest();
}
};
TEST_F(ExtensionTelemetryServiceVerdictHandlerTest, HandlesMalwareExtension) {
base::HistogramTester histograms;
InitializeGoodInstalledExtensionService();
service()->Init();
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
Blocklist::BlocklistStateMap state_map;
state_map[kTestExtensionId] = BlocklistState::BLOCKLISTED_MALWARE;
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_EQ(blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kTestExtensionId, prefs),
BitMapBlocklistState::BLOCKLISTED_MALWARE);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/1);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionReenabled_"
"PastDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/0);
}
TEST_F(ExtensionTelemetryServiceVerdictHandlerTest,
ReenablesUnblocklistedExtension) {
base::HistogramTester histograms;
InitializeGoodInstalledExtensionService();
service()->Init();
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
Blocklist::BlocklistStateMap state_map;
state_map[kTestExtensionId] = BlocklistState::BLOCKLISTED_MALWARE;
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_EQ(blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kTestExtensionId, prefs),
BitMapBlocklistState::BLOCKLISTED_MALWARE);
// Acknowledged state is false since user hasn't acknowledged.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE, prefs));
// User acknowledges.
blocklist_prefs::AddAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE, prefs);
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE, prefs));
// Unblocklists kTestExtensionId.
state_map[kTestExtensionId] = BlocklistState::NOT_BLOCKLISTED;
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
EXPECT_EQ(blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kTestExtensionId, prefs),
BitMapBlocklistState::NOT_BLOCKLISTED);
// Acknowledged state is cleared since the extension is removed from the
// blocklist.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE, prefs));
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/1);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionReenabled_"
"PastDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/1);
}
TEST_F(ExtensionTelemetryServiceVerdictHandlerTest,
IgnoresUninstalledExtension) {
base::HistogramTester histograms;
InitializeGoodInstalledExtensionService();
service()->Init();
Blocklist::BlocklistStateMap state_map;
state_map[kUninstalledExtensionId] = BlocklistState::BLOCKLISTED_MALWARE;
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_EQ(blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kUninstalledExtensionId, prefs),
BitMapBlocklistState::NOT_BLOCKLISTED);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/0);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionReenabled_"
"PastDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/0);
}
TEST_F(ExtensionTelemetryServiceVerdictHandlerTest,
IgnoresUnknownBlocklistState) {
base::HistogramTester histograms;
InitializeGoodInstalledExtensionService();
service()->Init();
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
Blocklist::BlocklistStateMap state_map;
state_map[kTestExtensionId] = BlocklistState::BLOCKLISTED_UNKNOWN;
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
EXPECT_EQ(blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kTestExtensionId, prefs),
BitMapBlocklistState::NOT_BLOCKLISTED);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/0);
histograms.ExpectBucketCount(
"SafeBrowsing.ExtensionTelemetry.OffstoreExtensionReenabled_"
"PastDisabledReason",
/*sample=*/ExtensionTelemetryDisableReason::kMalware,
/*expected_count=*/0);
}
TEST_F(ExtensionTelemetryServiceVerdictHandlerTest,
ExtensionAlreadyUninstalled) {
InitializeGoodInstalledExtensionService();
service()->Init();
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
registrar()->UninstallExtension(kTestExtensionId,
UNINSTALL_REASON_FOR_TESTING, nullptr);
Blocklist::BlocklistStateMap state_map;
state_map[kTestExtensionId] = BlocklistState::BLOCKLISTED_MALWARE;
// kTestExtensionId is already uninstalled. Performing action on it should
// not crash. Regression test for https://crbug.com/1305490.
service()->PerformActionBasedOnExtensionTelemetryServiceVerdicts(state_map);
}
} // namespace extensions
|
