1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/external_provider_impl.h"
#include <memory>
#include "ash/constants/ash_pref_names.h"
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/scoped_path_override.h"
#include "chrome/browser/ash/customization/customization_document.h"
#include "chrome/browser/ash/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/external_provider_manager.h"
#include "chrome/browser/prefs/pref_service_syncable_util.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/signin/identity_test_environment_profile_adaptor.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chromeos/ash/components/system/fake_statistics_provider.h"
#include "chromeos/ash/components/system/statistics_provider.h"
#include "components/sync/base/command_line_switches.h"
#include "components/sync/base/data_type.h"
#include "components/sync/base/pref_names.h"
#include "components/sync/model/sync_change_processor.h"
#include "components/sync/test/fake_sync_change_processor.h"
#include "components/sync_preferences/pref_service_syncable.h"
#include "components/user_manager/scoped_user_manager.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/pending_extension_manager.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
const char kExternalAppId[] = "kekdneafjmhmndejhmbcadfiiofngffo";
const char kStandaloneAppId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
const char kStandaloneChildAppId[] = "hcglmfcclpfgljeaiahehebeoaiicbko";
const char kTestUserAccount[] = "user@test";
class ExternalProviderImplChromeOSTest : public ExtensionServiceTestBase {
public:
ExternalProviderImplChromeOSTest()
: fake_user_manager_(new ash::FakeChromeUserManager()),
scoped_user_manager_(base::WrapUnique(fake_user_manager_.get())) {}
ExternalProviderImplChromeOSTest(const ExternalProviderImplChromeOSTest&) =
delete;
ExternalProviderImplChromeOSTest& operator=(
const ExternalProviderImplChromeOSTest&) = delete;
~ExternalProviderImplChromeOSTest() override = default;
ExternalProviderManager* external_provider_manager() {
return ExternalProviderManager::Get(profile());
}
void InitServiceWithExternalProviders(bool standalone) {
InitServiceWithExternalProvidersAndUserType(standalone,
false /* is_child */);
}
void InitServiceWithExternalProvidersAndUserType(bool standalone,
bool is_child) {
InitializeEmptyExtensionService();
if (is_child) {
profile_->SetIsSupervisedProfile();
}
service_->Init();
if (standalone) {
external_externsions_overrides_ =
std::make_unique<base::ScopedPathOverride>(
chrome::DIR_STANDALONE_EXTERNAL_EXTENSIONS,
data_dir().Append("external_standalone"));
} else {
external_externsions_overrides_ =
std::make_unique<base::ScopedPathOverride>(
chrome::DIR_EXTERNAL_EXTENSIONS, data_dir().Append("external"));
}
// This switch is set when creating a TestingProfile, but needs to be
// removed for some ExternalProviders to be created.
base::CommandLine::ForCurrentProcess()->RemoveSwitch(
switches::kDisableDefaultApps);
ProviderCollection providers;
ExternalProviderImpl::CreateExternalProviders(external_provider_manager(),
profile_.get(), &providers);
for (std::unique_ptr<ExternalProviderInterface>& provider : providers) {
external_provider_manager()->AddProviderForTesting(std::move(provider));
}
}
// ExtensionServiceTestBase overrides:
void SetUp() override { ExtensionServiceTestBase::SetUp(); }
void TearDown() override {
// If some extensions are being installed (on a background thread) and we
// stop before the intsallation is complete, some installation related
// objects might be leaked (as the background thread won't block on exit and
// finish cleanly).
// So ensure we let pending extension installations finish.
WaitForPendingStandaloneExtensionsInstalled();
ExtensionServiceTestBase::TearDown();
}
// Waits until all possible standalone extensions are installed.
void WaitForPendingStandaloneExtensionsInstalled() {
external_provider_manager()->CheckForExternalUpdates();
base::RunLoop().RunUntilIdle();
PendingExtensionManager* const pending_extension_manager =
PendingExtensionManager::Get(profile());
while (pending_extension_manager->IsIdPending(kStandaloneAppId) ||
pending_extension_manager->IsIdPending(kStandaloneChildAppId)) {
base::RunLoop().RunUntilIdle();
}
}
void ValidateExternalProviderCountInAppMode(size_t expected_count) {
base::CommandLine* command = base::CommandLine::ForCurrentProcess();
command->AppendSwitchASCII(switches::kForceAppMode, std::string());
command->AppendSwitchASCII(switches::kAppId, std::string("app_id"));
InitializeEmptyExtensionService();
ProviderCollection providers;
ExternalProviderImpl::CreateExternalProviders(external_provider_manager(),
profile_.get(), &providers);
EXPECT_EQ(providers.size(), expected_count);
}
ash::FakeChromeUserManager* fake_user_manager() const {
return fake_user_manager_;
}
private:
std::unique_ptr<base::ScopedPathOverride> external_externsions_overrides_;
ash::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
raw_ptr<ash::FakeChromeUserManager, DanglingUntriaged> fake_user_manager_;
user_manager::ScopedUserManager scoped_user_manager_;
};
} // namespace
// Normal mode, external app should be installed.
TEST_F(ExternalProviderImplChromeOSTest, Normal) {
InitServiceWithExternalProviders(false);
TestExtensionRegistryObserver observer(registry(), kExternalAppId);
external_provider_manager()->CheckForExternalUpdates();
scoped_refptr<const Extension> loaded_extension =
observer.WaitForExtensionLoaded();
EXPECT_EQ(loaded_extension->id(), kExternalAppId);
}
// App mode, no external app should be installed.
TEST_F(ExternalProviderImplChromeOSTest, AppMode) {
base::CommandLine* command = base::CommandLine::ForCurrentProcess();
command->AppendSwitchASCII(switches::kForceAppMode, std::string());
command->AppendSwitchASCII(switches::kAppId, std::string("app_id"));
InitServiceWithExternalProviders(false);
external_provider_manager()->CheckForExternalUpdates();
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(registry()->GetInstalledExtension(kExternalAppId));
}
// Normal mode, standalone app should be installed, because sync is enabled but
// not running.
// flaky: crbug.com/854206
TEST_F(ExternalProviderImplChromeOSTest, DISABLED_Standalone) {
InitServiceWithExternalProviders(true);
WaitForPendingStandaloneExtensionsInstalled();
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneAppId));
// Also include apps available for child.
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneChildAppId));
}
// Should include only subset of default apps
// flaky: crbug.com/854206
TEST_F(ExternalProviderImplChromeOSTest, DISABLED_StandaloneChild) {
InitServiceWithExternalProvidersAndUserType(true /* standalone */,
true /* is_child */);
WaitForPendingStandaloneExtensionsInstalled();
// kStandaloneAppId is not available for child.
EXPECT_FALSE(registry()->GetInstalledExtension(kStandaloneAppId));
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneChildAppId));
}
// Normal mode, standalone app should be installed, because sync is disabled.
TEST_F(ExternalProviderImplChromeOSTest, SyncDisabled) {
base::CommandLine::ForCurrentProcess()->AppendSwitch(syncer::kDisableSync);
InitServiceWithExternalProviders(true);
TestExtensionRegistryObserver observer(registry(), kStandaloneAppId);
external_provider_manager()->CheckForExternalUpdates();
scoped_refptr<const Extension> loaded_extension =
observer.WaitForExtensionLoaded();
EXPECT_EQ(loaded_extension->id(), kStandaloneAppId);
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneAppId));
}
// User signed in, sync service started, install app when sync is disabled by
// policy.
TEST_F(ExternalProviderImplChromeOSTest, PolicyDisabled) {
InitServiceWithExternalProviders(true);
// Log user in, start sync.
TestingBrowserProcess::GetGlobal()->SetProfileManager(
std::make_unique<ProfileManagerWithoutInit>(temp_dir().GetPath()));
auto identity_test_env_profile_adaptor =
std::make_unique<IdentityTestEnvironmentProfileAdaptor>(profile());
identity_test_env_profile_adaptor->identity_test_env()
->MakePrimaryAccountAvailable("test_user@gmail.com",
signin::ConsentLevel::kSync);
// Sync is dsabled by policy.
profile_->GetPrefs()->SetBoolean(syncer::prefs::internal::kSyncManaged, true);
TestExtensionRegistryObserver observer(registry(), kStandaloneAppId);
// App sync will wait for priority sync to complete.
external_provider_manager()->CheckForExternalUpdates();
scoped_refptr<const Extension> loaded_extension =
observer.WaitForExtensionLoaded();
EXPECT_EQ(loaded_extension->id(), kStandaloneAppId);
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneAppId));
TestingBrowserProcess::GetGlobal()->SetProfileManager(nullptr);
}
// User signed in, sync service started, install app when priority sync is
// completed.
TEST_F(ExternalProviderImplChromeOSTest, PriorityCompleted) {
InitServiceWithExternalProviders(true);
// User is logged in.
auto identity_test_env_profile_adaptor =
std::make_unique<IdentityTestEnvironmentProfileAdaptor>(profile());
identity_test_env_profile_adaptor->identity_test_env()->SetPrimaryAccount(
"test_user@gmail.com", signin::ConsentLevel::kSync);
// OOBE screen completed with OS sync enabled.
PrefService* prefs = profile()->GetPrefs();
prefs->SetBoolean(ash::prefs::kSyncOobeCompleted, true);
TestExtensionRegistryObserver observer(registry(), kStandaloneAppId);
// Priority sync completed.
PrefServiceSyncableFromProfile(profile())
->GetSyncableService(syncer::OS_PRIORITY_PREFERENCES)
->MergeDataAndStartSyncing(
syncer::OS_PRIORITY_PREFERENCES, syncer::SyncDataList(),
std::make_unique<syncer::FakeSyncChangeProcessor>());
// App sync will wait for priority sync to complete.
external_provider_manager()->CheckForExternalUpdates();
scoped_refptr<const Extension> loaded_extension =
observer.WaitForExtensionLoaded();
EXPECT_EQ(loaded_extension->id(), kStandaloneAppId);
EXPECT_TRUE(registry()->GetInstalledExtension(kStandaloneAppId));
}
// Validate the external providers enabled in the Chrome App Kiosk session. The
// expected number should be 3.
// - |policy_provider|.
// - |kiosk_app_provider|.
// - |secondary_kiosk_app_provider|.
TEST_F(ExternalProviderImplChromeOSTest, ChromeAppKiosk) {
const AccountId kiosk_account_id(AccountId::FromUserEmail(kTestUserAccount));
fake_user_manager()->AddKioskChromeAppUser(kiosk_account_id);
fake_user_manager()->LoginUser(kiosk_account_id);
ValidateExternalProviderCountInAppMode(3u);
}
// Validate the external providers enabled in the Web App Kiosk session. The
// expected number should be only 1.
// - |policy_provider|.
TEST_F(ExternalProviderImplChromeOSTest, WebAppKiosk) {
const AccountId kiosk_account_id(AccountId::FromUserEmail(kTestUserAccount));
fake_user_manager()->AddKioskWebAppUser(kiosk_account_id);
fake_user_manager()->LoginUser(kiosk_account_id);
ValidateExternalProviderCountInAppMode(1u);
}
} // namespace extensions
|
