1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/installed_loader.h"
#include "base/test/metrics/histogram_tester.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/extension_service_user_test_base.h"
#include "chrome/browser/extensions/permissions/permissions_updater.h"
#include "chrome/browser/extensions/permissions/scripting_permissions_modifier.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/buildflags/buildflags.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_features.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/ash/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/ash/profiles/profile_helper.h"
#endif // BUILDFLAG(IS_CHROMEOS)
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
namespace {
constexpr const char kHasWithheldHostsHistogram[] =
"Extensions.RuntimeHostPermissions.ExtensionHasWithheldHosts";
constexpr const char kGrantedHostCountHistogram[] =
"Extensions.RuntimeHostPermissions.GrantedHostCount";
constexpr const char kGrantedAccessHistogram[] =
"Extensions.HostPermissions.GrantedAccess";
constexpr const char kGrantedAccessForBroadRequestsHistogram[] =
"Extensions.HostPermissions.GrantedAccessForBroadRequests";
constexpr const char kGrantedAccessForTargetedRequestsHistogram[] =
"Extensions.HostPermissions.GrantedAccessForTargetedRequests";
// Use an internal location for extensions since metrics aren't recorded for
// unpacked extensions.
constexpr mojom::ManifestLocation kManifestInternal =
mojom::ManifestLocation::kInternal;
constexpr mojom::ManifestLocation kManifestExternalPolicy =
mojom::ManifestLocation::kExternalPolicy;
struct HostPermissionsMetricsTestParams {
// The manifest location of the extension to install.
mojom::ManifestLocation manifest_location = kManifestInternal;
// The host permissions the extension requests.
std::vector<std::string> requested_host_permissions;
// Whether the extension requests activeTab.
bool requests_active_tab = false;
// Whether the user enables host permission withholding for the extension.
bool has_withholding_permissions = false;
// The host permissions the user grants. Only valid if
// `has_withholding_permissions` is true.
std::vector<std::string> granted_host_permissions;
// The expected access level to be reported by the histogram.
HostPermissionsAccess expected_access_level;
// The scope of the extension request, which determines if it is reported in
// additional histograms.
enum class RequestScope { kNone, kTargeted, kBroad };
RequestScope request_scope = RequestScope::kNone;
};
} // namespace
class InstalledLoaderUnitTest : public ExtensionServiceUserTestBase {
public:
InstalledLoaderUnitTest() = default;
InstalledLoaderUnitTest(const InstalledLoaderUnitTest&) = delete;
InstalledLoaderUnitTest& operator=(const InstalledLoaderUnitTest&) = delete;
~InstalledLoaderUnitTest() override = default;
void SetUp() override {
ExtensionServiceUserTestBase::SetUp();
InitializeEmptyExtensionService();
}
const Extension* AddExtension(const std::vector<std::string>& permissions,
mojom::ManifestLocation location,
bool requests_active_tab = false);
void RunHostPermissionsMetricsTest(HostPermissionsMetricsTestParams params);
void RunEmitUserHistogramsTest(int nonuser_expected_total_count,
int user_expected_total_count);
};
const Extension* InstalledLoaderUnitTest::AddExtension(
const std::vector<std::string>& host_permissions,
mojom::ManifestLocation location,
bool requests_active_tab) {
ExtensionBuilder builder("test");
builder.AddHostPermissions(host_permissions);
builder.SetLocation(location);
if (requests_active_tab) {
builder.AddAPIPermission("activeTab");
}
scoped_refptr<const Extension> extension = builder.Build();
PermissionsUpdater updater(profile());
updater.InitializePermissions(extension.get());
updater.GrantActivePermissions(extension.get());
registrar()->AddExtension(extension);
return extension.get();
}
void InstalledLoaderUnitTest::RunHostPermissionsMetricsTest(
HostPermissionsMetricsTestParams params) {
const Extension* extension =
AddExtension(params.requested_host_permissions, params.manifest_location,
params.requests_active_tab);
ScriptingPermissionsModifier modifier(profile(), extension);
if (params.has_withholding_permissions) {
modifier.SetWithholdHostPermissions(true);
for (auto const& permission : params.granted_host_permissions) {
modifier.GrantHostPermission(GURL(permission));
}
} else {
DCHECK(params.granted_host_permissions.empty())
<< "granted_host_permissions are only valid if "
"has_withholding_permission is true";
}
base::HistogramTester histograms;
InstalledLoader loader(profile());
loader.RecordExtensionsMetricsForTesting();
histograms.ExpectUniqueSample(kGrantedAccessHistogram,
params.expected_access_level, 1);
switch (params.request_scope) {
case HostPermissionsMetricsTestParams::RequestScope::kNone:
histograms.ExpectTotalCount(kGrantedAccessForBroadRequestsHistogram, 0);
histograms.ExpectTotalCount(kGrantedAccessForTargetedRequestsHistogram,
0);
break;
case HostPermissionsMetricsTestParams::RequestScope::kBroad:
histograms.ExpectUniqueSample(kGrantedAccessForBroadRequestsHistogram,
params.expected_access_level, 1);
histograms.ExpectTotalCount(kGrantedAccessForTargetedRequestsHistogram,
0);
break;
case HostPermissionsMetricsTestParams::RequestScope::kTargeted:
histograms.ExpectTotalCount(kGrantedAccessForBroadRequestsHistogram, 0);
histograms.ExpectUniqueSample(kGrantedAccessForTargetedRequestsHistogram,
params.expected_access_level, 1);
break;
}
}
// Test that certain histograms are emitted for user and non-user profiles
// (users for ChromeOS Ash).
void InstalledLoaderUnitTest::RunEmitUserHistogramsTest(
int nonuser_expected_total_count,
int user_expected_total_count) {
base::HistogramTester histograms;
InstalledLoader loader(profile());
loader.RecordExtensionsIncrementedMetricsForTesting(profile());
histograms.ExpectTotalCount("Extensions.LoadAllTime2", 1);
histograms.ExpectTotalCount("Extensions.LoadAll", 1);
histograms.ExpectTotalCount("Extensions.Disabled", 1);
histograms.ExpectTotalCount("Extensions.LoadAllTime2.NonUser",
nonuser_expected_total_count);
histograms.ExpectTotalCount("Extensions.LoadAllTime2.User",
user_expected_total_count);
histograms.ExpectTotalCount("Extensions.LoadAll2", user_expected_total_count);
histograms.ExpectTotalCount("Extensions.Disabled2",
user_expected_total_count);
histograms.ExpectTotalCount("Extensions.ManifestVersion2",
user_expected_total_count);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_HasWithheldHosts_False) {
AddExtension({"<all_urls>"}, kManifestInternal);
base::HistogramTester histograms;
InstalledLoader loader(profile());
loader.RecordExtensionsMetricsForTesting();
// The extension didn't have withheld hosts, so a single `false` record
// should be present.
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, false, 1);
// Granted host counts should only be recorded if the extension had withheld
// hosts.
histograms.ExpectTotalCount(kGrantedHostCountHistogram, 0);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_HasWithheldHosts_True) {
const Extension* extension = AddExtension({"<all_urls>"}, kManifestInternal);
ScriptingPermissionsModifier(profile(), extension)
.SetWithholdHostPermissions(true);
base::HistogramTester histograms;
InstalledLoader loader(profile());
loader.RecordExtensionsMetricsForTesting();
// The extension had withheld hosts, so a single `true` record should be
// present.
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, true, 1);
// There were no granted hosts, so a single `0` record should be present.
constexpr int kGrantedHostCount = 0;
constexpr int kEmitCount = 1;
histograms.ExpectUniqueSample(kGrantedHostCountHistogram, kGrantedHostCount,
kEmitCount);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_GrantedHostCount) {
const Extension* extension = AddExtension({"<all_urls>"}, kManifestInternal);
ScriptingPermissionsModifier modifier(profile(), extension);
modifier.SetWithholdHostPermissions(true);
modifier.GrantHostPermission(GURL("https://example.com/"));
modifier.GrantHostPermission(GURL("https://chromium.org/"));
base::HistogramTester histograms;
InstalledLoader loader(profile());
loader.RecordExtensionsMetricsForTesting();
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, true, 1);
// The extension had granted hosts, so a single `2` record should be present.
constexpr int kGrantedHostCount = 2;
constexpr int kEmitCount = 1;
histograms.ExpectUniqueSample(kGrantedHostCountHistogram, kGrantedHostCount,
kEmitCount);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_CannotAffect) {
HostPermissionsMetricsTestParams params;
// The extension is loaded from an external policy, so the user cannot
// configure the host permissions that affect the extension.
params.manifest_location = kManifestExternalPolicy;
// The extension didn't request access to any eTLDs or requested host
// permissions.
params.expected_access_level = HostPermissionsAccess::kCannotAffect;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kNone;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_CannotAffect_Broad_AllUrls) {
HostPermissionsMetricsTestParams params;
// The extension with host permissions is loaded from an external policy, so
// the user cannot configure the host permissions that affect the extension.
params.manifest_location = kManifestExternalPolicy;
params.requested_host_permissions = {"<all_urls>"};
params.expected_access_level = HostPermissionsAccess::kCannotAffect;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_CannotAffect_Broad_Patterns) {
HostPermissionsMetricsTestParams params;
// The extension with host permissions is loaded from an external policy, so
// the user cannot configure the host permissions that affect the extension.
params.manifest_location = kManifestExternalPolicy;
params.requested_host_permissions = {"*://*/*"};
params.expected_access_level = HostPermissionsAccess::kCannotAffect;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_CannotAffect_Targeted) {
HostPermissionsMetricsTestParams params;
// The extension with host permissions is loaded from an external policy, so
// the user cannot configure the host permissions that affect the extension.
params.manifest_location = kManifestExternalPolicy;
params.requested_host_permissions = {"https://example.com/"};
params.expected_access_level = HostPermissionsAccess::kCannotAffect;
params.request_scope =
HostPermissionsMetricsTestParams::RequestScope::kTargeted;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_NotRequested) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
// The extension has no host permissions, so host permissions cannot be
// requested.
params.expected_access_level = HostPermissionsAccess::kNotRequested;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kNone;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnClick_Broad_AllUrls) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"<all_urls>"};
params.has_withholding_permissions = true;
params.expected_access_level = HostPermissionsAccess::kOnClick;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnClick_Broad_Pattern) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"*://*/*"};
params.has_withholding_permissions = true;
params.expected_access_level = HostPermissionsAccess::kOnClick;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnClick_Targeted) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"https://example.com/"};
params.has_withholding_permissions = true;
params.expected_access_level = HostPermissionsAccess::kOnClick;
params.request_scope =
HostPermissionsMetricsTestParams::RequestScope::kTargeted;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnSpecificSites_Broad_AllUrls) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"<all_urls>"};
params.has_withholding_permissions = true;
params.granted_host_permissions = {"https://example.com/"};
params.expected_access_level = HostPermissionsAccess::kOnSpecificSites;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnSpecificSites_Broad_Pattern) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"*://*/*"};
params.has_withholding_permissions = true;
params.granted_host_permissions = {"https://example.com/"};
params.expected_access_level = HostPermissionsAccess::kOnSpecificSites;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnSpecificSites_Targeted) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"https://example.com/",
"https://google.com/"};
params.has_withholding_permissions = true;
params.granted_host_permissions = {"https://example.com/"};
params.expected_access_level = HostPermissionsAccess::kOnSpecificSites;
params.request_scope =
HostPermissionsMetricsTestParams::RequestScope::kTargeted;
RunHostPermissionsMetricsTest(params);
}
TEST_F(
InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnAllRequestedSites_Broad_AllUrls) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"<all_urls>"};
params.expected_access_level = HostPermissionsAccess::kOnAllRequestedSites;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(
InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnAllRequestedSites_Broad_Pattern) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"*://*/*"};
params.expected_access_level = HostPermissionsAccess::kOnAllRequestedSites;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kBroad;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnAllRequestedSites_Targeted) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
params.requested_host_permissions = {"https://example.com/"};
params.expected_access_level = HostPermissionsAccess::kOnAllRequestedSites;
params.has_withholding_permissions = true;
params.granted_host_permissions = {"https://example.com/"};
params.request_scope =
HostPermissionsMetricsTestParams::RequestScope::kTargeted;
RunHostPermissionsMetricsTest(params);
}
TEST_F(InstalledLoaderUnitTest,
HostPermissions_Metrics_GrantedAccess_OnActiveTabOnly) {
HostPermissionsMetricsTestParams params;
params.manifest_location = kManifestInternal;
// The extension has activeTab API permission and no host permissions, so host
// permission access is on active tab only.
params.requests_active_tab = true;
params.expected_access_level = HostPermissionsAccess::kOnActiveTabOnly;
params.request_scope = HostPermissionsMetricsTestParams::RequestScope::kNone;
RunHostPermissionsMetricsTest(params);
}
// TODO(crbug.com/40878021): After deleting the deprecated unincremented
// histograms, consider modifying these to becomes less of change detectors in
// metrics being modified.
// Tests that some histograms that only emit for profiles that can use
// non-component extensions emit as expected.
TEST_F(InstalledLoaderUnitTest, UserMetrics_UserMetricsEmitForRegularUser) {
ASSERT_TRUE(AddExtension({"<all_urls>"}, kManifestInternal));
ASSERT_NO_FATAL_FAILURE(MaybeSetUpTestUser(/*is_guest=*/false));
RunEmitUserHistogramsTest(
/*nonuser_expected_total_count=*/0,
/*user_expected_total_count=*/1);
}
// Tests that some histograms that only emit for profiles that can use
// non-component extensions do not emit as expected.
TEST_F(InstalledLoaderUnitTest, UserMetrics_UserMetricsDoNotEmitForGuestUser) {
ASSERT_TRUE(AddExtension({"<all_urls>"}, kManifestInternal));
ASSERT_NO_FATAL_FAILURE(MaybeSetUpTestUser(/*is_guest=*/true));
RunEmitUserHistogramsTest(
/*nonuser_expected_total_count=*/1,
/*user_expected_total_count=*/0);
}
} // namespace extensions
|