1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/permissions/active_tab_permission_granter.h"
#include "chrome/browser/extensions/permissions/scripting_permissions_modifier.h"
#include "chrome/browser/extensions/permissions/site_permissions_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/test_browser_window.h"
#include "components/crx_file/id_util.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/web_contents_tester.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/host_access_request_helper.h"
#include "extensions/browser/permissions_manager.h"
#include "extensions/browser/unloaded_extension_reason.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/url_pattern.h"
#include "extensions/test/permissions_manager_waiter.h"
namespace extensions {
class HostAccessRequestsHelperUnittest : public ExtensionServiceTestBase {
public:
HostAccessRequestsHelperUnittest() = default;
~HostAccessRequestsHelperUnittest() override = default;
HostAccessRequestsHelperUnittest(const HostAccessRequestsHelperUnittest&) =
delete;
HostAccessRequestsHelperUnittest& operator=(
const HostAccessRequestsHelperUnittest&) = delete;
// Installs an extension with `host_permission` and withhelds them.
scoped_refptr<const Extension> InstallExtensionAndWithholdHostPermissions(
const std::string& name,
const std::string& host_permission);
// Installs an extension with activeTab permission.
scoped_refptr<const Extension> InstallExtensionWithActiveTab(
const std::string& name);
// Adds a new tab with `url` to the tab strip, and returns the WebContents
// associated with it.
content::WebContents* AddTab(const GURL& url);
// Returns the browser. Creates a new one if it doesn't exist.
Browser* browser();
PermissionsManager* permissions_manager() { return permissions_manager_; }
// ExtensionServiceTestBase:
void SetUp() override;
void TearDown() override;
private:
// The browser and accompaying window.
std::unique_ptr<TestBrowserWindow> browser_window_;
std::unique_ptr<Browser> browser_;
raw_ptr<PermissionsManager> permissions_manager_;
};
scoped_refptr<const Extension>
HostAccessRequestsHelperUnittest::InstallExtensionAndWithholdHostPermissions(
const std::string& name,
const std::string& host_permission) {
auto extension = ExtensionBuilder(name)
.SetManifestVersion(3)
.AddHostPermission(host_permission)
.SetID(crx_file::id_util::GenerateId(name))
.Build();
registrar()->AddExtension(extension);
ScriptingPermissionsModifier(profile(), extension)
.SetWithholdHostPermissions(true);
return extension;
}
scoped_refptr<const Extension>
HostAccessRequestsHelperUnittest::InstallExtensionWithActiveTab(
const std::string& name) {
auto extension = ExtensionBuilder(name)
.SetManifestVersion(3)
.SetID(crx_file::id_util::GenerateId(name))
.AddAPIPermission("activeTab")
.Build();
registrar()->AddExtension(extension);
return extension;
}
content::WebContents* HostAccessRequestsHelperUnittest::AddTab(
const GURL& url) {
std::unique_ptr<content::WebContents> web_contents(
content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
content::WebContents* raw_contents = web_contents.get();
browser()->tab_strip_model()->AppendWebContents(std::move(web_contents),
true);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents(), raw_contents);
content::NavigationSimulator::NavigateAndCommitFromBrowser(raw_contents, url);
EXPECT_EQ(url, raw_contents->GetLastCommittedURL());
return raw_contents;
}
Browser* HostAccessRequestsHelperUnittest::browser() {
if (!browser_) {
Browser::CreateParams params(profile(), true);
browser_window_ = std::make_unique<TestBrowserWindow>();
params.window = browser_window_.get();
browser_ = Browser::DeprecatedCreateOwnedForTesting(params);
}
return browser_.get();
}
void HostAccessRequestsHelperUnittest::SetUp() {
ExtensionServiceTestBase::SetUp();
InitializeEmptyExtensionService();
permissions_manager_ = PermissionsManager::Get(profile());
}
void HostAccessRequestsHelperUnittest::TearDown() {
// Remove any tabs in the tab strip; else the test crashes.
if (browser_) {
while (!browser_->tab_strip_model()->empty()) {
browser_->tab_strip_model()->DetachAndDeleteWebContentsAt(0);
}
}
permissions_manager_ = nullptr;
ExtensionServiceTestBase::TearDown();
}
// Tests host access requests are properly added and removed.
TEST_F(HostAccessRequestsHelperUnittest, AddAndRemoveRequests) {
auto extension_A =
InstallExtensionAndWithholdHostPermissions("Extension A", "<all_urls>");
auto extension_B =
InstallExtensionAndWithholdHostPermissions("Extension B", "<all_urls>");
content::WebContents* web_contents = AddTab(GURL("http://www.example.com/"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Try to remove a non-existent host access request. Verify nothing happens.
EXPECT_FALSE(permissions_manager()->RemoveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Add host access request for extension A. Verify only extension A has an
// active request.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id,
*extension_A);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Add host access request for extension B. Verify both extensions have active
// requests.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id,
*extension_B);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Remove host access request for extension A. Verify only extension B has an
// active request.
EXPECT_TRUE(permissions_manager()->RemoveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
}
// Tests that host access requests which include a filter are properly added
// and removed.
TEST_F(HostAccessRequestsHelperUnittest,
AddAndRemoveRequestsWithPatternFilter) {
auto extension =
InstallExtensionAndWithholdHostPermissions("Extension", "<all_urls>");
URLPattern matching_filter(Extension::kValidHostPermissionSchemes,
"http://www.matching.com/");
URLPattern non_matching_filter(Extension::kValidHostPermissionSchemes,
"http://www.non-matching.com/");
content::WebContents* web_contents = AddTab(GURL("http://www.matching.com/"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add a host access request with filter that does not match the current web
// contents. Verify request is not active.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
non_matching_filter);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Add a host access request with filter that matches the current web
// contents. Verify request is active.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
matching_filter);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Remove a host access request with filter that doesn't match the current web
// contents. Verify request is active.
permissions_manager()->RemoveHostAccessRequest(tab_id, extension->id(),
non_matching_filter);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Remove a host access request with filter that matches the current web
// contents. Verify request is not active.
permissions_manager()->RemoveHostAccessRequest(tab_id, extension->id(),
matching_filter);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Add back a host access request with filter that matches the current web
// contents (so we can test removal without filter). Verify request is active.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
matching_filter);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Remove a host access request for extension without specifying a filter.
// Verify request is no longer active, since a request without filter matches
// all patterns.
EXPECT_TRUE(
permissions_manager()->RemoveHostAccessRequest(tab_id, extension->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Test request is not added when extension only has activeTab permission.
TEST_F(HostAccessRequestsHelperUnittest,
InvalidRequest_ExtensionOnlyHasActiveTabPermission) {
auto extension = InstallExtensionWithActiveTab("Extension");
content::WebContents* web_contents = AddTab(GURL("http://www.example.com"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension. Verify request is not active.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Tests that host access requests dismissed by the user are not active
// requests.
TEST_F(HostAccessRequestsHelperUnittest, UserDismissedRequest) {
auto extension =
InstallExtensionAndWithholdHostPermissions("Extension", "<all_urls>");
content::WebContents* web_contents = AddTab(GURL("http://www.example.com/"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension A. Verify extension has an active
// request.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Dismiss host access request for extension. Verify request is not an active
// request.
permissions_manager()->UserDismissedHostAccessRequest(web_contents, tab_id,
extension->id());
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Tests request is removed on cross-origin navigations.
TEST_F(HostAccessRequestsHelperUnittest,
RequestRemovedOnCrossOriginNavigation) {
auto extension =
InstallExtensionAndWithholdHostPermissions("Extension", "<all_urls>");
content::WebContents* web_contents =
AddTab(GURL("http://www.same-origin.com/a"));
content::WebContentsTester* web_contents_tester =
content::WebContentsTester::For(web_contents);
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Same-origin navigation should retain request.
web_contents_tester->NavigateAndCommit(GURL("http://www.same-origin.com/b"));
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Cross-origin navigation should remove request.
web_contents_tester->NavigateAndCommit(GURL("http://www.cross-origin.com/c"));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Tests that a request with matching filter pattern are active on same origin
// navigations.
TEST_F(HostAccessRequestsHelperUnittest, RequestUpdatedOnPageNavigations) {
auto extension =
InstallExtensionAndWithholdHostPermissions("Extension", "<all_urls>");
content::WebContents* web_contents = AddTab(GURL("http://www.example.com/"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension. Verify request is active.
std::optional<URLPattern> filter;
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
filter);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Add host access request for extension with a filter that doesn't match the
// current web contents but has the same origin. Verify request is not
// active, since new request should override the previous one.
filter = URLPattern(Extension::kValidHostPermissionSchemes, "*://*/path");
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
filter);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Navigate to a host that matches the filter. Verify request is active.
content::NavigationSimulator::NavigateAndCommitFromBrowser(
web_contents, GURL("http://www.example.com/path"));
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Add host access request for extension with a filter that doesn't have the
// same origin as the current web contents. Verify request is not active.
filter = URLPattern(Extension::kValidHostPermissionSchemes,
"http://www.other.com/path");
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension,
filter);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Test request is removed when extension is granted "always on this host" host
// access.
TEST_F(HostAccessRequestsHelperUnittest,
RequestRemovedWhenExtensionHasSiteAccess) {
auto extension =
InstallExtensionAndWithholdHostPermissions("Extension", "<all_urls>");
content::WebContents* web_contents =
AddTab(GURL("http://www.same-origin.com/a"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Grant "always on this host" access to the extension.
PermissionsManagerWaiter waiter(PermissionsManager::Get(profile()));
SitePermissionsHelper permissions(profile());
permissions.UpdateSiteAccess(*extension, web_contents,
PermissionsManager::UserSiteAccess::kOnSite);
waiter.WaitForExtensionPermissionsUpdate();
// Request should be removed since extension has granted host access.
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Test request is removed when extension is granted one-time host access.
TEST_F(HostAccessRequestsHelperUnittest,
RequestRemovedWhenExtensionHasGrantedActiveTab) {
// Add extension with host permissions and activeTab, and withhold the host
// permissions.
const std::string extension_name = "Extension";
auto extension = ExtensionBuilder(extension_name)
.SetManifestVersion(3)
.AddHostPermission("http://www.example.com/")
.AddAPIPermission("activeTab")
.SetID(crx_file::id_util::GenerateId(extension_name))
.Build();
registrar()->AddExtension(extension);
ScriptingPermissionsModifier(profile(), extension)
.SetWithholdHostPermissions(true);
content::WebContents* web_contents = AddTab(GURL("http://www.example.com"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for extension.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id, *extension);
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
// Grant tab permission to extension.
ActiveTabPermissionGranter* active_tab_permission_granter =
ActiveTabPermissionGranter::FromWebContents(
browser()->tab_strip_model()->GetActiveWebContents());
ASSERT_TRUE(active_tab_permission_granter);
active_tab_permission_granter->GrantIfRequested(extension.get());
// Request should be removed since extension has granted host access.
// Even though the extension was only granted activeTab (and not persistent
// host access, as would be the case if the user accepted the request), we no
// longer show the host access request. This is to avoid a user seeing a
// request after having granted one-time access to an extension.
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension->id()));
}
// Test request is removed when extension is unloaded.
TEST_F(HostAccessRequestsHelperUnittest,
RequestRemovedWhenExtensionIsUnloaded) {
auto extension_A =
InstallExtensionAndWithholdHostPermissions("Extension A", "<all_urls>");
auto extension_B =
InstallExtensionAndWithholdHostPermissions("Extension B", "<all_urls>");
content::WebContents* web_contents =
AddTab(GURL("http://www.same-origin.com/a"));
int tab_id = ExtensionTabUtil::GetTabId(web_contents);
// Add host access request for both extensions.
permissions_manager()->AddHostAccessRequest(web_contents, tab_id,
*extension_A);
permissions_manager()->AddHostAccessRequest(web_contents, tab_id,
*extension_B);
ASSERT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
ASSERT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Uninstall extension A. Verify only extension B should have a host access
// request.
registrar()->UninstallExtension(
extension_A->id(), extensions::UNINSTALL_REASON_FOR_TESTING, nullptr);
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_TRUE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Disable extension B. Verify no extension should have a host access request.
registrar()->DisableExtension(
extension_B->id(), {extensions::disable_reason::DISABLE_USER_ACTION});
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
// Enable extension B. Verify no extension has a host access request. Request
// is not persisted when extension is re-enabled, the extension needs to add
// the request again.
registrar()->EnableExtension(extension_B->id());
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_A->id()));
EXPECT_FALSE(permissions_manager()->HasActiveHostAccessRequest(
tab_id, extension_B->id()));
}
} // namespace extensions
|
