1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/gesturenav/android/tab_on_back_gesture_handler.h"
#include <iomanip>
#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "content/public/browser/back_forward_transition_animation_manager.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_features.h"
#include "third_party/blink/public/common/features.h"
#include "ui/android/view_android.h"
#include "ui/android/window_android.h"
#include "ui/gfx/geometry/point_f.h"
// Must come after all headers that specialize FromJniType() / ToJniType().
#include "chrome/browser/gesturenav/android/jni_headers/TabOnBackGestureHandler_jni.h"
namespace gesturenav {
namespace {
const base::FeatureParam<bool> kDumpWithoutCrashTabOnBackGestureHandler{
&blink::features::kBackForwardTransitions,
"dump-without-crash-tab-on-back-gesture-handler", false};
using NavDirection =
content::BackForwardTransitionAnimationManager::NavigationDirection;
void AssertHasWindowAndCompositor(content::WebContents* web_contents) {
CHECK(web_contents);
auto* window = web_contents->GetNativeView()->GetWindowAndroid();
CHECK(window);
CHECK(window->GetCompositor());
}
} // namespace
TabOnBackGestureHandler::TabOnBackGestureHandler(TabAndroid* tab_android)
: tab_android_(tab_android) {}
void TabOnBackGestureHandler::OnBackStarted(JNIEnv* env,
float progress,
int edge,
bool forward,
bool is_gesture_mode) {
is_gesture_mode_ = is_gesture_mode;
SCOPED_CRASH_KEY_BOOL("OnBackStarted", "gesture mode", is_gesture_mode);
// Ideally the OS shouldn't start a new gesture without finishing the previous
// gesture but we see this pattern on multiple devices.
// See crbug.com/41484247.
if (is_in_progress_) {
if (kDumpWithoutCrashTabOnBackGestureHandler.Get()) {
base::debug::DumpWithoutCrashing();
}
OnBackCancelled(env, is_gesture_mode);
CHECK(!is_in_progress_);
}
is_in_progress_ = true;
content::WebContents* web_contents = tab_android_->web_contents();
CHECK(web_contents);
AssertHasWindowAndCompositor(web_contents);
ui::BackGestureEvent back_gesture(progress);
started_edge_ = static_cast<ui::BackGestureEventSwipeEdge>(edge);
web_contents->GetBackForwardTransitionAnimationManager()->OnGestureStarted(
back_gesture, static_cast<ui::BackGestureEventSwipeEdge>(edge),
forward ? NavDirection::kForward : NavDirection::kBackward);
}
void TabOnBackGestureHandler::OnBackProgressed(JNIEnv* env,
float progress,
int edge,
bool forward,
bool is_gesture_mode) {
SCOPED_CRASH_KEY_BOOL("OnBackProgressed", "gesture mode", is_gesture_mode);
if (
// http://crbug.com/373617224. Gracefully handle this case until the
// upstream is fixed.
!is_in_progress_ ||
// Ideally the edge value should not be changed during a navigation
// however, we see multiple instances with different edge values from
// start to progress. See crbug.com/370105609.
started_edge_ != static_cast<ui::BackGestureEventSwipeEdge>(edge)) {
if (kDumpWithoutCrashTabOnBackGestureHandler.Get()) {
std::ostringstream strs;
strs << std::fixed << std::setprecision(6) << progress;
SCOPED_CRASH_KEY_STRING64("OnBackProgressed", "progress", strs.str());
SCOPED_CRASH_KEY_STRING32(
"OnBackProgressed", "started edge",
started_edge_ == ui::BackGestureEventSwipeEdge::LEFT ? "left"
: "right");
SCOPED_CRASH_KEY_STRING32("OnBackProgressed", "edge",
edge == 0 ? "left" : "right");
SCOPED_CRASH_KEY_BOOL("OnBackProgressed", "forward", forward);
SCOPED_CRASH_KEY_BOOL("OnBackProgressed", "is in progress",
is_in_progress_);
base::debug::DumpWithoutCrashing();
}
if (is_in_progress_) {
OnBackCancelled(env, is_gesture_mode);
}
CHECK(!is_in_progress_);
OnBackStarted(env, progress, edge, forward, is_gesture_mode);
return;
}
content::WebContents* web_contents = tab_android_->web_contents();
AssertHasWindowAndCompositor(web_contents);
// The OS can give us incorrect progress values.
progress = std::clamp(progress, 0.f, 1.f);
ui::BackGestureEvent back_gesture(progress);
web_contents->GetBackForwardTransitionAnimationManager()->OnGestureProgressed(
back_gesture);
}
void TabOnBackGestureHandler::OnBackCancelled(JNIEnv* env,
bool is_gesture_mode) {
SCOPED_CRASH_KEY_BOOL("OnBackCancelled", "gesture mode", is_gesture_mode);
if (!is_in_progress_) {
if (kDumpWithoutCrashTabOnBackGestureHandler.Get()) {
SCOPED_CRASH_KEY_STRING32(
"OnBackCancelled", "started edge",
started_edge_ == ui::BackGestureEventSwipeEdge::LEFT ? "left"
: "right");
base::debug::DumpWithoutCrashing();
}
return;
}
is_in_progress_ = false;
content::WebContents* web_contents = tab_android_->web_contents();
AssertHasWindowAndCompositor(web_contents);
web_contents->GetBackForwardTransitionAnimationManager()
->OnGestureCancelled();
}
void TabOnBackGestureHandler::OnBackInvoked(JNIEnv* env, bool is_gesture_mode) {
SCOPED_CRASH_KEY_BOOL("OnBackInvoked", "gesture mode", is_gesture_mode);
if (!is_in_progress_) {
if (kDumpWithoutCrashTabOnBackGestureHandler.Get()) {
SCOPED_CRASH_KEY_STRING32(
"OnBackInvoked", "started edge",
started_edge_ == ui::BackGestureEventSwipeEdge::LEFT ? "left"
: "right");
base::debug::DumpWithoutCrashing();
}
return;
}
is_in_progress_ = false;
content::WebContents* web_contents = tab_android_->web_contents();
AssertHasWindowAndCompositor(web_contents);
web_contents->GetBackForwardTransitionAnimationManager()->OnGestureInvoked();
}
void TabOnBackGestureHandler::Destroy(JNIEnv* env) {
using AnimationStage =
content::BackForwardTransitionAnimationManager::AnimationStage;
auto* web_contents = tab_android_->web_contents();
if (is_in_progress_ && web_contents &&
web_contents->GetBackForwardTransitionAnimationManager()
->GetCurrentAnimationStage() != AnimationStage::kNone) {
// When the Java's Tab is destroyed, the compositor might already be
// detached from the Window. No need to call `OnBackCancelled()` because the
// animation is already aborted (thus `AnimationStage::kNone`).
OnBackCancelled(env, is_gesture_mode_);
}
delete this;
}
// ----------------------------------------------------------------------------
// Native JNI methods
// ----------------------------------------------------------------------------
// static
jlong JNI_TabOnBackGestureHandler_Init(JNIEnv* env,
const JavaParamRef<jobject>& jtab) {
TabOnBackGestureHandler* handler =
new TabOnBackGestureHandler(TabAndroid::GetNativeTab(env, jtab));
return reinterpret_cast<intptr_t>(handler);
}
// static
jboolean JNI_TabOnBackGestureHandler_ShouldAnimateNavigationTransition(
JNIEnv* env,
jboolean forward,
jint edge) {
return static_cast<jboolean>(
content::BackForwardTransitionAnimationManager::
ShouldAnimateNavigationTransition(
static_cast<bool>(forward) ? NavDirection::kForward
: NavDirection::kBackward,
static_cast<ui::BackGestureEventSwipeEdge>(edge)));
}
} // namespace gesturenav
|
